86812 2012-05-17 23:11:15 -0700 [perf-test] Add a binding benchmark for getElementById() for an undefined id 2012-05-18 02:22:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86581 1 haraken haraken rniwa webkit.review.bot oldest_to_newest 627372 0 haraken 2012-05-17 23:11:15 -0700 We should remove Bindings/dom-attributes.html and instead add more reasonable micro benchmarks by classifying DOM binding call paths. In this bug we add a benchmark for document.getElementById() for an undefined id. This benchmark covers 'getElementById (not in document)' in Dromaeo/dom-query.html, and other Node-query methods that return a null.' 627377 1 142641 haraken 2012-05-17 23:16:48 -0700 Created attachment 142641 Patch 627507 2 142641 webkit.review.bot 2012-05-18 02:22:52 -0700 Comment on attachment 142641 Patch Clearing flags on attachment: 142641 Committed r117569: <http://trac.webkit.org/changeset/117569> 627508 3 webkit.review.bot 2012-05-18 02:22:56 -0700 All reviewed patches have been landed. Closing bug. 142641 2012-05-17 23:16:48 -0700 2012-05-18 02:22:52 -0700 Patch bug-86812-20120518151647.patch text/plain 3112 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTM2CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0JpbmRpbmdzL3VuZGVmaW5lZC1nZXQtZWxlbWVudC1ieS1pZC5odG1sIGIvUGVyZm9ybWFuY2VU ZXN0cy9CaW5kaW5ncy91bmRlZmluZWQtZ2V0LWVsZW1lbnQtYnktaWQuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5kNjk4OGFkOWY2NmE2NmMyMWRlZTY4MGUzYmFjM2Q0ODNjMmFhNzA1Ci0tLSAvZGV2L251bGwK KysrIGIvUGVyZm9ybWFuY2VUZXN0cy9CaW5kaW5ncy91bmRlZmluZWQtZ2V0LWVsZW1lbnQtYnkt aWQuaHRtbApAQCAtMCwwICsxLDE0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+ Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2VzL3J1bm5lci5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0 PgorUGVyZlRlc3RSdW5uZXIucnVuUGVyU2Vjb25kKHsKKyAgICBkZXNjcmlwdGlvbjogIlRoaXMg YmVuY2htYXJrIGNvdmVycyAnZ2V0RWxlbWVudEJ5SWQgKG5vdCBpbiBkb2N1bWVudCknIGluIERy b21hZW8vZG9tLXF1ZXJ5Lmh0bWwsIGFuZCBvdGhlciBOb2RlLXF1ZXJ5IG1ldGhvZHMgdGhhdCBy ZXR1cm4gYSBudWxsLiIsCisgICAgcnVuOiBmdW5jdGlvbigpIHsKKyAgICAgICAgZm9yICh2YXIg aSA9IDA7IGkgPCAxMDAwMDA7IGkrKykKKyAgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJmb28iKTsKK319KTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0 IGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cgYi9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxv ZwppbmRleCBkZGMyODNiYTU0NDYwOTE2ZjYyYjk2ZjdiNjBhNzY2MzgwMjRiMjA0Li45YjYzZWUy NWVmMmJhY2VkYjZmODUxNDUwOTNiZmZjNjE5MWYwNzFhIDEwMDY0NAotLS0gYS9QZXJmb3JtYW5j ZVRlc3RzL0NoYW5nZUxvZworKysgYi9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1 ICsxLDQxIEBACiAyMDEyLTA1LTE3ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9y Zz4KIAorICAgICAgICBbcGVyZi10ZXN0XSBBZGQgYSBiaW5kaW5nIGJlbmNobWFyayBmb3IgZ2V0 RWxlbWVudEJ5SWQoKSBmb3IgYW4gdW5kZWZpbmVkIGlkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjgxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCByZW1vdmUgQmluZGluZ3MvZG9tLWF0 dHJpYnV0ZXMuaHRtbCBhbmQgaW5zdGVhZCBhZGQgbW9yZQorICAgICAgICByZWFzb25hYmxlIG1p Y3JvIGJlbmNobWFya3MgYnkgY2xhc3NpZnlpbmcgRE9NIGJpbmRpbmcgY2FsbCBwYXRocy4KKwor ICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBiZW5jaG1hcmsgZm9yIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCkgZm9yIGFuIHVuZGVmaW5lZCBpZC4KKyAgICAgICAgVGhpcyBiZW5jaG1hcmsgY292 ZXJzICdnZXRFbGVtZW50QnlJZCAobm90IGluIGRvY3VtZW50KScgaW4gRHJvbWFlby9kb20tcXVl cnkuaHRtbCwKKyAgICAgICAgYW5kIG90aGVyIE5vZGUtcXVlcnkgbWV0aG9kcyB0aGF0IHJldHVy biBhIG51bGwuJworCisgICAgICAgIChOb3RlOiBUaGlzIGJlbmNobWFyayBpcyBzbG93ZXIgdGhh biBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgpIGZvciBhIGRlZmluZWQgaWQuCisgICAgICAgIFdl IHdpbGwgZml4IHRoZSBwZXJmb3JtYW5jZSBpc3N1ZSBzb29uLikKKworICAgICAgICBUZXN0IHJl c3VsdHMgaW4gbXkgTGludXggZGVza3RvcDoKKworICAgICAgICBSRVNVTFQgQmluZGluZ3M6IHVu ZGVmaW5lZC1nZXQtZWxlbWVudC1ieS1pZD0gMjcxLjk0NTc1MTM0NSBydW5zL3MKKyAgICAgICAg bWVkaWFuPSAyNzMuMTIyMzg5NTMyIHJ1bnMvcywgc3RkZXY9IDYuNzgyMTkyMzcyOTkgcnVucy9z LCBtaW49IDI1Ny40MDAyNTc0IHJ1bnMvcywgbWF4PSAyODEuNjkwMTQwODQ1IHJ1bnMvcworCisg ICAgICAgIFJFU1VMVCBCaW5kaW5nczogdW5kZWZpbmVkLWdldC1lbGVtZW50LWJ5LWlkPSAyNjku MTA1ODcyNDA4IHJ1bnMvcworICAgICAgICBtZWRpYW49IDI2OC45NDg2NTUyNTcgcnVucy9zLCBz dGRldj0gNS43MzcwNzMyMzc1NSBydW5zL3MsIG1pbj0gMjU3LjQwMDI1NzQgcnVucy9zLCBtYXg9 IDI3OC4xMjg5NTA2OTUgcnVucy9zCisKKyAgICAgICAgUkVTVUxUIEJpbmRpbmdzOiB1bmRlZmlu ZWQtZ2V0LWVsZW1lbnQtYnktaWQ9IDI2OS45ODc1MTMzNzIgcnVucy9zCisgICAgICAgIG1lZGlh bj0gMjcyLjk1Mjg1MzU5OCBydW5zL3MsIHN0ZGV2PSA1LjMwMjUyMzM2MDc4IHJ1bnMvcywgbWlu PSAyNTUuNzU0NDc1NzAzIHJ1bnMvcywgbWF4PSAyNzMuOTcyNjAyNzQgcnVucy9zCisKKyAgICAg ICAgUkVTVUxUIEJpbmRpbmdzOiB1bmRlZmluZWQtZ2V0LWVsZW1lbnQtYnktaWQ9IDI3MC4xNjk2 MjU5MDEgcnVucy9zCisgICAgICAgIG1lZGlhbj0gMjcxLjYwNDkzODI3MiBydW5zL3MsIHN0ZGV2 PSA1LjI5NTAyMzkxOTA2IHJ1bnMvcywgbWluPSAyNTguMDY0NTE2MTI5IHJ1bnMvcywgbWF4PSAy NzguNDgxMDEyNjU4IHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBCaW5kaW5nczogdW5kZWZpbmVk LWdldC1lbGVtZW50LWJ5LWlkPSAyNjkuMDU0NjMxNDIyIHJ1bnMvcworICAgICAgICBtZWRpYW49 IDI2Ny45NjYyOTI4MDIgcnVucy9zLCBzdGRldj0gNi4yNzE5NzI0MDU3OSBydW5zL3MsIG1pbj0g MjU4LjA2NDUxNjEyOSBydW5zL3MsIG1heD0gMjc4LjQ4MTAxMjY1OCBydW5zL3MKKworICAgICAg ICAqIEJpbmRpbmdzL3VuZGVmaW5lZC1nZXQtZWxlbWVudC1ieS1pZC5odG1sOiBBZGRlZC4KKwor MjAxMi0wNS0xNyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgW3BlcmYtdGVzdF0gQWRkIGEgbWljcm8gYmVuY2htYXJrIGZvciBkaXYuZmlyc3RDaGlsZCBn ZXR0ZXIgZm9yIGFuIHVuZGVmaW5lZCBmaXJzdENoaWxkCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjcyNQogCg==