86808 2012-05-17 22:35:58 -0700 [perf-test] Add a binding benchmark for getElementById() 2012-05-17 23:29:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86581 1 haraken haraken rniwa webkit.review.bot oldest_to_newest 627344 0 haraken 2012-05-17 22:35:58 -0700 Currently Bindings/dom-attributes.html is just a collection of random DOM attributes and methods. We should remove it and instead add more reasonable micro benchmarks by classifying DOM binding call paths. In this bug we add a benchmark for document.getElementById(), which covers other DOM methods that return a Node Object. The reason why we want to add a benchmark for document.getElementById() in spite of the fact that Dromaeo/dom-query.html is already testing document.getElementById(), is that Dromaeo/dom-query.html outputs one result for several benchmarks (i.e. getElementById().nodeType, getElementsByTagName()[0].nodeType etc), and thus we cannot observe regression of getElementById() itself. (Catching regression of getElementById() would be critical.) 627348 1 142633 haraken 2012-05-17 22:41:02 -0700 Created attachment 142633 Patch 627355 2 142633 rniwa 2012-05-17 22:48:51 -0700 Comment on attachment 142633 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142633&action=review > PerformanceTests/ChangeLog:22 > + getElementById() would be critical.) I wouldn't say "critical" but sure. 627387 3 142633 webkit.review.bot 2012-05-17 23:29:16 -0700 Comment on attachment 142633 Patch Clearing flags on attachment: 142633 Committed r117548: <http://trac.webkit.org/changeset/117548> 627388 4 webkit.review.bot 2012-05-17 23:29:20 -0700 All reviewed patches have been landed. Closing bug. 142633 2012-05-17 22:41:02 -0700 2012-05-17 23:29:16 -0700 Patch bug-86808-20120518144100.patch text/plain 3358 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTM2CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0JpbmRpbmdzL2dldC1lbGVtZW50LWJ5LWlkLmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL0JpbmRp bmdzL2dldC1lbGVtZW50LWJ5LWlkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZmVjM2Y2NDIxNGQ5YTNjOWZm YzFiNTE4MDdjYmZmMzhmMjFhYTEwYwotLS0gL2Rldi9udWxsCisrKyBiL1BlcmZvcm1hbmNlVGVz dHMvQmluZGluZ3MvZ2V0LWVsZW1lbnQtYnktaWQuaHRtbApAQCAtMCwwICsxLDE1IEBACis8IURP Q1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8ZGl2IGlkPSJmb28iPjwvZGl2PgorPHNjcmlw dCBzcmM9Ii4uL3Jlc291cmNlcy9ydW5uZXIuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK1BlcmZU ZXN0UnVubmVyLnJ1blBlclNlY29uZCh7CisgICAgZGVzY3JpcHRpb246ICJUaGlzIGJlbmNobWFy ayBjb3ZlcnMgJ2dldEVsZW1lbnRCeUlkJyBpbiBEcm9tYWVvL2RvbS1xdWVyeS5odG1sLCBhbmQg b3RoZXIgRE9NIG1ldGhvZHMgdGhhdCByZXR1cm4gYSBOb2RlIG9iamVjdC4iLAorICAgIHJ1bjog ZnVuY3Rpb24oKSB7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwOyBpKyspCisg ICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZm9vIik7Cit9fSk7Cis8L3Njcmlw dD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdl TG9nIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGRjMjgzYmE1NDQ2MDkxNmY2 MmI5NmY3YjYwYTc2NjM4MDI0YjIwNC4uZWI1NGJhMGFjZmI1NzAwMGU3NzFkNjg0MDJmMGEzNzBl MjQxYWQxMSAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKKysrIGIvUGVy Zm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSw0NyBAQAogMjAxMi0wNS0xNyAgS2Vu dGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgW3BlcmYtdGVzdF0g QWRkIGEgYmluZGluZyBiZW5jaG1hcmsgZm9yIGdldEVsZW1lbnRCeUlkKCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2ODA4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5IEJpbmRpbmdzL2Rv bS1hdHRyaWJ1dGVzLmh0bWwgaXMganVzdCBhIGNvbGxlY3Rpb24KKyAgICAgICAgb2YgcmFuZG9t IERPTSBhdHRyaWJ1dGVzIGFuZCBtZXRob2RzLiBXZSBzaG91bGQgcmVtb3ZlIGl0IGFuZAorICAg ICAgICBpbnN0ZWFkIGFkZCBtb3JlIHJlYXNvbmFibGUgbWljcm8gYmVuY2htYXJrcyBieSBjbGFz c2lmeWluZworICAgICAgICBET00gYmluZGluZyBjYWxsIHBhdGhzLgorCisgICAgICAgIFRoaXMg cGF0Y2ggYWRkcyBhIGJlbmNobWFyayBmb3IgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoKSwKKyAg ICAgICAgd2hpY2ggY292ZXJzIG90aGVyIERPTSBtZXRob2RzIHRoYXQgcmV0dXJuIGEgTm9kZSBP YmplY3QuCisKKyAgICAgICAgVGhlIHJlYXNvbiB3aHkgd2Ugd2FudCB0byBhZGQgYSBiZW5jaG1h cmsgZm9yIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCkKKyAgICAgICAgaW4gc3BpdGUgb2YgdGhl IGZhY3QgdGhhdCBEcm9tYWVvL2RvbS1xdWVyeS5odG1sIGlzIGFscmVhZHkgdGVzdGluZworICAg ICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgpLCBpcyB0aGF0IERyb21hZW8vZG9tLXF1ZXJ5 Lmh0bWwgb3V0cHV0cyBvbmUKKyAgICAgICAgcmVzdWx0IGZvciBzZXZlcmFsIGJlbmNobWFya3Mg KGkuZS4gZ2V0RWxlbWVudEJ5SWQoKS5ub2RlVHlwZSwKKyAgICAgICAgZ2V0RWxlbWVudHNCeVRh Z05hbWUoKVswXS5ub2RlVHlwZSBldGMpLCBhbmQgdGh1cyB3ZSBjYW5ub3Qgb2JzZXJ2ZQorICAg ICAgICByZWdyZXNzaW9uIG9mIGdldEVsZW1lbnRCeUlkKCkgaXRzZWxmLiAoQ2F0Y2hpbmcgcmVn cmVzc2lvbiBvZgorICAgICAgICBnZXRFbGVtZW50QnlJZCgpIHdvdWxkIGJlIGNyaXRpY2FsLikK KworICAgICAgICBUZXN0IHJlc3VsdHMgaW4gbXkgTGludXggZGVza3RvcDoKKworICAgICAgICBS RVNVTFQgQmluZGluZ3M6IGdldC1lbGVtZW50LWJ5LWlkPSAzMDAuOTMzNzA3Nzk1IHJ1bnMvcwor ICAgICAgICBtZWRpYW49IDMwMi4yNjcwMDI1MTkgcnVucy9zLCBzdGRldj0gMy4wNDk1NDY0ODUw NCBydW5zL3MsIG1pbj0gMjk1LjkzMDk0OTQ0NSBydW5zL3MsIG1heD0gMzA1LjM0MzUxMTQ1IHJ1 bnMvcworCisgICAgICAgIFJFU1VMVCBCaW5kaW5nczogZ2V0LWVsZW1lbnQtYnktaWQ9IDMwMi4w MzAzMjQ0ODMgcnVucy9zCisgICAgICAgIG1lZGlhbj0gMzAyLjI2NzQ4MTk3NyBydW5zL3MsIHN0 ZGV2PSAxLjc4NTE4MDY4MzY3IHJ1bnMvcywgbWluPSAyOTguNTA3NDYyNjg3IHJ1bnMvcywgbWF4 PSAzMDQuNTY4NTI3OTE5IHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBCaW5kaW5nczogZ2V0LWVs ZW1lbnQtYnktaWQ9IDMwMS45OTM0ODM1MzggcnVucy9zCisgICAgICAgIG1lZGlhbj0gMzAyLjY0 ODE3MTUwMSBydW5zL3MsIHN0ZGV2PSAxLjg3NjA0MTI2NjI2IHJ1bnMvcywgbWluPSAyOTYuNjYy NTQ2MzU0IHJ1bnMvcywgbWF4PSAzMDQuNTY4NTI3OTE5IHJ1bnMvcworCisgICAgICAgIFJFU1VM VCBCaW5kaW5nczogZ2V0LWVsZW1lbnQtYnktaWQ9IDMwMS45MzY2MDc5ODIgcnVucy9zCisgICAg ICAgIG1lZGlhbj0gMzAyLjQ1NzU4NzAxIHJ1bnMvcywgc3RkZXY9IDEuODg5OTEwODcwNzIgcnVu cy9zLCBtaW49IDI5OC44NzkyMDI5ODkgcnVucy9zLCBtYXg9IDMwNC45NTU1MjczMTkgcnVucy9z CisKKyAgICAgICAgUkVTVUxUIEJpbmRpbmdzOiBnZXQtZWxlbWVudC1ieS1pZD0gMzAxLjk1MjIz NDU2MyBydW5zL3MKKyAgICAgICAgbWVkaWFuPSAzMDIuNjQ4MTcxNTAxIHJ1bnMvcywgc3RkZXY9 IDEuNTk5Mjk3NTI2MTQgcnVucy9zLCBtaW49IDI5OS42MjU0NjgxNjUgcnVucy9zLCBtYXg9IDMw NC41Njg1Mjc5MTkgcnVucy9zCisKKyAgICAgICAgKiBCaW5kaW5ncy9nZXQtZWxlbWVudC1ieS1p ZC5odG1sOiBBZGRlZC4KKworMjAxMi0wNS0xNyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJv bWl1bS5vcmc+CisKICAgICAgICAgW3BlcmYtdGVzdF0gQWRkIGEgbWljcm8gYmVuY2htYXJrIGZv ciBkaXYuZmlyc3RDaGlsZCBnZXR0ZXIgZm9yIGFuIHVuZGVmaW5lZCBmaXJzdENoaWxkCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjcyNQogCg==