86803 2012-05-17 21:45:20 -0700 [V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor() 2012-05-17 22:50:02 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 627318 0 haraken 2012-05-17 21:45:20 -0700 V8Proxy::deletionNotHandledByInterceptor() is used by V8StorageCustom.cpp only, just in order to return v8::Handle<v8::Boolean>(). In such cases, other custom bindings are hard-coding 'return v8::Handle<v8::Boolean>()'. Thus we can hard-code 'return v8::Handle<v8::Boolean>()' in V8StorageCustom.cpp too, and remove V8Proxy::deletionNotHandledByInterceptor(). 627321 1 142627 haraken 2012-05-17 21:47:05 -0700 Created attachment 142627 Patch 627334 2 142627 haraken 2012-05-17 22:18:33 -0700 Comment on attachment 142627 Patch Thanks! 627356 3 142627 webkit.review.bot 2012-05-17 22:49:57 -0700 Comment on attachment 142627 Patch Clearing flags on attachment: 142627 Committed r117546: <http://trac.webkit.org/changeset/117546> 627357 4 webkit.review.bot 2012-05-17 22:50:02 -0700 All reviewed patches have been landed. Closing bug. 142627 2012-05-17 21:47:05 -0700 2012-05-17 22:49:57 -0700 Patch bug-86803-20120518134703.patch text/plain 2606 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI3M2ExYTI0ODA4NGRm Zjg4YmNjMzNkM2IzZjM2ZDAyNzY5Zjc3NS4uNWNhMzc5NTVlMjgyNTdmY2I2NWM4ZDAyOTRlZjE0 ZjliZWZiOTIwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDEyLTA1LTE3ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdW1JlZmFjdG9y aW5nXSBSZW1vdmUgVjhQcm94eTo6ZGVsZXRpb25Ob3RIYW5kbGVkQnlJbnRlcmNlcHRvcigpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjgwMworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFY4UHJveHk6OmRl bGV0aW9uTm90SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKSBpcyB1c2VkIGJ5IFY4U3RvcmFnZUN1c3Rv bS5jcHAKKyAgICAgICAgb25seSwganVzdCBpbiBvcmRlciB0byByZXR1cm4gdjg6OkhhbmRsZTx2 ODo6Qm9vbGVhbj4oKS4gSW4gc3VjaCBjYXNlcywKKyAgICAgICAgb3RoZXIgY3VzdG9tIGJpbmRp bmdzIGFyZSBoYXJkLWNvZGluZyAncmV0dXJuIHY4OjpIYW5kbGU8djg6OkJvb2xlYW4+KCknLgor ICAgICAgICBUaHVzIHdlIGNhbiBoYXJkLWNvZGUgJ3JldHVybiB2ODo6SGFuZGxlPHY4OjpCb29s ZWFuPigpJyBpbiBWOFN0b3JhZ2VDdXN0b20uY3BwCisgICAgICAgIHRvbywgYW5kIHJlbW92ZSBW OFByb3h5OjpkZWxldGlvbk5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCkuCisKKyAgICAgICAgTm8g dGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4 UHJveHkuaDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhTdG9yYWdlQ3VzdG9tLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OnN0b3JhZ2VEZWxldGVyKToKKworMjAxMi0wNS0xNyAgS2Vu dGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW1Y4XVtSZWZhY3Rv cmluZ10gUmVtb3ZlIFY4UHJveHk6OnRocm93RXJyb3IoY29uc3QgY2hhciosIHY4OjpJc29sYXRl KiA9IDApCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 Njc5NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5Lmgg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgKaW5kZXggNDFkYzg1ZmE5ZTMx NjBkMTZlYjY0NGU1ZDRjODU1NjJmM2RkMDc1Mi4uZTVlOTQ3MTAzYzE1M2E5ZTk5NTY4Y2M4ZGU3 NmRlMGE5YTU2YjhmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQ cm94eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaApAQCAtMzIw LDExICszMjAsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHJldHVybiB2ODo6TG9j YWw8djg6Ok9iamVjdD4oKTsKICAgICB9CiAKLSAgICBpbmxpbmUgc3RhdGljIHY4OjpMb2NhbDx2 ODo6Qm9vbGVhbj4gZGVsZXRpb25Ob3RIYW5kbGVkQnlJbnRlcmNlcHRvcigpCi0gICAgewotICAg ICAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpCb29sZWFuPigpOwotICAgIH0KLQogICAgIGlubGlu ZSB2ODo6SGFuZGxlPHY4OjpQcmltaXRpdmU+IHRocm93RXJyb3IoY29uc3QgY2hhciogbWVzc2Fn ZSwgVjhQcm94eTo6RXJyb3JUeXBlIHR5cGUsIHY4OjpJc29sYXRlKiBpc29sYXRlID0gMCkKICAg ICB7CiAgICAgICAgIGlmICghdjg6OlY4OjpJc0V4ZWN1dGlvblRlcm1pbmF0aW5nKCkpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTdG9yYWdlQ3VzdG9t LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20u Y3BwCmluZGV4IDg5NjMzMDQzOTBmMzM2OGQzYzdlNjVlYmM1YThiMTM5N2Y5YTNmNjMuLjQyNDdm ZGU5ODk5MDUxOGY1Yjk4ODIyOThhYjYzMDRlZmU0YWRkNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFN0b3JhZ2VDdXN0b20uY3BwCkBAIC0xMzYs NyArMTM2LDcgQEAgc3RhdGljIHY4OjpIYW5kbGU8djg6OkJvb2xlYW4+IHN0b3JhZ2VEZWxldGVy KHY4OjpMb2NhbDx2ODo6U3RyaW5nPiB2OE5hbWUsIGNvbnMKICAgICAgICAgcmV0dXJuIHY4OjpU cnVlKCk7CiAgICAgfQogCi0gICAgcmV0dXJuIGRlbGV0aW9uTm90SGFuZGxlZEJ5SW50ZXJjZXB0 b3IoKTsKKyAgICByZXR1cm4gdjg6OkhhbmRsZTx2ODo6Qm9vbGVhbj4oKTsKIH0KIAogdjg6Okhh bmRsZTx2ODo6Qm9vbGVhbj4gVjhTdG9yYWdlOjppbmRleGVkUHJvcGVydHlEZWxldGVyKHVpbnQz Ml90IGluZGV4LCBjb25zdCB2ODo6QWNjZXNzb3JJbmZvJiBpbmZvKQo=