86800 2012-05-17 19:52:37 -0700 [NRWT] REGRESSION(r116021): Assertion when running with --no-http 2012-05-24 15:03:55 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64491 78628 1 rakuco tmpsantos abarth dpranke ojan ossy tmpsantos tony webkit.review.bot oldest_to_newest 627251 0 rakuco 2012-05-17 19:52:37 -0700 When running `./Tools/Scripts/run-webkit-tests --efl --debug --no-http' I hit the following assertion: Traceback (most recent call last): File "/home/rakuco/dev/webkit/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 457, in <module> sys.exit(main()) File "/home/rakuco/dev/webkit/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 452, in main return run(port, options, args) File "/home/rakuco/dev/webkit/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 125, in run unexpected_result_count = manager.run() File "/home/rakuco/dev/webkit/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 906, in run interrupted, keyboard_interrupted, thread_timings, test_timings, individual_test_timings = self._run_tests(self._test_files_list, result_summary, int(self._options.child_processes)) File "/home/rakuco/dev/webkit/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 756, in _run_tests self.start_servers_with_lock() File "/home/rakuco/dev/webkit/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 955, in start_servers_with_lock assert(self._options.http) 627256 1 dpranke 2012-05-17 19:55:13 -0700 Looks like this is caused by including perf tests in the "locked" shard. 627259 2 rakuco 2012-05-17 19:55:58 -0700 Added in <http://trac.webkit.org/changeset/116021>. 631683 3 rakuco 2012-05-23 08:22:55 -0700 *** Bug 87267 has been marked as a duplicate of this bug. *** 631759 4 tony 2012-05-23 10:15:32 -0700 We should roll out if no one is going to get a chance to investigate this soon. 631960 5 dpranke 2012-05-23 13:18:03 -0700 (In reply to comment #4) > We should roll out if no one is going to get a chance to investigate this soon. I'll fix this later today. 632581 6 143777 tmpsantos 2012-05-24 03:29:04 -0700 Created attachment 143777 Patch 632835 7 143777 abarth 2012-05-24 08:39:08 -0700 Comment on attachment 143777 Patch Can we write a test that will catch this problem in the future? 633034 8 dpranke 2012-05-24 12:04:38 -0700 This patch looks fine, but I think it might actually be better to revert the change that added the perf tests to the locked shards, since that didn't actually do what Tony thought it did, and I'm not sure if it had the intended effect. Tony, WDYT? 633216 9 tmpsantos 2012-05-24 14:22:11 -0700 (In reply to comment #8) > This patch looks fine, but I think it might actually be better to revert the change that added the perf tests to the locked shards, since that didn't actually do what Tony thought it did, and I'm not sure if it had the intended effect. Tony, WDYT? I was the one who wrote the original patch moving perf to locked shards. For the EFL Debug bot at least, it solved the flakiness issue. And yes, I can write utests for it. 633225 10 tony 2012-05-24 14:28:27 -0700 (In reply to comment #8) > This patch looks fine, but I think it might actually be better to revert the change that added the perf tests to the locked shards, since that didn't actually do what Tony thought it did, and I'm not sure if it had the intended effect. Tony, WDYT? Either is fine with me. It sounds like there were benefits of this patch for tmpsantos, so I don't mind keeping it. It still ensures that we don't mix http tests with perf tests, right? 633233 11 dpranke 2012-05-24 14:33:11 -0700 Oh, sorry, I thought Tony did the original patch. At any rate, the change looks fine so I'll r+ it and if it's valuable to you feel free to land it. 633245 12 tmpsantos 2012-05-24 14:38:18 -0700 (In reply to comment #11) > Oh, sorry, I thought Tony did the original patch. > > At any rate, the change looks fine so I'll r+ it and if it's valuable to you feel free to land it. I might need someone with cq+ superpowers then. :) 633280 13 143777 webkit.review.bot 2012-05-24 15:03:48 -0700 Comment on attachment 143777 Patch Clearing flags on attachment: 143777 Committed r118421: <http://trac.webkit.org/changeset/118421> 633281 14 webkit.review.bot 2012-05-24 15:03:55 -0700 All reviewed patches have been landed. Closing bug. 143777 2012-05-24 03:29:04 -0700 2012-05-24 15:03:47 -0700 Patch bug-86800-20120524133025.patch text/plain 1555 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTE4MTY0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmUyOTM0NGNiYjNlMzVkNTc2MDAwZTliMGY2NGE1Yjc0 Y2JkMmRkOC4uMjllN2E2M2I4N2VmZjJlMWQwYzM1NDE4MDE1YzlkZjI4Y2Y0ZTIxYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA1LTI0ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIFtOUldUXSBSRUdSRVNTSU9OKHIxMTYwMjEpOiBBc3NlcnRp b24gd2hlbiBydW5uaW5nIHdpdGggLS1uby1odHRwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjgwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERvbid0IGxhdW5jaCBhIEhUVFAgc2VydmVyIHdpdGggbG9j ayBiYXNlZCBvbmx5IG9uIHRoZSBleGlzdGVuY2Ugb2YKKyAgICAgICAgbG9ja2VkIHNoYXJkcyBz aW5jZSB3ZSBub3cgcnVuIHBlcmYgb24gbG9ja2VkIHNoYXJkcyB0b28uCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5OgorICAg ICAgICAoTWFuYWdlci5fcnVuX3Rlc3RzKToKKwogMjAxMi0wNS0yMyAgWmFuIERvYmVyc2VrICA8 emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFtHdGtdIEV2ZW50U2VuZGVyIHNob3Vs ZCBwcm9wZXJseSBoYW5kbGUgKGxlZnR8cmlnaHQpKGNvbnRyb2x8c2hpZnR8YWx0KSBhZnRlciBy MTE4MDAxCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9j b250cm9sbGVycy9tYW5hZ2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvY29udHJvbGxlcnMvbWFuYWdlci5weQppbmRleCA0MzIzZGJiMTRlNzE3NDUyYThmM2ZmYjJi Nzk4OTdlNDQ0ZjhlZmViLi4wNDczNzdjNzQ4YTIxZjg2ODRmZDNmOTBjODdlY2YwNjE5MWYzNDkw IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9s bGVycy9tYW5hZ2VyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L2NvbnRyb2xsZXJzL21hbmFnZXIucHkKQEAgLTc0MCw3ICs3NDAsNyBAQCBjbGFzcyBNYW5hZ2Vy KG9iamVjdCk6CiAKICAgICAgICAgYWxsX3NoYXJkcyA9IGxvY2tlZF9zaGFyZHMgKyB1bmxvY2tl ZF9zaGFyZHMKICAgICAgICAgc2VsZi5fcmVtYWluaW5nX2xvY2tlZF9zaGFyZHMgPSBsb2NrZWRf c2hhcmRzCi0gICAgICAgIGlmIGxvY2tlZF9zaGFyZHM6CisgICAgICAgIGlmIGxvY2tlZF9zaGFy ZHMgYW5kIHNlbGYuX29wdGlvbnMuaHR0cDoKICAgICAgICAgICAgIHNlbGYuc3RhcnRfc2VydmVy c193aXRoX2xvY2soKQogCiAgICAgICAgIG51bV93b3JrZXJzID0gbWluKG51bV93b3JrZXJzLCBs ZW4oYWxsX3NoYXJkcykpCg==