86788 2012-05-17 17:06:01 -0700 Plug-ins blacklist mechanism can tell clients about plug-in with null identifier 2012-05-17 21:47:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca pnormand oldest_to_newest 627138 0 andersca 2012-05-17 17:06:01 -0700 Plug-ins blacklist mechanism can tell clients about plug-in with null identifier 627139 1 142591 andersca 2012-05-17 17:08:36 -0700 Created attachment 142591 Patch 627140 2 andersca 2012-05-17 17:12:17 -0700 Committed r117516: <http://trac.webkit.org/changeset/117516> 627312 3 142591 pnormand 2012-05-17 21:36:03 -0700 Comment on attachment 142591 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142591&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:3639 > - m_loaderClient.didBlockInsecurePluginVersion(this, mimeType, pluginIdentifier, pluginVersion); > + m_loaderClient.didBlockInsecurePluginVersion(this, newMimeType, pluginIdentifier, pluginVersion); newMimeType is guarded by PLATFORM(MAC) above... This patch broke GTK and Qt builds... 627317 4 pnormand 2012-05-17 21:44:40 -0700 Build fix in http://trac.webkit.org/changeset/117539. Can you please care about the EWS next time before landing? FYI, purple bubble means patch didn't apply correctly (=> EWS did not build the patch). 627322 5 pnormand 2012-05-17 21:47:27 -0700 Actually at least the GTK EWS did build the patch and failed at it. So... no excuse :) 142591 2012-05-17 17:08:36 -0700 2012-05-17 21:36:03 -0700 Patch bug-86788-20120517171105.patch text/plain 5022 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWU0OTVkN2Y0ODMwZmI3 NjdjYzczMGNlZjZlNzc4MjhhN2UxMDNjOS4uNDE2NTZmOTc3NzllN2I2ZmZmMjA3YzZkOTJjYmI3 ZDY3MjRhZDk2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTE3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUGx1Zy1pbnMgYmxh Y2tsaXN0IG1lY2hhbmlzbSBjYW4gdGVsbCBjbGllbnRzIGFib3V0IHBsdWctaW4gd2l0aCBudWxs IGlkZW50aWZpZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg2Nzg4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTQ3OTUwMz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXNzIGFsb25nIHRoZSBVUkwg c3RyaW5nIG9mIHRoZSBibG9ja2VkIHBsdWctaW4gc28gd2UgY2FuIGZpbmQgdGhlIHBsdWctaW4g ZXZlbiBpZiB0aGVyZSB3YXMgbm8KKyAgICAgICAgTUlNRSB0eXBlIHNwZWNpZmllZCBpbiB0aGUg PGVtYmVkPiBvciA8b2JqZWN0PiB0YWcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkaWRCbG9ja0luc2VjdXJl UGx1Z2luVmVyc2lvbik6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oOgorICAg ICAgICAoV2ViUGFnZVByb3h5KToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1l c3NhZ2VzLmluOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Y3JlYXRlUGx1Z2luKToKKwogMjAxMi0wNS0xNyAgT2xp dmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEVuZGVhdm91ciB0byBtYWtl IHRoZSB3aW5kb3dzIHRlc3QgYm90IGFjdHVhbGx5IGFibGUgdG8gcnVuIHRlc3RzLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCBlYjBlZjcxZTY2ZDQzYTI2 YWRlNDVhNWFkYWVlN2IzZjFiOWY1MzA5Li5iY2M3NDhiZTQ2ZjFjZTJlZDU2ZjQxZTkwZjIwNDBm ZWU4ZjhlMTJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApA QCAtMzYyMywyMCArMzYyMywyMCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkRmFpbFRvSW5pdGlh bGl6ZVBsdWdpbihjb25zdCBTdHJpbmcmIG1pbWVUeXBlKQogICAgIG1fbG9hZGVyQ2xpZW50LmRp ZEZhaWxUb0luaXRpYWxpemVQbHVnaW4odGhpcywgbWltZVR5cGUpOwogfQogCi12b2lkIFdlYlBh Z2VQcm94eTo6ZGlkQmxvY2tJbnNlY3VyZVBsdWdpblZlcnNpb24oY29uc3QgU3RyaW5nJiBtaW1l VHlwZSkKK3ZvaWQgV2ViUGFnZVByb3h5OjpkaWRCbG9ja0luc2VjdXJlUGx1Z2luVmVyc2lvbihj b25zdCBTdHJpbmcmIG1pbWVUeXBlLCBjb25zdCBTdHJpbmcmIHVybFN0cmluZykKIHsKICAgICBT dHJpbmcgcGx1Z2luSWRlbnRpZmllcjsKICAgICBTdHJpbmcgcGx1Z2luVmVyc2lvbjsKIAogI2lm IFBMQVRGT1JNKE1BQykKICAgICBTdHJpbmcgbmV3TWltZVR5cGUgPSBtaW1lVHlwZTsKLSAgICBQ bHVnaW5Nb2R1bGVJbmZvIHBsdWdpbiA9IG1fcHJvY2Vzcy0+Y29udGV4dCgpLT5wbHVnaW5JbmZv U3RvcmUoKS5maW5kUGx1Z2luKG5ld01pbWVUeXBlLCBLVVJMKCkpOworICAgIFBsdWdpbk1vZHVs ZUluZm8gcGx1Z2luID0gbV9wcm9jZXNzLT5jb250ZXh0KCktPnBsdWdpbkluZm9TdG9yZSgpLmZp bmRQbHVnaW4obmV3TWltZVR5cGUsIEtVUkwoS1VSTCgpLCB1cmxTdHJpbmcpKTsKIAogICAgIHBs dWdpbklkZW50aWZpZXIgPSBwbHVnaW4uYnVuZGxlSWRlbnRpZmllcjsKICAgICBwbHVnaW5WZXJz aW9uID0gcGx1Z2luLnZlcnNpb25TdHJpbmc7CiAjZW5kaWYKIAotICAgIG1fbG9hZGVyQ2xpZW50 LmRpZEJsb2NrSW5zZWN1cmVQbHVnaW5WZXJzaW9uKHRoaXMsIG1pbWVUeXBlLCBwbHVnaW5JZGVu dGlmaWVyLCBwbHVnaW5WZXJzaW9uKTsKKyAgICBtX2xvYWRlckNsaWVudC5kaWRCbG9ja0luc2Vj dXJlUGx1Z2luVmVyc2lvbih0aGlzLCBuZXdNaW1lVHlwZSwgcGx1Z2luSWRlbnRpZmllciwgcGx1 Z2luVmVyc2lvbik7CiB9CiAKIGJvb2wgV2ViUGFnZVByb3h5Ojp3aWxsSGFuZGxlSG9yaXpvbnRh bFNjcm9sbEV2ZW50cygpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmgKaW5kZXggZWYzMzFmYzdkNzM1YjcyMmM1YjFiZjFjMTE3ODVmODA3ZTFjNTg0ZC4uZGM5OTk0 ZjFhNDcyZWI1YzVhOTI3YTYxOTk4MzQyYWVhM2MzNzIyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuaApAQCAtNzQ1LDcgKzc0NSw3IEBAIHByaXZhdGU6CiAgICAgdm9p ZCBkaWRDaGFuZ2VTY3JvbGxPZmZzZXRQaW5uaW5nRm9yTWFpbkZyYW1lKGJvb2wgcGlubmVkVG9M ZWZ0U2lkZSwgYm9vbCBwaW5uZWRUb1JpZ2h0U2lkZSk7CiAgICAgdm9pZCBkaWRDaGFuZ2VQYWdl Q291bnQodW5zaWduZWQpOwogICAgIHZvaWQgZGlkRmFpbFRvSW5pdGlhbGl6ZVBsdWdpbihjb25z dCBTdHJpbmcmIG1pbWVUeXBlKTsKLSAgICB2b2lkIGRpZEJsb2NrSW5zZWN1cmVQbHVnaW5WZXJz aW9uKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpOworICAgIHZvaWQgZGlkQmxvY2tJbnNlY3VyZVBs dWdpblZlcnNpb24oY29uc3QgU3RyaW5nJiBtaW1lVHlwZSwgY29uc3QgU3RyaW5nJiB1cmxTdHJp bmcpOwogICAgIHZvaWQgc2V0Q2FuU2hvcnRDaXJjdWl0SG9yaXpvbnRhbFdoZWVsRXZlbnRzKGJv b2wgY2FuU2hvcnRDaXJjdWl0SG9yaXpvbnRhbFdoZWVsRXZlbnRzKSB7IG1fY2FuU2hvcnRDaXJj dWl0SG9yaXpvbnRhbFdoZWVsRXZlbnRzID0gY2FuU2hvcnRDaXJjdWl0SG9yaXpvbnRhbFdoZWVs RXZlbnRzOyB9CiAKICAgICB2b2lkIHJlYXR0YWNoVG9XZWJQcm9jZXNzKCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbgppbmRleCA0YzQ4 YTNjZDg1ZDUzNDcwYzM5MGZlNDJkNmY1ZTgzNWIyNDE3MTU1Li5mYWVjNTU1ZTFlZGEwYjJhZjZl MTA5NjFhZWZlODk3ODc5MGY0YmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW4KQEAgLTY2LDcgKzY2LDcgQEAgbWVzc2FnZXMgLT4g V2ViUGFnZVByb3h5IHsKICAgICBEaWRDaGFuZ2VTY3JvbGxPZmZzZXRQaW5uaW5nRm9yTWFpbkZy YW1lKGJvb2wgaGFzSG9yaXpvbnRhbFNjcm9sbGJhciwgYm9vbCBoYXNWZXJ0aWNhbFNjcm9sbGJh cikKICAgICBEaWRDaGFuZ2VQYWdlQ291bnQodW5zaWduZWQgcGFnZUNvdW50KTsKICAgICBEaWRG YWlsVG9Jbml0aWFsaXplUGx1Z2luKFdURjo6U3RyaW5nIG1pbWVUeXBlKQotICAgIERpZEJsb2Nr SW5zZWN1cmVQbHVnaW5WZXJzaW9uKFdURjo6U3RyaW5nIG1pbWVUeXBlKQorICAgIERpZEJsb2Nr SW5zZWN1cmVQbHVnaW5WZXJzaW9uKFdURjo6U3RyaW5nIG1pbWVUeXBlLCBXVEY6OlN0cmluZyB1 cmxTdHJpbmcpCiAgICAgU2V0Q2FuU2hvcnRDaXJjdWl0SG9yaXpvbnRhbFdoZWVsRXZlbnRzKGJv b2wgY2FuU2hvcnRDaXJjdWl0SG9yaXpvbnRhbFdoZWVsRXZlbnRzKQogCiAjaWYgVVNFKFRJTEVE X0JBQ0tJTkdfU1RPUkUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKaW5kZXggMmEwYTI2M2Q4MDExZTEwNzYxOGQzOTBlNGM3MThjZTdiMjRhZTNmYy4u OWRhYWNlNmE3NDY4MGQ4Mzc2YmFmOTBlOTc5NWQxY2VmN2FhYzQ1YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcApAQCAtNDAxLDcgKzQwMSw3IEBA IFBhc3NSZWZQdHI8UGx1Z2luPiBXZWJQYWdlOjpjcmVhdGVQbHVnaW4oV2ViRnJhbWUqIGZyYW1l LCBIVE1MUGx1Z0luRWxlbWVudCogcGx1CiAgICAgICAgIGlmIChwbHVnaW5FbGVtZW50LT5yZW5k ZXJlcigpLT5pc0VtYmVkZGVkT2JqZWN0KCkpCiAgICAgICAgICAgICB0b1JlbmRlckVtYmVkZGVk T2JqZWN0KHBsdWdpbkVsZW1lbnQtPnJlbmRlcmVyKCkpLT5zZXRQbHVnaW5VbmF2YWlsYWJpbGl0 eVJlYXNvbihSZW5kZXJFbWJlZGRlZE9iamVjdDo6SW5zZWN1cmVQbHVnaW5WZXJzaW9uKTsKIAot ICAgICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6OkRpZEJsb2NrSW5zZWN1cmVQbHVn aW5WZXJzaW9uKHBhcmFtZXRlcnMubWltZVR5cGUpKTsKKyAgICAgICAgc2VuZChNZXNzYWdlczo6 V2ViUGFnZVByb3h5OjpEaWRCbG9ja0luc2VjdXJlUGx1Z2luVmVyc2lvbihwYXJhbWV0ZXJzLm1p bWVUeXBlLCBwYXJhbWV0ZXJzLnVybC5zdHJpbmcoKSkpOwogICAgICAgICByZXR1cm4gMDsKICAg ICB9CiAK