86776 2012-05-17 14:26:52 -0700 [Skia] -webkit-font-smoothing has no effect in Windows 2013-04-08 18:13:36 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC Windows 7 RESOLVED WONTFIX P2 Normal --- 1 shezbaig.wk shezbaig.wk cc-bugs darin jamesr senorblanco webkit.review.bot oldest_to_newest 626984 0 shezbaig.wk 2012-05-17 14:26:52 -0700 Should should be propagated when setting up the paint for text 627935 1 142764 shezbaig.wk 2012-05-18 12:36:20 -0700 Created attachment 142764 Patch 758051 2 142764 rniwa 2012-11-03 22:58:34 -0700 Comment on attachment 142764 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142764&action=review > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:282 > + const FontPlatformData& data, This indentation violates WebKit's coding style. Is it expected in platform/graphics/skia? 784951 3 shezbaig.wk 2012-12-06 07:59:55 -0800 (In reply to comment #2) > (From update of attachment 142764 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142764&action=review > > > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:282 > > + const FontPlatformData& data, > > This indentation violates WebKit's coding style. Is it expected in platform/graphics/skia? It is consistent with the coding style used in the rest of the file. 871338 4 142764 darin 2013-04-08 18:13:25 -0700 Comment on attachment 142764 Patch Clearing flags from Skia-specific patch. 871339 5 darin 2013-04-08 18:13:36 -0700 Skia-specific patch. 142764 2012-05-18 12:36:20 -0700 2013-04-08 18:13:25 -0700 Patch bug-86776-20120518153730.patch text/plain 5153 shezbaig.wk U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTg1YjhkMjZhY2Y2NzU2 NDI1MjY0MDM1M2VlOTYxYmVkMWYzMDQzMi4uMzI1NzY1NjRkZGRkYzk4MTc1NGVkYzk5NDBhYzk4 MDc3OTI5YTdmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMxIEBACiAyMDEyLTA1LTE4ICBTaGV6 YW4gQmFpZyAgPHNoZXpiYWlnLndrQGdtYWlsLmNvbT4KIAorICAgICAgICBbU2tpYV0gLXdlYmtp dC1mb250LXNtb290aGluZyBoYXMgbm8gZWZmZWN0IGluIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2Nzc2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRoZSBmb250U21vb3RoaW5nIHNl dHRpbmcgZnJvbSB0aGUgRm9udERlc2NyaXB0aW9uIHRvIGRldGVybWluZSB0aGUKKyAgICAgICAg bGZRdWFsaXR5IHVzZWQgaW4gcGFpbnRTa2lhVGV4dC4gVGhlIGxmUXVhbGl0eSBmcm9tIHRoZQor ICAgICAgICBGb250UGxhdGZvcm1EYXRhIHdpbGwgb25seSBiZSB1c2VkIGlmIHRoZSBmb250U21v b3RoaW5nIGlzIHRoZSBkZWZhdWx0CisgICAgICAgIEF1dG9TbW9vdGhpbmcuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiBBbnRpYWxpYXNlZCB0ZXh0IGlzIGRpc2FibGVkIGluIGxheW91dHRlc3Rz LCBzbyB0aGV5CisgICAgICAgIHNob3VsZCBiZSB1bmFmZmVjdGVkIGJ5IHRoZSBkaWZmZXJlbmNl IGluIGFudGlhbGlhc2luZyBxdWFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vRm9udENocm9taXVtV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZvbnQ6OmRy YXdHbHlwaHMpOgorICAgICAgICBEZXRlcm1pbmUgdGhlIHF1YWxpdHkgYmFzZWQgb24gdGhlIGZv bnRTbW9vdGhpbmcgc2V0dGluZy4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL1Nr aWFGb250V2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBhaW50U2tpYVRleHQpOgorICAgICAg ICAoV2ViQ29yZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9Ta2lhRm9udFdp bi5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIEFkZCBhbiBvdmVybG9hZGVkIHBhaW50 U2tpYVRleHQgdGhhdCBhbGxvd3MgdXMgdG8gb3ZlcnJpZGUgdGhlIHF1YWxpdHkKKyAgICAgICAg ZnJvbSB0aGUgRm9udFBsYXRmb3JtRGF0YS4KKworMjAxMi0wNS0xOCAgU2hlemFuIEJhaWcgIDxz aGV6YmFpZy53a0BnbWFpbC5jb20+CisKICAgICAgICAgRXhwb3NlIEZyYW1lU2VsZWN0aW9uOjph YnNvbHV0ZUNhcmV0Qm91bmRzIHZpYSB3aW5kb3cuaW50ZXJuYWxzCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjM5MAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2hyb21pdW1XaW4uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vRm9udENocm9taXVt V2luLmNwcAppbmRleCAzZDMwZTE4ZWI5OGE3ZmVhOGE0NDE4OTJiMzA0YjcyZjhmZGY1OTE5Li5j MmFhOTMxMjFlYjljZWRhYjdmMGVmM2E0ZWIxMTFjYjhhZmU5ZWFjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9Gb250Q2hyb21pdW1XaW4uY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0ZvbnRDaHJv bWl1bVdpbi5jcHAKQEAgLTQyNyw3ICs0MjcsMjQgQEAgdm9pZCBGb250OjpkcmF3R2x5cGhzKEdy YXBoaWNzQ29udGV4dCogZ3JhcGhpY3NDb250ZXh0LAogCiAgICAgICAgIFNrUG9pbnQgb3JpZ2lu ID0gcG9pbnQ7CiAgICAgICAgIG9yaWdpbi5mWCArPSBTa0Zsb2F0VG9TY2FsYXIoaG9yaXpvbnRh bE9mZnNldCAtIHBvaW50LngoKSAtIGN1cnJlbnRXaWR0aCk7Ci0gICAgICAgIHBhaW50U2tpYVRl eHQoZ3JhcGhpY3NDb250ZXh0LCBmb250LT5wbGF0Zm9ybURhdGEoKSwgY3VyTGVuLCAmZ2x5cGhz WzBdLCAmYWR2YW5jZXNbMF0sIDAsICZvcmlnaW4pOworCisgICAgICAgIGludCBxdWFsaXR5Owor ICAgICAgICBzd2l0Y2ggKG1fZm9udERlc2NyaXB0aW9uLmZvbnRTbW9vdGhpbmcoKSkgeworICAg ICAgICBjYXNlIE5vU21vb3RoaW5nOgorICAgICAgICAgICAgcXVhbGl0eSA9IE5PTkFOVElBTElB U0VEX1FVQUxJVFk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBBbnRpYWxpYXNl ZDoKKyAgICAgICAgICAgIHF1YWxpdHkgPSBBTlRJQUxJQVNFRF9RVUFMSVRZOworICAgICAgICAg ICAgYnJlYWs7CisgICAgICAgIGNhc2UgU3VicGl4ZWxBbnRpYWxpYXNlZDoKKyAgICAgICAgICAg IHF1YWxpdHkgPSBDTEVBUlRZUEVfUVVBTElUWTsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAg ICBkZWZhdWx0OgorICAgICAgICAgICAgcXVhbGl0eSA9IGZvbnQtPnBsYXRmb3JtRGF0YSgpLmxm UXVhbGl0eSgpOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIH0KKworICAgICAgICBwYWlu dFNraWFUZXh0KGdyYXBoaWNzQ29udGV4dCwgZm9udC0+cGxhdGZvcm1EYXRhKCksIHF1YWxpdHks IGN1ckxlbiwgJmdseXBoc1swXSwgJmFkdmFuY2VzWzBdLCAwLCAmb3JpZ2luKTsKICAgICB9CiB9 CiAjZWxzZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9Ta2lhRm9udFdpbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1NraWFGb250V2luLmNwcAppbmRleCBhNmYzN2NmZjA3NGUyYmMyMzAzOWI1MzkzOTM2MGNhN2Zi MDFiM2Q4Li5mMjdkNGMyNWU2MTA0MzdkNjhkYzVmYzM0YzYzYWQ0MGFlNWY4ZDE4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1NraWFGb250V2luLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1NraWFGb250V2lu LmNwcApAQCAtMjc5LDYgKzI3OSwxOSBAQCB2b2lkIHBhaW50U2tpYVRleHQoR3JhcGhpY3NDb250 ZXh0KiBjb250ZXh0LAogfQogCiB2b2lkIHBhaW50U2tpYVRleHQoR3JhcGhpY3NDb250ZXh0KiBj b250ZXh0LAorICAgICAgICAgICAgICAgICAgIGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEmIGRhdGEs CisgICAgICAgICAgICAgICAgICAgaW50IHF1YWxpdHksCisgICAgICAgICAgICAgICAgICAgaW50 IG51bUdseXBocywKKyAgICAgICAgICAgICAgICAgICBjb25zdCBXT1JEKiBnbHlwaHMsCisgICAg ICAgICAgICAgICAgICAgY29uc3QgaW50KiBhZHZhbmNlcywKKyAgICAgICAgICAgICAgICAgICBj b25zdCBHT0ZGU0VUKiBvZmZzZXRzLAorICAgICAgICAgICAgICAgICAgIGNvbnN0IFNrUG9pbnQq IG9yaWdpbikKK3sKKyAgICBwYWludFNraWFUZXh0KGNvbnRleHQsIGRhdGEuaGZvbnQoKSwgZGF0 YS50eXBlZmFjZSgpLCBkYXRhLnNpemUoKSwgcXVhbGl0eSwKKyAgICAgICAgICAgICAgICAgIG51 bUdseXBocywgZ2x5cGhzLCBhZHZhbmNlcywgb2Zmc2V0cywgb3JpZ2luKTsKK30KKwordm9pZCBw YWludFNraWFUZXh0KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwKICAgICAgICAgICAgICAgICAg ICBIRk9OVCBoZm9udCwKICAgICAgICAgICAgICAgICAgICBpbnQgbnVtR2x5cGhzLAogICAgICAg ICAgICAgICAgICAgIGNvbnN0IFdPUkQqIGdseXBocywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvU2tpYUZvbnRXaW4uaAppbmRleCAwZjM0MzJkYzBhNDUx NGVjMTY3YjNkY2QxZTU5YTU4NWI2ODE0ZTExLi42Njg5NjYyNmQ0Yjc3MGY0ZTQ3OWIxMDVhNjll NTc0YTcwNDQxZTAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9za2lhL1NraWFGb250V2luLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvc2tpYS9Ta2lhRm9udFdpbi5oCkBAIC04Miw2ICs4MiwxOSBAQCB2b2lkIHBhaW50U2tpYVRl eHQoR3JhcGhpY3NDb250ZXh0KiwKIAogLy8gTm90ZSB0aGF0IHRoZSBvZmZzZXRzIHBhcmFtZXRl ciBpcyBvcHRpb25hbC4gSWYgbm90IG51bGwgaXQgcmVwcmVzZW50cyBhCiAvLyBwZXIgZ2x5cGgg b2Zmc2V0IChzdWNoIGFzIHJldHVybmVkIGJ5IFNjcmlwdFBsYWNlIFdpbmRvd3MgQVBJIGZ1bmN0 aW9uKS4KKy8vIE5vdGU6IHVzZSB0aGlzIGZ1bmN0aW9uIGlmIHlvdSBuZWVkIHRvIHVzZSBhIGRp ZmZlcmVudCBxdWFsaXR5IGZyb20gdGhlIG9uZQorLy8gdGhhdCBpcyBzZXQgaW4gdGhlIEZvbnRQ bGF0Zm9ybURhdGEuCit2b2lkIHBhaW50U2tpYVRleHQoR3JhcGhpY3NDb250ZXh0KiwKKyAgICAg ICAgICAgICAgICAgICBjb25zdCBGb250UGxhdGZvcm1EYXRhJiwKKyAgICAgICAgICAgICAgICAg ICBpbnQgcXVhbGl0eSwKKyAgICAgICAgICAgICAgICAgICBpbnQgbnVtR2x5cGhzLAorICAgICAg ICAgICAgICAgICAgIGNvbnN0IFdPUkQqIGdseXBocywKKyAgICAgICAgICAgICAgICAgICBjb25z dCBpbnQqIGFkdmFuY2VzLAorICAgICAgICAgICAgICAgICAgIGNvbnN0IEdPRkZTRVQqIG9mZnNl dHMsCisgICAgICAgICAgICAgICAgICAgY29uc3QgU2tQb2ludCogb3JpZ2luKTsKKworLy8gTm90 ZSB0aGF0IHRoZSBvZmZzZXRzIHBhcmFtZXRlciBpcyBvcHRpb25hbC4gSWYgbm90IG51bGwgaXQg cmVwcmVzZW50cyBhCisvLyBwZXIgZ2x5cGggb2Zmc2V0IChzdWNoIGFzIHJldHVybmVkIGJ5IFNj cmlwdFBsYWNlIFdpbmRvd3MgQVBJIGZ1bmN0aW9uKS4KIC8vIE5vdGU6IHRoaXMgaXMgbGVzcyBl ZmZpY2llbnQgdGhhbiBjYWxsaW5nIHRoZSB2ZXJzaW9uIHdpdGggRm9udFBsYXRmb3JtRGF0YSwK IC8vIGFzIHRoYXQgY2FjaGVzIHRoZSBTa1R5cGVmYWNlIG9iamVjdC4KIHZvaWQgcGFpbnRTa2lh VGV4dChHcmFwaGljc0NvbnRleHQqLAo=