86773 2012-05-17 14:04:58 -0700 Don't let -[CALayer renderInContext:] try to render WebView's root layer 2012-05-17 16:10:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes oldest_to_newest 626947 0 aestes 2012-05-17 14:04:58 -0700 Don't let -[CALayer renderInContext:] try to render WebView's root layer 626951 1 142548 aestes 2012-05-17 14:07:15 -0700 Created attachment 142548 Patch 626953 2 aestes 2012-05-17 14:08:37 -0700 <rdar://problem/10950075> 626961 3 142548 mitz 2012-05-17 14:13:30 -0700 Comment on attachment 142548 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review > Source/WebKit/mac/WebView/WebHTMLView.mm:215 > +@interface WebLayerHostingLayer : CALayer I don’t think there’s such a thing as a “layer hosting layer”. Would it be wrong to call this class WebRootLayer? 626962 4 142548 simon.fraser 2012-05-17 14:13:43 -0700 Comment on attachment 142548 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review > Source/WebKit/mac/ChangeLog:4 > + Don't let -[CALayer renderInContext:] try to render WebView's root layer > + https://bugs.webkit.org/show_bug.cgi?id=86773 You should list the radar here too. > Source/WebKit/mac/WebView/WebHTMLView.mm:5483 > - CALayer* viewLayer = [CALayer layer]; > + CALayer* viewLayer = [[[WebLayerHostingLayer alloc] init] autorelease]; Pretty sure you can still call [WebLayerHostingLayer layer]. 627074 5 aestes 2012-05-17 15:54:18 -0700 (In reply to comment #3) > (From update of attachment 142548 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review > > > Source/WebKit/mac/WebView/WebHTMLView.mm:215 > > +@interface WebLayerHostingLayer : CALayer > > I don’t think there’s such a thing as a “layer hosting layer”. Would it be wrong to call this class WebRootLayer? Nope, it would be very right! Will rename. 627076 6 aestes 2012-05-17 15:54:33 -0700 (In reply to comment #4) > (From update of attachment 142548 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review > > > Source/WebKit/mac/ChangeLog:4 > > + Don't let -[CALayer renderInContext:] try to render WebView's root layer > > + https://bugs.webkit.org/show_bug.cgi?id=86773 > > You should list the radar here too. Ok. > > > Source/WebKit/mac/WebView/WebHTMLView.mm:5483 > > - CALayer* viewLayer = [CALayer layer]; > > + CALayer* viewLayer = [[[WebLayerHostingLayer alloc] init] autorelease]; > > Pretty sure you can still call [WebLayerHostingLayer layer]. Yeah, I can and will. 627081 7 aestes 2012-05-17 16:02:03 -0700 (In reply to comment #4) > (From update of attachment 142548 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review > > Source/WebKit/mac/WebView/WebHTMLView.mm:5483 > > - CALayer* viewLayer = [CALayer layer]; > > + CALayer* viewLayer = [[[WebLayerHostingLayer alloc] init] autorelease]; > > Pretty sure you can still call [WebLayerHostingLayer layer]. Oh, no I can't since it's a class method. 627088 8 aestes 2012-05-17 16:03:32 -0700 (In reply to comment #7) > (In reply to comment #4) > > (From update of attachment 142548 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=142548&action=review > > > Source/WebKit/mac/WebView/WebHTMLView.mm:5483 > > > - CALayer* viewLayer = [CALayer layer]; > > > + CALayer* viewLayer = [[[WebLayerHostingLayer alloc] init] autorelease]; > > > > Pretty sure you can still call [WebLayerHostingLayer layer]. > > Oh, no I can't since it's a class method. Please ignore me. This works fine. 627093 9 aestes 2012-05-17 16:10:28 -0700 Committed r117510: <http://trac.webkit.org/changeset/117510> 142548 2012-05-17 14:07:15 -0700 2012-05-17 14:13:43 -0700 Patch bug-86773-20120517140714.patch text/plain 2453 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggM2NiY2RkNGZl ODQyYTJmMzY3NzEyNWIxOTQ4NzExNDEzMjVjZmM2ZS4uZWNlZjUxYjdhYWVkYjYzMDYyZDRjNTM2 ZWFiNWIwODI1YjVlNDExMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEy LTA1LTE3ICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBs ZXQgLVtDQUxheWVyIHJlbmRlckluQ29udGV4dDpdIHRyeSB0byByZW5kZXIgV2ViVmlldydzIHJv b3QgbGF5ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg2NzczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAor ICAgICAgICAtW0NBTGF5ZXIgcmVuZGVySW5Db250ZXh0Ol0gZG9lc24ndCBjb3JyZWN0bHkgcmVu ZGVyIG91ciBsYXllciB0cmVlLCBzbworICAgICAgICBkb24ndCBsZXQgaXQgdHJ5LiBDYWxsaW5n IGRyYXdSZWN0OiB3aXRoIGEgYml0bWFwIGNvbnRleHQgd2lsbCBhbHJlYWR5CisgICAgICAgIGRv IHRoZSByaWdodCB0aGluZyBmb3IgV2ViVmlld3MuCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkhU TUxWaWV3Lm1tOiBDcmVhdGUgYSBzdWJjbGFzcyBvZiBDQUxheWVyIGNhbGxlZCBXZWJMYXllckhv c3RpbmdMYXllci4KKyAgICAgICAgKC1bV2ViTGF5ZXJIb3N0aW5nTGF5ZXIgcmVuZGVySW5Db250 ZXh0Ol0pOiBvdmVycmlkZSByZW5kZXJJbkNvbnRleHQ6IHRvIGJlIGEgTk9PUC4KKyAgICAgICAg KC1bV2ViSFRNTFZpZXcgYXR0YWNoUm9vdExheWVyOl0pOiBDcmVhdGUgYSBXZWJMYXllckhvc3Rp bmdMYXllciByYXRoZXIgdGhhbiBhIENBTGF5ZXIuCisKIDIwMTItMDUtMTcgIERhbiBCZXJuc3Rl aW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMTE3NDI4KTogV2Vi S2l0IEFQSS9TUEkgd2FzIHJlbW92ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dl YlZpZXcvV2ViSFRNTFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxW aWV3Lm1tCmluZGV4IDQyZGQxMDQ5MmJhNGQxMGVkZTk0ODZhZmYxZTg1MTJjOGJiNDk2ZGMuLmVk NzM0NzJhOTg3NDc1NTdjOWViYzk0NDRkNjQxZTQyYzcwMThlZjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbQpAQCAtMjEyLDYgKzIxMiwyMCBAQCBzdGF0aWMgV2Vi TWVudVRhcmdldCogdGFyZ2V0OwogfQogQGVuZAogCitAaW50ZXJmYWNlIFdlYkxheWVySG9zdGlu Z0xheWVyIDogQ0FMYXllcgorQGVuZAorCitAaW1wbGVtZW50YXRpb24gV2ViTGF5ZXJIb3N0aW5n TGF5ZXIKKy0gKHZvaWQpcmVuZGVySW5Db250ZXh0OihDR0NvbnRleHRSZWYpY3R4Cit7CisgICAg Ly8gQXBwS2l0IGNhbGxzIC1bQ0FMYXllciByZW5kZXJJbkNvbnRleHQ6XSB0byByZW5kZXIgbGF5 ZXItYmFja2VkIHZpZXdzCisgICAgLy8gaW50byBiaXRtYXAgY29udGV4dHMsIGJ1dCByZW5kZXJJ bkNvbnRleHQ6IGRvZXNuJ3QgY2FwdHVyZSBtYXNrIGxheWVycworICAgIC8vICg8cmRhcjovL3By b2JsZW0vOTUzOTUyNj4pLCBzbyB3ZSBjYW4ndCByZWx5IG9uIGl0LiBTaW5jZSBvdXIgbGF5ZXIK KyAgICAvLyBjb250ZW50cyB3aWxsIGhhdmUgYWxyZWFkeSBiZWVuIHJlbmRlcmVkIGJ5IGRyYXdS ZWN0Oiwgd2UgY2FuIHNhZmVseSBtYWtlCisgICAgLy8gdGhpcyBhIE5PT1AuCit9CitAZW5kCisK IC8vIGlmIFlFUywgZG8gdGhlIHN0YW5kYXJkIE5TVmlldyBoaXQgdGVzdCAod2hpY2ggY2FuJ3Qg Z2l2ZSB0aGUgcmlnaHQgcmVzdWx0IHdoZW4gSFRNTCBvdmVybGFwcyBhIHZpZXcpCiBzdGF0aWMg Qk9PTCBmb3JjZU5TVmlld0hpdFRlc3Q7CiAKQEAgLTU0NjYsNyArNTQ4MCw3IEBAIHN0YXRpYyBD R1BvaW50IGNvcmVHcmFwaGljc1NjcmVlblBvaW50Rm9yQXBwS2l0U2NyZWVuUG9pbnQoTlNQb2lu dCBwb2ludCkKICAgICB9CiAKICAgICAvLyBNYWtlIGEgY29udGFpbmVyIGxheWVyLCB3aGljaCB3 aWxsIGdldCBzaXplZC9wb3NpdGlvbmVkIGJ5IEFwcEtpdCBhbmQgQ0EuCi0gICAgQ0FMYXllciog dmlld0xheWVyID0gW0NBTGF5ZXIgbGF5ZXJdOworICAgIENBTGF5ZXIqIHZpZXdMYXllciA9IFtb W1dlYkxheWVySG9zdGluZ0xheWVyIGFsbG9jXSBpbml0XSBhdXRvcmVsZWFzZV07CiAKICNpZmRl ZiBCVUlMRElOR19PTl9MRU9QQVJECiAgICAgLy8gVHVybiBvZmYgZGVmYXVsdCBhbmltYXRpb25z Lgo=