86770 2012-05-17 13:08:37 -0700 Move logic of checking whether a frame needs to be flattened to RenderFrameBase. 2025-07-01 16:04:08 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 zalan zalan ahmad.saleem792 kenneth koivisto oldest_to_newest 626894 0 zalan 2012-05-17 13:08:37 -0700 So that flattening checking code can somewhat be shared between frameset and iframe. That would eliminate the need of early return and mimicking non-flattening layout case in RenderFrameBase::layoutWithFlattening(), which can get (and is) out of sync in case of iframe layouting. See below. RenderFrameBase::layoutWithFlattening(...) { ... if (!width() || !height() || !childRoot) { updateWidgetPosition(); if (childFrameView) childFrameView->layout(); setNeedsLayout(false); return; ... } vs. RenderIFrame::layout() { ... RenderPart::layout(); m_overflow.clear(); addVisualEffectOverflow(); updateLayerTransform(); setNeedsLayout(false); ... } 2127129 1 ahmad.saleem792 2025-07-01 14:54:04 -0700 https://github.com/WebKit/WebKit/commit/37224f042c178a094cc2287dee595345bc89f687 <- Frame Flattening code is gone, should we close this? @Alan