86764 2012-05-17 11:55:01 -0700 [chromium] Limiting render surface texture manager memory to 0 when contentsMemoryUseBytes is large. 2012-05-17 13:03:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmocny mmocny cc-bugs enne jamesr nduca webkit.review.bot oldest_to_newest 626798 0 mmocny 2012-05-17 11:55:01 -0700 [chromium] Limiting render surface texture manager memory to 0 when contentsMemoryUseBytes is large. 626800 1 142520 mmocny 2012-05-17 11:55:25 -0700 Created attachment 142520 Patch 626808 2 mmocny 2012-05-17 11:57:43 -0700 Patch fixes a bug where renderSurfaceTextureManager memory set to a large value due to unchecked unsigned subtraction. contentsMemoryUseBytes can be higher than TextureManager::highLimitBytes when memory limits are increased. There is an open issue to improve synchronization between render surface texture manager and contents surface texture manager. 626812 3 142520 enne 2012-05-17 12:03:12 -0700 Comment on attachment 142520 Patch Eep. R=me. Can you explain a little bit more how we get into this situation? If the memory limit is increased, why does maxLimit not represent that? 626823 4 mmocny 2012-05-17 12:07:59 -0700 Sure, highLimitBytes is a static function that returns a hard coded limit based on viewport size. LRC doesn't actually have access to contents TextureManager so it cannot query to actually current max memory limit. Instead, it uses the conservative lower limit of assuming the default. However, contentsTextureAllocator tracks texture memory usage and is used by LRC to get the actual current usage, which can now be higher than the default maximum. 626887 5 142520 webkit.review.bot 2012-05-17 13:03:23 -0700 Comment on attachment 142520 Patch Clearing flags on attachment: 142520 Committed r117485: <http://trac.webkit.org/changeset/117485> 626888 6 webkit.review.bot 2012-05-17 13:03:29 -0700 All reviewed patches have been landed. Closing bug. 142520 2012-05-17 11:55:25 -0700 2012-05-17 13:03:23 -0700 Patch bug-86764-20120517145524.patch text/plain 1764 mmocny U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGUxNzkzM2Q0NWNmNjdi OWY2ZjhhNWNkZWQwYmMwMTNiNTM2ODcwNy4uOWYyOGY2OWU2ZmEwZWUyNmMwMWM5ZjFkNmQ3NjQz NjQ5ODE4MTQyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTE3ICBNaWNo YWwgTW9jbnkgIDxtbW9jbnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIExpbWl0 aW5nIHJlbmRlciBzdXJmYWNlIHRleHR1cmUgbWFuYWdlciBtZW1vcnkgdG8gMCB3aGVuIGNvbnRl bnRzTWVtb3J5VXNlQnl0ZXMgaXMgbGFyZ2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04Njc2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5k ZXJlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyUmVuZGVyZXJDaHJvbWl1 bTo6YmVnaW5EcmF3aW5nRnJhbWUpOgorCiAyMDEyLTA1LTE3ICBJbHlhIFRpa2hvbm92c2t5ICA8 bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBIZWFwU25hcHNo b3Q6IHNwZWVkLXVwIGNhbGN1bGF0ZU9iamVjdFRvV2luZG93RGlzdGFuY2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJD aHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9M YXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCmluZGV4IDllNGEwYWYyNWUzZWYyNGZlZmY2NzlhZDRh ZGFlMzY4ZTExYjg5ZWQuLmE5ZjNkNDY2NWQzNmU1MjhkM2ZlM2ZjOTFjODYwMjVmNGU5YTg3ZWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xh eWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcApAQCAtNDE2LDcgKzQxNiw4 IEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpiZWdpbkRyYXdpbmdGcmFtZShDQ1JlbmRl clN1cmZhY2UqIGRlZmF1bHRSZW5kZXJTdXJmCiAKICAgICBzaXplX3QgY29udGVudHNNZW1vcnlV c2VCeXRlcyA9IG1fY29udGVudHNUZXh0dXJlQWxsb2NhdG9yLT5jdXJyZW50TWVtb3J5VXNlQnl0 ZXMoKTsKICAgICBzaXplX3QgbWF4TGltaXQgPSBUZXh0dXJlTWFuYWdlcjo6aGlnaExpbWl0Qnl0 ZXModmlld3BvcnRTaXplKCkpOwotICAgIG1fcmVuZGVyU3VyZmFjZVRleHR1cmVNYW5hZ2VyLT5z ZXRNYXhNZW1vcnlMaW1pdEJ5dGVzKG1heExpbWl0IC0gY29udGVudHNNZW1vcnlVc2VCeXRlcyk7 CisgICAgc2l6ZV90IG5ld0xpbWl0ID0gKG1heExpbWl0ID4gY29udGVudHNNZW1vcnlVc2VCeXRl cykgPyBtYXhMaW1pdCAtIGNvbnRlbnRzTWVtb3J5VXNlQnl0ZXMgOiAwOworICAgIG1fcmVuZGVy U3VyZmFjZVRleHR1cmVNYW5hZ2VyLT5zZXRNYXhNZW1vcnlMaW1pdEJ5dGVzKG5ld0xpbWl0KTsK IAogICAgIGlmICh2aWV3cG9ydFNpemUoKS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsK