86762 2012-05-17 11:48:04 -0700 Enable web intents flag for chromium build 2012-05-18 13:33:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75123 1 gbillock gbillock abarth webkit.review.bot oldest_to_newest 626786 0 gbillock 2012-05-17 11:48:04 -0700 Enable web intents flag for chromium build 626787 1 142517 gbillock 2012-05-17 11:48:55 -0700 Created attachment 142517 Patch 626821 2 abarth 2012-05-17 12:06:19 -0700 Can we unskip some tests now that this feature is enabled during testing? 626873 3 gbillock 2012-05-17 12:47:05 -0700 (In reply to comment #2) > Can we unskip some tests now that this feature is enabled during testing? They're not skipped in chromium now, but the tests should now actually be running the full test in the suite instead of skipping the good stuff. (The intent tag test is still skipped.) 626875 4 abarth 2012-05-17 12:49:18 -0700 > They're not skipped in chromium now, but the tests should now actually be running the full test in the suite instead of skipping the good stuff. (The intent tag test is still skipped.) What does that mean? Do we need to update any -expected.txt files? I'm confused. 627004 5 gbillock 2012-05-17 14:46:13 -0700 (In reply to comment #4) > > They're not skipped in chromium now, but the tests should now actually be running the full test in the suite instead of skipping the good stuff. (The intent tag test is still skipped.) > > What does that mean? Do we need to update any -expected.txt files? I'm confused. I don't think so (the bot passes fine). My local webkit checkout builds and runs the tests. Am I doing what I think I'm doing with this flag? My expectation was that the webkit chromium builds use it, but the flags can be (and are)set differently in the chromium-initiated builds, from the chromium gypi files. (And that this change merely aligns them.) Is that not the right understanding? The tests were definitely running before this cl (hence the red tests in cr-linux on the delivery change). IOW, my impression is that the chromium code would no longer need to pass in enable_web_intents=1, but that it in fact does pass that in right now. So they're now more aligned, but there's still a shut-off valve on both sides. Is that right? Or does this change also (inadvertently) disable the enable_web_intents shut-off valve on the Chromium side? 627028 6 abarth 2012-05-17 15:09:22 -0700 There shouldn't be any misalignment. We use the same build flags for both. It sounds like the next step after this patch is to delete the enable_web_intents variable. 627038 7 gbillock 2012-05-17 15:19:38 -0700 (In reply to comment #6) > There shouldn't be any misalignment. We use the same build flags for both. It sounds like the next step after this patch is to delete the enable_web_intents variable. Right. That sounds good to me. 627995 8 142517 webkit.review.bot 2012-05-18 13:32:57 -0700 Comment on attachment 142517 Patch Clearing flags on attachment: 142517 Committed r117615: <http://trac.webkit.org/changeset/117615> 627996 9 webkit.review.bot 2012-05-18 13:33:02 -0700 All reviewed patches have been landed. Closing bug. 142517 2012-05-17 11:48:55 -0700 2012-05-18 13:32:57 -0700 Patch bug-86762-20120517114854.patch text/plain 1207 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGU1MzE5NDIyMTRiYTEwMTBmYzAwZWY0NTgzZWNjNzE1MDU0NzFlZTkuLjcxZWUyMWU2ZTEwODQw NDVkZDQwODhkOTdjMjVkMWY1ZWIzYjU2ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTItMDUtMTcgIEdyZWcgQmlsbG9jayAgPGdiaWxsb2NrQGdvb2ds ZS5jb20+CisKKyAgICAgICAgRW5hYmxlIHdlYiBpbnRlbnRzIGZsYWcgZm9yIGNocm9taXVtIGJ1 aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Njc2 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg ZmxhZyBpcyBlbmFibGVkIGluIHRoZSBDaHJvbWl1bS1zaWRlIGJ1aWxkLgorCisgICAgICAgICog ZmVhdHVyZXMuZ3lwaToKKwogMjAxMi0wNS0xNSAgVGllbi1SZW4gQ2hlbiAgPHRyY2hlbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBDQ1RpbWVyOjppc0FjdGl2ZSgpIGlzIGlu Y29ycmVjdCBpbnNpZGUgdGljayBjYWxsYmFjawpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9mZWF0dXJlcy5neXBpIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5n eXBpCmluZGV4IDA3NmZjMzhhOWE5YmQxYWFkZDg5NDg5NjYxODE0MTQ5ZTEzOTc0ZWUuLjEzMjlm ODY1M2I3M2MwMzA1ODlhOTc2M2ExMWEyZGRmOTYyZDBhOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L2ZlYXR1cmVzLmd5cGkKQEAgLTEwNiw2ICsxMDYsNyBAQAogICAgICAgJ0VOQUJMRV9WSURFT19U UkFDSz0xJywKICAgICAgICdFTkFCTEVfVklFV1BPUlQ9MScsCiAgICAgICAnRU5BQkxFX1dFQkdM PTEnLAorICAgICAgJ0VOQUJMRV9XRUJfSU5URU5UUz0xJywKICAgICAgICdFTkFCTEVfV0VCX1NP Q0tFVFM9MScsCiAgICAgICAnRU5BQkxFX1dFQl9USU1JTkc9MScsCiAgICAgICAnRU5BQkxFX1dP UktFUlM9MScsCg==