86759 2012-05-17 11:33:20 -0700 [BlackBerry] expandSelectionToGranularity should only use VisibleSelection and not range. 2012-05-17 13:04:40 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 626757 0 mifenton 2012-05-17 11:33:20 -0700 SelectionHandler expandSelectionToGranularity requires an update. 626762 1 142512 mifenton 2012-05-17 11:35:53 -0700 Created attachment 142512 Patch 626889 2 142512 webkit.review.bot 2012-05-17 13:04:34 -0700 Comment on attachment 142512 Patch Clearing flags on attachment: 142512 Committed r117483: <http://trac.webkit.org/changeset/117483> 626890 3 webkit.review.bot 2012-05-17 13:04:40 -0700 All reviewed patches have been landed. Closing bug. 142512 2012-05-17 11:35:53 -0700 2012-05-17 13:04:34 -0700 Patch 0001-2012-05-17-Mike-Fenton-mifenton-rim.com.patch text/plain 2922 mifenton RnJvbSBmMTliZTFkNGU4MmFiNGY5ZGQ4ODMxNDZjOWRiMjQ1MmIyMGQ5YjE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog VGh1LCAxNyBNYXkgMjAxMiAxMjo1MzoyMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDUt MTcgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgZXhwYW5kU2VsZWN0 aW9uVG9HcmFudWxhcml0eSB1bm5lY2VzYXJpbHkgY29udmVydGVkIHRoZQogICAgICAgIHNlbGVj dGlvbiB0byByYW5nZSBhbmQgYmFjay4gVXNpbmcgdGhlIHNlbGVjdGlvbgogICAgICAgIGRpcmVj dGx5IGlzIHByZWZlcnJlZC4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgog ICAgICAgICogV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcDoKICAgICAgICAoV2Vi S2l0KToKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpzZWxl Y3RPYmplY3QpOgotLS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcCAgfCAgICA5ICsrKystLS0tLQogMiBmaWxlcyBjaGFu Z2VkLCAxOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nCmluZGV4IDk4N2M3ZjYuLmUxOGM5ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0No YW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA1LTE3ICBNaWtlIEZlbnRvbiAgPG1pZmVu dG9uQHJpbS5jb20+CiAKKyAgICAgICAgW0JsYWNrQmVycnldIGV4cGFuZFNlbGVjdGlvblRvR3Jh bnVsYXJpdHkgc2hvdWxkIG9ubHkgdXNlIFZpc2libGVTZWxlY3Rpb24gYW5kIG5vdCByYW5nZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NzU5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBHb21lcy4KKworICAgICAgICBleHBhbmRTZWxl Y3Rpb25Ub0dyYW51bGFyaXR5IHVubmVjZXNhcmlseSBjb252ZXJ0ZWQgdGhlCisgICAgICAgIHNl bGVjdGlvbiB0byByYW5nZSBhbmQgYmFjay4gVXNpbmcgdGhlIHNlbGVjdGlvbgorICAgICAgICBk aXJlY3RseSBpcyBwcmVmZXJyZWQuCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L1NlbGVjdGlv bkhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpleHBhbmRTZWxlY3Rp b25Ub0dyYW51bGFyaXR5KToKKworMjAxMi0wNS0xNyAgTWlrZSBGZW50b24gIDxtaWZlbnRvbkBy aW0uY29tPgorCiAgICAgICAgIFtCbGFja0JlcnJ5XSBCdWlsZCBmaXgsIFNlbGVjdGlvbkhhbmRs ZXIgZXh0cmEgZGVidWcgbG9ncwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODY3NDMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcAppbmRleCAzZWJjZjNmLi5l OTM3Y2MzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9TZWxlY3Rpb25IYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmNwcApAQCAtNTk4LDE0ICs1OTgsMTMgQEAgc3Rh dGljIGJvb2wgZXhwYW5kU2VsZWN0aW9uVG9HcmFudWxhcml0eShGcmFtZSogZnJhbWUsIFZpc2li bGVTZWxlY3Rpb24gc2VsZWN0aW8KICAgICAgICAgc2VsZWN0aW9uID0gRE9NU3VwcG9ydDo6dmlz aWJsZVNlbGVjdGlvbkZvckNsb3Nlc3RBY3R1YWxXb3JkU3RhcnQoc2VsZWN0aW9uKTsKIAogICAg IHNlbGVjdGlvbi5leHBhbmRVc2luZ0dyYW51bGFyaXR5KGdyYW51bGFyaXR5KTsKLSAgICBSZWZQ dHI8UmFuZ2U+IG5ld1JhbmdlID0gc2VsZWN0aW9uLnRvTm9ybWFsaXplZFJhbmdlKCk7Ci0gICAg UmVmUHRyPFJhbmdlPiBvbGRSYW5nZSA9IGZyYW1lLT5zZWxlY3Rpb24oKS0+c2VsZWN0aW9uKCku dG9Ob3JtYWxpemVkUmFuZ2UoKTsKLSAgICBFQWZmaW5pdHkgYWZmaW5pdHkgPSBmcmFtZS0+c2Vs ZWN0aW9uKCktPmFmZmluaXR5KCk7CisgICAgc2VsZWN0aW9uLnNldEFmZmluaXR5KGZyYW1lLT5z ZWxlY3Rpb24oKS0+YWZmaW5pdHkoKSk7CiAKLSAgICBpZiAoaXNJbnB1dE1vZGUgJiYgIWZyYW1l LT5lZGl0b3IoKS0+Y2xpZW50KCktPnNob3VsZENoYW5nZVNlbGVjdGVkUmFuZ2Uob2xkUmFuZ2Uu Z2V0KCksIG5ld1JhbmdlLmdldCgpLCBhZmZpbml0eSwgZmFsc2UpKQorICAgIGlmIChpc0lucHV0 TW9kZSAmJiAhZnJhbWUtPnNlbGVjdGlvbigpLT5zaG91bGRDaGFuZ2VTZWxlY3Rpb24oc2VsZWN0 aW9uKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgcmV0dXJuIGZyYW1lLT5zZWxlY3Rp b24oKS0+c2V0U2VsZWN0ZWRSYW5nZShuZXdSYW5nZS5nZXQoKSwgYWZmaW5pdHksIHRydWUpOwor ICAgIGZyYW1lLT5zZWxlY3Rpb24oKS0+c2V0U2VsZWN0aW9uKHNlbGVjdGlvbik7CisgICAgcmV0 dXJuIHRydWU7CiB9CiAKIHZvaWQgU2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0T2JqZWN0KGNvbnN0 IFdlYkNvcmU6OkludFBvaW50JiBsb2NhdGlvbiwgVGV4dEdyYW51bGFyaXR5IGdyYW51bGFyaXR5 KQotLSAKMS43LjkuNQoK