86747 2012-05-17 09:21:23 -0700 [EFL] Fix link error caused by not directly linking with edbus 2012-05-17 10:25:18 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos tmpsantos gyuyoung.kim kihong.kwon lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 626632 0 tmpsantos 2012-05-17 09:21:23 -0700 We are not specifying edbus as dependency but we are using it's symbols on BatteryClientEfl.cpp ../../../lib/libewebkit.so.0.1.0: error: undefined reference to 'e_dbus_bus_get' ../../../lib/libewebkit.so.0.1.0: error: undefined reference to 'dbus_error_is_set' ../../../lib/libewebkit.so.0.1.0: error: undefined reference to 'dbus_error_free' It might work when not using the shared core build option because edbus is a dependency for eukit and the symbol is indirectly resolved. 626636 1 142488 tmpsantos 2012-05-17 09:30:00 -0700 Created attachment 142488 Patch 626679 2 142488 webkit.review.bot 2012-05-17 10:25:13 -0700 Comment on attachment 142488 Patch Clearing flags on attachment: 142488 Committed r117459: <http://trac.webkit.org/changeset/117459> 626680 3 webkit.review.bot 2012-05-17 10:25:18 -0700 All reviewed patches have been landed. Closing bug. 142488 2012-05-17 09:30:00 -0700 2012-05-17 10:25:13 -0700 Patch bug-86747-20120517192958.patch text/plain 2675 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDljYjRkYjQyOTQwZWNjMzMx NmEyMjkxZTcxNTkzNWUzM2RiMWQ4ZWMuLjFhYzUzNzhlYWE1YWQyMGIyNzdhMzc0NDI5ZjVlZDhh ODc3OTFkMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDUtMTcgIFRoaWFnbyBN YXJjb3MgUC4gU2FudG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VG TF0gRml4IGxpbmsgZXJyb3IgY2F1c2VkIGJ5IG5vdCBkaXJlY3RseSBsaW5raW5nIHdpdGggZWRi dXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NzQ3 CisKKyAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgKiBQbGF0Zm9ybUVm bC5jbWFrZToKKwogMjAxMi0wNS0xNSAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28u c2FudG9zQGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgQVBJIGZvciBXZWIgRGF0YWJh c2UgaGFuZGxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1FZmwuY21ha2Ug Yi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IGQ5ODZjODQwNmYyY2FlMGY4 MDE3NDQyOTljZDgzNDg1Y2JkYmRkOTUuLjE4NDNjMmQwNzU4OTczMDhmZjg5N2NjM2RjMmExOWZk MzA0ODg2OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1FZmwuY21ha2UKKysr IGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtMjAsNiArMjAsNyBAQCBMSVNU KEFQUEVORCBXZWJLaXRfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICR7RUZMREVQU19JTkNMVURF X0RJUlN9CiAgICAgJHtFVkFTX0lOQ0xVREVfRElSU30KICAgICAke0VVS0lUX0lOQ0xVREVfRElS U30KKyAgICAke0VEQlVTX0lOQ0xVREVfRElSU30KICAgICAke0xJQlhNTDJfSU5DTFVERV9ESVJ9 CiAgICAgJHtMSUJYU0xUX0lOQ0xVREVfRElSfQogICAgICR7U1FMSVRFX0lOQ0xVREVfRElSfQpA QCAtMTI3LDYgKzEyOCw3IEBAIExJU1QoQVBQRU5EIFdlYktpdF9MSUJSQVJJRVMKICAgICAke0VD T1JFX1hfTElCUkFSSUVTfQogICAgICR7RUZMREVQU19MSUJSQVJJRVN9CiAgICAgJHtFVUtJVF9M SUJSQVJJRVN9CisgICAgJHtFREJVU19MSUJSQVJJRVN9CiAgICAgJHtGUkVFVFlQRV9MSUJSQVJJ RVN9CiAgICAgJHtMSUJYTUwyX0xJQlJBUklFU30KICAgICAke1NRTElURV9MSUJSQVJJRVN9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmluZEVGTC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5k RUZMLmNtYWtlCmluZGV4IDA0ZjU1ODhkZTc4OTIwNWMyMzU2Nzg1OWIxZjI0ZDE0NWUxZDg0Y2Iu LjhjOWI1NjZlZTA0NWIzYzc4ZTk1Mjk1NzI5MWJhODk3MDljMmQ0YTkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9jbWFrZS9GaW5kRUZMLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kRUZMLmNtYWtl CkBAIC0xMCwxMSArMTAsMTMgQEAgUEtHX0NIRUNLX01PRFVMRVMgKEVGTERFUFMgUkVRVUlSRUQK ICAgZWNvcmUtZmlsZT49MS4wLjAKICAgZWNvcmUtZXZhcz49MS4wLjk5OS41OTc2MwogICBlZGpl Pj0xLjAuMAotICBldWtpdD49MS4xLjApCisgIGV1a2l0Pj0xLjEuMAorICBlZGJ1cz49MS4xLjAp CiBQS0dfQ0hFQ0tfTU9EVUxFUyAoRUlOQSBSRVFVSVJFRCBlaW5hPj0xLjAuMCkKIFBLR19DSEVD S19NT0RVTEVTIChFQ09SRV9YIGVjb3JlLXg+PTEuMC4wKQogUEtHX0NIRUNLX01PRFVMRVMgKEVW QVMgUkVRVUlSRUQgZXZhcz49MS4wLjApCiBQS0dfQ0hFQ0tfTU9EVUxFUyAoRVVLSVQgUkVRVUlS RUQgZXVraXQ+PTEuMS4wKQorUEtHX0NIRUNLX01PRFVMRVMgKEVEQlVTIFJFUVVJUkVEIGVkYnVz Pj0xLjEuMCkKIAogRklORF9QUk9HUkFNIChFREpFX0NDX0VYRUNVVEFCTEUgZWRqZV9jYykKIElG IChOT1QgRURKRV9DQ19FWEVDVVRBQkxFKQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdl TG9nCmluZGV4IDhkZGFmNzI1YWM2N2RkZTI1MjJhMzNmYmE2NTJmOTQwMjQ5MGMzOTMuLjUxZGYw MjRmNzBhMzRkZmYyYmRkZjJkYzc4Nzc0NjU0MDRiZGMxMTAgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxv ZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wNS0xNyAgVGhpYWdvIE1h cmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4KKworICAgICAgICBbRUZM XSBGaXggbGluayBlcnJvciBjYXVzZWQgYnkgbm90IGRpcmVjdGx5IGxpbmtpbmcgd2l0aCBlZGJ1 cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY3NDcK KworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKworICAgICAgICAqIFNvdXJjZS9jbWFr ZS9GaW5kRUZMLmNtYWtlOgorCiAyMDEyLTA1LTE3ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5r aW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgQ29udmVydCBzZXREb21haW5SZWxheGF0aW9uRm9y YmlkZGVuRm9yVVJMU2NoZW1lIHRvIHVzZSBJbnRlcm5hbFNldHRpbmdzIGludGVyZmFjZQo=