86725 2012-05-17 06:20:44 -0700 [perf-test] Add a micro benchmark for div.firstChild getter for an undefined firstChild 2012-05-17 15:04:09 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86581 1 haraken haraken rniwa webkit.review.bot oldest_to_newest 626512 0 haraken 2012-05-17 06:20:44 -0700 We are going to remove Bindings/dom-attributes.html and instead add more reasonable micro benchmarks by classifying DOM binding call paths. In this bug, we add a micro benchmark for div.firstChild getter for an undefined firstChild. This benchmark covers other undefined DOM attributes that return a null. 626517 1 142462 haraken 2012-05-17 06:27:35 -0700 Created attachment 142462 Patch 626519 2 142463 haraken 2012-05-17 06:29:23 -0700 Created attachment 142463 Patch 627018 3 142463 webkit.review.bot 2012-05-17 15:04:04 -0700 Comment on attachment 142463 Patch Clearing flags on attachment: 142463 Committed r117503: <http://trac.webkit.org/changeset/117503> 627019 4 webkit.review.bot 2012-05-17 15:04:09 -0700 All reviewed patches have been landed. Closing bug. 142462 2012-05-17 06:27:35 -0700 2012-05-17 06:29:19 -0700 Patch bug-86725-20120517222733.patch text/plain 2974 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NDIxCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0JpbmRpbmdzL3VuZGVmaW5lZC1maXJzdC1jaGlsZC5odG1sIGIvUGVyZm9ybWFuY2VUZXN0cy9C aW5kaW5ncy91bmRlZmluZWQtZmlyc3QtY2hpbGQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41MzcxNGFkMjVk Yjc2Njc4ZDM3Y2JkNTNhNWM1ODkxYzFjNTYxYTc5Ci0tLSAvZGV2L251bGwKKysrIGIvUGVyZm9y bWFuY2VUZXN0cy9CaW5kaW5ncy91bmRlZmluZWQtZmlyc3QtY2hpbGQuaHRtbApAQCAtMCwwICsx LDE3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4v cmVzb3VyY2VzL3J1bm5lci5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgordmFyIGRpdiA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworCitQZXJmVGVzdFJ1bm5lci5ydW5QZXJTZWNvbmQo eworICAgIGRlc2NyaXB0aW9uOiAiVGhpcyBiZW5jaG1hcmsgY292ZXJzIHVuZGVmaW5lZCBET00g YXR0cmlidXRlcyB0aGF0IHJldHVybiBhIG51bGwuIiwKKyAgICBydW46IGZ1bmN0aW9uKCkgewor ICAgICAgICB2YXIgbG9jYWxEaXYgPSBkaXY7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwg MTAwMDAwOyBpKyspCisgICAgICAgICAgICBsb2NhbERpdi5maXJzdENoaWxkOworfX0pOworPC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL0No YW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg4MjNhYWVkZDZhNGQ2 ZTAxZDlmYzQyMTFjZmIwMGI1YjcyM2ViMTQuLjZjMzQyYWJjZDhkMGM3ZWVhYjlmYmQyNDdmZGNm NThjNDYzYjMwYzMgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisrKyBi L1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzkgQEAKKzIwMTItMDUtMTcg IEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtwZXJmLXRl c3RdIEFkZCBhIG1pY3JvIGJlbmNobWFyayBmb3IgZGl2LmZpcnN0Q2hpbGQgZ2V0dGVyIGZvciBh biB1bmRlZmluZWQgZmlyc3RDaGlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODY3MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZSBhcmUgZ29pbmcgdG8gcmVtb3ZlIEJpbmRpbmdzL2RvbS1hdHRyaWJ1 dGVzLmh0bWwgYW5kIGluc3RlYWQgYWRkIG1vcmUKKyAgICAgICAgcmVhc29uYWJsZSBtaWNybyBi ZW5jaG1hcmtzIGJ5IGNsYXNzaWZ5aW5nIERPTSBiaW5kaW5nIGNhbGwgcGF0aHMuCisKKyAgICAg ICAgSW4gdGhpcyBidWcsIHdlIGFkZCBhIG1pY3JvIGJlbmNobWFyayBmb3IgZGl2LmZpcnN0Q2hp bGQgZ2V0dGVyIGZvciBhbgorICAgICAgICB1bmRlZmluZWQgZmlyc3RDaGlsZC4gVGhpcyBiZW5j aG1hcmsgY292ZXJzIG90aGVyIHVuZGVmaW5lZCBET00gYXR0cmlidXRlcworICAgICAgICB0aGF0 IHJldHVybiBhIG51bGwuCisKKyAgICAgICAgKE5vdGU6IEluIFY4LCBkaXYuZmlyc3RDaGlsZCBm b3IgYW4gdW5kZWZpbmVkIGdldHRlciBpcyBjdXJyZW50bHkgc2xvd2VyCisgICAgICAgIHRoYW4g ZGl2LmZpcnN0Q2hpbGQgZm9yIGEgZGVmaW5lZCBnZXR0ZXIuKQorCisgICAgICAgIFRlc3QgcmVz dWx0cyBpbiBteSBMaW51eCBkZXNrdG9wOgorCisgICAgICAgIFJFU1VMVCBCaW5kaW5nczogdW5k ZWZpbmVkLWZpcnN0LWNoaWxkPSA1NDEuNDA4MzExMDQyIHJ1bnMvcworICAgICAgICBtZWRpYW49 IDU0MS4yMDU0MTIwNTQgcnVucy9zLCBzdGRldj0gMS4yOTg0MTIxOTE4NyBydW5zL3MsIG1pbj0g NTM3Ljg5NzMxMDUxMyBydW5zL3MsIG1heD0gNTQzLjIwOTg3NjU0MyBydW5zL3MKKworICAgICAg ICBSRVNVTFQgQmluZGluZ3M6IHVuZGVmaW5lZC1maXJzdC1jaGlsZD0gNTQxLjAwNzUwNjk1IHJ1 bnMvcworICAgICAgICBtZWRpYW49IDU0MC41NDA1NDA1NDEgcnVucy9zLCBzdGRldj0gMC45Njc1 MjEyMzA5NjUgcnVucy9zLCBtaW49IDUzOS4yMTU2ODYyNzUgcnVucy9zLCBtYXg9IDU0My4yMDk4 NzY1NDMgcnVucy9zCisKKyAgICAgICAgUkVTVUxUIEJpbmRpbmdzOiB1bmRlZmluZWQtZmlyc3Qt Y2hpbGQ9IDUyMy42MzA3MTQ4OTcgcnVucy9zCisgICAgICAgIG1lZGlhbj0gNTIzLjU2MDIwOTQy NCBydW5zL3MsIHN0ZGV2PSAxLjAxNTcwOTE5NjQ1IHJ1bnMvcywgbWluPSA1MjIuMTkzMjExNDg4 IHJ1bnMvcywgbWF4PSA1MjUuNjI0MTc4NzEyIHJ1bnMvcworCisgICAgICAgIFJFU1VMVCBCaW5k aW5nczogdW5kZWZpbmVkLWZpcnN0LWNoaWxkPSA1NTMuMDc3NjYzNTg4IHJ1bnMvcworICAgICAg ICBtZWRpYW49IDU1My40NTkxMTk0OTcgcnVucy9zLCBzdGRldj0gMC44MDU2OTczOTc4NjMgcnVu cy9zLCBtaW49IDU1MS4zNzg0NDYxMTUgcnVucy9zLCBtYXg9IDU1NC4xNTYxNzEyODUgcnVucy9z CisKKyAgICAgICAgUkVTVUxUIEJpbmRpbmdzOiB1bmRlZmluZWQtZmlyc3QtY2hpbGQ9IDU0MS41 NDAxNDMyIHJ1bnMvcworICAgICAgICBtZWRpYW49IDU0MS41Mzg2NjY2MTggcnVucy9zLCBzdGRl dj0gMC45NTQzMDEzNjQ3NjcgcnVucy9zLCBtaW49IDUzOS44NzczMDA2MTMgcnVucy9zLCBtYXg9 IDU0My4yMDk4NzY1NDMgcnVucy9zCisKKyAgICAgICAgKiBCaW5kaW5ncy91bmRlZmluZWQtZmly c3QtY2hpbGQuaHRtbDogQWRkZWQuCisKIDIwMTItMDUtMTYgIEtlbnRhcm8gSGFyYSAgPGhhcmFr ZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtQZXJmb3JtYW5jZSB0ZXN0XSBTdXBwb3J0ICJk ZXNjcmlwdGlvbiIgZm9yIFBlcmZUZXN0UnVubmVyLnJ1biBhbmQgUGVyZlRlc3RSdW5uZXIucnVu UGVyU2Vjb25kCg== 142463 2012-05-17 06:29:23 -0700 2012-05-17 15:04:04 -0700 Patch bug-86725-20120517222922.patch text/plain 2982 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3NDIxCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0JpbmRpbmdzL3VuZGVmaW5lZC1maXJzdC1jaGlsZC5odG1sIGIvUGVyZm9ybWFuY2VUZXN0cy9C aW5kaW5ncy91bmRlZmluZWQtZmlyc3QtY2hpbGQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41MzcxNGFkMjVk Yjc2Njc4ZDM3Y2JkNTNhNWM1ODkxYzFjNTYxYTc5Ci0tLSAvZGV2L251bGwKKysrIGIvUGVyZm9y bWFuY2VUZXN0cy9CaW5kaW5ncy91bmRlZmluZWQtZmlyc3QtY2hpbGQuaHRtbApAQCAtMCwwICsx LDE3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4v cmVzb3VyY2VzL3J1bm5lci5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgordmFyIGRpdiA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOworCitQZXJmVGVzdFJ1bm5lci5ydW5QZXJTZWNvbmQo eworICAgIGRlc2NyaXB0aW9uOiAiVGhpcyBiZW5jaG1hcmsgY292ZXJzIHVuZGVmaW5lZCBET00g YXR0cmlidXRlcyB0aGF0IHJldHVybiBhIG51bGwuIiwKKyAgICBydW46IGZ1bmN0aW9uKCkgewor ICAgICAgICB2YXIgbG9jYWxEaXYgPSBkaXY7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwg MTAwMDAwOyBpKyspCisgICAgICAgICAgICBsb2NhbERpdi5maXJzdENoaWxkOworfX0pOworPC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL0No YW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg4MjNhYWVkZDZhNGQ2 ZTAxZDlmYzQyMTFjZmIwMGI1YjcyM2ViMTQuLmE5NzgwNjM4NTY5NTE5YTI5YTcxYzUyZmZhYjFi YWI3NjAxNzRjMzEgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisrKyBi L1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzkgQEAKKzIwMTItMDUtMTcg IEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtwZXJmLXRl c3RdIEFkZCBhIG1pY3JvIGJlbmNobWFyayBmb3IgZGl2LmZpcnN0Q2hpbGQgZ2V0dGVyIGZvciBh biB1bmRlZmluZWQgZmlyc3RDaGlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODY3MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZSBhcmUgZ29pbmcgdG8gcmVtb3ZlIEJpbmRpbmdzL2RvbS1hdHRyaWJ1 dGVzLmh0bWwgYW5kIGluc3RlYWQgYWRkIG1vcmUKKyAgICAgICAgcmVhc29uYWJsZSBtaWNybyBi ZW5jaG1hcmtzIGJ5IGNsYXNzaWZ5aW5nIERPTSBiaW5kaW5nIGNhbGwgcGF0aHMuCisKKyAgICAg ICAgSW4gdGhpcyBidWcsIHdlIGFkZCBhIG1pY3JvIGJlbmNobWFyayBmb3IgZGl2LmZpcnN0Q2hp bGQgZ2V0dGVyIGZvciBhbgorICAgICAgICB1bmRlZmluZWQgZmlyc3RDaGlsZC4gVGhpcyBiZW5j aG1hcmsgY292ZXJzIG90aGVyIHVuZGVmaW5lZCBET00gYXR0cmlidXRlcworICAgICAgICB0aGF0 IHJldHVybiBhIG51bGwuCisKKyAgICAgICAgKE5vdGU6IEluIFY4LCBkaXYuZmlyc3RDaGlsZCBm b3IgYW4gdW5kZWZpbmVkIGZpcnN0Q2hpbGQgaXMgY3VycmVudGx5IHNsb3dlcgorICAgICAgICB0 aGFuIGRpdi5maXJzdENoaWxkIGZvciBhIGRlZmluZWQgZmlyc3RDaGlsZC4pCisKKyAgICAgICAg VGVzdCByZXN1bHRzIGluIG15IExpbnV4IGRlc2t0b3A6CisKKyAgICAgICAgUkVTVUxUIEJpbmRp bmdzOiB1bmRlZmluZWQtZmlyc3QtY2hpbGQ9IDU0MS40MDgzMTEwNDIgcnVucy9zCisgICAgICAg IG1lZGlhbj0gNTQxLjIwNTQxMjA1NCBydW5zL3MsIHN0ZGV2PSAxLjI5ODQxMjE5MTg3IHJ1bnMv cywgbWluPSA1MzcuODk3MzEwNTEzIHJ1bnMvcywgbWF4PSA1NDMuMjA5ODc2NTQzIHJ1bnMvcwor CisgICAgICAgIFJFU1VMVCBCaW5kaW5nczogdW5kZWZpbmVkLWZpcnN0LWNoaWxkPSA1NDEuMDA3 NTA2OTUgcnVucy9zCisgICAgICAgIG1lZGlhbj0gNTQwLjU0MDU0MDU0MSBydW5zL3MsIHN0ZGV2 PSAwLjk2NzUyMTIzMDk2NSBydW5zL3MsIG1pbj0gNTM5LjIxNTY4NjI3NSBydW5zL3MsIG1heD0g NTQzLjIwOTg3NjU0MyBydW5zL3MKKworICAgICAgICBSRVNVTFQgQmluZGluZ3M6IHVuZGVmaW5l ZC1maXJzdC1jaGlsZD0gNTIzLjYzMDcxNDg5NyBydW5zL3MKKyAgICAgICAgbWVkaWFuPSA1MjMu NTYwMjA5NDI0IHJ1bnMvcywgc3RkZXY9IDEuMDE1NzA5MTk2NDUgcnVucy9zLCBtaW49IDUyMi4x OTMyMTE0ODggcnVucy9zLCBtYXg9IDUyNS42MjQxNzg3MTIgcnVucy9zCisKKyAgICAgICAgUkVT VUxUIEJpbmRpbmdzOiB1bmRlZmluZWQtZmlyc3QtY2hpbGQ9IDU1My4wNzc2NjM1ODggcnVucy9z CisgICAgICAgIG1lZGlhbj0gNTUzLjQ1OTExOTQ5NyBydW5zL3MsIHN0ZGV2PSAwLjgwNTY5NzM5 Nzg2MyBydW5zL3MsIG1pbj0gNTUxLjM3ODQ0NjExNSBydW5zL3MsIG1heD0gNTU0LjE1NjE3MTI4 NSBydW5zL3MKKworICAgICAgICBSRVNVTFQgQmluZGluZ3M6IHVuZGVmaW5lZC1maXJzdC1jaGls ZD0gNTQxLjU0MDE0MzIgcnVucy9zCisgICAgICAgIG1lZGlhbj0gNTQxLjUzODY2NjYxOCBydW5z L3MsIHN0ZGV2PSAwLjk1NDMwMTM2NDc2NyBydW5zL3MsIG1pbj0gNTM5Ljg3NzMwMDYxMyBydW5z L3MsIG1heD0gNTQzLjIwOTg3NjU0MyBydW5zL3MKKworICAgICAgICAqIEJpbmRpbmdzL3VuZGVm aW5lZC1maXJzdC1jaGlsZC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNS0xNiAgS2VudGFybyBIYXJh ICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1BlcmZvcm1hbmNlIHRlc3RdIFN1 cHBvcnQgImRlc2NyaXB0aW9uIiBmb3IgUGVyZlRlc3RSdW5uZXIucnVuIGFuZCBQZXJmVGVzdFJ1 bm5lci5ydW5QZXJTZWNvbmQK