86714 2012-05-17 00:35:50 -0700 [Worker] Web Worker lacks test to check the name attribute of SharedWorker 2012-05-17 01:05:59 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 li.yin webkit-unassigned haraken levin webkit.review.bot oldest_to_newest 626340 0 li.yin 2012-05-17 00:35:50 -0700 Spec: http://www.w3.org/TR/2012/CR-workers-20120501/#sharedworkerglobalscope The name attribute must return the value it was assigned when the SharedWorkerGlobalScope object was created. So we should have a test to check it, there is a test "fast/worker/shared-worker-name.html" already, but it doesn't cover this. I will improve the test to do that. 626344 1 142432 li.yin 2012-05-17 00:42:11 -0700 Created attachment 142432 Patch 626353 2 142432 haraken 2012-05-17 00:52:08 -0700 Comment on attachment 142432 Patch Thanks for improving the test coverage! 626362 3 142432 webkit.review.bot 2012-05-17 01:05:55 -0700 Comment on attachment 142432 Patch Clearing flags on attachment: 142432 Committed r117411: <http://trac.webkit.org/changeset/117411> 626363 4 webkit.review.bot 2012-05-17 01:05:59 -0700 All reviewed patches have been landed. Closing bug. 142432 2012-05-17 00:42:11 -0700 2012-05-17 01:05:54 -0700 Patch bug-86714-20120518154526.patch text/plain 3486 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzNkOTQ5Y2RlOWRhOGY0MTBjNGYw ZDU3NWU5YmM2YWU5YjZjNGYwYS4uZjc4YzA5ZmEzYzg1ODkxODc1NTFjODAyZWQ5YjJmYTlkYjA5 NGYyNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTE4ICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIFtXb3JrZXJdIFdlYiBXb3JrZXIgbGFja3MgdGVzdCB0byBj aGVjayB0aGUgbmFtZSBhdHRyaWJ1dGUgb2YgU2hhcmVkV29ya2VyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjcxNAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNwZWM6IGh0dHA6Ly93d3cudzMub3JnL1RS LzIwMTIvQ1Itd29ya2Vycy0yMDEyMDUwMS8jc2hhcmVkd29ya2VyZ2xvYmFsc2NvcGUKKyAgICAg ICAgVGhlIG5hbWUgYXR0cmlidXRlIG11c3QgcmV0dXJuIHRoZSB2YWx1ZSBpdCB3YXMgYXNzaWdu ZWQgd2hlbiB0aGUgU2hhcmVkV29ya2VyR2xvYmFsU2NvcGUgb2JqZWN0IHdhcyBjcmVhdGVkLgor ICAgICAgICBTbyB3ZSBzaG91bGQgaGF2ZSBhIHRlc3QgdG8gY2hlY2sgaXQsIHRoZXJlIGlzIGEg cmVsYXRlZCB0ZXN0ICJmYXN0L3dvcmtlci9zaGFyZWQtd29ya2VyLW5hbWUuaHRtbCIgYWxyZWFk eSwgCisgICAgICAgIGJ1dCBpdCBkb2Vzbid0IGNvdmVyIHRoaXMuCisKKyAgICAgICAgKiBmYXN0 L3dvcmtlcnMvcmVzb3VyY2VzL3NoYXJlZC13b3JrZXItY29tbW9uLmpzOgorICAgICAgICAoaGFu ZGxlTWVzc2FnZSk6CisgICAgICAgICogZmFzdC93b3JrZXJzL3Jlc291cmNlcy9zaGFyZWQtd29y a2VyLW5hbWUuanM6CisgICAgICAgICh0ZXN0MTEud29ya2VyLnBvcnQub25tZXNzYWdlKToKKyAg ICAgICAgKHRlc3QxMSk6CisgICAgICAgICogZmFzdC93b3JrZXJzL3NoYXJlZC13b3JrZXItbmFt ZS1leHBlY3RlZC50eHQ6CisKIDIwMTItMDUtMTUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3Rv cGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBVcGRhdGUgdGVzdCBleHBlY3Rh dGlvbnMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvcmVzb3VyY2VzL3No YXJlZC13b3JrZXItY29tbW9uLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3Jlc291cmNl cy9zaGFyZWQtd29ya2VyLWNvbW1vbi5qcwppbmRleCA3MjA4MjFiNTg0NTc1Mzc5NzA5ZWM4YjM2 NGY1YTBlYmFhZDNkNDYyLi4xMzNkNTcxYjRkZWRhMjA1YjIwYjRlMWRmZjQxYmFkMDUxOWE2YjA2 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvcmVzb3VyY2VzL3NoYXJlZC13 b3JrZXItY29tbW9uLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMv c2hhcmVkLXdvcmtlci1jb21tb24uanMKQEAgLTI0LDYgKzI0LDggQEAgZnVuY3Rpb24gaGFuZGxl TWVzc2FnZShldmVudCwgcG9ydCkgewogICAgICAgICBwb3J0LnBvc3RNZXNzYWdlKCJET05FIik7 CiAgICAgZWxzZSBpZiAoZXZlbnQuZGF0YSA9PSAidGhyb3ciKQogICAgICAgICBnZW5lcmF0ZUVy cm9yKCk7CisgICAgZWxzZSBpZiAoZXZlbnQuZGF0YSA9PSAidGVzdGluZ05hbWVBdHRyaWJ1dGUi KQorICAgICAgICBwb3J0LnBvc3RNZXNzYWdlKHNlbGYubmFtZSk7CiAgICAgZWxzZSBpZiAoL2V2 YWwuKy8udGVzdChldmVudC5kYXRhKSkgewogICAgICAgICB0cnkgewogICAgICAgICAgICAgcG9y dC5wb3N0TWVzc2FnZShldmVudC5kYXRhLnN1YnN0cig1KSArICI6ICIgKyBldmFsKGV2ZW50LmRh dGEuc3Vic3RyKDUpKSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3dvcmtlcnMvcmVz b3VyY2VzL3NoYXJlZC13b3JrZXItbmFtZS5qcyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9y ZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1uYW1lLmpzCmluZGV4IDYwNjkzYmI3Y2M0MDFjMTMwZTc1 ZjY0N2Y2OWRmYzlkYzVlM2U3YzcuLjg5NTJiOTlhNDhmM2VmMGM1OTkyYjBiYjliZWIyNzBhNjg4 YmY4OTAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJjZXMvc2hh cmVkLXdvcmtlci1uYW1lLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvd29ya2Vycy9yZXNvdXJj ZXMvc2hhcmVkLXdvcmtlci1uYW1lLmpzCkBAIC0xNDcsNiArMTQ3LDE3IEBAIGZ1bmN0aW9uIHRl c3QxMCgpCiAgICAgfQogfQogCitmdW5jdGlvbiB0ZXN0MTEoKQoreworICAgIC8vIENyZWF0aW5n IGEgd29ya2VyIHdpdGggYSBzcGVjaWZpYyBuYW1lLCB0aGUgbmFtZSBhdHRyaWJ1dGUgc2hvdWxk IGJlIHNldCB0byB3b3JrZXIgY29ycmVjdGx5LgorICAgIHZhciB3b3JrZXIgPSBuZXcgU2hhcmVk V29ya2VyKCdyZXNvdXJjZXMvc2hhcmVkLXdvcmtlci1jb21tb24uanMnLCAidGVzdGluZ05hbWVB dHRyaWJ1dGUiKTsKKyAgICB3b3JrZXIucG9ydC5wb3N0TWVzc2FnZSgidGVzdGluZ05hbWVBdHRy aWJ1dGUiKTsKKyAgICB3b3JrZXIucG9ydC5vbm1lc3NhZ2UgPSBmdW5jdGlvbihldmVudCkgewor ICAgICAgICBzaG91bGRCZUVxdWFsKCJ0aGUgbmFtZSBhdHRyaWJ1dGUgb2Ygd29ya2VyIGNhbiBi ZSBzZXQgY29ycmVjdGx5IiwgZXZlbnQuZGF0YSwgInRlc3RpbmdOYW1lQXR0cmlidXRlIik7Cisg ICAgICAgIG5leHRUZXN0KCk7CisgICAgfQorfQorCiBmdW5jdGlvbiBzaG91bGRCZUVxdWFsKGRl c2NyaXB0aW9uLCBhLCBiKQogewogICAgIGlmIChhID09IGIpCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L3dvcmtlcnMvc2hhcmVkLXdvcmtlci1uYW1lLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2Zhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLW5hbWUtZXhwZWN0ZWQudHh0CmluZGV4 IDQyODA2Y2M5NWJiYmEwMWUzM2RhODUzYzVkNDRjYjUyZDk4NmUxZmYuLjM5YzM5YTEzMmM3MGFl ZGVlMzI2Yzc4M2MyNWE2ZDM3MzNjOGNhY2IgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv d29ya2Vycy9zaGFyZWQtd29ya2VyLW5hbWUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L2Zhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLW5hbWUtZXhwZWN0ZWQudHh0CkBAIC0xNiw2ICsx Niw3IEBAIFBBU1MgY3JlYXRpbmcgd29ya2VyIHdpdGggYSBudWxsIG5hbWUKIFBBU1MgY3JlYXRl ZCBTaGFyZWRXb3JrZXIgd2l0aCBuYW1lICd1bmRlZmluZWQnCiBQQVNTIHNldHRpbmcgc2VsZi5m b28KIFBBU1MgY3JlYXRpbmcgd29ya2VyIHdpdGggYW4gdW5kZWZpbmVkIG5hbWUKK1BBU1MgdGhl IG5hbWUgYXR0cmlidXRlIG9mIHdvcmtlciBjYW4gYmUgc2V0IGNvcnJlY3RseQogCiBURVNUIENP TVBMRVRFCiAK