86702 2012-05-16 20:46:04 -0700 This is not a joke: 3.7X speedup from removing a call to sleep 2012-09-04 15:17:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren eric fishd webkit.review.bot oldest_to_newest 626210 0 ggaren 2012-05-16 20:46:04 -0700 This is not a joke: 3.7X speedup from removing a call to sleep 626222 1 142407 ggaren 2012-05-16 20:53:40 -0700 Created attachment 142407 Patch 626225 2 webkit.review.bot 2012-05-16 20:57:31 -0700 Attachment 142407 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/TC..." exit_code: 1 Source/WTF/wtf/TCSpinLock.h:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 626230 3 142409 ggaren 2012-05-16 21:31:13 -0700 Created attachment 142409 Patch 626232 4 webkit.review.bot 2012-05-16 21:33:07 -0700 Attachment 142409 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/TC..." exit_code: 1 Source/WTF/wtf/TCSpinLock.h:132: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 626421 5 eric 2012-05-17 03:31:06 -0700 Entertaining. :) 626422 6 142409 eric 2012-05-17 03:33:36 -0700 Comment on attachment 142409 Patch I should note this is from the original tcmalloc import: http://trac.webkit.org/changeset/10634 626822 7 ggaren 2012-05-17 12:07:12 -0700 Committed r117478: <http://trac.webkit.org/changeset/117478> 711490 8 162108 ggaren 2012-09-04 15:16:41 -0700 Created attachment 162108 The GC benchmark (for posterity) 711492 9 ggaren 2012-09-04 15:17:24 -0700 Uploading a version of the benchmark I was using, so other folks can play with it. 142407 2012-05-16 20:53:40 -0700 2012-05-16 21:31:10 -0700 Patch bug-86702-20120516205338.patch text/plain 2590 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMTczODgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA1LTE2ICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgVGhpcyBpcyBub3QgYSBqb2tlOiAzLjdYIHNwZWVk dXAgZnJvbSByZW1vdmluZyBhIGNhbGwgdG8gc2xlZXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NzAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHNwZWVkdXAgd2FzIG9uIGEgR0MgYmVuY2htYXJr LCB3aXRoIGEgY3VzdG9tIFZNIGNhY2hpbmcgbGF5ZXIKKyAgICAgICAgbm90IGluIFRPVCB5ZXQu CisKKyAgICAgICAgSW5zdHJ1bWVudHMgc2hvd2VkIG1vc3QgR0MgdGhyZWFkcyBzcGVuZGluZyB0 aGUgbWFqb3JpdHkgb2YgdGhlaXIKKyAgICAgICAgdGltZSBzbGVlcGluZyBpbnN0ZWFkIG9mIGRv aW5nIHVzZWZ1bCB3b3JrLiBSZW1vdmluZyB0aGUgY2FsbCB0bworICAgICAgICBzbGVlcCBzcGVk IHVwIHRoZSBiZW5jaG1hcmsuCisKKyAgICAgICAgKiB3dGYvVENTcGluTG9jay5oOgorICAgICAg ICAoVENNYWxsb2NfU2xvd0xvY2spOiBTaW5jZSBhIHNwaW4gbG9jayBpcyBvbmx5IGV2ZXIgaGVs ZCBmb3IgYSBzaG9ydAorICAgICAgICBhbW91bnQgb2YgdGltZSwgZG9uJ3Qgc2xlZXAgZm9yIGEg bG9uZyBhbW91bnQgb2YgdGltZSB3YWl0aW5nIGZvciBpdAorICAgICAgICB0byB1bmxvY2sgLS0g eWllbGRpbmcgdG8gdGhlIHNjaGVkdWxlciBpcyBzdWZmaWNpZW50LgorCisgICAgICAgIElmIHdl IGZpbmQgYSBjYXNlIHdoZXJlIHNvbWVvbmUgaXMgc2l0dGluZyBvbiBhIHNwaW4gbG9jayBmb3Ig b3ZlciAybXMsCisgICAgICAgIHdlIHNob3VsZCBmaXggdGhlIHNwaW4gbG9jayBob2xkZXIsIG5v dCB0aGUgc3BpbiBsb2NrLgorCiAyMDEyLTA1LTE2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgdGhpbmdzIGJ1aWxkIHdpdGggRFVNUF9IQVNI VEFCTEVfU1RBVFM9MQpJbmRleDogU291cmNlL1dURi93dGYvVENTcGluTG9jay5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1RDU3BpbkxvY2suaAkocmV2aXNpb24gMTE3MzQwKQorKysg U291cmNlL1dURi93dGYvVENTcGluTG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjksMTMgKzEy OSwxNCBAQCBzdHJ1Y3QgVENNYWxsb2NfU3BpbkxvY2sgewogI2RlZmluZSBTUElOTE9DS19JTklU SUFMSVpFUiB7IDAgfQogCiBzdGF0aWMgdm9pZCBUQ01hbGxvY19TbG93TG9jayh2b2xhdGlsZSB1 bnNpZ25lZCBpbnQqIGxvY2t3b3JkKSB7CisgIHdoaWxlICh0cnVlKSB7CiAvLyBZaWVsZCBpbW1l ZGlhdGVseSBzaW5jZSBmYXN0IHBhdGggZmFpbGVkCiAjaWYgT1MoV0lORE9XUykKICAgU2xlZXAo MCk7CiAjZWxzZQogICBzY2hlZF95aWVsZCgpOwogI2VuZGlmCi0gIHdoaWxlICh0cnVlKSB7CisK ICAgICBpbnQgcjsKICNpZiBDT01QSUxFUihHQ0MpCiAjaWYgQ1BVKFg4NikgfHwgQ1BVKFg4Nl82 NCkKQEAgLTE2NywyNSArMTY4LDYgQEAgc3RhdGljIHZvaWQgVENNYWxsb2NfU2xvd0xvY2sodm9s YXRpbGUgdQogICAgIGlmICghcikgewogICAgICAgcmV0dXJuOwogICAgIH0KLQotICAgIC8vIFRo aXMgY29kZSB3YXMgYWRhcHRlZCBmcm9tIHRoZSBwdG1hbGxvYzIgaW1wbGVtZW50YXRpb24gb2YK LSAgICAvLyBzcGlubG9ja3Mgd2hpY2ggd291bGQgc2NoZWRfeWllbGQoKSB1cHRvIDUwIHRpbWVz IGJlZm9yZQotICAgIC8vIHNsZWVwaW5nIG9uY2UgZm9yIGEgZmV3IG1pbGxpc2Vjb25kcy4gIE1p a2UgQnVycm93cyBzdWdnZXN0ZWQKLSAgICAvLyBqdXN0IGRvaW5nIG9uZSBzY2hlZF95aWVsZCgp IG91dHNpZGUgdGhlIGxvb3AgYW5kIGFsd2F5cwotICAgIC8vIHNsZWVwaW5nIGFmdGVyIHRoYXQu ICBUaGlzIGNoYW5nZSBoZWxwZWQgYSBncmVhdCBkZWFsIG9uIHRoZQotICAgIC8vIHBlcmZvcm1h bmNlIG9mIHNwaW5sb2NrcyB1bmRlciBoaWdoIGNvbnRlbnRpb24uICBBIHRlc3QgcHJvZ3JhbQot ICAgIC8vIHdpdGggMTAgdGhyZWFkcyBvbiBhIGR1YWwgWGVvbiAoZm91ciB2aXJ0dWFsIHByb2Nl c3NvcnMpIHdlbnQKLSAgICAvLyBmcm9tIHRha2luZyAzMCBzZWNvbmRzIHRvIDE2IHNlY29uZHMu Ci0KLSAgICAvLyBTbGVlcCBmb3IgYSBmZXcgbWlsbGlzZWNvbmRzCi0jaWYgT1MoV0lORE9XUykK LSAgICBTbGVlcCgyKTsKLSNlbHNlCi0gICAgc3RydWN0IHRpbWVzcGVjIHRtOwotICAgIHRtLnR2 X3NlYyA9IDA7Ci0gICAgdG0udHZfbnNlYyA9IDIwMDAwMDE7Ci0gICAgbmFub3NsZWVwKCZ0bSwg TlVMTCk7Ci0jZW5kaWYKICAgfQogfQogCg== 142409 2012-05-16 21:31:13 -0700 2012-05-17 03:33:36 -0700 Patch bug-86702-20120516213112.patch text/plain 2674 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMTczODgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA1LTE2ICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgVGhpcyBpcyBub3QgYSBqb2tlOiAzLjdYIHNwZWVk dXAgZnJvbSByZW1vdmluZyBhIGNhbGwgdG8gc2xlZXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NzAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHNwZWVkdXAgd2FzIG9uIGEgR0MgYmVuY2htYXJr LCB3aXRoIGEgY3VzdG9tIFZNIGNhY2hpbmcgbGF5ZXIKKyAgICAgICAgbm90IGluIFRPVCB5ZXQu CisKKyAgICAgICAgSW5zdHJ1bWVudHMgc2hvd2VkIG1vc3QgR0MgdGhyZWFkcyBzcGVuZGluZyB0 aGUgbWFqb3JpdHkgb2YgdGhlaXIKKyAgICAgICAgdGltZSBzbGVlcGluZyBpbnN0ZWFkIG9mIGRv aW5nIHVzZWZ1bCB3b3JrLiBSZW1vdmluZyB0aGUgY2FsbCB0bworICAgICAgICBzbGVlcCBzcGVk IHVwIHRoZSBiZW5jaG1hcmsuCisKKyAgICAgICAgKiB3dGYvVENTcGluTG9jay5oOgorICAgICAg ICAoVENNYWxsb2NfU2xvd0xvY2spOiBTaW5jZSBhIHNwaW4gbG9jayBpcyBvbmx5IGV2ZXIgaGVs ZCBmb3IgYSBzaG9ydAorICAgICAgICBhbW91bnQgb2YgdGltZSwgZG9uJ3Qgc2xlZXAgZm9yIGEg bG9uZyBhbW91bnQgb2YgdGltZSB3YWl0aW5nIGZvciBpdAorICAgICAgICB0byB1bmxvY2sgLS0g eWllbGRpbmcgdG8gdGhlIHNjaGVkdWxlciBpcyBzdWZmaWNpZW50LgorCisgICAgICAgIElmIHdl IGZpbmQgYSBjYXNlIHdoZXJlIHNvbWVvbmUgaXMgc2l0dGluZyBvbiBhIHNwaW4gbG9jayBmb3Ig b3ZlciAybXMsCisgICAgICAgIHdlIHNob3VsZCBmaXggdGhlIHNwaW4gbG9jayBob2xkZXIsIG5v dCB0aGUgc3BpbiBsb2NrLgorCiAyMDEyLTA1LTE2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFz ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgdGhpbmdzIGJ1aWxkIHdpdGggRFVNUF9IQVNI VEFCTEVfU1RBVFM9MQpJbmRleDogU291cmNlL1dURi93dGYvVENTcGluTG9jay5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1RDU3BpbkxvY2suaAkocmV2aXNpb24gMTE3Mzg4KQorKysg U291cmNlL1dURi93dGYvVENTcGluTG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMjksMTMgKzEy OSwxNCBAQCBzdHJ1Y3QgVENNYWxsb2NfU3BpbkxvY2sgewogI2RlZmluZSBTUElOTE9DS19JTklU SUFMSVpFUiB7IDAgfQogCiBzdGF0aWMgdm9pZCBUQ01hbGxvY19TbG93TG9jayh2b2xhdGlsZSB1 bnNpZ25lZCBpbnQqIGxvY2t3b3JkKSB7Ci0vLyBZaWVsZCBpbW1lZGlhdGVseSBzaW5jZSBmYXN0 IHBhdGggZmFpbGVkCisgIHdoaWxlICh0cnVlKSB7CisgICAgLy8gWWllbGQgaW1tZWRpYXRlbHkg c2luY2UgZmFzdCBwYXRoIGZhaWxlZAogI2lmIE9TKFdJTkRPV1MpCi0gIFNsZWVwKDApOworICAg IFNsZWVwKDApOwogI2Vsc2UKLSAgc2NoZWRfeWllbGQoKTsKKyAgICBzY2hlZF95aWVsZCgpOwog I2VuZGlmCi0gIHdoaWxlICh0cnVlKSB7CisKICAgICBpbnQgcjsKICNpZiBDT01QSUxFUihHQ0Mp CiAjaWYgQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkKQEAgLTE2NywyNSArMTY4LDYgQEAgc3RhdGlj IHZvaWQgVENNYWxsb2NfU2xvd0xvY2sodm9sYXRpbGUgdQogICAgIGlmICghcikgewogICAgICAg cmV0dXJuOwogICAgIH0KLQotICAgIC8vIFRoaXMgY29kZSB3YXMgYWRhcHRlZCBmcm9tIHRoZSBw dG1hbGxvYzIgaW1wbGVtZW50YXRpb24gb2YKLSAgICAvLyBzcGlubG9ja3Mgd2hpY2ggd291bGQg c2NoZWRfeWllbGQoKSB1cHRvIDUwIHRpbWVzIGJlZm9yZQotICAgIC8vIHNsZWVwaW5nIG9uY2Ug Zm9yIGEgZmV3IG1pbGxpc2Vjb25kcy4gIE1pa2UgQnVycm93cyBzdWdnZXN0ZWQKLSAgICAvLyBq dXN0IGRvaW5nIG9uZSBzY2hlZF95aWVsZCgpIG91dHNpZGUgdGhlIGxvb3AgYW5kIGFsd2F5cwot ICAgIC8vIHNsZWVwaW5nIGFmdGVyIHRoYXQuICBUaGlzIGNoYW5nZSBoZWxwZWQgYSBncmVhdCBk ZWFsIG9uIHRoZQotICAgIC8vIHBlcmZvcm1hbmNlIG9mIHNwaW5sb2NrcyB1bmRlciBoaWdoIGNv bnRlbnRpb24uICBBIHRlc3QgcHJvZ3JhbQotICAgIC8vIHdpdGggMTAgdGhyZWFkcyBvbiBhIGR1 YWwgWGVvbiAoZm91ciB2aXJ0dWFsIHByb2Nlc3NvcnMpIHdlbnQKLSAgICAvLyBmcm9tIHRha2lu ZyAzMCBzZWNvbmRzIHRvIDE2IHNlY29uZHMuCi0KLSAgICAvLyBTbGVlcCBmb3IgYSBmZXcgbWls bGlzZWNvbmRzCi0jaWYgT1MoV0lORE9XUykKLSAgICBTbGVlcCgyKTsKLSNlbHNlCi0gICAgc3Ry dWN0IHRpbWVzcGVjIHRtOwotICAgIHRtLnR2X3NlYyA9IDA7Ci0gICAgdG0udHZfbnNlYyA9IDIw MDAwMDE7Ci0gICAgbmFub3NsZWVwKCZ0bSwgTlVMTCk7Ci0jZW5kaWYKICAgfQogfQogCg== 162108 2012-09-04 15:16:41 -0700 2012-09-04 15:16:41 -0700 The GC benchmark (for posterity) scratch-gc.html text/html 1595 ggaren PHA+VGhpcyB0ZXN0IG1lYXN1cmVzIEdDIHRocm91Z2hwdXQgYW5kIGxhdGVuY3kuCjwvcD4KPHBy ZSBpZD0iY29uc29sZSI+PC9wcmU+Cgo8c2NyaXB0PgpmdW5jdGlvbiBsb2cocykKewogICAgdmFy IGNvbnNvbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpOwogICAgY29uc29s ZS5pbm5lckhUTUwgPSAocyArICJcbiIpOwp9Cgp2YXIgcm9vdF9jb3VudCA9IDIwMDA7CnZhciBy b290X3NpemUgPSA1MDA7CnZhciByb290X2luZGV4ID0gMDsKdmFyIHJvb3RzID0gW107CmZ1bmN0 aW9uIGN5Y2xlUm9vdHMoKQp7CiAgICBpZiAocm9vdF9pbmRleCA9PSByb290X2NvdW50KQogICAg ICAgIHJvb3RfaW5kZXggPSAwOwoKICAgIHZhciByb290ID0gW107CiAgICBmb3IgKHZhciBpID0g MDsgaSA8IHJvb3Rfc2l6ZTsgKytpKQogICAgICAgIHJvb3RbaV0gPSB7IGE6IDAsIGI6IDAsIGM6 IDAsIGQ6IDAsIGU6IDAsIGY6IDAgfTsKCiAgICByb290c1tyb290X2luZGV4KytdID0gcm9vdDsK fQoKLy8gQ3JlYXRlIGFuIGluaXRpYWwgcm9vdCBzZXQsIGFuZCBjeWNsZSB0aGUgYmVuY2htYXJr IGEgZmV3IHRpbWVzIHRvIHJlYWNoIHN0ZWFkeSBzdGF0ZS4KZm9yICh2YXIgaSA9IDA7IGkgPCBy b290X2NvdW50ICogMTA7ICsraSkKICAgIGN5Y2xlUm9vdHMoKTsKCnZhciBpdGVyYXRlX3RpbWVv dXQgPSAxMDA7CnZhciBzbGVlcF90aW1lb3V0ID0gMjU7Cgp2YXIgY291bnRfdG90YWwgPSAwOwp2 YXIgdGltZV90b3RhbCA9IDA7CnZhciBwYXVzZV9tYXggPSAwOwoKKGZ1bmN0aW9uIGl0ZXJhdGUo KSB7CiAgICB2YXIgc3RhcnQgPSBOdW1iZXIobmV3IERhdGUpOwogICAgdmFyIGNvdW50ID0gMDsK ICAgIHZhciB0aW1lOwogICAgd2hpbGUgKDEpIHsKICAgICAgICArK2NvdW50OwogICAgICAgIGN5 Y2xlUm9vdHMoKTsKICAgICAgICB0aW1lID0gbmV3IERhdGUgLSBzdGFydDsKCiAgICAgICAgaWYg KHRpbWUgPiBpdGVyYXRlX3RpbWVvdXQpCiAgICAgICAgICAgIGJyZWFrOwogICAgfQogICAgdmFy IHBhdXNlID0gdGltZSAtIGl0ZXJhdGVfdGltZW91dDsgLy8gQSAicmVhbHRpbWUgbWlzcyIgaXMg YSBmYWlsdXJlIHRvIGhpdCBvdXIgMTAwbXMgdGltZSB0YXJnZXQuCgogICAgdGltZV90b3RhbCAr PSB0aW1lOwogICAgY291bnRfdG90YWwgKz0gY291bnQ7CiAgICBpZiAocGF1c2UgPiBwYXVzZV9t YXgpCiAgICAgICAgcGF1c2VfbWF4ID0gcGF1c2U7CgogICAgdmFyIHRocm91Z2hwdXRfYXZlcmFn ZSA9IGNvdW50X3RvdGFsIC8gdGltZV90b3RhbDsKICAgIGxvZygKICAgICAgICAiYXZlcmFnZSB0 aHJvdWdocHV0IChiaWdnZXIgaXMgYmV0dGVyKTogIiArIChNYXRoLnJvdW5kKHRocm91Z2hwdXRf YXZlcmFnZSkpICsgIiBpdGVyYXRpb25zIC8gbXNcbiIgKwogICAgICAgICJtYXhpbXVtIHJlYWx0 aW1lIG1pc3MgKHNtYWxsZXIgaXMgYmV0dGVyKTogIiArIHBhdXNlX21heCArICJtc1xuIgogICAg KTsKCiAgICAvLyBSdW4gaW4gdGltZSBzbGljZXMgdG8gYXZvaWQgaGFuZ2luZyB0aGUgcGFnZS4K ICAgIHNldFRpbWVvdXQoaXRlcmF0ZSwgc2xlZXBfdGltZW91dCk7Cn0pKCk7Cjwvc2NyaXB0Pgo=