86686 2012-05-16 16:05:54 -0700 Crash if SVG gradient stop has display: none set 2012-05-17 11:26:00 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap dino webkit.review.bot zimmermann oldest_to_newest 625970 0 thorton 2012-05-16 16:05:54 -0700 We crash if an otherwise-valid SVG gradient stop has display: none set, because there is no renderer created, but we depend on it having been created. I have a patch. <rdar://problem/10751905> 625977 1 142362 thorton 2012-05-16 16:16:41 -0700 Created attachment 142362 patch 625990 2 142362 dino 2012-05-16 16:29:15 -0700 Comment on attachment 142362 patch View in context: https://bugs.webkit.org/attachment.cgi?id=142362&action=review > LayoutTests/ChangeLog:5 > + <rdar://problem/10751905> I don't *think* we typically include the radar link in ChangeLogs. 626003 3 142362 ap 2012-05-16 16:39:47 -0700 Comment on attachment 142362 patch View in context: https://bugs.webkit.org/attachment.cgi?id=142362&action=review >> LayoutTests/ChangeLog:5 >> + <rdar://problem/10751905> > > I don't *think* we typically include the radar link in ChangeLogs. Please do include them, and encourage that practice! :) 626036 4 142362 webkit.review.bot 2012-05-16 17:06:32 -0700 Comment on attachment 142362 patch Clearing flags on attachment: 142362 Committed r117365: <http://trac.webkit.org/changeset/117365> 626037 5 webkit.review.bot 2012-05-16 17:06:42 -0700 All reviewed patches have been landed. Closing bug. 626750 6 dino 2012-05-17 11:26:00 -0700 (In reply to comment #3) > (From update of attachment 142362 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=142362&action=review > > >> LayoutTests/ChangeLog:5 > >> + <rdar://problem/10751905> > > > > I don't *think* we typically include the radar link in ChangeLogs. > > Please do include them, and encourage that practice! :) Yeah, I was corrected on IRC. What's crazy is that I've been intentionally leaving them out for years! 142362 2012-05-16 16:16:41 -0700 2012-05-16 17:06:32 -0700 patch gradient-stop-display-none.diff text/plain 3998 thorton ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MTE5ZWMwLi5mMDVkOGEwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUt MTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jh c2ggaWYgU1ZHIGdyYWRpZW50IHN0b3AgaGFzIGRpc3BsYXk6IG5vbmUgc2V0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjY4NgorICAgICAgICA8cmRh cjovL3Byb2JsZW0vMTA3NTE5MDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0aGF0IGVuc3VyZXMgdGhhdCB3ZSBkb24ndCBjcmFz aCBpZiAiZGlzcGxheTogbm9uZSIgaXMgc2V0IG9uIGFuIFNWR1N0b3BFbGVtZW50LgorCisgICAg ICAgICogc3ZnL2N1c3RvbS9ncmFkaWVudC1zdG9wLWRpc3BsYXktbm9uZS1jcmFzaC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9jdXN0b20vZ3JhZGllbnQtc3RvcC1kaXNwbGF5 LW5vbmUtY3Jhc2guc3ZnOiBBZGRlZC4KKwogMjAxMi0wNS0xNiAgRW1pbCBBIEVrbHVuZCAgPGVh ZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2hhbmdlIGFzY2VudHMgYW5kIGRlc2NlbnQgYmFj ayB0byBpbnRzIGZvciBub3cKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vZ3Jh ZGllbnQtc3RvcC1kaXNwbGF5LW5vbmUtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv c3ZnL2N1c3RvbS9ncmFkaWVudC1zdG9wLWRpc3BsYXktbm9uZS1jcmFzaC1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMjJmOWZlMAotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vZ3JhZGllbnQtc3RvcC1kaXNwbGF5LW5vbmUt Y3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1RoaXMgdGVzdCBwYXNzZXMgaWYgdGhl cmUgaXMgbm8gY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL2dyYWRp ZW50LXN0b3AtZGlzcGxheS1ub25lLWNyYXNoLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20v Z3JhZGllbnQtc3RvcC1kaXNwbGF5LW5vbmUtY3Jhc2guc3ZnCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLmE1NzcxNWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9z dmcvY3VzdG9tL2dyYWRpZW50LXN0b3AtZGlzcGxheS1ub25lLWNyYXNoLnN2ZwpAQCAtMCwwICsx LDEzIEBACis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+CisgICAgPHNj cmlwdD4KKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAg ICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICA8L3NjcmlwdD4KKyAg ICA8ZGVmcz4KKyAgICAgICAgPGxpbmVhckdyYWRpZW50IGlkPSJncmFkMSIgeDE9IjAlIiB5MT0i MCUiIHgyPSIxMDAlIiB5Mj0iMCUiPgorICAgICAgICAgICAgPHN0b3Agb2Zmc2V0PSIwJSIgc3R5 bGU9InN0b3AtY29sb3I6IHJnYigwLDI1NSwwKTsgZGlzcGxheTogbm9uZTsiLz4KKyAgICAgICAg PC9saW5lYXJHcmFkaWVudD4KKyAgICA8L2RlZnM+CisgICAgPHJlY3QgeD0iMCIgeT0iMCIgd2lk dGg9IjEwMCIgaGVpZ2h0PSIxMDAiIGZpbGw9InVybCgjZ3JhZDEpIi8+CisgICAgPHRleHQgeD0i MTIwIiB5PSIyMCI+VGhpcyB0ZXN0IHBhc3NlcyBpZiB0aGVyZSBpcyBubyBjcmFzaC48L3RleHQ+ Cis8L3N2Zz4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MDYyMTE3Li4wMGMyZjIyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMjQgQEAKIDIwMTItMDUtMTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBs ZS5jb20+CiAKKyAgICAgICAgQ3Jhc2ggaWYgU1ZHIGdyYWRpZW50IHN0b3AgaGFzIGRpc3BsYXk6 IG5vbmUgc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD04NjY4NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTA3NTE5MDU+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3JlYXRlIGEgcmVuZGVyZXIgZm9y IFNWR1N0b3BFbGVtZW50IHJlZ2FyZGxlc3Mgb2YgdGhlICJkaXNwbGF5IiBwcm9wZXJ0eS4KKyAg ICAgICAgVGhpcyBtYXRjaGVzIHRoZSBiZWhhdmlvciBvZiBPcGVyYSBhbmQgdGhlIFNWRyBzcGVj aWZpY2F0aW9uLgorCisgICAgICAgIFRlc3Q6IHN2Zy9jdXN0b20vZ3JhZGllbnQtc3RvcC1kaXNw bGF5LW5vbmUtY3Jhc2guc3ZnCisKKyAgICAgICAgKiBzdmcvU1ZHU3RvcEVsZW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U1ZHU3RvcEVsZW1lbnQ6OnJlbmRlcmVySXNOZWVkZWQpOgorICAg ICAgICAoV2ViQ29yZSk6CisgICAgICAgICogc3ZnL1NWR1N0b3BFbGVtZW50Lmg6CisgICAgICAg IChTVkdTdG9wRWxlbWVudCk6CisKKzIwMTItMDUtMTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CisKICAgICAgICAgU2Nyb2xsYmFyIGxheWVycyBzaG91bGQgcmVzcGVj dCBhY2NlbGVyYXRlZCBkcmF3aW5nIHNldHRpbmcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NjQ0CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTQ2 MjAzOD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdTdG9wRWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHU3RvcEVsZW1lbnQuY3BwCmluZGV4IDg2NDMyMTAuLjg3 MTQzZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdTdG9wRWxlbWVudC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1N0b3BFbGVtZW50LmNwcApAQCAtMTA2LDYgKzEw NiwxMSBAQCBSZW5kZXJPYmplY3QqIFNWR1N0b3BFbGVtZW50OjpjcmVhdGVSZW5kZXJlcihSZW5k ZXJBcmVuYSogYXJlbmEsIFJlbmRlclN0eWxlKikKICAgICByZXR1cm4gbmV3IChhcmVuYSkgUmVu ZGVyU1ZHR3JhZGllbnRTdG9wKHRoaXMpOwogfQogCitib29sIFNWR1N0b3BFbGVtZW50OjpyZW5k ZXJlcklzTmVlZGVkKGNvbnN0IE5vZGVSZW5kZXJpbmdDb250ZXh0JikKK3sKKyAgICByZXR1cm4g dHJ1ZTsKK30KKwogQ29sb3IgU1ZHU3RvcEVsZW1lbnQ6OnN0b3BDb2xvckluY2x1ZGluZ09wYWNp dHkoKSBjb25zdAogewogICAgIEFTU0VSVChyZW5kZXJlcigpKTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3N2Zy9TVkdTdG9wRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1N0 b3BFbGVtZW50LmgKaW5kZXggMTA0ZGIxYi4uMjViOWUzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvc3ZnL1NWR1N0b3BFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1N0 b3BFbGVtZW50LmgKQEAgLTQzLDYgKzQzLDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wg aXNHcmFkaWVudFN0b3AoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9CiAKICAgICB2aXJ0dWFsIFJl bmRlck9iamVjdCogY3JlYXRlUmVuZGVyZXIoUmVuZGVyQXJlbmEqLCBSZW5kZXJTdHlsZSopOwor ICAgIHZpcnR1YWwgYm9vbCByZW5kZXJlcklzTmVlZGVkKGNvbnN0IE5vZGVSZW5kZXJpbmdDb250 ZXh0JikgT1ZFUlJJREU7CiAKICAgICBCRUdJTl9ERUNMQVJFX0FOSU1BVEVEX1BST1BFUlRJRVMo U1ZHU3RvcEVsZW1lbnQpCiAgICAgICAgIERFQ0xBUkVfQU5JTUFURURfTlVNQkVSKE9mZnNldCwg b2Zmc2V0KQo=