86664 2012-05-16 12:13:18 -0700 Make window-property-shadowing-name.html fail faster 2012-05-16 14:57:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arv arv ap jianli ojan webkit.review.bot oldest_to_newest 625719 0 arv 2012-05-16 12:13:18 -0700 Make window-property-shadowing-name.html fail faster 625720 1 142318 arv 2012-05-16 12:14:50 -0700 Created attachment 142318 Patch 625724 2 arv 2012-05-16 12:15:47 -0700 As discussed in bug 86389 we should not timeout when the tests fails. 625746 3 142325 arv 2012-05-16 12:34:31 -0700 Created attachment 142325 Patch 625752 4 142325 ojan 2012-05-16 12:37:32 -0700 Comment on attachment 142325 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142325&action=review Feel free to ignore the nits. > LayoutTests/fast/dom/Window/window-property-shadowing-name.html:16 > +var pass = finish.bind(null, "PASS"); > +var fail = finish.bind(null, "FAIL"); Nit: don't need these methods anymore, you can just call them inline below. > LayoutTests/fast/dom/Window/window-property-shadowing-name.html:24 > +var w = window.open("javascript:void 0", "test"); > +if (w === window) Nit: no need for the local variable. 625777 5 142328 arv 2012-05-16 13:10:37 -0700 Created attachment 142328 Patch for landing 625888 6 142328 webkit.review.bot 2012-05-16 14:57:18 -0700 Comment on attachment 142328 Patch for landing Clearing flags on attachment: 142328 Committed r117349: <http://trac.webkit.org/changeset/117349> 625889 7 webkit.review.bot 2012-05-16 14:57:25 -0700 All reviewed patches have been landed. Closing bug. 142318 2012-05-16 12:14:50 -0700 2012-05-16 12:34:27 -0700 Patch bug-86664-20120516121448.patch text/plain 1795 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MzA2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjgwYTBhMWIxYTk4ODZiMTBmN2Mw NjgxOTA1OGVlNWRiNjJlYmYwYi4uODM2ZmVmOWNkYmE1MmM4ZTExYzI1NzA3OWJhZTRjMGVkMTMw NzdiNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTE2ICBFcmlrIEFydmlkc3NvbiAg PGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSB3aW5kb3ctcHJvcGVydHktc2hhZG93 aW5nLW5hbWUuaHRtbCBmYWlsIGZhc3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODY2NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSB0aW1lb3V0IG9mIDUwMG1zLgorCisgICAgICAgICogZmFz dC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1zaGFkb3dpbmctbmFtZS5odG1sOgorCiAyMDEy LTA1LTE2ICBBYmhpc2hlayBBcnlhICA8aW5mZXJub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg TWlzc2luZyBSZW5kZXJBcHBsZXQgY2FzdCBjaGVjayBpbiBIVE1MQXBwbGV0RWxlbWVudDo6cmVu ZGVyV2lkZ2V0Rm9ySlNCaW5kaW5ncy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9t L1dpbmRvdy93aW5kb3ctcHJvcGVydHktc2hhZG93aW5nLW5hbWUuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydHktc2hhZG93aW5nLW5hbWUuaHRtbAppbmRl eCAzNTUyNjhlNDFlNzIxZjA4YWU1NWY2YmIwNjZlMzE1MGI3NTZlNGYxLi45ZDU2MzIzMDE4YTM3 MTIzNzVlNjg0MjdhYjQ0ZDgxOWMyYmVkNTlhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnR5LXNoYWRvd2luZy1uYW1lLmh0bWwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1zaGFkb3dpbmctbmFtZS5o dG1sCkBAIC03LDEzICs3LDE2IEBAIG5hbWUgaW4gdGhlIERPTS4gSWYgdGhlIHRlc3QgcGFzc2Vz LCB5b3UnbGwgc2VlIGEgUEFTUyBtZXNzYWdlIGJlbG93LgogCiA8c2NyaXB0PgogCi1mdW5jdGlv biBwYXNzKCkKK2Z1bmN0aW9uIGZpbmlzaChyZXN1bHQpCiB7Ci0gICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoImNvbnNvbGUiKS5pbm5lckhUTUwgPSAiUEFTUyI7CisgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5pbm5lckhUTUwgPSByZXN1bHQ7CiAgICAgaWYgKHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlcikKICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90 aWZ5RG9uZSgpOwogfQogCit2YXIgcGFzcyA9IGZpbmlzaC5iaW5kKG51bGwsICJQQVNTIik7Cit2 YXIgZmFpbCA9IGZpbmlzaC5iaW5kKG51bGwsICJGQUlMIik7CisKIGlmICh3aW5kb3cubGF5b3V0 VGVzdENvbnRyb2xsZXIpIHsKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7 CiAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwpAQCAtMjEsNSArMjQs NiBAQCBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAKIHZhciBuYW1lID0gInRl c3QiOwogd2luZG93Lm9wZW4oImphdmFzY3JpcHQ6cGFzcygpIiwgInRlc3QiKTsKK3NldFRpbWVv dXQoZmFpbCwgNTAwKTsKIAogPC9zY3JpcHQ+Cg== 142325 2012-05-16 12:34:31 -0700 2012-05-16 13:10:27 -0700 Patch bug-86664-20120516123430.patch text/plain 2014 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MzA2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjgwYTBhMWIxYTk4ODZiMTBmN2Mw NjgxOTA1OGVlNWRiNjJlYmYwYi4uMjQ4YzBiMjkyYjhmNWRiZDQxMzAwN2VlMTRlYjdjM2M5MmY4 NTJhZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTE2ICBFcmlrIEFydmlkc3NvbiAg PGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSB3aW5kb3ctcHJvcGVydHktc2hhZG93 aW5nLW5hbWUuaHRtbCBmYWlsIGZhc3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODY2NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIG1ha2VzIHRlc3Qgc3luYyBpbnN0ZWFkIG9mIGFzeW5jIGJ5 IGNoZWNraW5nIHRoZSByZXR1cm4gdmFsdWUgb2Ygd2luZG93Lm9wZW4uCisKKyAgICAgICAgKiBm YXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnR5LXNoYWRvd2luZy1uYW1lLmh0bWw6CisKIDIw MTItMDUtMTYgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBNaXNzaW5nIFJlbmRlckFwcGxldCBjYXN0IGNoZWNrIGluIEhUTUxBcHBsZXRFbGVtZW50Ojpy ZW5kZXJXaWRnZXRGb3JKU0JpbmRpbmdzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1zaGFkb3dpbmctbmFtZS5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1zaGFkb3dpbmctbmFtZS5odG1sCmlu ZGV4IDM1NTI2OGU0MWU3MjFmMDhhZTU1ZjZiYjA2NmUzMTUwYjc1NmU0ZjEuLmVjOTIwOTA5MGQ0 YTg2MjMyMmFiYjJmMzI4ZGU3M2I0MmM3NGJiY2EgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zh c3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydHktc2hhZG93aW5nLW5hbWUuaHRtbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnR5LXNoYWRvd2luZy1uYW1l Lmh0bWwKQEAgLTMsMjMgKzMsMjcgQEAgVGhpcyBwYWdlIHRlc3RzIHdoZXRoZXIgZGVjbGFyaW5n IGEgdmFyaWFibGUgbmFtZWQgIm5hbWUiIGNoYW5nZXMgdGhlIHdpbmRvdydzCiBuYW1lIGluIHRo ZSBET00uIElmIHRoZSB0ZXN0IHBhc3NlcywgeW91J2xsIHNlZSBhIFBBU1MgbWVzc2FnZSBiZWxv dy4KIDwvcD4KIAotPHByZSBpZD0iY29uc29sZSI+RkFJTDwvcHJlPgorPHByZT5GQUlMPC9wcmU+ CiAKIDxzY3JpcHQ+CiAKLWZ1bmN0aW9uIHBhc3MoKQorZnVuY3Rpb24gZmluaXNoKHJlc3VsdCkK IHsKLSAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29uc29sZSIpLmlubmVySFRNTCA9ICJQ QVNTIjsKLSAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQotICAgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgZG9jdW1lbnQucXVlcnlTZWxlY3Rv cigicHJlIikudGV4dENvbnRlbnQgPSByZXN1bHQ7CiB9CiAKK3ZhciBwYXNzID0gZmluaXNoLmJp bmQobnVsbCwgIlBBU1MiKTsKK3ZhciBmYWlsID0gZmluaXNoLmJpbmQobnVsbCwgIkZBSUwiKTsK KwogaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewogICAgIGxheW91dFRlc3RDb250 cm9sbGVyLmR1bXBBc1RleHQoKTsKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxE b25lKCk7CiB9CiAKIHZhciBuYW1lID0gInRlc3QiOwotd2luZG93Lm9wZW4oImphdmFzY3JpcHQ6 cGFzcygpIiwgInRlc3QiKTsKK3ZhciB3ID0gd2luZG93Lm9wZW4oImphdmFzY3JpcHQ6dm9pZCAw IiwgInRlc3QiKTsKK2lmICh3ID09PSB3aW5kb3cpCisgICAgcGFzcygpOworZWxzZQorICAgIGZh aWwoKTsKIAogPC9zY3JpcHQ+Cg== 142328 2012-05-16 13:10:37 -0700 2012-05-16 14:57:18 -0700 Patch for landing bug-86664-20120516131036.patch text/plain 1937 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MzA2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjgwYTBhMWIxYTk4ODZiMTBmN2Mw NjgxOTA1OGVlNWRiNjJlYmYwYi4uMjZjMDc5N2ZmODVmNWY3YmM2ZjE5NzEyZDMwMGIxMzhhMWQ5 ZjU3MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTE2ICBFcmlrIEFydmlkc3NvbiAg PGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTWFrZSB3aW5kb3ctcHJvcGVydHktc2hhZG93 aW5nLW5hbWUuaHRtbCBmYWlsIGZhc3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODY2NjQKKworICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFp LgorCisgICAgICAgIFRoaXMgbWFrZXMgdGVzdCBzeW5jIGluc3RlYWQgb2YgYXN5bmMgYnkgY2hl Y2tpbmcgdGhlIHJldHVybiB2YWx1ZSBvZiB3aW5kb3cub3Blbi4KKworICAgICAgICAqIGZhc3Qv ZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydHktc2hhZG93aW5nLW5hbWUuaHRtbDoKKwogMjAxMi0w NS0xNiAgQWJoaXNoZWsgQXJ5YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1p c3NpbmcgUmVuZGVyQXBwbGV0IGNhc3QgY2hlY2sgaW4gSFRNTEFwcGxldEVsZW1lbnQ6OnJlbmRl cldpZGdldEZvckpTQmluZGluZ3MuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9X aW5kb3cvd2luZG93LXByb3BlcnR5LXNoYWRvd2luZy1uYW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnR5LXNoYWRvd2luZy1uYW1lLmh0bWwKaW5kZXgg MzU1MjY4ZTQxZTcyMWYwOGFlNTVmNmJiMDY2ZTMxNTBiNzU2ZTRmMS4uZjNiMGU5ZmE2MDVhOTY4 MTUwZGRlZTQzZGRiNzUxMzMxZWI1M2RiYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1zaGFkb3dpbmctbmFtZS5odG1sCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydHktc2hhZG93aW5nLW5hbWUuaHRt bApAQCAtMywyMyArMywyNCBAQCBUaGlzIHBhZ2UgdGVzdHMgd2hldGhlciBkZWNsYXJpbmcgYSB2 YXJpYWJsZSBuYW1lZCAibmFtZSIgY2hhbmdlcyB0aGUgd2luZG93J3MKIG5hbWUgaW4gdGhlIERP TS4gSWYgdGhlIHRlc3QgcGFzc2VzLCB5b3UnbGwgc2VlIGEgUEFTUyBtZXNzYWdlIGJlbG93Lgog PC9wPgogCi08cHJlIGlkPSJjb25zb2xlIj5GQUlMPC9wcmU+Cis8cHJlPkZBSUw8L3ByZT4KIAog PHNjcmlwdD4KIAotZnVuY3Rpb24gcGFzcygpCitmdW5jdGlvbiBsb2cocmVzdWx0KQogewotICAg IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIikuaW5uZXJIVE1MID0gIlBBU1MiOwot ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCi0gICAgICAgIGxheW91dFRlc3RD b250cm9sbGVyLm5vdGlmeURvbmUoKTsKKyAgICBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCJwcmUi KS50ZXh0Q29udGVudCA9IHJlc3VsdDsKIH0KIAogaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlcikgewogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKLSAgICBsYXlv dXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CiB9CiAKIHZhciBuYW1lID0gInRlc3Qi Owotd2luZG93Lm9wZW4oImphdmFzY3JpcHQ6cGFzcygpIiwgInRlc3QiKTsKK3ZhciB3ID0gd2lu ZG93Lm9wZW4oImphdmFzY3JpcHQ6dm9pZCAwIiwgInRlc3QiKTsKK2lmICh3ID09PSB3aW5kb3cp CisgICAgbG9nKCJQQVNTIik7CitlbHNlCisgICAgbG9nKCJGQUlMIik7CiAKIDwvc2NyaXB0Pgo=