86639 2012-05-16 09:20:11 -0700 Web Inspector: Pressing esc after requesting snippet creation should remove snippet. 2012-05-16 10:35:39 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 75094 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 625534 0 vsevik 2012-05-16 09:20:11 -0700 Patch to follow. 625538 1 142279 vsevik 2012-05-16 09:28:35 -0700 Created attachment 142279 Patch 625564 2 142279 pfeldman 2012-05-16 09:52:16 -0700 Comment on attachment 142279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142279&action=review > Source/WebCore/ChangeLog:3 > + Web Inspector: Pressing esc after requwsting snippet creation should remove snippet. requesting > Source/WebCore/ChangeLog:8 > + Added committed parameter to rNavigatorView.rename() callback. rNavigatorView ? 625610 3 vsevik 2012-05-16 10:35:39 -0700 Committed r117306: <http://trac.webkit.org/changeset/117306> 142279 2012-05-16 09:28:35 -0700 2012-05-16 09:52:15 -0700 Patch bug-86639-20120516202833.patch text/plain 4379 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3Mjk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVlY2FlOTJjNTM3YmE2 OTc0MGRlMjVkY2Y5NTk0NTBiNWUxZGJkYy4uMWYxMDUxYmJlNjRmMDhmYThhNWIzZWU2NzRjNWE4 YjJkNDY4ZGVhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDEyLTA1LTE2ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFByZXNzaW5nIGVzYyBhZnRlciByZXF1d3N0aW5nIHNuaXBwZXQgY3JlYXRpb24gc2hvdWxk IHJlbW92ZSBzbmlwcGV0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODY2MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCBjb21taXR0ZWQgcGFyYW1ldGVyIHRvIHJOYXZpZ2F0b3JWaWV3LnJlbmFt ZSgpIGNhbGxiYWNrLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9OYXZpZ2F0b3JW aWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5hdmlnYXRvclZpZXcucHJvdG90eXBlLnJl bmFtZS5jb21taXRIYW5kbGVyKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OYXZpZ2F0b3JWaWV3 LnByb3RvdHlwZS5yZW5hbWUuY2FuY2VsSGFuZGxlcik6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu TmF2aWdhdG9yVmlldy5wcm90b3R5cGUucmVuYW1lLmFmdGVyRWRpdGluZyk6CisgICAgICAgICog aW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzTmF2aWdhdG9yLmpzOgorICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNj cmlwdHNQYW5lbC5wcm90b3R5cGUuX3NuaXBwZXRDcmVhdGlvblJlcXVlc3RlZC5jYWxsYmFjayk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZS5fc25pcHBldENy ZWF0aW9uUmVxdWVzdGVkKToKKworMjAxMi0wNS0xNiAgVnNldm9sb2QgVmxhc292ICA8dnNldmlr QGNocm9taXVtLm9yZz4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTdXBwb3J0IHNjcmlwdCBz bmlwcGV0cyBzYXZpbmcuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NjYzMgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL05hdmlnYXRvclZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL05hdmlnYXRvclZpZXcuanMKaW5kZXggZTViMTNlYjFiOTgyYjZlYzhlZGIwNzI0ZjJmYzJk N2QzYzk4NzMyNS4uMGI4YTdlMDk5ZDlmNDg2MTRkZmMyZDgxMWQzODIwMWJkZTY1YTFjNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OYXZpZ2F0b3JWaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmF2aWdhdG9yVmll dy5qcwpAQCAtMjQzLDcgKzI0Myw3IEBAIFdlYkluc3BlY3Rvci5OYXZpZ2F0b3JWaWV3LnByb3Rv dHlwZSA9IHsKIAogICAgIC8qKgogICAgICAqIEBwYXJhbSB7V2ViSW5zcGVjdG9yLlVJU291cmNl Q29kZX0gdWlTb3VyY2VDb2RlCi0gICAgICogQHBhcmFtIHtmdW5jdGlvbigpPX0gY2FsbGJhY2sK KyAgICAgKiBAcGFyYW0ge2Z1bmN0aW9uKGJvb2xlYW4pPX0gY2FsbGJhY2sKICAgICAgKi8KICAg ICByZW5hbWU6IGZ1bmN0aW9uKHVpU291cmNlQ29kZSwgY2FsbGJhY2spCiAgICAgewpAQCAtMjYw LDE5ICsyNjAsMjIgQEAgV2ViSW5zcGVjdG9yLk5hdmlnYXRvclZpZXcucHJvdG90eXBlID0gewog ICAgICAgICAgICAgICAgIHRoaXMuX2ZpbGVSZW5hbWVkKHVpU291cmNlQ29kZSwgbmV3VGl0bGUp OwogICAgICAgICAgICAgZWxzZQogICAgICAgICAgICAgICAgIHRoaXMuX3VwZGF0ZVNjcmlwdFRp dGxlKHVpU291cmNlQ29kZSk7Ci0gICAgICAgICAgICBhZnRlckVkaXRpbmcoKTsKKyAgICAgICAg ICAgIGFmdGVyRWRpdGluZyh0cnVlKTsKICAgICAgICAgfQogCiAgICAgICAgIGZ1bmN0aW9uIGNh bmNlbEhhbmRsZXIoKQogICAgICAgICB7Ci0gICAgICAgICAgICBhZnRlckVkaXRpbmcoKTsKKyAg ICAgICAgICAgIGFmdGVyRWRpdGluZyhmYWxzZSk7CiAgICAgICAgIH0KIAotICAgICAgICBmdW5j dGlvbiBhZnRlckVkaXRpbmcoKQorICAgICAgICAvKioKKyAgICAgICAgICogQHBhcmFtIHtib29s ZWFufSBjb21taXR0ZWQKKyAgICAgICAgICovCisgICAgICAgIGZ1bmN0aW9uIGFmdGVyRWRpdGlu Zyhjb21taXR0ZWQpCiAgICAgICAgIHsKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5tYXJrQmVp bmdFZGl0ZWQoc2NyaXB0VHJlZUVsZW1lbnQudHJlZU91dGxpbmUuZWxlbWVudCwgZmFsc2UpOwog ICAgICAgICAgICAgaWYgKGNhbGxiYWNrKQotICAgICAgICAgICAgICAgIGNhbGxiYWNrKCk7Cisg ICAgICAgICAgICAgICAgY2FsbGJhY2soY29tbWl0dGVkKTsKICAgICAgICAgfQogCiAgICAgICAg IHZhciBlZGl0aW5nQ29uZmlnID0gbmV3IFdlYkluc3BlY3Rvci5FZGl0aW5nQ29uZmlnKGNvbW1p dEhhbmRsZXIuYmluZCh0aGlzKSwgY2FuY2VsSGFuZGxlci5iaW5kKHRoaXMpKTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c05hdmlnYXRvci5q cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c05hdmlnYXRvci5q cwppbmRleCA2MDRhODk5N2Q1N2Q0OWM1N2E0MmE2OGY0Mjg4YzE3M2RhYzM0ZGNmLi42MmQ3OGFk MDRmMWUxMGE5OTY0OWNjMjkyNjhjOTlkNDY4ZmFiNWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNOYXZpZ2F0b3IuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzTmF2aWdhdG9yLmpzCkBAIC0xMzIs NyArMTMyLDcgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdHNOYXZpZ2F0b3IucHJvdG90eXBlID0gewog CiAgICAgLyoqCiAgICAgICogQHBhcmFtIHtXZWJJbnNwZWN0b3IuVUlTb3VyY2VDb2RlfSB1aVNv dXJjZUNvZGUKLSAgICAgKiBAcGFyYW0ge2Z1bmN0aW9uKCk9fSBjYWxsYmFjaworICAgICAqIEBw YXJhbSB7ZnVuY3Rpb24oYm9vbGVhbik9fSBjYWxsYmFjawogICAgICAqLwogICAgIHJlbmFtZTog ZnVuY3Rpb24odWlTb3VyY2VDb2RlLCBjYWxsYmFjaykKICAgICB7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCmluZGV4IGUzNGZkODYx YTcyODNhYmIzMTU1MjRlZDM3ZjE1OWJiY2QzNDNkNTQuLjNhZWI0OWI1YzM1NTIxODg5NDlhZGQx N2Q1MzVjMmJkMzhiMDdkMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzCkBAIC05ODgsMTAgKzk4OCwxOSBAQCBXZWJJbnNwZWN0 b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuX25hdmlnYXRv ckNvbnRyb2xsZXIuc2hvd05hdmlnYXRvck92ZXJsYXkoKTsKICAgICAgICAgdGhpcy5fbmF2aWdh dG9yLnJlbmFtZShzbmlwcGV0SmF2YVNjcmlwdFNvdXJjZSwgY2FsbGJhY2suYmluZCh0aGlzKSk7 CiAgICAgCi0gICAgICAgIGZ1bmN0aW9uIGNhbGxiYWNrKCkKKyAgICAgICAgLyoqCisgICAgICAg ICAqIEBwYXJhbSB7Ym9vbGVhbn0gY29tbWl0dGVkCisgICAgICAgICAqLworICAgICAgICBmdW5j dGlvbiBjYWxsYmFjayhjb21taXR0ZWQpCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmIChzaG91 bGRIaWRlTmF2aWdhdG9yKQogICAgICAgICAgICAgICAgIHRoaXMuX25hdmlnYXRvckNvbnRyb2xs ZXIuaGlkZU5hdmlnYXRvck92ZXJsYXkoKTsKKworICAgICAgICAgICAgaWYgKCFjb21taXR0ZWQp IHsKKyAgICAgICAgICAgICAgICBXZWJJbnNwZWN0b3Iuc2NyaXB0U25pcHBldE1vZGVsLmRlbGV0 ZVNjcmlwdFNuaXBwZXQoc25pcHBldEphdmFTY3JpcHRTb3VyY2UpOworICAgICAgICAgICAgICAg IHJldHVybjsKKyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgdGhpcy5fc2hvd1NvdXJjZUxp bmUoc25pcHBldEphdmFTY3JpcHRTb3VyY2UpOwogICAgICAgICB9CiAgICAgfQo=