86638 2012-05-16 08:54:00 -0700 Bump the version number on the WKBundlePageLoaderClient 2012-05-16 10:27:27 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 beidson beidson dinu.jacob gustavo xan.lopez oldest_to_newest 625499 0 beidson 2012-05-16 08:54:00 -0700 Bump the version number on the WKBundlePageLoaderClient 625501 1 142273 beidson 2012-05-16 08:56:30 -0700 Created attachment 142273 Patch v1 625508 2 beidson 2012-05-16 08:59:41 -0700 Working on the traits, also. 625516 3 142276 beidson 2012-05-16 09:03:31 -0700 Created attachment 142276 Patch v2 - Now with more traits Still waiting on my build to catch up, won't land before that. 625522 4 142276 gustavo 2012-05-16 09:10:02 -0700 Comment on attachment 142276 Patch v2 - Now with more traits Attachment 142276 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12708584 625523 5 142276 buildbot 2012-05-16 09:10:43 -0700 Comment on attachment 142276 Patch v2 - Now with more traits Attachment 142276 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12723049 625532 6 142276 buildbot 2012-05-16 09:19:15 -0700 Comment on attachment 142276 Patch v2 - Now with more traits Attachment 142276 did not pass win-ews (win): Output: http://queues.webkit.org/results/12716297 625539 7 beidson 2012-05-16 09:30:37 -0700 http://trac.webkit.org/changeset/117301 625540 8 beidson 2012-05-16 09:30:59 -0700 The EWS failures were things I picked up locally and resolved before landing. Sorry for the noise. 625560 9 dinu.jacob 2012-05-16 09:49:34 -0700 Is there a general guideline on when the version should be bumped up when a new callback is added? 625604 10 beidson 2012-05-16 10:27:27 -0700 (In reply to comment #9) > Is there a general guideline on when the version should be bumped up when a new callback is added? Not in cases like this one. The folks impacted in this case are trying to come up with a better process going forward. 142273 2012-05-16 08:56:30 -0700 2012-05-16 09:03:31 -0700 Patch v1 patch.txt text/plain 1919 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmYmI2NTNkLi4xNjcwNDg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDYgKzEsMTYg QEAKKzIwMTItMDUtMTYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjYzOAorICAgICAg ICBCdW1wIHRoZSB2ZXJzaW9uIG51bWJlciBvbiB0aGUgV0tCdW5kbGVQYWdlTG9hZGVyQ2xpZW50 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5oOiBzLzEvMi8KKyAgICAg ICAgKiBDaGFuZ2VMb2c6IENoYW5nZSBhIGNvbmZ1c2luZyBDaGFuZ2VMb2cgZW50cnkgdG8gcmVm bGVjdCB0aGUgYWN0dWFsIGNsaWVudCB0aGF0IHdhcyBjaGFuZ2VkLgorCiAyMDEyLTA1LTE2ICBE aW51IEphY29iICA8ZGludS5qYWNvYkBub2tpYS5jb20+CiAKLSAgICAgICAgQWRkIGRpZEZpbmlz aFByb2dyZXNzIEJ1bmRsZVVJQ2xpZW50IGNhbGxiYWNrCisgICAgICAgIEFkZCBkaWRGaW5pc2hQ cm9ncmVzcyBCdW5kbGVQYWdlTG9hZGVyQ2xpZW50IGNhbGxiYWNrCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjU0MQogCiAgICAgICAgIFJldmlld2Vk IGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaCBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmgK aW5kZXggN2E1Y2JkMi4uNmJhZTI1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5oCkBAIC0x NDIsMTEgKzE0MiwxMyBAQCBzdHJ1Y3QgV0tCdW5kbGVQYWdlTG9hZGVyQ2xpZW50IHsKICAgICBX S0J1bmRsZVBhZ2VXaWxsRGlzY29ubmVjdERPTVdpbmRvd0V4dGVuc2lvbkZyb21HbG9iYWxPYmpl Y3RDYWxsYmFjayAgICB3aWxsRGlzY29ubmVjdERPTVdpbmRvd0V4dGVuc2lvbkZyb21HbG9iYWxP YmplY3Q7CiAgICAgV0tCdW5kbGVQYWdlRGlkUmVjb25uZWN0RE9NV2luZG93RXh0ZW5zaW9uVG9H bG9iYWxPYmplY3RDYWxsYmFjayAgICAgICAgZGlkUmVjb25uZWN0RE9NV2luZG93RXh0ZW5zaW9u VG9HbG9iYWxPYmplY3Q7CiAgICAgV0tCdW5kbGVQYWdlV2lsbERlc3Ryb3lHbG9iYWxPYmplY3RG b3JET01XaW5kb3dFeHRlbnNpb25DYWxsYmFjayAgICAgICAgd2lsbERlc3Ryb3lHbG9iYWxPYmpl Y3RGb3JET01XaW5kb3dFeHRlbnNpb247CisgICAgCisgICAgLy8gVmVyc2lvbiAyCiAgICAgV0tC dW5kbGVQYWdlRGlkRmluaXNoUHJvZ3Jlc3NDYWxsYmFjayAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgZGlkRmluaXNoUHJvZ3Jlc3M7CiB9OwogdHlwZWRlZiBzdHJ1Y3QgV0tCdW5k bGVQYWdlTG9hZGVyQ2xpZW50IFdLQnVuZGxlUGFnZUxvYWRlckNsaWVudDsKIAotZW51bSB7IGtX S0J1bmRsZVBhZ2VMb2FkZXJDbGllbnRDdXJyZW50VmVyc2lvbiA9IDEgfTsKK2VudW0geyBrV0tC dW5kbGVQYWdlTG9hZGVyQ2xpZW50Q3VycmVudFZlcnNpb24gPSAyIH07CiAKIGVudW0gewogICAg IFdLQnVuZGxlUGFnZVBvbGljeUFjdGlvblBhc3NUaHJvdWdoLAo= 142276 2012-05-16 09:03:31 -0700 2012-05-16 09:19:14 -0700 Patch v2 - Now with more traits patch.txt text/plain 2527 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmYmI2NTNkLi41Zjg4MzIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDYgKzEsMTgg QEAKKzIwMTItMDUtMTYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjYzOAorICAgICAg ICBCdW1wIHRoZSB2ZXJzaW9uIG51bWJlciBvbiB0aGUgV0tCdW5kbGVQYWdlTG9hZGVyQ2xpZW50 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5oOiBzLzEvMi8KKyAgICAg ICAgKiBTaGFyZWQvQVBJQ2xpZW50VHJhaXRzLmNwcDogVXBkYXRlIGNsaWVudCB0cmFpdHMgZm9y IHRoZSBCdW5kbGVQYWdlTG9hZGVyQ2xpZW50CisKKyAgICAgICAgKiBDaGFuZ2VMb2c6IENoYW5n ZSBhIGNvbmZ1c2luZyBDaGFuZ2VMb2cgZW50cnkgdG8gcmVmbGVjdCB0aGUgYWN0dWFsIGNsaWVu dCB0aGF0IHdhcyBjaGFuZ2VkLgorCiAyMDEyLTA1LTE2ICBEaW51IEphY29iICA8ZGludS5qYWNv YkBub2tpYS5jb20+CiAKLSAgICAgICAgQWRkIGRpZEZpbmlzaFByb2dyZXNzIEJ1bmRsZVVJQ2xp ZW50IGNhbGxiYWNrCisgICAgICAgIEFkZCBkaWRGaW5pc2hQcm9ncmVzcyBCdW5kbGVQYWdlTG9h ZGVyQ2xpZW50IGNhbGxiYWNrCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NjU0MQogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hy aXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSUNsaWVudFRy YWl0cy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJQ2xpZW50VHJhaXRzLmNwcAppbmRl eCBmMWY2ODhjLi4xNTFhOTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJ Q2xpZW50VHJhaXRzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJQ2xpZW50VHJh aXRzLmNwcApAQCAtMzMsNiArMzMsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAogY29uc3Qgc2l6 ZV90IEFQSUNsaWVudFRyYWl0czxXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQ+OjppbnRlcmZhY2VT aXplc0J5VmVyc2lvbltdID0gewogICAgIG9mZnNldG9mKFdLQnVuZGxlUGFnZUxvYWRlckNsaWVu dCwgZGlkTGF5b3V0Rm9yRnJhbWUpLAorICAgIG9mZnNldG9mKFdLQnVuZGxlUGFnZUxvYWRlckNs aWVudCwgZGlkRmluaXNoUHJvZ3Jlc3MpLAogICAgIHNpemVvZihXS0J1bmRsZVBhZ2VMb2FkZXJD bGllbnQpCiB9OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVj dGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlUGFnZS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZVBhZ2UuaAppbmRleCA3YTVjYmQyLi42YmFl MjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxl L0FQSS9jL1dLQnVuZGxlUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5q ZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVQYWdlLmgKQEAgLTE0MiwxMSArMTQyLDEzIEBAIHN0 cnVjdCBXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQgewogICAgIFdLQnVuZGxlUGFnZVdpbGxEaXNj b25uZWN0RE9NV2luZG93RXh0ZW5zaW9uRnJvbUdsb2JhbE9iamVjdENhbGxiYWNrICAgIHdpbGxE aXNjb25uZWN0RE9NV2luZG93RXh0ZW5zaW9uRnJvbUdsb2JhbE9iamVjdDsKICAgICBXS0J1bmRs ZVBhZ2VEaWRSZWNvbm5lY3RET01XaW5kb3dFeHRlbnNpb25Ub0dsb2JhbE9iamVjdENhbGxiYWNr ICAgICAgICBkaWRSZWNvbm5lY3RET01XaW5kb3dFeHRlbnNpb25Ub0dsb2JhbE9iamVjdDsKICAg ICBXS0J1bmRsZVBhZ2VXaWxsRGVzdHJveUdsb2JhbE9iamVjdEZvckRPTVdpbmRvd0V4dGVuc2lv bkNhbGxiYWNrICAgICAgICB3aWxsRGVzdHJveUdsb2JhbE9iamVjdEZvckRPTVdpbmRvd0V4dGVu c2lvbjsKKyAgICAKKyAgICAvLyBWZXJzaW9uIDIKICAgICBXS0J1bmRsZVBhZ2VEaWRGaW5pc2hQ cm9ncmVzc0NhbGxiYWNrICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaWRGaW5p c2hQcm9ncmVzczsKIH07CiB0eXBlZGVmIHN0cnVjdCBXS0J1bmRsZVBhZ2VMb2FkZXJDbGllbnQg V0tCdW5kbGVQYWdlTG9hZGVyQ2xpZW50OwogCi1lbnVtIHsga1dLQnVuZGxlUGFnZUxvYWRlckNs aWVudEN1cnJlbnRWZXJzaW9uID0gMSB9OworZW51bSB7IGtXS0J1bmRsZVBhZ2VMb2FkZXJDbGll bnRDdXJyZW50VmVyc2lvbiA9IDIgfTsKIAogZW51bSB7CiAgICAgV0tCdW5kbGVQYWdlUG9saWN5 QWN0aW9uUGFzc1Rocm91Z2gsCg==