86635 2012-05-16 08:27:59 -0700 Web Inspector: Speedup heap snapshot postprocessing 2012-05-16 08:48:55 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 alph alph apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 625463 0 alph 2012-05-16 08:27:59 -0700 It is possible to make _markQueriableHeapObjects run faster. 625466 1 142268 alph 2012-05-16 08:31:40 -0700 Created attachment 142268 Patch 625491 2 142268 webkit.review.bot 2012-05-16 08:48:50 -0700 Comment on attachment 142268 Patch Clearing flags on attachment: 142268 Committed r117296: <http://trac.webkit.org/changeset/117296> 625492 3 webkit.review.bot 2012-05-16 08:48:55 -0700 All reviewed patches have been landed. Closing bug. 142268 2012-05-16 08:31:40 -0700 2012-05-16 08:48:50 -0700 Patch bug-86635-20120516193139.patch text/plain 3362 alph U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWNhMjExMWQ1ZTdjNGQ3 MjA4MzZmM2IxNTA5MTA5OTIwZjM1NWIzZi4uN2FkMmFiMDljZjgxNTIzNDZiMmUwYjZkOTlkOWE5 NDIzNWRlYmMwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTE2ICBBbGV4 ZWkgRmlsaXBwb3YgIDxhbGV4ZWlmQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBTcGVlZHVwIGhlYXAgc25hcHNob3QgcG9zdHByb2Nlc3NpbmcKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NjM1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0hl YXBTbmFwc2hvdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3QucHJvdG90 eXBlLl9tYXJrUXVlcmlhYmxlSGVhcE9iamVjdHMpOgorCiAyMDEyLTA1LTE2ICBEb25hbGQgQ2Fy ciAgPGRvbmFsZC5jYXJyQG5va2lhLmNvbT4KIAogICAgICAgICBGaXhlcyB0aGUgYnVpbGQgd2l0 aCBRdCA1IEhFQUQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvSGVhcFNuYXBzaG90LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9I ZWFwU25hcHNob3QuanMKaW5kZXggNWM1N2VjNWUxNTliMzQ0MGY3ZDNjM2VhNGZmNWMyZDRmNTU5 MDQyZS4uZTMyMjYwNDczNTg3NTA5MmEwMzA3N2I0NTk4ODgxNTI1NjIxYTYyNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMKQEAg LTExNjYsMzQgKzExNjYsMzYgQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUg PSB7CiAgICAgICAgIC8vIHZpYSByZWd1bGFyIHByb3BlcnRpZXMsIGFuZCBmb3IgRE9NIHdyYXBw ZXJzLiBUcnlpbmcgdG8gYWNjZXNzIHJhbmRvbSBvYmplY3RzCiAgICAgICAgIC8vIGNhbiBjYXVz ZSBhIGNyYXNoIGR1ZSB0byBpbnNvbnNpc3RlbnQgc3RhdGUgb2YgaW50ZXJuYWwgcHJvcGVydGll cyBvZiB3cmFwcGVycy4KICAgICAgICAgdmFyIGZsYWcgPSB0aGlzLl9ub2RlRmxhZ3MuY2FuQmVR dWVyaWVkOworICAgICAgICB2YXIgaGlkZGVuRWRnZVR5cGUgPSB0aGlzLl9lZGdlSGlkZGVuVHlw ZTsKKyAgICAgICAgdmFyIGludGVybmFsRWRnZVR5cGUgPSB0aGlzLl9lZGdlSW50ZXJuYWxUeXBl OworICAgICAgICB2YXIgaW52aXNpYmxlRWRnZVR5cGUgPSB0aGlzLl9lZGdlSW52aXNpYmxlVHlw ZTsKKyAgICAgICAgdmFyIGVkZ2VUb05vZGVPZmZzZXQgPSB0aGlzLl9lZGdlVG9Ob2RlT2Zmc2V0 OworICAgICAgICB2YXIgZWRnZVR5cGVPZmZzZXQgPSB0aGlzLl9lZGdlVHlwZU9mZnNldDsKKyAg ICAgICAgdmFyIGVkZ2VGaWVsZHNDb3VudCA9IHRoaXMuX2VkZ2VGaWVsZHNDb3VudDsKIAorICAg ICAgICB2YXIgZmxhZ3MgPSB0aGlzLl9mbGFnczsKICAgICAgICAgdmFyIGxpc3QgPSBbXTsKICAg ICAgICAgZm9yICh2YXIgaXRlciA9IHRoaXMucm9vdE5vZGUuZWRnZXM7IGl0ZXIuaGFzTmV4dCgp OyBpdGVyLm5leHQoKSkgewogICAgICAgICAgICAgaWYgKGl0ZXIuZWRnZS5ub2RlLmlzV2luZG93 KQogICAgICAgICAgICAgICAgIGxpc3QucHVzaChpdGVyLmVkZ2Uubm9kZS5ub2RlSW5kZXgpOwog ICAgICAgICB9CiAKLSAgICAgICAgdmFyIGVkZ2UgPSBuZXcgV2ViSW5zcGVjdG9yLkhlYXBTbmFw c2hvdEVkZ2UodGhpcywgdW5kZWZpbmVkKTsKICAgICAgICAgdmFyIG5vZGUgPSBuZXcgV2ViSW5z cGVjdG9yLkhlYXBTbmFwc2hvdE5vZGUodGhpcyk7CiAgICAgICAgIHdoaWxlIChsaXN0Lmxlbmd0 aCkgewogICAgICAgICAgICAgdmFyIG5vZGVJbmRleCA9IGxpc3QucG9wKCk7Ci0gICAgICAgICAg ICBpZiAodGhpcy5fZmxhZ3Nbbm9kZUluZGV4XSAmIGZsYWcpCisgICAgICAgICAgICBpZiAoZmxh Z3Nbbm9kZUluZGV4XSAmIGZsYWcpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAg ICAgICBub2RlLm5vZGVJbmRleCA9IG5vZGVJbmRleDsKLSAgICAgICAgICAgIHRoaXMuX2ZsYWdz W25vZGVJbmRleF0gfD0gZmxhZzsKKyAgICAgICAgICAgIGZsYWdzW25vZGVJbmRleF0gfD0gZmxh ZzsKICAgICAgICAgICAgIHZhciBlZGdlc0NvdW50ID0gbm9kZS5lZGdlc0NvdW50OwotICAgICAg ICAgICAgZWRnZS5fZWRnZXMgPSBub2RlLnJhd0VkZ2VzOworICAgICAgICAgICAgdmFyIGVkZ2Vz ID0gbm9kZS5yYXdFZGdlczsKICAgICAgICAgICAgIGZvciAodmFyIGogPSAwOyBqIDwgZWRnZXND b3VudDsgKytqKSB7Ci0gICAgICAgICAgICAgICAgZWRnZS5lZGdlSW5kZXggPSBqICogdGhpcy5f ZWRnZUZpZWxkc0NvdW50OwotICAgICAgICAgICAgICAgIG5vZGVJbmRleCA9IGVkZ2Uubm9kZUlu ZGV4OwotICAgICAgICAgICAgICAgIGlmICh0aGlzLl9mbGFnc1tub2RlSW5kZXhdICYgZmxhZykK LSAgICAgICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICAgICAgaWYgKGVkZ2Uu aXNIaWRkZW4gfHwgZWRnZS5pc0ludmlzaWJsZSkKLSAgICAgICAgICAgICAgICAgICAgY29udGlu dWU7Ci0gICAgICAgICAgICAgICAgaWYgKGVkZ2UuaXNJbnRlcm5hbCkKKyAgICAgICAgICAgICAg ICB2YXIgZWRnZUluZGV4ID0gaiAqIGVkZ2VGaWVsZHNDb3VudDsKKyAgICAgICAgICAgICAgICBu b2RlSW5kZXggPSBlZGdlcy5pdGVtKGVkZ2VJbmRleCArIGVkZ2VUb05vZGVPZmZzZXQpOworICAg ICAgICAgICAgICAgIGlmIChmbGFnc1tub2RlSW5kZXhdICYgZmxhZykKICAgICAgICAgICAgICAg ICAgICAgY29udGludWU7Ci0gICAgICAgICAgICAgICAgdmFyIG5hbWUgPSBlZGdlLm5hbWU7Ci0g ICAgICAgICAgICAgICAgaWYgKCFuYW1lKQorICAgICAgICAgICAgICAgIHZhciB0eXBlID0gZWRn ZXMuaXRlbShlZGdlSW5kZXggKyBlZGdlVHlwZU9mZnNldCk7CisgICAgICAgICAgICAgICAgaWYg KHR5cGUgPT09IGhpZGRlbkVkZ2VUeXBlIHx8IHR5cGUgPT09IGludmlzaWJsZUVkZ2VUeXBlIHx8 IHR5cGUgPT09IGludGVybmFsRWRnZVR5cGUpCiAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVl OwogICAgICAgICAgICAgICAgIGxpc3QucHVzaChub2RlSW5kZXgpOwogICAgICAgICAgICAgfQo=