86619 2012-05-16 06:41:17 -0700 [EFL] appcache tests are flaky 2012-05-18 00:06:18 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez d-r gustavo gyuyoung.kim lucas.de.marchi naginenis rakuco tmpsantos webkit.review.bot oldest_to_newest 625356 0 cdumez 2012-05-16 06:41:17 -0700 appcache tests were recently unskipped in Bug 85585 but a lot of them appear to be flaky on the EFL debug build bot. 625374 1 142249 cdumez 2012-05-16 07:00:43 -0700 Created attachment 142249 Patch 625406 2 142249 rakuco 2012-05-16 07:29:13 -0700 Comment on attachment 142249 Patch Looks good. 626065 3 142249 gyuyoung.kim 2012-05-16 17:34:47 -0700 Comment on attachment 142249 Patch Looks make sense. 626171 4 142249 webkit.review.bot 2012-05-16 19:58:18 -0700 Comment on attachment 142249 Patch Clearing flags on attachment: 142249 Committed r117382: <http://trac.webkit.org/changeset/117382> 626172 5 webkit.review.bot 2012-05-16 19:58:23 -0700 All reviewed patches have been landed. Closing bug. 626423 6 naginenis 2012-05-17 03:47:32 -0700 DRT crashes on the test startup with this patch. The EFL Debug Buildbot is red exiting early after 20 crashes and 0 timeouts. 7188 tests run. http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/1874/steps/layout-test/logs/stdio Here is the backtrace of the crash: Program terminated with signal 11, Segmentation fault. #0 0x00007f1784e586e9 in WebCore::ApplicationCacheStorage::setCacheDirectory (this=0x227ef50, cacheDirectory="/tmp/DumpRenderTree-DwQlJv/Applications") at /WebKit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:366 366 ASSERT(m_cacheDirectory.isNull()); (gdb) bt #0 0x00007f1784e586e9 in WebCore::ApplicationCacheStorage::setCacheDirectory (this=0x227ef50, cacheDirectory="/tmp/DumpRenderTree-DwQlJv/Applications") at /WebKit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:366 #1 0x00007f1781d818c6 in ewk_settings_application_cache_path_set (path=0x7fff8797f9c0 "/tmp/DumpRenderTree-DwQlJv/Applications") at /WebKit/Source/WebKit/efl/ewk/ewk_settings.cpp:306 #2 0x0000000000464068 in DumpRenderTreeChrome::initialize (this=0x2291cb0) at /WebKit/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:163 #3 0x00000000004638a3 in DumpRenderTreeChrome::create (evas=0x228b230) at /WebKit/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:58 #4 0x0000000000461cb9 in main (argc=2, argv=0x7fff87980388) at /WebKit/Tools/DumpRenderTree/efl/DumpRenderTree.cpp:402 (gdb) 626426 7 cdumez 2012-05-17 03:58:53 -0700 Ok, I'll make a debug build to reproduce. Feel free to roll out the patch in the mean time. 626583 8 rakuco 2012-05-17 08:12:45 -0700 Reopening. Gyuyoung rolled out r117382 manually in <http://trac.webkit.org/changeset/117425> and did not reopen this bug. 626938 9 142546 cdumez 2012-05-17 14:01:34 -0700 Created attachment 142546 Patch No longer set the app cache path in ewk_main since the path can only be set once and this prevents DRT to override it. Update the ewk_settings documentation to clarify this and indicate the default value change. 626952 10 142546 rakuco 2012-05-17 14:08:23 -0700 Comment on attachment 142546 Patch Looks good to me, thank you. 626959 11 142546 tmpsantos 2012-05-17 14:12:17 -0700 Comment on attachment 142546 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142546&action=review > Source/WebKit/efl/ewk/ewk_main.cpp:-170 > - ewk_settings_application_cache_path_set(webkitDirectory.utf8().data()); You should remove the brackets here. 626966 12 142552 cdumez 2012-05-17 14:14:57 -0700 Created attachment 142552 Patch Fix minor style issue. Thanks Thiago. 626977 13 tmpsantos 2012-05-17 14:20:41 -0700 LGTM. Thanks. BTW, I think we should apply the idea of this patch to other "default paths". IMO it is intrusive to set something by default to ~/.webkit/. 627420 14 142552 webkit.review.bot 2012-05-18 00:06:13 -0700 Comment on attachment 142552 Patch Clearing flags on attachment: 142552 Committed r117552: <http://trac.webkit.org/changeset/117552> 627421 15 webkit.review.bot 2012-05-18 00:06:18 -0700 All reviewed patches have been landed. Closing bug. 142249 2012-05-16 07:00:43 -0700 2012-05-17 14:01:34 -0700 Patch 86619_app_cach_path.patch text/plain 1298 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwOTcx M2I2Li5jODQwMjgxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMTYgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBhcHBjYWNoZSB0ZXN0 cyBhcmUgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg2NjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ29ycmVjdGx5IHNldCB0aGUgYXBwbGljYXRpb24gY2FjaGUgZGF0YWJhc2UgcGF0aCBpbiBF RkwncworICAgICAgICBEdW1wUmVuZGVyVHJlZSBpbml0aWFsaXphdGlvbiBjb2RlLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcDoKKyAgICAg ICAgKER1bXBSZW5kZXJUcmVlQ2hyb21lOjppbml0aWFsaXplKToKKwogMjAxMi0wNS0xNSAgUGll cnJlIFJvc3NpICA8cGllcnJlLnJvc3NpQGdtYWlsLmNvbT4KIAogICAgICAgICBbUXRdIEVuYWJs ZSBTVkcgRm9udHMgYnkgZGVmYXVsdApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv ZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9E dW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKaW5kZXggOGNhNjRkNi4uMjQwNTAxZCAxMDA2NDQKLS0t IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAorKysg Yi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCkBAIC0x NTksNiArMTU5LDggQEAgYm9vbCBEdW1wUmVuZGVyVHJlZUNocm9tZTo6aW5pdGlhbGl6ZSgpCiAg ICAgICAgIGV3a19zZXR0aW5nc19sb2NhbF9zdG9yYWdlX3BhdGhfc2V0KHBhdGgpOwogICAgICAg ICBlaW5hX3N0cl9qb2luKHBhdGgsIHNpemVvZihwYXRoKSwgJy8nLCBkcnRUZW1wLCAiRGF0YWJh c2VzIik7CiAgICAgICAgIGV3a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfcGF0aF9zZXQocGF0aCk7 CisgICAgICAgIGVpbmFfc3RyX2pvaW4ocGF0aCwgc2l6ZW9mKHBhdGgpLCAnLycsIGRydFRlbXAs ICJBcHBsaWNhdGlvbnMiKTsKKyAgICAgICAgZXdrX3NldHRpbmdzX2FwcGxpY2F0aW9uX2NhY2hl X3BhdGhfc2V0KHBhdGgpOwogICAgIH0KIAogICAgIHJldHVybiB0cnVlOwo= 142546 2012-05-17 14:01:34 -0700 2012-05-17 14:14:57 -0700 Patch 86619_set_appcache_path.patch text/plain 3965 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyNDU2N2U2Li5hOThiZTBhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDUtMTcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhl LmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBhcHBjYWNoZSB0ZXN0cyBhcmUgZmxh a3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NjE5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbG9u Z2VyIHNldCB0aGUgYXBwbGljYXRpb24gY2FjaGUgcGF0aCBpbiBld2tfbWFpbiBzaW5jZSB0aGUg CisgICAgICAgIHBhdGggY2FuIG9ubHkgYmUgc2V0IG9uY2UgYW5kIHRoaXMgcHJldmVudHMgRFJU IChvciBhcHBzKSB0byBzZXQKKyAgICAgICAgaXQuIFVwZGF0ZSB0aGUgZXdrX3NldHRpbmdzIGRv Y3VtZW50YXRpb24gdG8gcmVmbGVjdCB0aGVzZSAKKyAgICAgICAgY2hhbmdlcy4KKworICAgICAg ICAqIGV3ay9ld2tfbWFpbi5jcHA6CisgICAgICAgIChfZXdrX2luaXRfYm9keSk6CisgICAgICAg ICogZXdrL2V3a19zZXR0aW5ncy5oOgorCiAyMDEyLTA1LTE3ICBIaXJvbm9yaSBCb25vICA8aGJv bm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtSZWZhY3RvcmluZ10gTW92ZSBwbGF0Zm9ybS1z cGVjaWZpYyBjb2RlIGluIEVkaXRvcjo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbiB0byB0aGUg V2ViS2l0IGxheWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21haW4u Y3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcAppbmRleCBkOWJlNTg3Li5m ZjAyNDE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21haW4uY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAKQEAgLTE2Nyw3ICsxNjcsNiBA QCBFaW5hX0Jvb2wgX2V3a19pbml0X2JvZHkodm9pZCkKICAgICBXVEY6OlN0cmluZyB3ZWJraXRE aXJlY3RvcnkgPSBob21lICsgIi8ud2Via2l0IjsKICAgICBpZiAoV2ViQ29yZTo6bWFrZUFsbERp cmVjdG9yaWVzKHdlYmtpdERpcmVjdG9yeSkpIHsKICAgICAgICAgZXdrX3NldHRpbmdzX3dlYl9k YXRhYmFzZV9wYXRoX3NldCh3ZWJraXREaXJlY3RvcnkudXRmOCgpLmRhdGEoKSk7Ci0gICAgICAg IGV3a19zZXR0aW5nc19hcHBsaWNhdGlvbl9jYWNoZV9wYXRoX3NldCh3ZWJraXREaXJlY3Rvcnku dXRmOCgpLmRhdGEoKSk7CiAgICAgfQogCiAgICAgZXdrX25ldHdvcmtfdGxzX2NlcnRpZmljYXRl X2NoZWNrX3NldChmYWxzZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3NldHRpbmdzLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRpbmdzLmgKaW5kZXgg NmZhZDEwNi4uZTNhMTA0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19z ZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2V0dGluZ3MuaApAQCAt MTk2LDcgKzE5Niw4IEBAIEVBUEkgRXZhc19PYmplY3QgICAgICpld2tfc2V0dGluZ3NfaWNvbl9k YXRhYmFzZV9pY29uX29iamVjdF9nZXQoY29uc3QgY2hhciAqdXJsCiAgKiBUaGUgT2ZmbGluZSBB cHBsaWNhdGlvbiBDYWNoaW5nIEFQSXMgYXJlIHBhcnQgb2YgSFRNTDUgYW5kIGFsbG93IGFwcGxp Y2F0aW9ucyB0byBzdG9yZSBkYXRhIGxvY2FsbHkgdGhhdCBpcyBhY2Nlc3NlZAogICogd2hlbiB0 aGUgbmV0d29yayBjYW5ub3QgYmUgcmVhY2hlZC4KICAqCi0gKiBCeSBkZWZhdWx0LCB0aGUgcGF0 aCBpcyBAYyB+Ly53ZWJraXQuCisgKiBCeSBkZWZhdWx0LCB0aGUgcGF0aCBpcyBAYyBOVUxMLCBp bmRpY2F0aW5nIHRoYXQgdGhlIGZlYXR1cmUgaXMgZGlzYWJsZWQuIE9uY2UgdGhlIHBhdGggaXMg c2V0LCB0aGUgZmVhdHVyZSBpcyBlbmFibGVkCisgKiBhbmQgdGhlIHBhdGggY2Fubm90IGJlIGNo YW5nZWQuCiAgKgogICogQHBhcmFtIHBhdGggd2hlcmUgdG8gc3RvcmUgY2FjaGUsIG11c3QgYmUg d3JpdGUtYWJsZS4KICAqCkBAIC0yMTAsNyArMjExLDcgQEAgRUFQSSB2b2lkICAgICAgICAgICAg IGV3a19zZXR0aW5nc19hcHBsaWNhdGlvbl9jYWNoZV9wYXRoX3NldChjb25zdCBjaGFyICpwYXRo KTsKICAqIFRoZSBPZmZsaW5lIEFwcGxpY2F0aW9uIENhY2hpbmcgQVBJcyBhcmUgcGFydCBvZiBI VE1MNSBhbmQgYWxsb3cgYXBwbGljYXRpb25zIHRvIHN0b3JlIGRhdGEgbG9jYWxseSB0aGF0IGlz IGFjY2Vzc2VkCiAgKiB3aGVuIHRoZSBuZXR3b3JrIGNhbm5vdCBiZSByZWFjaGVkLgogICoKLSAq IEJ5IGRlZmF1bHQsIHRoZSBwYXRoIGlzIEBjIH4vLndlYmtpdC4KKyAqIEJ5IGRlZmF1bHQsIHRo ZSBwYXRoIGlzIEBjIE5VTEwsIGluZGljYXRpbmcgdGhhdCB0aGUgZmVhdHVyZSBpcyBkaXNhYmxl ZC4KICAqCiAgKiBAcmV0dXJuIGVpbmFfc3RyaW5nc2hhcmUnZCBwYXRoIHZhbHVlLgogICoKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4OTlmZWZh Li4wNDdiY2Q3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDUtMTcgIENocmlzdG9waGUgRHVtZXogIDxjaHJp c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBhcHBjYWNoZSB0ZXN0cyBh cmUgZmxha3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg2NjE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q29ycmVjdGx5IHNldCB0aGUgYXBwbGljYXRpb24gY2FjaGUgZGF0YWJhc2UgcGF0aCBpbiBFRkwn cworICAgICAgICBEdW1wUmVuZGVyVHJlZSBpbml0aWFsaXphdGlvbiBjb2RlLgorCisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcDoKKyAgICAgICAg KER1bXBSZW5kZXJUcmVlQ2hyb21lOjppbml0aWFsaXplKToKKwogMjAxMi0wNS0xNyAgQ2FpbyBN YXJjZWxvIGRlIE9saXZlaXJhIEZpbGhvICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgog CiAgICAgICAgIFtRdF0gRml4IE1pbmlCcm93c2VyIGJ5IHVzaW5nIGNvcnJlY3Qgc3ludGF4IGZv ciBxcmMgVVJMcwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5k ZXJUcmVlQ2hyb21lLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJl ZUNocm9tZS5jcHAKaW5kZXggYTExYWQ1YS4uNGQ0NThlNCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVt cFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAorKysgYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCkBAIC0xNjIsNiArMTYyLDgg QEAgYm9vbCBEdW1wUmVuZGVyVHJlZUNocm9tZTo6aW5pdGlhbGl6ZSgpCiAgICAgICAgIGV3a19z ZXR0aW5nc19sb2NhbF9zdG9yYWdlX3BhdGhfc2V0KHBhdGgpOwogICAgICAgICBlaW5hX3N0cl9q b2luKHBhdGgsIHNpemVvZihwYXRoKSwgJy8nLCBkcnRUZW1wLCAiRGF0YWJhc2VzIik7CiAgICAg ICAgIGV3a19zZXR0aW5nc193ZWJfZGF0YWJhc2VfcGF0aF9zZXQocGF0aCk7CisgICAgICAgIGVp bmFfc3RyX2pvaW4ocGF0aCwgc2l6ZW9mKHBhdGgpLCAnLycsIGRydFRlbXAsICJBcHBsaWNhdGlv bnMiKTsKKyAgICAgICAgZXdrX3NldHRpbmdzX2FwcGxpY2F0aW9uX2NhY2hlX3BhdGhfc2V0KHBh dGgpOwogICAgIH0KIAogICAgIHJldHVybiB0cnVlOwo= 142552 2012-05-17 14:14:57 -0700 2012-05-18 00:06:13 -0700 Patch 86619_set_appcache_path.patch text/plain 4032 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAyNDU2N2U2Li5hOThiZTBhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDUtMTcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhl LmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBhcHBjYWNoZSB0ZXN0cyBhcmUgZmxh a3kKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NjE5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbG9u Z2VyIHNldCB0aGUgYXBwbGljYXRpb24gY2FjaGUgcGF0aCBpbiBld2tfbWFpbiBzaW5jZSB0aGUg CisgICAgICAgIHBhdGggY2FuIG9ubHkgYmUgc2V0IG9uY2UgYW5kIHRoaXMgcHJldmVudHMgRFJU IChvciBhcHBzKSB0byBzZXQKKyAgICAgICAgaXQuIFVwZGF0ZSB0aGUgZXdrX3NldHRpbmdzIGRv Y3VtZW50YXRpb24gdG8gcmVmbGVjdCB0aGVzZSAKKyAgICAgICAgY2hhbmdlcy4KKworICAgICAg ICAqIGV3ay9ld2tfbWFpbi5jcHA6CisgICAgICAgIChfZXdrX2luaXRfYm9keSk6CisgICAgICAg ICogZXdrL2V3a19zZXR0aW5ncy5oOgorCiAyMDEyLTA1LTE3ICBIaXJvbm9yaSBCb25vICA8aGJv bm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtSZWZhY3RvcmluZ10gTW92ZSBwbGF0Zm9ybS1z cGVjaWZpYyBjb2RlIGluIEVkaXRvcjo6cmVzcG9uZFRvQ2hhbmdlZFNlbGVjdGlvbiB0byB0aGUg V2ViS2l0IGxheWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21haW4u Y3BwIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19tYWluLmNwcAppbmRleCBkOWJlNTg3Li44 YTBkZDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX21haW4uY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfbWFpbi5jcHAKQEAgLTE2NSwxMCArMTY1LDgg QEAgRWluYV9Cb29sIF9ld2tfaW5pdF9ib2R5KHZvaWQpCiAgICAgfQogCiAgICAgV1RGOjpTdHJp bmcgd2Via2l0RGlyZWN0b3J5ID0gaG9tZSArICIvLndlYmtpdCI7Ci0gICAgaWYgKFdlYkNvcmU6 Om1ha2VBbGxEaXJlY3Rvcmllcyh3ZWJraXREaXJlY3RvcnkpKSB7CisgICAgaWYgKFdlYkNvcmU6 Om1ha2VBbGxEaXJlY3Rvcmllcyh3ZWJraXREaXJlY3RvcnkpKQogICAgICAgICBld2tfc2V0dGlu Z3Nfd2ViX2RhdGFiYXNlX3BhdGhfc2V0KHdlYmtpdERpcmVjdG9yeS51dGY4KCkuZGF0YSgpKTsK LSAgICAgICAgZXdrX3NldHRpbmdzX2FwcGxpY2F0aW9uX2NhY2hlX3BhdGhfc2V0KHdlYmtpdERp cmVjdG9yeS51dGY4KCkuZGF0YSgpKTsKLSAgICB9CiAKICAgICBld2tfbmV0d29ya190bHNfY2Vy dGlmaWNhdGVfY2hlY2tfc2V0KGZhbHNlKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9l ZmwvZXdrL2V3a19zZXR0aW5ncy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZXR0aW5n cy5oCmluZGV4IDZmYWQxMDYuLmUzYTEwNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2V0dGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NldHRp bmdzLmgKQEAgLTE5Niw3ICsxOTYsOCBAQCBFQVBJIEV2YXNfT2JqZWN0ICAgICAqZXdrX3NldHRp bmdzX2ljb25fZGF0YWJhc2VfaWNvbl9vYmplY3RfZ2V0KGNvbnN0IGNoYXIgKnVybAogICogVGhl IE9mZmxpbmUgQXBwbGljYXRpb24gQ2FjaGluZyBBUElzIGFyZSBwYXJ0IG9mIEhUTUw1IGFuZCBh bGxvdyBhcHBsaWNhdGlvbnMgdG8gc3RvcmUgZGF0YSBsb2NhbGx5IHRoYXQgaXMgYWNjZXNzZWQK ICAqIHdoZW4gdGhlIG5ldHdvcmsgY2Fubm90IGJlIHJlYWNoZWQuCiAgKgotICogQnkgZGVmYXVs dCwgdGhlIHBhdGggaXMgQGMgfi8ud2Via2l0LgorICogQnkgZGVmYXVsdCwgdGhlIHBhdGggaXMg QGMgTlVMTCwgaW5kaWNhdGluZyB0aGF0IHRoZSBmZWF0dXJlIGlzIGRpc2FibGVkLiBPbmNlIHRo ZSBwYXRoIGlzIHNldCwgdGhlIGZlYXR1cmUgaXMgZW5hYmxlZAorICogYW5kIHRoZSBwYXRoIGNh bm5vdCBiZSBjaGFuZ2VkLgogICoKICAqIEBwYXJhbSBwYXRoIHdoZXJlIHRvIHN0b3JlIGNhY2hl LCBtdXN0IGJlIHdyaXRlLWFibGUuCiAgKgpAQCAtMjEwLDcgKzIxMSw3IEBAIEVBUEkgdm9pZCAg ICAgICAgICAgICBld2tfc2V0dGluZ3NfYXBwbGljYXRpb25fY2FjaGVfcGF0aF9zZXQoY29uc3Qg Y2hhciAqcGF0aCk7CiAgKiBUaGUgT2ZmbGluZSBBcHBsaWNhdGlvbiBDYWNoaW5nIEFQSXMgYXJl IHBhcnQgb2YgSFRNTDUgYW5kIGFsbG93IGFwcGxpY2F0aW9ucyB0byBzdG9yZSBkYXRhIGxvY2Fs bHkgdGhhdCBpcyBhY2Nlc3NlZAogICogd2hlbiB0aGUgbmV0d29yayBjYW5ub3QgYmUgcmVhY2hl ZC4KICAqCi0gKiBCeSBkZWZhdWx0LCB0aGUgcGF0aCBpcyBAYyB+Ly53ZWJraXQuCisgKiBCeSBk ZWZhdWx0LCB0aGUgcGF0aCBpcyBAYyBOVUxMLCBpbmRpY2F0aW5nIHRoYXQgdGhlIGZlYXR1cmUg aXMgZGlzYWJsZWQuCiAgKgogICogQHJldHVybiBlaW5hX3N0cmluZ3NoYXJlJ2QgcGF0aCB2YWx1 ZS4KICAqCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5k ZXggODk5ZmVmYS4uMDQ3YmNkNyAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA1LTE3ICBDaHJpc3RvcGhlIER1 bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gYXBwY2Fj aGUgdGVzdHMgYXJlIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NjYxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENvcnJlY3RseSBzZXQgdGhlIGFwcGxpY2F0aW9uIGNhY2hlIGRhdGFiYXNlIHBh dGggaW4gRUZMJ3MKKyAgICAgICAgRHVtcFJlbmRlclRyZWUgaW5pdGlhbGl6YXRpb24gY29kZS4K KworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHA6 CisgICAgICAgIChEdW1wUmVuZGVyVHJlZUNocm9tZTo6aW5pdGlhbGl6ZSk6CisKIDIwMTItMDUt MTcgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFAb3BlbmJv c3NhLm9yZz4KIAogICAgICAgICBbUXRdIEZpeCBNaW5pQnJvd3NlciBieSB1c2luZyBjb3JyZWN0 IHN5bnRheCBmb3IgcXJjIFVSTHMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Vm bC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVt cFJlbmRlclRyZWVDaHJvbWUuY3BwCmluZGV4IGExMWFkNWEuLjRkNDU4ZTQgMTAwNjQ0Ci0tLSBh L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKKysrIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlQ2hyb21lLmNwcApAQCAtMTYy LDYgKzE2Miw4IEBAIGJvb2wgRHVtcFJlbmRlclRyZWVDaHJvbWU6OmluaXRpYWxpemUoKQogICAg ICAgICBld2tfc2V0dGluZ3NfbG9jYWxfc3RvcmFnZV9wYXRoX3NldChwYXRoKTsKICAgICAgICAg ZWluYV9zdHJfam9pbihwYXRoLCBzaXplb2YocGF0aCksICcvJywgZHJ0VGVtcCwgIkRhdGFiYXNl cyIpOwogICAgICAgICBld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX3BhdGhfc2V0KHBhdGgpOwor ICAgICAgICBlaW5hX3N0cl9qb2luKHBhdGgsIHNpemVvZihwYXRoKSwgJy8nLCBkcnRUZW1wLCAi QXBwbGljYXRpb25zIik7CisgICAgICAgIGV3a19zZXR0aW5nc19hcHBsaWNhdGlvbl9jYWNoZV9w YXRoX3NldChwYXRoKTsKICAgICB9CiAKICAgICByZXR1cm4gdHJ1ZTsK