86610 2012-05-16 05:28:14 -0700 [EFL] Do not check NULL pointer allocated by new 2012-05-17 01:21:13 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Minor --- 1 g.czajkowski g.czajkowski gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 625299 0 g.czajkowski 2012-05-16 05:28:14 -0700 WebKit-Efl doesn't check pointers that are initialized by new. Those checks are not needed because new operator doesn't return NULL. Only an overloaded version of new returns NULL pointer. 625343 1 142239 g.czajkowski 2012-05-16 06:20:53 -0700 Created attachment 142239 proposed patch 625409 2 142239 rakuco 2012-05-16 07:30:08 -0700 Comment on attachment 142239 proposed patch Looks good. 626067 3 142239 gyuyoung.kim 2012-05-16 17:37:34 -0700 Comment on attachment 142239 proposed patch Looks good to me, thank you. 626372 4 142239 webkit.review.bot 2012-05-17 01:21:08 -0700 Comment on attachment 142239 proposed patch Clearing flags on attachment: 142239 Committed r117414: <http://trac.webkit.org/changeset/117414> 626373 5 webkit.review.bot 2012-05-17 01:21:13 -0700 All reviewed patches have been landed. Closing bug. 142239 2012-05-16 06:20:53 -0700 2012-05-17 01:21:07 -0700 proposed patch skip_null_checks_after_new.patch text/plain 3133 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA5NDRjYmYwLi41NWE0MzBlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDUtMTYgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gRG8gbm90IGNoZWNrIE5VTEwgcG9p bnRlciBhbGxvY2F0ZWQgYnkgbmV3LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODY2MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXZWJLaXQtRWZsIGRvZXNuJ3QgY2hlY2sgcG9pbnRlcnMgdGhhdCBhcmUg aW5pdGlhbGl6ZWQgYnkgbmV3LgorICAgICAgICBUaG9zZSBjaGVja3MgYXJlIG5vdCBuZWVkZWQg YmVjYXVzZSBuZXcgb3BlcmF0b3IgZG9lc24ndCByZXR1cm4gTlVMTC4KKyAgICAgICAgT25seSBh biBvdmVybG9hZGVkIHZlcnNpb24gb2YgbmV3IHJldHVybnMgTlVMTCBwb2ludGVyLgorCisgICAg ICAgICogZXdrL2V3a190aWxlZF9tYXRyaXguY3BwOgorICAgICAgICAoZXdrX3RpbGVfbWF0cml4 X2VudHJ5X25ldyk6CisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9ld2tf dmlld19jb3JlX2ZyYW1lX25ldyk6CisKIDIwMTItMDUtMTYgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBFRkwncyBMYXlvdXRU ZXN0Q29udHJvbGxlciBkb2VzIG5vdCBpbXBsZW1lbnQgc2V0QXBwbGljYXRpb25DYWNoZU9yaWdp blF1b3RhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21hdHJp eC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX21hdHJpeC5jcHAKaW5kZXgg OTU1MWE2NC4uYTE0YTFkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a190 aWxlZF9tYXRyaXguY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfbWF0 cml4LmNwcApAQCAtMjY1LDE4ICsyNjUsMTYgQEAgdm9pZCBld2tfdGlsZV9tYXRyaXhfZW50cnlf bmV3KEV3a19UaWxlX01hdHJpeCogdGlsZU1hdHJpeCwgZmxvYXQgem9vbSkKICAgICBFSU5BX1NB RkVUWV9PTl9OVUxMX1JFVFVSTih0aWxlTWF0cml4KTsKIAogICAgIEV3a19UaWxlX01hdHJpeF9F bnRyeSogZW50cnkgPSBuZXcgRXdrX1RpbGVfTWF0cml4X0VudHJ5OwotICAgIGlmIChlbnRyeSkg ewotICAgICAgICBlbnRyeS0+em9vbSA9IHpvb207Ci0gICAgICAgIGVudHJ5LT5jb3VudCA9IDA7 Ci0gICAgICAgIGVudHJ5LT5tYXRyaXggPSBlaW5hX21hdHJpeHNwYXJzZV9uZXcoMSwgMSwgX2V3 a190aWxlX21hdHJpeF9jZWxsX2ZyZWUsIHRpbGVNYXRyaXgpOwotICAgICAgICBpZiAoIWVudHJ5 LT5tYXRyaXgpIHsKLSAgICAgICAgICAgIEVSUigiY291bGQgbm90IGNyZWF0ZSBzcGFyc2UgbWF0 cml4LiIpOwotICAgICAgICAgICAgZGVsZXRlIGVudHJ5OwotICAgICAgICAgICAgcmV0dXJuOwot ICAgICAgICB9Ci0gICAgICAgIHRpbGVNYXRyaXgtPm1hdHJpY2VzID0gZWluYV9pbmxpc3RfcHJl cGVuZCh0aWxlTWF0cml4LT5tYXRyaWNlcywgRUlOQV9JTkxJU1RfR0VUKGVudHJ5KSk7Ci0gICAg ICAgIHRpbGVNYXRyaXgtPm1hdHJpeCA9IGVudHJ5LT5tYXRyaXg7CisgICAgZW50cnktPnpvb20g PSB6b29tOworICAgIGVudHJ5LT5jb3VudCA9IDA7CisgICAgZW50cnktPm1hdHJpeCA9IGVpbmFf bWF0cml4c3BhcnNlX25ldygxLCAxLCBfZXdrX3RpbGVfbWF0cml4X2NlbGxfZnJlZSwgdGlsZU1h dHJpeCk7CisgICAgaWYgKCFlbnRyeS0+bWF0cml4KSB7CisgICAgICAgIEVSUigiY291bGQgbm90 IGNyZWF0ZSBzcGFyc2UgbWF0cml4LiIpOworICAgICAgICBkZWxldGUgZW50cnk7CisgICAgICAg IHJldHVybjsKICAgICB9CisgICAgdGlsZU1hdHJpeC0+bWF0cmljZXMgPSBlaW5hX2lubGlzdF9w cmVwZW5kKHRpbGVNYXRyaXgtPm1hdHJpY2VzLCBFSU5BX0lOTElTVF9HRVQoZW50cnkpKTsKKyAg ICB0aWxlTWF0cml4LT5tYXRyaXggPSBlbnRyeS0+bWF0cml4OwogfQogCiB2b2lkIGV3a190aWxl X21hdHJpeF9pbnZhbGlkYXRlKEV3a19UaWxlX01hdHJpeCogdGlsZU1hdHJpeCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Vm bC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDRhOWZmOGQuLjdlMmVmODAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcApAQCAtNzAwLDEwICs3MDAsNiBAQCBzdGF0aWMgdm9pZCBfZXdrX3Zp ZXdfb25fa2V5X3VwKHZvaWQqIGRhdGEsIEV2YXMqLCBFdmFzX09iamVjdCosIHZvaWQqIGV2ZW50 SW5mbwogc3RhdGljIFdURjo6UGFzc1JlZlB0cjxXZWJDb3JlOjpGcmFtZT4gX2V3a192aWV3X2Nv cmVfZnJhbWVfbmV3KEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNtYXJ0RGF0YSwgRXdrX1ZpZXdfUHJp dmF0ZV9EYXRhKiBwcml2LCBXZWJDb3JlOjpIVE1MRnJhbWVPd25lckVsZW1lbnQqIG93bmVyKQog ewogICAgIFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50RWZsKiBmcmFtZUxvYWRlckNsaWVudCA9 IG5ldyBXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEVmbChzbWFydERhdGEtPnNlbGYpOwotICAg IGlmICghZnJhbWVMb2FkZXJDbGllbnQpIHsKLSAgICAgICAgQ1JJVElDQUwoIkNvdWxkIG5vdCBj cmVhdGUgZnJhbWUgbG9hZGVyIGNsaWVudC4iKTsKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgfQog ICAgIGZyYW1lTG9hZGVyQ2xpZW50LT5zZXRDdXN0b21Vc2VyQWdlbnQoU3RyaW5nOjpmcm9tVVRG OChwcml2LT5zZXR0aW5ncy51c2VyQWdlbnQpKTsKIAogICAgIHJldHVybiBXZWJDb3JlOjpGcmFt ZTo6Y3JlYXRlKHByaXYtPnBhZ2UuZ2V0KCksIG93bmVyLCBmcmFtZUxvYWRlckNsaWVudCk7Cg==