86603 2012-05-16 03:06:44 -0700 Memory leak in NetworkInfoClient 2012-05-17 16:35:02 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis abarth gustavo gyuyoung.kim gyuyoung.kim lucas.de.marchi mrobinson pnormand rakuco webkit.review.bot oldest_to_newest 625210 0 naginenis 2012-05-16 03:06:44 -0700 Valgrind reports a memory leak in NetworkInfoClient. I think NetworkInfoClient needs to be released explicitly when the NetworkInfoController is destroyed. ==24745== 48 bytes in 1 blocks are definitely lost in loss record 4,353 of 9,337 ==24745== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==24745== by 0x9E0D17E: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==24745== by 0x4FF4C04: WTF::RefCounted<WebCore::NetworkInfoClient>::operator new(unsigned long) (RefCounted.h:185) ==24745== by 0x4FCF937: _ewk_view_priv_new(_Ewk_View_Smart_Data*) (ewk_view.cpp:656) ==24745== by 0x4FD0A1E: _ewk_view_smart_add(_Evas_Object*) (ewk_view.cpp:833) ==24745== by 0x4FF52C8: _ewk_view_single_smart_add(_Evas_Object*) (ewk_view_single.cpp:45) ==24745== by 0x4E78E18: evas_object_smart_add (evas_object_smart.c:323) ==24745== by 0x4FF6542: ewk_view_single_add (ewk_view_single.cpp:419) ==24745== by 0x4047DB: browserCreate (main.c:637) ==24745== by 0x405135: main (main.c:830) 625214 1 gyuyoung.kim 2012-05-16 03:15:13 -0700 Thank you for your bug report. Will you submit a patch for this ? 625215 2 naginenis 2012-05-16 03:21:15 -0700 (In reply to comment #1) > Thank you for your bug report. Will you submit a patch for this ? Yes, Gyuyoung. Fixing the leak now. 625232 3 142213 naginenis 2012-05-16 03:45:03 -0700 Created attachment 142213 Patch Fix memory leak. 625237 4 142213 gyuyoung.kim 2012-05-16 03:52:07 -0700 Comment on attachment 142213 Patch LGTM. 625524 5 mrobinson 2012-05-16 09:10:57 -0700 When modifying platform-independent code careful with the use of the [EFL] tag. It usually is a signal to reviewers who know the WebCore code well to ignore your patch. 625529 6 naginenis 2012-05-16 09:15:00 -0700 (In reply to comment #5) > When modifying platform-independent code careful with the use of the [EFL] tag. It usually is a signal to reviewers who know the WebCore code well to ignore your patch. Understood, thanks Martin! 625533 7 mrobinson 2012-05-16 09:20:07 -0700 (In reply to comment #6) > (In reply to comment #5) > > When modifying platform-independent code careful with the use of the [EFL] tag. It usually is a signal to reviewers who know the WebCore code well to ignore your patch. > > Understood, thanks Martin! Nice work, hunting all these leaks too. :) 626182 8 142213 abarth 2012-05-16 20:15:17 -0700 Comment on attachment 142213 Patch Thanks for the patch, but this isn't the normal idiom we use for managing the lifetime of clients. Take a look at how some of the other clients work, such as the Geolocation clients. It's better if we're consistent in how we handle these sorts of objects. 626254 9 gyuyoung.kim 2012-05-16 22:08:26 -0700 (In reply to comment #8) > (From update of attachment 142213 [details]) > Thanks for the patch, but this isn't the normal idiom we use for managing the lifetime of clients. Take a look at how some of the other clients work, such as the Geolocation clients. It's better if we're consistent in how we handle these sorts of objects. Adam, I'm sorry. I will take care of reviewing patch informally further. 626580 10 rakuco 2012-05-17 08:05:30 -0700 (In reply to comment #8) > (From update of attachment 142213 [details]) > Thanks for the patch, but this isn't the normal idiom we use for managing the lifetime of clients. Take a look at how some of the other clients work, such as the Geolocation clients. It's better if we're consistent in how we handle these sorts of objects. To be honest, I got a bit confused when trying to review this yesterday. While some clients do inherit from RefCounted, most of them do not. GeolocationClient itself follows the pattern of not inheriting from RefCounted and having a fooDestroyed() method that's called from its controller's destructor. One of the exceptions I found was SpeechRecognitionController, which says in a comment: "Call m_client->pageDestroyed(); once we have implemented a client" in the destructor. What would be the normal idiom here? 626607 11 abarth 2012-05-17 08:41:02 -0700 > What would be the normal idiom here? Yeah, we should probably clean these up to be more consistent. IMHO, we should have these clients be owned by the WebView. That will cause them to naturally outlive the controller. Notice the OwnPtrs to various clients here: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/src/WebViewImpl.h#L783 That approach is nice because it avoids these destruction notification functions. 626874 12 rakuco 2012-05-17 12:48:14 -0700 That sounds nice. I now wonder whether these client classes in WebCore should inherit from RefCounted or not; some of them do, some don't, and using them requires using RefPtrs instead of OwnPtrs in WebKit. 626877 13 abarth 2012-05-17 12:50:26 -0700 We'll need to look at them each individually. The approach in Comment #11 uses OwnPtr, not RefPtr, so they shouldn't need to subclass RefCounted. 627042 14 naginenis 2012-05-17 15:22:04 -0700 Thanks for the feedback and letting me know this nice approach for clients destruction. I'm going to update the patch now. 627053 15 142569 naginenis 2012-05-17 15:32:32 -0700 Created attachment 142569 Fix memory leak Updated patch taking Adam Barth's feedback into consideration. 627061 16 142569 abarth 2012-05-17 15:39:23 -0700 Comment on attachment 142569 Fix memory leak Perfect. Thanks! 627121 17 142569 webkit.review.bot 2012-05-17 16:34:55 -0700 Comment on attachment 142569 Fix memory leak Clearing flags on attachment: 142569 Committed r117515: <http://trac.webkit.org/changeset/117515> 627122 18 webkit.review.bot 2012-05-17 16:35:02 -0700 All reviewed patches have been landed. Closing bug. 142213 2012-05-16 03:45:03 -0700 2012-05-17 15:32:32 -0700 Patch 86603.patch text/plain 3922 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MTE4MDZhLi41OGU4YTlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDUtMTYgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gTWVtb3J5IGxlYWsgaW4gTmV0d29ya0lu Zm9DbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg2NjAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4IGEgbWVtb3J5IGxlYWsgaW4gTmV0d29ya0luZm9DbGllbnQgYnkgZGVsZXRpbmcgdGhlIGNs aWVudAorICAgICAgICB3aGVuIHRoZSBjb250cm9sbGVyIGlzIGRlc3Ryb3llZC4KKworICAgICAg ICAqIE1vZHVsZXMvbmV0d29ya2luZm8vTmV0d29ya0luZm9DbGllbnQuaDoKKyAgICAgICAgKE5l dHdvcmtJbmZvQ2xpZW50KToKKyAgICAgICAgKiBNb2R1bGVzL25ldHdvcmtpbmZvL05ldHdvcmtJ bmZvQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSW5mb0NvbnRyb2xs ZXI6On5OZXR3b3JrSW5mb0NvbnRyb2xsZXIpOgorCiAyMDEyLTA1LTE2ICBTaGVyaWZmIEJvdCAg PHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMTE3MDUwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9uZXR3 b3JraW5mby9OZXR3b3JrSW5mb0NsaWVudC5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9uZXR3 b3JraW5mby9OZXR3b3JrSW5mb0NsaWVudC5oCmluZGV4IDcyOTExOGUuLmUyYWNmMGQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbmV0d29ya2luZm8vTmV0d29ya0luZm9DbGll bnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25ldHdvcmtpbmZvL05ldHdvcmtJbmZv Q2xpZW50LmgKQEAgLTM2LDcgKzM2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgTmV0 d29ya0luZm9Db250cm9sbGVyOwogY2xhc3MgUGFnZTsKIAotY2xhc3MgTmV0d29ya0luZm9DbGll bnQgOiBwdWJsaWMgUmVmQ291bnRlZDxOZXR3b3JrSW5mb0NsaWVudD4geworY2xhc3MgTmV0d29y a0luZm9DbGllbnQgewogcHVibGljOgogICAgIHZpcnR1YWwgfk5ldHdvcmtJbmZvQ2xpZW50KCkg eyB9CiAKQEAgLTQ1LDYgKzQ1LDcgQEAgcHVibGljOgogICAgCiAgICAgdmlydHVhbCB2b2lkIHN0 YXJ0VXBkYXRpbmcoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHN0b3BVcGRhdGluZygpID0gMDsK KyAgICB2aXJ0dWFsIHZvaWQgbmV0d29ya0luZm9Db250cm9sbGVyRGVzdHJveWVkKCkgPSAwOwog fTsKIAogdm9pZCBwcm92aWRlTmV0d29ya0luZm9UbyhQYWdlKiwgTmV0d29ya0luZm9DbGllbnQq KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbmV0d29ya2luZm8vTmV0d29y a0luZm9Db250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbmV0d29ya2luZm8v TmV0d29ya0luZm9Db250cm9sbGVyLmNwcAppbmRleCBhYTY5NWVjLi5mNWZlZGRjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL25ldHdvcmtpbmZvL05ldHdvcmtJbmZvQ29udHJv bGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9uZXR3b3JraW5mby9OZXR3b3Jr SW5mb0NvbnRyb2xsZXIuY3BwCkBAIC00NCw2ICs0NCw3IEBAIE5ldHdvcmtJbmZvQ29udHJvbGxl cjo6TmV0d29ya0luZm9Db250cm9sbGVyKFBhZ2UqIHBhZ2UsIE5ldHdvcmtJbmZvQ2xpZW50KiBj bGllCiAKIE5ldHdvcmtJbmZvQ29udHJvbGxlcjo6fk5ldHdvcmtJbmZvQ29udHJvbGxlcigpCiB7 CisgICAgbV9jbGllbnQtPm5ldHdvcmtJbmZvQ29udHJvbGxlckRlc3Ryb3llZCgpOwogfQogCiBQ YXNzT3duUHRyPE5ldHdvcmtJbmZvQ29udHJvbGxlcj4gTmV0d29ya0luZm9Db250cm9sbGVyOjpj cmVhdGUoUGFnZSogcGFnZSwgTmV0d29ya0luZm9DbGllbnQqIGNsaWVudCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxv ZwppbmRleCBjMWNiNjJhLi5lNTE4NGNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDUtMTYgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gTWVtb3J5IGxlYWsgaW4gTmV0d29ya0lu Zm9DbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg2NjAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4IGEgbWVtb3J5IGxlYWsgaW4gTmV0d29ya0luZm9DbGllbnQgYnkgZGVsZXRpbmcgdGhlIGNs aWVudAorICAgICAgICB3aGVuIHRoZSBjb250cm9sbGVyIGlzIGRlc3Ryb3llZC4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L05ldHdvcmtJbmZvQ2xpZW50RWZsLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok5ldHdvcmtJbmZvQ2xpZW50RWZsOjpuZXR3b3JrSW5mb0NvbnRyb2xsZXJEZXN0cm95 ZWQpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvTmV0d29y a0luZm9DbGllbnRFZmwuaDoKKyAgICAgICAgKE5ldHdvcmtJbmZvQ2xpZW50RWZsKToKKwogMjAx Mi0wNS0xNSAgS2lob25nIEt3b24gIDxraWhvbmcua3dvbkBzYW1zdW5nLmNvbT4KIAogICAgICAg ICBbRUZMXSBFbmFibGUgRnVsbHNjcmVlbiBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv ZWZsL1dlYkNvcmVTdXBwb3J0L05ldHdvcmtJbmZvQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJL aXQvZWZsL1dlYkNvcmVTdXBwb3J0L05ldHdvcmtJbmZvQ2xpZW50RWZsLmNwcAppbmRleCA2NmQ1 YTAwLi4wZTc1YTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9y dC9OZXR3b3JrSW5mb0NsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9lZmwvV2ViQ29y ZVN1cHBvcnQvTmV0d29ya0luZm9DbGllbnRFZmwuY3BwCkBAIC02Niw1ICs2NiwxMCBAQCBib29s IE5ldHdvcmtJbmZvQ2xpZW50RWZsOjptZXRlcmVkKCkgY29uc3QKICAgICByZXR1cm4gZmFsc2U7 CiB9CiAKK3ZvaWQgTmV0d29ya0luZm9DbGllbnRFZmw6Om5ldHdvcmtJbmZvQ29udHJvbGxlckRl c3Ryb3llZCgpCit7CisgICAgZGVsZXRlIHRoaXM7Cit9CisKIH0KICNlbmRpZgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvTmV0d29ya0luZm9DbGllbnRFZmwu aCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L05ldHdvcmtJbmZvQ2xpZW50RWZs LmgKaW5kZXggOTc5NzEwMy4uM2M0OTM5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv V2ViQ29yZVN1cHBvcnQvTmV0d29ya0luZm9DbGllbnRFZmwuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L2VmbC9XZWJDb3JlU3VwcG9ydC9OZXR3b3JrSW5mb0NsaWVudEVmbC5oCkBAIC00Myw2ICs0Myw3 IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdW5zaWduZWQgaW50IGJhbmR3aWR0aCgpIGNvbnN0 OwogICAgIHZpcnR1YWwgYm9vbCBtZXRlcmVkKCkgY29uc3Q7CisgICAgdmlydHVhbCB2b2lkIG5l dHdvcmtJbmZvQ29udHJvbGxlckRlc3Ryb3llZCgpOwogCiBwcml2YXRlOgogCg== 142569 2012-05-17 15:32:32 -0700 2012-05-17 16:34:55 -0700 Fix memory leak 86603.patch text/plain 2969 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxZGI3ODk0Li4yNTc1YThiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDUtMTcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgTWVtb3J5IGxlYWsgaW4gTmV0d29ya0luZm9DbGll bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NjAz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGEg bWVtb3J5IGxlYWsgaW4gTmV0d29ya0luZm9DbGllbnQgYnkgdXNpbmcgT3duUHRyIGFuZAorICAg ICAgICBjaGFuZ2UgdGhlIGNsYXNzIG5vdCB0byBpbmhlcml0ZSBmcm9tIFJlZkNvdW50ZWQuCisK KyAgICAgICAgKiBNb2R1bGVzL25ldHdvcmtpbmZvL05ldHdvcmtJbmZvQ2xpZW50Lmg6CisKIDIw MTItMDUtMTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAg ICAgICBDb252ZXJ0IHNldERvbWFpblJlbGF4YXRpb25Gb3JiaWRkZW5Gb3JVUkxTY2hlbWUgdG8g dXNlIEludGVybmFsU2V0dGluZ3MgaW50ZXJmYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL25ldHdvcmtpbmZvL05ldHdvcmtJbmZvQ2xpZW50LmggYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL25ldHdvcmtpbmZvL05ldHdvcmtJbmZvQ2xpZW50LmgKaW5kZXggNzI5MTE4ZS4u YTM1ZDE0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9uZXR3b3JraW5mby9O ZXR3b3JrSW5mb0NsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbmV0d29ya2lu Zm8vTmV0d29ya0luZm9DbGllbnQuaApAQCAtMzYsNyArMzYsNyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiBjbGFzcyBOZXR3b3JrSW5mb0NvbnRyb2xsZXI7CiBjbGFzcyBQYWdlOwogCi1jbGFzcyBO ZXR3b3JrSW5mb0NsaWVudCA6IHB1YmxpYyBSZWZDb3VudGVkPE5ldHdvcmtJbmZvQ2xpZW50PiB7 CitjbGFzcyBOZXR3b3JrSW5mb0NsaWVudCB7CiBwdWJsaWM6CiAgICAgdmlydHVhbCB+TmV0d29y a0luZm9DbGllbnQoKSB7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdl TG9nIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCmluZGV4IDE0NTc1MmUuLjZlMGU2ZmEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi S2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNS0xNyAgU3VkYXJzYW5h IE5hZ2luZW5pICA8c3VkYXJzYW5hLm5hZ2luZW5pQGxpbnV4LmludGVsLmNvbT4KKworICAgICAg ICBNZW1vcnkgbGVhayBpbiBOZXR3b3JrSW5mb0NsaWVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY2MDMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBtZW1vcnkgbGVhayBpbiBOZXR3b3JrSW5m b0NsaWVudCBieSB1c2luZyBPd25QdHIgYW5kIG1ha2luZworICAgICAgICB0aGUgY2xpZW50IHRv IGJlIG93bmVkIGJ5IHRoZSBWaWV3LgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAg ICAgICAgKF9Fd2tfVmlld19Qcml2YXRlX0RhdGEpOgorICAgICAgICAoX2V3a192aWV3X3ByaXZf bmV3KToKKwogMjAxMi0wNS0xNyAgTWFyaXVzeiBHcnplZ29yY3p5ayAgPG1hcml1c3ouZ0BzYW1z dW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBbRFJUXSBFRkwncyBEdW1wUmVuZGVyVHJlZSBzaG91 bGQgc3VwcG9ydCBMYXlvdXRUZXN0Q29udHJvbGxlcidzIGR1bXBFZGl0aW5nQ2FsbGJhY2tzKCkK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDdlMmVmODAuLmNlYjIwM2QgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dl YktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMjM5LDYgKzIzOSw5IEBAIHN0cnVjdCBfRXdr X1ZpZXdfUHJpdmF0ZV9EYXRhIHsKICAgICBXZWJDb3JlOjpWaWV3cG9ydEFyZ3VtZW50cyB2aWV3 cG9ydEFyZ3VtZW50czsKICAgICBFd2tfSGlzdG9yeSogaGlzdG9yeTsKICAgICBPd25QdHI8UGFn ZUNsaWVudEVmbD4gcGFnZUNsaWVudDsKKyNpZiBFTkFCTEUoTkVUV09SS19JTkZPKQorICAgIE93 blB0cjxXZWJDb3JlOjpOZXR3b3JrSW5mb0NsaWVudEVmbD4gbmV0d29ya0luZm9DbGllbnQ7Cisj ZW5kaWYKICNpZiBFTkFCTEUoSU5QVVRfVFlQRV9DT0xPUikKICAgICBXZWJDb3JlOjpDb2xvckNo b29zZXJDbGllbnQqIGNvbG9yQ2hvb3NlckNsaWVudDsKICNlbmRpZgpAQCAtNzI4LDcgKzczMSw4 IEBAIHN0YXRpYyBFd2tfVmlld19Qcml2YXRlX0RhdGEqIF9ld2tfdmlld19wcml2X25ldyhFd2tf Vmlld19TbWFydF9EYXRhKiBzbWFydERhdGEpCiAjZW5kaWYKIAogI2lmIEVOQUJMRShORVRXT1JL X0lORk8pCi0gICAgV2ViQ29yZTo6cHJvdmlkZU5ldHdvcmtJbmZvVG8ocHJpdi0+cGFnZS5nZXQo KSwgbmV3IFdlYkNvcmU6Ok5ldHdvcmtJbmZvQ2xpZW50RWZsKTsKKyAgICBwcml2LT5uZXR3b3Jr SW5mb0NsaWVudCA9IGFkb3B0UHRyKG5ldyBXZWJDb3JlOjpOZXR3b3JrSW5mb0NsaWVudEVmbCk7 CisgICAgV2ViQ29yZTo6cHJvdmlkZU5ldHdvcmtJbmZvVG8ocHJpdi0+cGFnZS5nZXQoKSwgcHJp di0+bmV0d29ya0luZm9DbGllbnQuZ2V0KCkpOwogI2VuZGlmCiAKICNpZiBFTkFCTEUoVklCUkFU SU9OKQo=