86589 2012-05-16 00:42:27 -0700 [Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing 2012-05-16 11:20:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi shawnsingh abarth dglazkov enne fishd jamesr tkent tkent+wkapi webkit.review.bot oldest_to_newest 625090 0 bashi 2012-05-16 00:42:27 -0700 The test didn't complete all platform. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20%28dbg%29%281%29/builds/12336 http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28dbg%29%281%29/builds/7239 http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20%28dbg%29/builds/6817 625174 1 142202 bashi 2012-05-16 02:18:31 -0700 Created attachment 142202 Patch 625177 2 webkit.review.bot 2012-05-16 02:20:53 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 625178 3 bashi 2012-05-16 02:22:26 -0700 The failure is caused by the assertion at WebPrivateOwnPtr::~WebPrivateOwnPtr(). Kent-san, could you take a look? 625202 4 142202 tkent 2012-05-16 02:57:25 -0700 Comment on attachment 142202 Patch ok 625213 5 bashi 2012-05-16 03:13:33 -0700 (In reply to comment #4) > (From update of attachment 142202 [details]) > ok Thanks! 625252 6 142202 webkit.review.bot 2012-05-16 04:19:38 -0700 Comment on attachment 142202 Patch Clearing flags on attachment: 142202 Committed r117257: <http://trac.webkit.org/changeset/117257> 625253 7 webkit.review.bot 2012-05-16 04:19:44 -0700 All reviewed patches have been landed. Closing bug. 625478 8 shawnsingh 2012-05-16 08:40:34 -0700 Thank you for fixing this, I apologize you had to do it on my behalf 625664 9 142202 jamesr 2012-05-16 11:20:33 -0700 Comment on attachment 142202 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=142202&action=review > Source/Platform/chromium/public/WebTransformationMatrix.h:54 > + ~WebTransformationMatrix(); we typically have this declared inline and call a exported reset() function. this class is still in a bit of flux, though (it doesn't have proper exports yet, for instance) 142202 2012-05-16 02:18:31 -0700 2012-05-16 11:20:33 -0700 Patch bug-86589-20120516181830.patch text/plain 3293 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA2OGEzN2MxYTg5NDFm NzU0NDZmNzNiNmUyYWM5ODE5MDNkZWNjOTczLi5hYThmM2ZkZmI5OWU3NWM1MjY0ZDI0MTcyNzA1 MGYwZGYxM2I5YmEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNS0xNiAg S2VuaWNoaSBJc2hpYmFzaGkgIDxiYXNoaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9t aXVtXSBXZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeFRlc3QudmVyaWZ5RGVmYXVsdENvbnN0cnVjdG9y Q3JlYXRlc0lkZW50aXR5TWF0cml4IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvV2ViVHJhbnNmb3JtYXRp b25NYXRyaXguaDogQWRkZWQgZGVzdHJ1Y3Rvci4KKyAgICAgICAgKFdlYlRyYW5zZm9ybWF0aW9u TWF0cml4KToKKwogMjAxMi0wNS0xNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExNzIwNC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCAwZTg2YmFhMjkwNzJiNzJkMmVhNjBjNzMxZjk5YjVjNjRhODU5OGU0Li5iMjM4 YzE4M2Q2MjYxN2FlODM3N2Q2ZGMyOWY5NTA5ZTMxM2Y4OGIwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMTItMDUtMTYgIEtlbmljaGkgSXNoaWJhc2hpICA8YmFzaGlAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gV2ViVHJhbnNmb3JtYXRpb25NYXRyaXhUZXN0LnZl cmlmeURlZmF1bHRDb25zdHJ1Y3RvckNyZWF0ZXNJZGVudGl0eU1hdHJpeCBpcyBmYWlsaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjU4OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5lZWQgdG8gY2Fs bCBtX3ByaXZhdGUucmVzZXQoMCkgYmVmb3JlIGRlc3RydWN0aW5nIFdlYlRyYW5zZm9ybWF0aW9u TWF0cml4IG9iamVjdHMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBXZWJUcmFuc2Zvcm1hdGlv bk1hdHJpeFRlc3Qgc2hvdWxkIHBhc3Mgb24gZGVidWcgYnVpbGQuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYlRyYW5zZm9ybWF0aW9uTWF0cml4LmNwcDoKKyAgICAg ICAgKFdlYktpdDo6V2ViVHJhbnNmb3JtYXRpb25NYXRyaXg6On5XZWJUcmFuc2Zvcm1hdGlvbk1h dHJpeCk6CisgICAgICAgIChXZWJLaXQpOgorCiAyMDEyLTA1LTE2ICBQYXZlbCBGZWxkbWFuICA8 cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlbmFtZSBE ZWJ1Z2dlclByZXNlbnRhdGlvbk1vZGVsIHRvIERlYnVnZ2VyU2NyaXB0TWFwcGluZywgbWFrZSBp dCBwcml2YXRlIHRvIFNjcmlwdHNQYW5lbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9j aHJvbWl1bS9wdWJsaWMvV2ViVHJhbnNmb3JtYXRpb25NYXRyaXguaCBiL1NvdXJjZS9QbGF0Zm9y bS9jaHJvbWl1bS9wdWJsaWMvV2ViVHJhbnNmb3JtYXRpb25NYXRyaXguaAppbmRleCA5MzNiODZh MTgzZGM5NGM2MzEzOTQwMjlhYzA5NGY0NDJkOGE3MWEyLi40MTIxNjc0ZTRiOGFiMzNkZTRlY2Yx OTYzNWFlNTU1N2UwNDQzNzRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0v cHVibGljL1dlYlRyYW5zZm9ybWF0aW9uTWF0cml4LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2No cm9taXVtL3B1YmxpYy9XZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeC5oCkBAIC01MSw2ICs1MSw3IEBA IHB1YmxpYzoKICAgICBXZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeCgpOwogICAgIFdlYlRyYW5zZm9y bWF0aW9uTWF0cml4KGRvdWJsZSBhLCBkb3VibGUgYiwgZG91YmxlIGMsIGRvdWJsZSBkLCBkb3Vi bGUgZSwgZG91YmxlIGYpOwogICAgIFdlYlRyYW5zZm9ybWF0aW9uTWF0cml4KGNvbnN0IFdlYlRy YW5zZm9ybWF0aW9uTWF0cml4Jik7CisgICAgfldlYlRyYW5zZm9ybWF0aW9uTWF0cml4KCk7CiAK ICAgICAvLyBPcGVyYXRpb25zIHRoYXQgcmV0dXJuIGEgc2VwYXJhdGUgbWF0cml4IGFuZCBkbyBu b3QgbW9kaWZ5IHRoaXMgb25lLgogICAgIFdlYlRyYW5zZm9ybWF0aW9uTWF0cml4IGludmVyc2Uo KSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL3N1 cHBvcnQvV2ViVHJhbnNmb3JtYXRpb25NYXRyaXguY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vc3VwcG9ydC9XZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeC5jcHAKaW5kZXggOGE0 ZWEwMDhmOTFkYWIyMzU0NTY0ZjQ0Y2FjYzNkMGVkOTM4MmNiYy4uZDQxYWI2YTdkYmQ3MzAwNmJj MmRmNDdkM2M3NjQ3OTAyZTFhYzg3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vc3VwcG9ydC9XZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJUcmFuc2Zvcm1hdGlvbk1h dHJpeC5jcHAKQEAgLTUwLDYgKzUwLDEyIEBAIFdlYlRyYW5zZm9ybWF0aW9uTWF0cml4OjpXZWJU cmFuc2Zvcm1hdGlvbk1hdHJpeChjb25zdCBXZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeCYKIHsKIH0K IAorV2ViVHJhbnNmb3JtYXRpb25NYXRyaXg6On5XZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeCgpCit7 CisgICAgLy8gV2UgbmVlZCB0byBjYWxsIG1fcHJpdmF0ZS5yZXNldCgwKS4gU2VlIHRoZSBjb21t ZW50IG9mIFdlYlByaXZhdGVPd25QdHIgY2xhc3MuCisgICAgbV9wcml2YXRlLnJlc2V0KDApOwor fQorCiAjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiBXZWJUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6 V2ViVHJhbnNmb3JtYXRpb25NYXRyaXgoY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIHQpCiAg ICAgOiBtX3ByaXZhdGUobmV3IFRyYW5zZm9ybWF0aW9uTWF0cml4KHQpKQo=