86561 2012-05-15 20:19:07 -0700 RenderTableSection wastes vector capacity 2012-06-18 10:11:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86281 1 simon.fraser jchaffraix eric jchaffraix kling koivisto robert simon.fraser webkit.review.bot oldest_to_newest 624909 0 simon.fraser 2012-05-15 20:19:07 -0700 279 vectors, 87.19KB used of 174.38KB, 87.19KB wasted at: 1 0x1095d7c50 WTF::Vector<WebCore::RenderTableSection::CellStruct, 0ul>::Vector(WTF::Vector<WebCore::RenderTableSection::CellStruct, 0ul> const&) 2 0x1095d7a73 WTF::VectorMover<false, WebCore::RenderTableSection::RowStruct>::move(WebCore::RenderTableSection::RowStruct const*, WebCore::RenderTableSection::RowStruct const*, WebCore::RenderTableSection::RowStruct*) 3 0x1095d9878 WTF::Vector<WebCore::RenderTableSection::RowStruct, 0ul>::reserveCapacity(unsigned long) 4 0x1095d6892 WTF::Vector<WebCore::RenderTableSection::RowStruct, 0ul>::grow(unsigned long) 5 0x1095d1e05 WebCore::RenderTableSection::addChild(WebCore::RenderObject*, WebCore::RenderObject*) 152 vectors, 26.48KB used of 95.00KB, 68.52KB wasted at: 1 0x1095d68e8 WTF::Vector<WebCore::RenderTableSection::RowStruct, 0ul>::grow(unsigned long) 2 0x1095d1e05 WebCore::RenderTableSection::addChild(WebCore::RenderObject*, WebCore::RenderObject*) 3 0x1094898b9 WebCore::NodeRendererFactory::createRendererIfNeeded() 4 0x109480213 WebCore::Node::createRendererIfNeeded() 5 0x108f1ced7 WebCore::Element::attach() 624914 1 simon.fraser 2012-05-15 20:21:35 -0700 Also 36 vectors, 20.20KB used of 40.45KB, 20.25KB wasted at: 1 0x1095d18a4 WebCore::RenderTableSection::RenderTableSection(WebCore::Node*) 2 0x10957b6b5 WebCore::RenderObject::createObject(WebCore::Node*, WebCore::RenderStyle*) 3 0x10948957c WebCore::NodeRendererFactory::createRenderer() 4 0x109489887 WebCore::NodeRendererFactory::createRendererIfNeeded() 5 0x109480213 WebCore::Node::createRendererIfNeeded() 651385 2 148099 jchaffraix 2012-06-18 07:46:22 -0700 Created attachment 148099 Proposed memory optimization. 651487 3 148099 webkit.review.bot 2012-06-18 10:11:29 -0700 Comment on attachment 148099 Proposed memory optimization. Clearing flags on attachment: 148099 Committed r120605: <http://trac.webkit.org/changeset/120605> 651488 4 webkit.review.bot 2012-06-18 10:11:42 -0700 All reviewed patches have been landed. Closing bug. 148099 2012-06-18 07:46:22 -0700 2012-06-18 10:11:29 -0700 Proposed memory optimization. bug-86561-20120618074615.patch text/plain 2068 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2I5MzJjZjRmOWE4OGZj ZDc0NjdkNWY2YWJiNDZjOWRmNjQyZWIwMy4uNWZlNjk1MjVlNmMyODEzMGU1OTkyYmIzZjMwNmZk NjdhNjQ3NjY0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA2LTE4ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbmRlclRh YmxlU2VjdGlvbiB3YXN0ZXMgdmVjdG9yIGNhcGFjaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjU2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE1lbW9yeSBvcHRpbWl6YXRpb24sIGNvdmVyZWQgYnkg ZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgVGhlIGlzc3VlIGlzIHRoYXQgYWRkQ2hpbGQgY2Fs bHMgVmVjdG9yOjpncm93KCkgd2hpY2ggY2FuIG92ZXItYWxsb2NhdGUgb3VyIHJvdyBncmlkIChl c3BlY2lhbGx5CisgICAgICAgIGZvciBzbWFsbCB0YWJsZXMgYXMgd2UgYWxsb2NhdGUgYXQgbGVh c3QgMTYgZW50cmllcykuIEFzIHdlIGRvbid0IGtub3cgaWYgYWRkQ2hpbGQgaXMgY2FsbGVkCisg ICAgICAgIGluIGEgbG9vcCAoZS5nLiBkdXJpbmcgcGFyc2luZyksIHdlIHBvc3Rwb25lIHRoZSBz aHJpbmtUb0ZpdCBjYWxsIGF0IGxheW91dCB0aW1lLgorCisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJUYWJsZVNlY3Rpb246OmxheW91dCk6CisgICAgICAgIEFkZGVkIGEgc2hyaW5rVG9GaXQgY2Fs bCB3aXRoIHNvbWUgZXhwbGFuYXRpb24gYXMgdG8gd2h5IGl0J3MgZ29vZCB0cmFkZS1vZmYgdG8g ZG8gaXQgbm93LgorCiAyMDEyLTA2LTE1ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OIChyMTExMDQxKTogTWlzc2luZyBlbGVtZW50IHR5cGUgY2hl Y2sgaW4gUmVuZGVyVGhlbWVNYWM6OnBhaW50TWVkaWFGdWxsc2NyZWVuQnV0dG9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVTZWN0aW9uLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCmluZGV4IGExNmUw ZjY2ZGY2NjVjYWRkYjk3OTAzMjZkMjk0ZTdkZDU1MzgwY2EuLjliYjc5M2JlMzM2MGQzNDRhMGJh Mjg0OGM4ZTZlYWRhYTAzMTA3Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUYWJsZVNlY3Rpb24uY3BwCkBAIC00MDYsNiArNDA2LDEwIEBAIHZvaWQgUmVuZGVyVGFi bGVTZWN0aW9uOjpsYXlvdXQoKQogICAgIEFTU0VSVCghbmVlZHNDZWxsUmVjYWxjKCkpOwogICAg IEFTU0VSVCghdGFibGUoKS0+bmVlZHNTZWN0aW9uUmVjYWxjKCkpOwogCisgICAgLy8gYWRkQ2hp bGQgbWF5IG92ZXItZ3JvdyBtX2dyaWQgYnV0IHdlIGRvbid0IHdhbnQgdG8gdGhyb3cgYXdheSB0 aGUgbWVtb3J5IHRvbyBlYXJseSBhcyBhZGRDaGlsZAorICAgIC8vIGNhbiBiZSBjYWxsZWQgaW4g YSBsb29wIChlLmcgZHVyaW5nIHBhcnNpbmcpLiBEb2luZyBpdCBub3cgZW5zdXJlcyB3ZSBoYXZl IGEgc3RhYmxlLWVub3VnaCBzdHJ1Y3R1cmUuCisgICAgbV9ncmlkLnNocmlua1RvRml0KCk7CisK ICAgICBMYXlvdXRTdGF0ZU1haW50YWluZXIgc3RhdGVQdXNoZXIodmlldygpLCB0aGlzLCBsb2Nh dGlvbk9mZnNldCgpLCBzdHlsZSgpLT5pc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpKTsKICAg ICBmb3IgKFJlbmRlck9iamVjdCogY2hpbGQgPSBjaGlsZHJlbigpLT5maXJzdENoaWxkKCk7IGNo aWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKSB7CiAgICAgICAgIGlmIChjaGlsZC0+ aXNUYWJsZVJvdygpKSB7Cg==