<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>86560</bug_id>
          
          <creation_ts>2012-05-15 20:17:38 -0700</creation_ts>
          <short_desc>StylePropertySet::StylePropertySet() wastes vector capacity</short_desc>
          <delta_ts>2012-10-04 06:15:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>86281</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Fraser (smfr)">simon.fraser</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>kling</cc>
    
    <cc>koivisto</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>624907</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2012-05-15 20:17:38 -0700</bug_when>
    <thetext>This shows up high on the wasted vector capacity logging:

7287 vectors, 585.92KB used of 740.78KB, 154.86KB wasted at:
1   0x1096bbc48 WebCore::StylePropertySet::StylePropertySet(WebCore::CSSProperty const*, int, WebCore::CSSParserMode)
2   0x108da1c5f WebCore::CSSParser::createStyleRule(WTF::Vector&lt;WTF::OwnPtr&lt;WebCore::CSSParserSelector&gt;, 0ul&gt;*)
3   0x108d7748a cssyyparse(void*)
4   0x108d83a7f WebCore::CSSParser::parseSheet(WebCore::StyleSheetInternal*, WTF::String const&amp;, int, WTF::HashMap&lt;WebCore::StyleRule*, WTF::RefPtr&lt;WebCore::CSSRuleSourceData&gt;, WTF::PtrHash&lt;WebCore::StyleRule*&gt;, WTF::HashTraits&lt;WebCore::StyleRule*&gt;, WTF::HashTraits&lt;WTF::RefPtr&lt;WebCore::CSSRuleSourceData&gt; &gt; &gt;*)
5   0x108dbbe43 WebCore::StyleSheetInternal::parseAuthorStyleSheet(WebCore::CachedCSSStyleSheet const*, WebCore::SecurityOrigin const*)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>624908</commentid>
    <comment_count>1</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2012-05-15 20:18:08 -0700</bug_when>
    <thetext>Also being created via:

2531 vectors, 40.50KB used of 158.66KB, 118.16KB wasted at:
1   0x1096bbb80 WebCore::StylePropertySet::StylePropertySet(WebCore::CSSParserMode)
2   0x108f2304b WebCore::ElementAttributeData::updateInlineStyleAvoidingMutation(WebCore::StyledElement*, WTF::String const&amp;)
3   0x1096b6d52 WebCore::StyledElement::parseAttribute(WebCore::Attribute const&amp;)
4   0x109000cdf WebCore::HTMLElement::parseAttribute(WebCore::Attribute const&amp;)
5   0x1096b6b8c WebCore::StyledElement::attributeChanged(WebCore::Attribute const&amp;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>734635</commentid>
    <comment_count>2</comment_count>
    <who name="Andreas Kling">kling</who>
    <bug_when>2012-10-04 06:15:23 -0700</bug_when>
    <thetext>This was fixed by making StylePropertySet a variable-sized object in &lt;http://trac.webkit.org/changeset/118809&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>