86539 2012-05-15 15:46:36 -0700 [chromium] Contents flash when switching tabs when composting, due to drawing when content texture manager limit is 0. 2012-07-27 01:11:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 85108 P2 Normal --- 1 mmocny mmocny cc-bugs danakj jamesr nduca webkit.review.bot oldest_to_newest 624671 0 mmocny 2012-05-15 15:46:36 -0700 [chromium] Contents flash when switching tabs when composting, due to drawing when content texture manager limit is 0. 624675 1 142085 mmocny 2012-05-15 15:49:47 -0700 Created attachment 142085 Patch 624684 2 mmocny 2012-05-15 15:54:49 -0700 Notes on the approach here: 1. We would prefer not to manually increase memory when a tab is foregrounded to get around the issue of drawing white frames, but this is a temporary solution until that larger problem is solved. Specifically, this is also happening without threaded compositor and it is unclear if https://bugs.webkit.org/show_bug.cgi?id=85108 fixes that, or if it will land soon. 2. Regarding early exit in setContentsMemoryAllocationLimitBytes, @danakj suggested we add a tag to the memory allocation struct saying "expected visibility". Then, we can early exit whenever the current state is != expected state, without specifically testing for bytes == 0. 624693 3 danakj 2012-05-15 16:00:44 -0700 (In reply to comment #2) > Notes on the approach here: > > 1. We would prefer not to manually increase memory when a tab is foregrounded to get around the issue of drawing white frames, but this is a temporary solution until that larger problem is solved. Specifically, this is also happening without threaded compositor and it is unclear if https://bugs.webkit.org/show_bug.cgi?id=85108 fixes that, or if it will land soon. I *think* if we also make CCSingleThreadProxy skip drawing frames where prepareToDraw() fails, then bug #85108 would fix this problem. That could be done as a simple followup to 85108, or along with it. 625007 4 nduca 2012-05-15 22:56:03 -0700 agreed with dana 630374 5 mmocny 2012-05-22 08:08:18 -0700 *** This bug has been marked as a duplicate of bug 85108 *** 680250 6 142085 abarth 2012-07-27 01:11:05 -0700 Comment on attachment 142085 Patch Cleared review? from attachment 142085 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 142085 2012-05-15 15:49:47 -0700 2012-07-27 01:11:05 -0700 Patch bug-86539-20120515184946.patch text/plain 2985 mmocny U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjViYTY3YTlmNTk5MDlk ZTRmMmYyYTJlNjM0NmE5YjQ2MTRiYTBlZC4uZTM5NjMyM2EyMzBiMTBkMTZmMWUyOGFlNjk4ZTUz ODE5NGI1Mjg3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTE1ICBNaWNo YWwgTW9jbnkgIDxtbW9jbnlAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIENvbnRl bnRzIGZsYXNoIHdoZW4gc3dpdGNoaW5nIHRhYnMgd2hlbiBjb21wb3N0aW5nLCBkdWUgdG8gZHJh d2luZyB3aGVuIGNvbnRlbnQgdGV4dHVyZSBtYW5hZ2VyIGxpbWl0IGlzIDAuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjUzOQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hbnVhbGx5IHJlc2V0dGluZyB0 aGUgbWVtb3J5IGFsbG9jYXRpb24gdmFsdWUgb2YgdGhlIGNvbnRlbnQgdGV4dHVyZSBtYW5hZ2Vy IHdoZW4gYSB0YWIgcmV0dXJucyB0byBmb3JlZ3JvdW5kLgorICAgICAgICBUaGUgR3B1TWVtb3J5 TWFuYWdlciB3aWxsIHNlbmQgYSBuZXcgbm9uLXplcm8gYWxsb2NhdGlvbiwgYnV0IGl0IHdpbGwg YXJyaXZlIGFmdGVyIHRoZSBmaXJzdCBmcmFtZSBpcyBkcmF3bi4KKyAgICAgICAgV2UgY2FuIHJl bW92ZSB0aGlzIG1hbnVhbCBpbmNyZWFzZSBvbmNlIHdlIGRvIG5vdCBkcmF3IGVtcHR5IGZyYW1l cy4KKworICAgICAgICBUaGlzIHBhdGNoIGFsc28gcHJldmVudHMgYW4gaXNzdWUgd2l0aCBzdGFs ZSBtZW1vcnkgYWxsb2NhdGlvbnMgYmVpbmcgYWNjZXB0ZWQuICBTcGVjaWZpY2FsbHksIHdoZW4g YSB0YWIKKyAgICAgICAgcmV0dXJucyB0byBmb3JlZ3JvdW5kIGJ1dCByZWNlaXZlcyBhbiBhbGxv Y2F0aW9uIHRvIHplcm8sIGl0IHNob3VsZCBpZ25vcmUgaXQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q0NMYXllclRyZWVIb3N0OjpzZXRWaXNpYmxlKToKKyAgICAgICAgKFdlYkNvcmU6OkND TGF5ZXJUcmVlSG9zdDo6c2V0Q29udGVudHNNZW1vcnlBbGxvY2F0aW9uTGltaXRCeXRlcyk6CisK IDIwMTItMDUtMTUgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogcmVtb3ZlIHVubmVjZXNzYXJ5IHNldFRpbWVvdXQgaW4gSGVh cFNuYXBzaG90R3JpZE5vZGVzLmpzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NMYXllclRyZWVIb3N0LmNwcAppbmRl eCA5ZTU3NmFjMzc5NmI2OGE0MzI4NzkzNWI1MzI2NzE1M2E0Y2E4MjY5Li4zYjUyMWViN2IxNWRi MTUzZTQwZDFmMTY1OWIxYjEyNjU5YjZkOTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0xheWVyVHJlZUhvc3QuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDTGF5ZXJUcmVlSG9z dC5jcHAKQEAgLTM3OSw2ICszNzksMTQgQEAgdm9pZCBDQ0xheWVyVHJlZUhvc3Q6OnNldFZpc2li bGUoYm9vbCB2aXNpYmxlKQogCiAgICAgbV92aXNpYmxlID0gdmlzaWJsZTsKIAorICAgIC8vIEZJ WE1FOiBGaXhlcyBjcmJ1Zy5jb20vMTI4MDU4OiB3aGl0ZSBmbGFzaGVzIHdoZW4gc3dpdGNoaW5n IHRhYnMuCisgICAgLy8gV2Ugd291bGQgcHJlZmVyIHRvIG5vdCBtYW51YWxseSBhZGp1c3QgbWVt b3J5IGxpbWl0IGhlcmUsIGFuZCB3b3VsZAorICAgIC8vIHJhdGhlciBwcmV2ZW50IHRoZSBjb21w b3NpdG9yIGZyb20gZHJhd2luZyB3aGl0ZS4KKyAgICBpZiAodmlzaWJsZSAmJiBtX2NvbnRlbnRz VGV4dHVyZU1hbmFnZXIKKyAgICAgICAgJiYgIW1fY29udGVudHNUZXh0dXJlTWFuYWdlci0+bWF4 TWVtb3J5TGltaXRCeXRlcygpKSB7CisgICAgICBtX2NvbnRlbnRzVGV4dHVyZU1hbmFnZXItPnNl dE1lbW9yeUFsbG9jYXRpb25MaW1pdEJ5dGVzKFRleHR1cmVNYW5hZ2VyOjpoaWdoTGltaXRCeXRl cyh2aWV3cG9ydFNpemUoKSkpOworICAgIH0KKwogICAgIC8vIFRlbGxzIHRoZSBwcm94eSB0aGF0 IHZpc2liaWxpdHkgc3RhdGUgaGFzIGNoYW5nZWQuIFRoaXMgd2lsbCBpbiB0dXJuIGNhbGwKICAg ICAvLyBDQ0xheWVyVHJlZUhvc3Q6OmRpZEJlY29tZUludmlzaWJsZU9uSW1wbFRocmVhZCBvbiB0 aGUgYXBwcm9wcmlhdGUgdGhyZWFkLCBmb3IKICAgICAvLyB0aGUgY2FzZSB3aGVyZSAhdmlzaWJs ZS4KQEAgLTQxOSw2ICs0MjcsMTIgQEAgdm9pZCBDQ0xheWVyVHJlZUhvc3Q6OnNldENvbnRlbnRz TWVtb3J5QWxsb2NhdGlvbkxpbWl0Qnl0ZXMoc2l6ZV90IGJ5dGVzKQogICAgIGlmICghbV9sYXll clJlbmRlcmVySW5pdGlhbGl6ZWQpCiAgICAgICAgIHJldHVybjsKIAorICAgIC8vIEZJWE1FOiBX ZSBzaG91bGQgb25seSBnZXQgYSAwIGFsbG9jYXRpb24gd2hlbiBub3QgdmlzaWJsZSwgYnV0IGJl Y2F1c2Ugb2YKKyAgICAvLyByYWNlcyBkdXJpbmcgdGFiIHN3aXRjaCB3ZSBtYXkgZ2V0IGEgc3Rh bGUgcmVxdWVzdC4gRWFybHkgZXhpdCBoZXJlCisgICAgLy8gaW4gdGhhdCBjYXNlLgorICAgIGlm IChtX3Zpc2libGUgJiYgIWJ5dGVzKQorICAgICAgcmV0dXJuOworCiAgICAgbV9jb250ZW50c1Rl eHR1cmVNYW5hZ2VyLT5zZXRNZW1vcnlBbGxvY2F0aW9uTGltaXRCeXRlcyhieXRlcyk7CiAgICAg c2V0TmVlZHNDb21taXQoKTsKIH0K