86538 2012-05-15 15:35:53 -0700 CopiedSpace::doneCopying could start another collection 2012-05-29 11:38:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg dongseong.hwang ggaren oliver webkit.review.bot oldest_to_newest 624662 0 mhahnenberg 2012-05-15 15:35:53 -0700 It's possible that if we don't have anything at the head of to-space after a collection and the BlockAllocator doesn't have any fresh blocks to give us right now we could start another collection while still in the middle of the first collection when we call CopiedSpace::addNewBlock(). One way to resolve this would be to have Heap::shouldCollect() check that m_operationInProgress is NoOperation. This would prevent the path in getFreshBlock() that starts the collection if we're already in the middle of one. 624667 1 142084 mhahnenberg 2012-05-15 15:42:41 -0700 Created attachment 142084 Patch 624674 2 mhahnenberg 2012-05-15 15:49:16 -0700 <rdar://problem/11459513> 636214 3 mhahnenberg 2012-05-29 10:41:19 -0700 *** Bug 87723 has been marked as a duplicate of this bug. *** 636222 4 142084 ggaren 2012-05-29 10:46:48 -0700 Comment on attachment 142084 Patch r=me 636272 5 142084 webkit.review.bot 2012-05-29 11:38:33 -0700 Comment on attachment 142084 Patch Clearing flags on attachment: 142084 Committed r118810: <http://trac.webkit.org/changeset/118810> 636273 6 webkit.review.bot 2012-05-29 11:38:37 -0700 All reviewed patches have been landed. Closing bug. 142084 2012-05-15 15:42:41 -0700 2012-05-29 11:38:33 -0700 Patch bug-86538-20120515154239.patch text/plain 2179 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE3MTcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDEyLTA1LTE1ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgQ29waWVkU3BhY2U6OmRvbmVDb3B5aW5nIGNvdWxkIHN0YXJ0IGFub3RoZXIgY29s bGVjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODY1MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ dCdzIHBvc3NpYmxlIHRoYXQgaWYgd2UgZG9uJ3QgaGF2ZSBhbnl0aGluZyBhdCB0aGUgaGVhZCBv ZiB0by1zcGFjZSAKKyAgICAgICAgYWZ0ZXIgYSBjb2xsZWN0aW9uIGFuZCB0aGUgQmxvY2tBbGxv Y2F0b3IgZG9lc24ndCBoYXZlIGFueSBmcmVzaCBibG9ja3MgCisgICAgICAgIHRvIGdpdmUgdXMg cmlnaHQgbm93IHdlIGNvdWxkIHN0YXJ0IGFub3RoZXIgY29sbGVjdGlvbiB3aGlsZSBzdGlsbCBp biAKKyAgICAgICAgdGhlIG1pZGRsZSBvZiB0aGUgZmlyc3QgY29sbGVjdGlvbiB3aGVuIHdlIGNh bGwgQ29waWVkU3BhY2U6OmFkZE5ld0Jsb2NrKCkuIAorCisgICAgICAgIE9uZSB3YXkgdG8gcmVz b2x2ZSB0aGlzIHdvdWxkIGJlIHRvIGhhdmUgSGVhcDo6c2hvdWxkQ29sbGVjdCgpIGNoZWNrIHRo YXQgCisgICAgICAgIG1fb3BlcmF0aW9uSW5Qcm9ncmVzcyBpcyBOb09wZXJhdGlvbi4gVGhpcyB3 b3VsZCBwcmV2ZW50IHRoZSBwYXRoIGluIAorICAgICAgICBnZXRGcmVzaEJsb2NrKCkgdGhhdCBz dGFydHMgdGhlIGNvbGxlY3Rpb24gaWYgd2UncmUgYWxyZWFkeSBpbiB0aGUgbWlkZGxlIG9mIG9u ZS4KKworICAgICAgICBJIGNvdWxkIG5vdCBjb21lIHVwIHdpdGggYSB0ZXN0IGNhc2UgdG8gcmVw cm9kdWNlIHRoaXMgY3Jhc2ggb24gVG9ULgorCisgICAgICAgICogaGVhcC9IZWFwLmg6CisgICAg ICAgIChKU0M6OkhlYXA6OnNob3VsZENvbGxlY3QpOiBXZSBzaG91bGRuJ3QgY29sbGVjdCBpZiB3 ZSdyZSBhbHJlYWR5IGluIHRoZSBtaWRkbGUKKyAgICAgICAgb2YgYSBjb2xsZWN0aW9uLCBpLmUu IHRoZSBjdXJyZW50IG9wZXJhdGlvbiBzaG91bGQgYmUgTm9PcGVyYXRpb24uCisKIDIwMTItMDUt MTQgIEx1a2UgTWFjcGhlcnNvbiAgPG1hY3BoZXJzb25AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IEludHJvZHVjZSBFTkFCTEVfQ1NTX1ZBUklBQkxFUyBjb21waWxlIGZsYWcuCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvSGVhcC5oCShyZXZpc2lvbiAxMTY5OTEpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaGVhcC9IZWFwLmgJKHdvcmtpbmcgY29weSkKQEAgLTI1Myw5ICsyNTMsOSBAQCBu YW1lc3BhY2UgSlNDIHsKICAgICBpbmxpbmUgYm9vbCBIZWFwOjpzaG91bGRDb2xsZWN0KCkKICAg ICB7CiAjaWYgRU5BQkxFKEdHQykKLSAgICAgICAgcmV0dXJuIG1fb2JqZWN0U3BhY2UubnVyc2Vy eVdhdGVyTWFyaygpID49IG1fbWluQnl0ZXNQZXJDeWNsZSAmJiBtX2lzU2FmZVRvQ29sbGVjdDsK KyAgICAgICAgcmV0dXJuIG1fb2JqZWN0U3BhY2UubnVyc2VyeVdhdGVyTWFyaygpID49IG1fbWlu Qnl0ZXNQZXJDeWNsZSAmJiBtX2lzU2FmZVRvQ29sbGVjdCAmJiBtX29wZXJhdGlvbkluUHJvZ3Jl c3MgPT0gTm9PcGVyYXRpb247CiAjZWxzZQotICAgICAgICByZXR1cm4gbV9ieXRlc0FsbG9jYXRl ZCA+IG1fYnl0ZXNBbGxvY2F0ZWRMaW1pdCAmJiBtX2lzU2FmZVRvQ29sbGVjdDsKKyAgICAgICAg cmV0dXJuIG1fYnl0ZXNBbGxvY2F0ZWQgPiBtX2J5dGVzQWxsb2NhdGVkTGltaXQgJiYgbV9pc1Nh ZmVUb0NvbGxlY3QgJiYgbV9vcGVyYXRpb25JblByb2dyZXNzID09IE5vT3BlcmF0aW9uOwogI2Vu ZGlmCiAgICAgfQogCg==