86535 2012-05-15 15:06:26 -0700 [Chromium] Reset ScriptInstance in HTMLPlugInElement on WebPluginContainerImpl::setPlugin 2012-05-15 18:59:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fsamuel fsamuel fishd webkit.review.bot oldest_to_newest 624627 0 fsamuel 2012-05-15 15:06:26 -0700 [Chromium] Reset ScriptInstance in HTMLPlugInElement on WebPluginContainerImpl::setPlugin 624632 1 142071 fsamuel 2012-05-15 15:09:11 -0700 Created attachment 142071 Patch 624645 2 fsamuel 2012-05-15 15:18:43 -0700 We would like to be able to postMessage to the browser plugin. However, as we do cross-process navigation, we swap out WebPluginImpls and a stale, invalid ScriptInstance object continues being used in HTMLPlugInElement and so the postMessages never arrive after cross-process navigation. This patch fixes this issue. 624850 3 142071 webkit.review.bot 2012-05-15 18:59:17 -0700 Comment on attachment 142071 Patch Clearing flags on attachment: 142071 Committed r117203: <http://trac.webkit.org/changeset/117203> 624851 4 webkit.review.bot 2012-05-15 18:59:21 -0700 All reviewed patches have been landed. Closing bug. 142071 2012-05-15 15:09:11 -0700 2012-05-15 18:59:17 -0700 Patch bug-86535-20120515180910.patch text/plain 4347 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2OTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2NmMDQxOTE1ZTQwOGZj ZDcwOWUzOTBiOGNlMWM3N2UyZWRlMTk4Ni4uMDQ1ODRkMjMzMjZiN2QyOTZmY2JjYTI2NTgzMjRh ZTlhZmZmNGVjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA1LTE1ICBGYWR5 IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gUmVz ZXQgU2NyaXB0SW5zdGFuY2UgaW4gSFRNTFBsdWdJbkVsZW1lbnQgb24gV2ViUGx1Z2luQ29udGFp bmVySW1wbDo6c2V0UGx1Z2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NjUzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor ICAgICAgICAKKyAgICAgICAgV2hlbiB3ZSBzd2FwIG91dCBXZWJQbHVnaW5JbXBscyBmb3IgdGhl IEJyb3dzZXIgUGx1Z2luLCB0aGUgSFRNTFBsdWdJbkVsZW1lbnQgY29udGludWVzCisgICAgICAg IHRvIHVzZSBhIG5vdyBpbnZhbGlkIFNjcmlwdEluc3RhbmNlLCBzbyB3ZSByZXNldCB0aGUgU2Ny aXB0SW5zdGFuY2Ugb24gV2ViUGx1Z2luQ29udGFpbmVySW1wbDo6c2V0UGx1Z2luCisKKyAgICAg ICAgKiBodG1sL0hUTUxQbHVnSW5FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxQ bHVnSW5FbGVtZW50OjpyZXNldEluc3RhbmNlKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAg ICAqIGh0bWwvSFRNTFBsdWdJbkVsZW1lbnQuaDoKKyAgICAgICAgKEhUTUxQbHVnSW5FbGVtZW50 KToKKwogMjAxMi0wNS0xNCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbUXRdIFJFR1JFU1NJT04gKHIxMTY3ODkpOiBpbnNwZWN0b3IvZGVidWdnZXIv c2NyaXB0LWZvcm1hdHRlci1jb25zb2xlLmh0bWwgZmFpbHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cKaW5kZXggZjhhNTBiYzUwMzM2OWRjYjM4OWY5Yzg5N2YxYWJmZWIzYzgwODFiYi4uZGU5NWFm YjhhOTM1OWViY2QyMDBkN2M4MGY3MTlhYmRhZWRlYmZiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNS0xNSAgRmFkeSBTYW11ZWwgIDxmc2FtdWVs QGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFJlc2V0IFNjcmlwdEluc3RhbmNl IGluIEhUTUxQbHVnSW5FbGVtZW50IG9uIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OnNldFBsdWdp bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY1MzUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHNyYy9X ZWJQbHVnaW5Db250YWluZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGx1Z2luQ29u dGFpbmVySW1wbDo6c2V0UGx1Z2luKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICogc3Jj L1dlYlBsdWdpbkNvbnRhaW5lckltcGwuaDoKKyAgICAgICAgKFdlYlBsdWdpbkNvbnRhaW5lcklt cGwpOgorCiAyMDEyLTA1LTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWls LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTE2ODEyLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luRWxlbWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxQbHVnSW5FbGVtZW50LmNwcAppbmRleCBhNmMyNDUyMmNjNjkyZGRj N2Q4ZWFlZDQ1MWY2NGRjMjRhMmIzNzc4Li42ZGZhZTYyZTA2NmUzYmE4MDU5YmM5YjhiZDVmNzYy ZGVkNDNmZTU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5FbGVt ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5FbGVtZW50LmNwcApA QCAtODgsNiArODgsMTEgQEAgdm9pZCBIVE1MUGx1Z0luRWxlbWVudDo6ZGV0YWNoKCkKICAgICBI VE1MRnJhbWVPd25lckVsZW1lbnQ6OmRldGFjaCgpOwogfQogCit2b2lkIEhUTUxQbHVnSW5FbGVt ZW50OjpyZXNldEluc3RhbmNlKCkKK3sKKyAgICBtX2luc3RhbmNlLmNsZWFyKCk7Cit9CisKIFBh c3NTY3JpcHRJbnN0YW5jZSBIVE1MUGx1Z0luRWxlbWVudDo6Z2V0SW5zdGFuY2UoKQogewogICAg IEZyYW1lKiBmcmFtZSA9IGRvY3VtZW50KCktPmZyYW1lKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxQbHVnSW5FbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxQbHVnSW5FbGVtZW50LmgKaW5kZXggNjVmODY5YmRiNTBlNTJjMWQzNzNiZGVjZDhjMTk1ODBi OGNkYWFiMC4uNWY1YzM3Mjk3NmI3MDBjOGE1OTdjOGQ0YzkzY2QzNTcxOWY0OWRhMCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1Z0luRWxlbWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkVsZW1lbnQuaApAQCAtNDAsNiArNDAsOCBAQCBjbGFz cyBIVE1MUGx1Z0luRWxlbWVudCA6IHB1YmxpYyBIVE1MRnJhbWVPd25lckVsZW1lbnQgewogcHVi bGljOgogICAgIHZpcnR1YWwgfkhUTUxQbHVnSW5FbGVtZW50KCk7CiAKKyAgICB2b2lkIHJlc2V0 SW5zdGFuY2UoKTsKKwogICAgIFBhc3NTY3JpcHRJbnN0YW5jZSBnZXRJbnN0YW5jZSgpOwogCiAg ICAgV2lkZ2V0KiBwbHVnaW5XaWRnZXQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYlBsdWdpbkNvbnRhaW5lckltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5jcHAKaW5kZXggNmVlMDFlZmRkOGUzNWVm YWE5M2E2MDJiMzk3ZjJlZWI1OWVjZmYwZC4uMjk2MzA2MjBiMjk3YzU3OWY1YWE4ZjQ3MGYxNzM1 ZTMzZWZmYmQwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUGx1 Z2luQ29udGFpbmVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi UGx1Z2luQ29udGFpbmVySW1wbC5jcHAKQEAgLTIzMyw2ICsyMzMsMTQgQEAgdm9pZCBXZWJQbHVn aW5Db250YWluZXJJbXBsOjpzZXRQYXJlbnQoU2Nyb2xsVmlldyogdmlldykKICAgICAgICAgcmVw b3J0R2VvbWV0cnkoKTsKIH0KIAordm9pZCBXZWJQbHVnaW5Db250YWluZXJJbXBsOjpzZXRQbHVn aW4oV2ViUGx1Z2luKiBwbHVnaW4pCit7CisgICAgaWYgKHBsdWdpbiAhPSBtX3dlYlBsdWdpbikg eworICAgICAgICBtX2VsZW1lbnQtPnJlc2V0SW5zdGFuY2UoKTsKKyAgICAgICAgbV93ZWJQbHVn aW4gPSBwbHVnaW47CisgICAgfQorfQorCiBib29sIFdlYlBsdWdpbkNvbnRhaW5lckltcGw6OnN1 cHBvcnRzUGFnaW5hdGVkUHJpbnQoKSBjb25zdAogewogICAgIHJldHVybiBtX3dlYlBsdWdpbi0+ c3VwcG9ydHNQYWdpbmF0ZWRQcmludCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViUGx1Z2luQ29udGFpbmVySW1wbC5oCmluZGV4IDA0ODc4NDU1YzhjYjY1ZTUzZGRm YTdkMGY0ZmNiZDc3NDlhYzcxNzcuLjRjMThhZGEwN2ExMjQwM2NjZjE2MjlmNWI4MzM5OWIyYWVm NzhmNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlBsdWdpbkNv bnRhaW5lckltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQbHVnaW5D b250YWluZXJJbXBsLmgKQEAgLTExMCw3ICsxMTAsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBUaGlz IGNhbm5vdCBiZSBudWxsLgogICAgIFdlYlBsdWdpbiogcGx1Z2luKCkgeyByZXR1cm4gbV93ZWJQ bHVnaW47IH0KLSAgICB2b2lkIHNldFBsdWdpbihXZWJQbHVnaW4qIHBsdWdpbikgeyBtX3dlYlBs dWdpbiA9IHBsdWdpbjsgfQorICAgIHZvaWQgc2V0UGx1Z2luKFdlYlBsdWdpbiopOwogCiAgICAg Ly8gUHJpbnRpbmcgaW50ZXJmYWNlLiBUaGUgcGx1Z2luIGNhbiBzdXBwb3J0IGN1c3RvbSBwcmlu dGluZwogICAgIC8vICh3aGljaCBtZWFucyBpdCBjb250cm9scyB0aGUgbGF5b3V0LCBudW1iZXIg b2YgcGFnZXMgZXRjKS4K