86505 2012-05-15 11:57:28 -0700 [WK2] Crash when dropping a reference to a non-existing file 2012-05-15 12:52:28 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 ap ap enrica oldest_to_newest 624356 0 ap 2012-05-15 11:57:28 -0700 Drag data can contain non-existing file paths (an application you're dragging form has full control of that). We should not crash. <rdar://problem/11402084> 624360 1 142020 ap 2012-05-15 12:01:09 -0700 Created attachment 142020 proposed fix 624363 2 142020 darin 2012-05-15 12:04:07 -0700 Comment on attachment 142020 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=142020&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2191 > + RefPtr<SandboxExtension> extension = SandboxExtension::create(sandboxExtensionsHandleArray[i]); > + if (extension) > + m_pendingDropExtensionsForFileUpload.append(extension); I would have put the definition inside the if statement. 624423 3 ap 2012-05-15 12:52:28 -0700 Committed <http://trac.webkit.org/changeset/117124>. 142020 2012-05-15 12:01:09 -0700 2012-05-15 12:04:07 -0700 proposed fix NullExtension.txt text/plain 1851 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzEwOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTE1ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIENyYXNoIHdoZW4g ZHJvcHBpbmcgYSByZWZlcmVuY2UgdG8gYSBub24tZXhpc3RpbmcgZmlsZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY1MDUKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzExNDAyMDg0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwOiAoV2ViS2l0OjpX ZWJQYWdlOjpwZXJmb3JtRHJhZ0NvbnRyb2xsZXJBY3Rpb24pOiBDaGVjayB0aGF0CisgICAgICAg IGV4dGVuc2lvbiBoYW5kbGUgYWN0dWFsbHkgaGFzIGEgbm9uLW51bGwgZXh0ZW5zaW9uLiBFeHRl bnNpb25zIGZvciBub24tZXhpc3RlbnQgZmlsZXMgY2FuIG5vdAorICAgICAgICBleGlzdCwgc28g dGhleSBhcmUgcGFzc2VkIGFzIG51bGwgb25lcy4KKwogMjAxMi0wNS0xNSAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRGVlcCBjb3B5IFBsdWdpbk1vZHVsZUlu Zm8gYmVmb3JlIHBhc3NpbmcgYWNyb3NzIHRocmVhZCBib3VuZGFyeS4KSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHJldmlzaW9uIDExNDU1 MSkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjE4NSw4ICsyMTg1LDExIEBAIHZvaWQgV2ViUGFnZTo6cGVyZm9ybURy YWdDb250cm9sbGVyQWN0aW8KICAgICAgICAgQVNTRVJUKCFtX3BlbmRpbmdEcm9wU2FuZGJveEV4 dGVuc2lvbik7CiAKICAgICAgICAgbV9wZW5kaW5nRHJvcFNhbmRib3hFeHRlbnNpb24gPSBTYW5k Ym94RXh0ZW5zaW9uOjpjcmVhdGUoc2FuZGJveEV4dGVuc2lvbkhhbmRsZSk7Ci0gICAgICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgc2FuZGJveEV4dGVuc2lvbnNIYW5kbGVBcnJheS5zaXplKCk7 IGkrKykKLSAgICAgICAgICAgIG1fcGVuZGluZ0Ryb3BFeHRlbnNpb25zRm9yRmlsZVVwbG9hZC5h cHBlbmQoU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlKHNhbmRib3hFeHRlbnNpb25zSGFuZGxlQXJy YXlbaV0pKTsKKyAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzYW5kYm94RXh0ZW5zaW9u c0hhbmRsZUFycmF5LnNpemUoKTsgaSsrKSB7CisgICAgICAgICAgICBSZWZQdHI8U2FuZGJveEV4 dGVuc2lvbj4gZXh0ZW5zaW9uID0gU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlKHNhbmRib3hFeHRl bnNpb25zSGFuZGxlQXJyYXlbaV0pOworICAgICAgICAgICAgaWYgKGV4dGVuc2lvbikKKyAgICAg ICAgICAgICAgICBtX3BlbmRpbmdEcm9wRXh0ZW5zaW9uc0ZvckZpbGVVcGxvYWQuYXBwZW5kKGV4 dGVuc2lvbik7CisgICAgICAgIH0KIAogICAgICAgICBtX3BhZ2UtPmRyYWdDb250cm9sbGVyKCkt PnBlcmZvcm1EcmFnKCZkcmFnRGF0YSk7CiAK