<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>86502</bug_id>
          
          <creation_ts>2012-05-15 11:01:09 -0700</creation_ts>
          <short_desc>[BlackBerry] InputHandler missing an include</short_desc>
          <delta_ts>2012-05-16 08:26:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit BlackBerry</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter>gmak</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>624272</commentid>
    <comment_count>0</comment_count>
    <who name="">gmak</who>
    <bug_when>2012-05-15 11:01:09 -0700</bug_when>
    <thetext>Missing an include which causes build errors when other changes are made.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>624293</commentid>
    <comment_count>1</comment_count>
      <attachid>142011</attachid>
    <who name="">gmak</who>
    <bug_when>2012-05-15 11:18:13 -0700</bug_when>
    <thetext>Created attachment 142011
patch with commit log</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>624443</commentid>
    <comment_count>2</comment_count>
      <attachid>142011</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2012-05-15 13:05:15 -0700</bug_when>
    <thetext>Comment on attachment 142011
patch with commit log

OK</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>624580</commentid>
    <comment_count>3</comment_count>
      <attachid>142011</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-15 14:34:33 -0700</bug_when>
    <thetext>Comment on attachment 142011
patch with commit log

Rejecting attachment 142011 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 1

Liam Quinn found in /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/blackberry/ChangeLog neither lists a valid reviewer nor contains the string &quot;Unreviewed&quot; or &quot;Rubber stamp&quot; (case insensitive).

Full output: http://queues.webkit.org/results/12685919</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>624921</commentid>
    <comment_count>4</comment_count>
      <attachid>142011</attachid>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2012-05-15 20:42:07 -0700</bug_when>
    <thetext>Comment on attachment 142011
patch with commit log

View in context: https://bugs.webkit.org/attachment.cgi?id=142011&amp;action=review

&gt; Source/WebKit/blackberry/ChangeLog:5
&gt; +        Reviewed Internally by Liam Quinn.

move this line down below to &quot;Reviewed by&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625423</commentid>
    <comment_count>5</comment_count>
      <attachid>142260</attachid>
    <who name="">gmak</who>
    <bug_when>2012-05-16 07:40:59 -0700</bug_when>
    <thetext>Created attachment 142260
Patch - moved line

Moved reviewedBy line</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625436</commentid>
    <comment_count>6</comment_count>
      <attachid>142260</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-05-16 07:55:40 -0700</bug_when>
    <thetext>Comment on attachment 142260
Patch - moved line

View in context: https://bugs.webkit.org/attachment.cgi?id=142260&amp;action=review

Ok.

&gt; Source/WebKit/blackberry/ChangeLog:6
&gt; +        Reviewed by NOBODY (OOPS!).

Normally you have an empty line after Reviewed by.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625461</commentid>
    <comment_count>7</comment_count>
      <attachid>142260</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-16 08:26:24 -0700</bug_when>
    <thetext>Comment on attachment 142260
Patch - moved line

Clearing flags on attachment: 142260

Committed r117292: &lt;http://trac.webkit.org/changeset/117292&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625462</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-05-16 08:26:28 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>142011</attachid>
            <date>2012-05-15 11:18:13 -0700</date>
            <delta_ts>2012-05-16 07:40:59 -0700</delta_ts>
            <desc>patch with commit log</desc>
            <filename>0001-2012-05-15-Genevieve-Mak-gmak-rim.com.patch</filename>
            <type>text/plain</type>
            <size>1806</size>
            <attacher>gmak</attacher>
            
              <data encoding="base64">RnJvbSBjYTAzMTBlMDIzZmM5MjczNjdkZDUxMDA1MzE4ZjEwYjNkOWJiYzIzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHZW5ldmlldmUgTWFrIDxnbWFrQHJpbS5jb20+CkRhdGU6IFR1
ZSwgMTUgTWF5IDIwMTIgMTQ6MTE6NTAgLTA0MDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA1LTE1
ICBHZW5ldmlldmUgTWFrICA8Z21ha0ByaW0uY29tPgoKICAgICAgICBBZGQgbWlzc2luZyBpbmNs
dWRlIHRoYXQgd2FzIGNhdXNpbmcgYnVpbGQgZXJyb3JzLgogICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjUwMgogICAgICAgIFJldmlld2VkIEludGVybmFs
bHkgYnkgTGlhbSBRdWlubgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAg
ICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6Ci0tLQogU291cmNlL1dlYktp
dC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysK
IC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcCAgICAgIHwgICAg
MSArCiAyIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9X
ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggYTYyZTE5Ni4uOTgxZDNhNCAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi
S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDUtMTUgIEdl
bmV2aWV2ZSBNYWsgIDxnbWFrQHJpbS5jb20+CisKKyAgICAgICAgQWRkIG1pc3NpbmcgaW5jbHVk
ZSB0aGF0IHdhcyBjYXVzaW5nIGJ1aWxkIGVycm9ycy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NTAyCisgICAgICAgIFJldmlld2VkIEludGVybmFs
bHkgYnkgTGlhbSBRdWlubi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKwogMjAxMi0wNS0x
NCAgSmFja3kgSmlhbmcgIDx6aGFqaWFuZ0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5
XSBBU1NFUlQgZmFpbHVyZSBpbiBGcmFtZVZpZXc6OnBhaW50Q29udGVudHMgd2hlbiByZWZsZXNo
aW5nIHd3dy50aGVzdGFyLmNvbS9pcGhvbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxh
Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Js
YWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCmluZGV4IGEwNGQ3MDUuLjBi
NDEwOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0
L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1
cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtNTYsNiArNTYsNyBAQAogI2luY2x1ZGUgIldlYlNl
dHRpbmdzLmgiCiAKICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1LZXlib2FyZEV2ZW50Lmg+
CisjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtTG9nLmg+CiAjaW5jbHVkZSA8QmxhY2tCZXJy
eVBsYXRmb3JtTWlzYy5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVNldHRpbmdzLmg+
CiAjaW5jbHVkZSA8aW1mL2V2ZW50cy5oPgotLSAKMS43LjcuNAoK
</data>
<flag name="review"
          id="148244"
          type_id="1"
          status="+"
          setter="darin"
    />
    <flag name="commit-queue"
          id="148283"
          type_id="3"
          status="-"
          setter="webkit.review.bot"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>142260</attachid>
            <date>2012-05-16 07:40:59 -0700</date>
            <delta_ts>2012-05-16 08:26:23 -0700</delta_ts>
            <desc>Patch - moved line</desc>
            <filename>0002-2012-05-15-Genevieve-Mak-gmak-rim.com.patch</filename>
            <type>text/plain</type>
            <size>1810</size>
            <attacher>gmak</attacher>
            
              <data encoding="base64">RnJvbSBkMDVlY2RkYmQwNDEzOTIzZWI5ZGVmN2RjYTgzYWRhZTRjYzQwMzU3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBHZW5ldmlldmUgTWFrIDxnbWFrQHJpbS5jb20+CkRhdGU6IFR1
ZSwgMTUgTWF5IDIwMTIgMTQ6MTE6NTAgLTA0MDAKU3ViamVjdDogW1BBVENIIDIvMl0gMjAxMi0w
NS0xNSAgR2VuZXZpZXZlIE1hayAgPGdtYWtAcmltLmNvbT4KCiAgICAgICAgQWRkIG1pc3Npbmcg
aW5jbHVkZSB0aGF0IHdhcyBjYXVzaW5nIGJ1aWxkIGVycm9ycy4KICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY1MDIKCiAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCiAgICAgICAgUmV2aWV3ZWQgSW50ZXJuYWxseSBieSBMaWFtIFF1aW5u
CgogICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgotLS0KIFNvdXJjZS9X
ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAxMCArKysrKysr
KysrCiAuLi4vYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAgICAgICB8
ICAgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3Vy
Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IGE2MmUxOTYuLmZjYWNiMDggMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNl
L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA1LTE1
ICBHZW5ldmlldmUgTWFrICA8Z21ha0ByaW0uY29tPgorCisgICAgICAgIEFkZCBtaXNzaW5nIGlu
Y2x1ZGUgdGhhdCB3YXMgY2F1c2luZyBidWlsZCBlcnJvcnMuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjUwMgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorICAgICAgICBSZXZpZXdlZCBJbnRlcm5hbGx5IGJ5IExpYW0gUXVp
bm4uCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CisKIDIwMTIt
MDUtMTQgIEphY2t5IEppYW5nICA8emhhamlhbmdAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tC
ZXJyeV0gQVNTRVJUIGZhaWx1cmUgaW4gRnJhbWVWaWV3OjpwYWludENvbnRlbnRzIHdoZW4gcmVm
bGVzaGluZyB3d3cudGhlc3Rhci5jb20vaXBob25lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0
L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktp
dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCBhMDRkNzA1
Li4wYjQxMDllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw
cG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL
aXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTU2LDYgKzU2LDcgQEAKICNpbmNsdWRlICJX
ZWJTZXR0aW5ncy5oIgogCiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtS2V5Ym9hcmRFdmVu
dC5oPgorI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUxvZy5oPgogI2luY2x1ZGUgPEJsYWNr
QmVycnlQbGF0Zm9ybU1pc2MuaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1TZXR0aW5n
cy5oPgogI2luY2x1ZGUgPGltZi9ldmVudHMuaD4KLS0gCjEuNy43LjQKCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>