86499 2012-05-15 10:45:33 -0700 [Chromium] IndexedDB: Allow a default data directory to be specified for IDBFactory 2012-05-15 16:48:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 jsbell jsbell abarth alecflett dglazkov dgrogan fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 624258 0 jsbell 2012-05-15 10:45:33 -0700 [Chromium] IndexedDB: Allow a default data directory to be specified for IDBFactory 624346 1 142018 jsbell 2012-05-15 11:52:52 -0700 Created attachment 142018 Patch 624355 2 webkit.review.bot 2012-05-15 11:56:29 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 624357 3 jsbell 2012-05-15 11:59:16 -0700 The corresponding Chromium changes will live in src/webkit/support/test_webkit_platform_support.{h,cc} - TestWebKitPlatformSupport will have a ScopedTempDir and pass it through to WebIDBFactory::create in TestWebKitPlatformSupport::idbFactory 624378 4 jsbell 2012-05-15 12:15:42 -0700 Chromium side is: https://chromiumcodereview.appspot.com/10382180 624587 5 dgrogan 2012-05-15 14:38:08 -0700 LGTM 624723 6 jsbell 2012-05-15 16:36:13 -0700 Updated patches to https://chromiumcodereview.appspot.com/10382180 can do this w/o a WebKit API change, which is preferable. 624732 7 142018 jamesr 2012-05-15 16:48:52 -0700 Comment on attachment 142018 Patch Clearing review? flag to remove this from webkit.org/pending-review 142018 2012-05-15 11:52:52 -0700 2012-05-15 16:48:52 -0700 Patch bug-86499-20120515115250.patch text/plain 5051 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDVkYWFmOTY2NzM4YmFiNjFiYzgyZWRiMmE3ZWM5Y2U1NDQ3MjdkMWMuLjBhNDQ2ZTlkMjFkNmFm MDM1MzE4M2JmMjY1Y2M0OWU3Njc5ZGNhZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjcgQEAKKzIwMTItMDUtMTUgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEluZGV4ZWREQjogQWxsb3cgYSBkZWZhdWx0IGRh dGEgZGlyZWN0b3J5IHRvIGJlIHNwZWNpZmllZCBmb3IgSURCRmFjdG9yeQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY0OTkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJDb3JlOjpJREJGYWN0b3J5IHVz ZXMgYW4gaW4tbWVtb3J5IGRhdGFiYXNlIGlmIG5vIGRhdGEgZGlyZWN0b3J5IGlzIHNwZWNpZmll ZC4KKyAgICAgICAgVGhpcyBwcmV2ZW50cyB0ZXN0aW5nIHBlcnNpc3RlbmNlIChlLmcuIG9wZW4s IHdyaXRlLCBjbG9zZSwgZHJvcCBhbGwgcmVmZXJlbmNlcywKKyAgICAgICAgcmUtb3BlbiwgdmVy aWZ5IGRhdGEpLiBBbGxvdyBXZWJJREJGYWN0b3J5IGNyZWF0b3JzIC0gZS5nLiBDaHJvbWl1bSBE UlQgLSB0byBzcGVjaWZ5CisgICAgICAgIGEgZGVmYXVsdCBkYXRhIGRpcmVjdG9yeSBmb3IgdGVz dGluZyBwdXJwb3Nlcy4KKworICAgICAgICAqIHB1YmxpYy9XZWJJREJGYWN0b3J5Lmg6CisgICAg ICAgIChXZWJJREJGYWN0b3J5KToKKyAgICAgICAgKiBzcmMvV2ViSURCRmFjdG9yeUltcGwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJJREJGYWN0b3J5OjpjcmVhdGUpOgorICAgICAgICAoV2Vi S2l0KToKKyAgICAgICAgKFdlYktpdDo6V2ViSURCRmFjdG9yeUltcGw6OldlYklEQkZhY3RvcnlJ bXBsKToKKyAgICAgICAgKFdlYktpdDo6V2ViSURCRmFjdG9yeUltcGw6OmdldERhdGFiYXNlTmFt ZXMpOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJGYWN0b3J5SW1wbDo6b3Blbik6CisgICAgICAg IChXZWJLaXQ6OldlYklEQkZhY3RvcnlJbXBsOjpkZWxldGVEYXRhYmFzZSk6CisgICAgICAgICog c3JjL1dlYklEQkZhY3RvcnlJbXBsLmg6CisgICAgICAgIChXZWJJREJGYWN0b3J5SW1wbCk6CisK IDIwMTItMDUtMTUgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBTcGVlY2ggSmF2YVNjcmlwdCBBUEk6IEludHJvZHVjZSBlcnJvciBjb2RlIGVudW0gaW4gQ2hy b21pdW0gcGx1bWJpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYklEQkZhY3RvcnkuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkZh Y3RvcnkuaAppbmRleCBlOTU2ZWJkZWQ4YzQ1OWU3ZWZlNjMyMzcxZjZlNmQyNGFkYTgwOWYyLi44 YmYyMzgxYTdhYmY1MzU2NTViMWI4YTA1YjczNDAxYWQxOTMxMzExIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJGYWN0b3J5LmgKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCRmFjdG9yeS5oCkBAIC00OCw2ICs0OCw4IEBAIGNs YXNzIFdlYlNlY3VyaXR5T3JpZ2luOwogY2xhc3MgV2ViSURCRmFjdG9yeSB7CiBwdWJsaWM6CiAg ICAgV0VCS0lUX0VYUE9SVCBzdGF0aWMgV2ViSURCRmFjdG9yeSogY3JlYXRlKCk7CisgICAgLy8g T25seSBmb3IgdGVzdGluZyBwdXJwb3NlczoKKyAgICBXRUJLSVRfRVhQT1JUIHN0YXRpYyBXZWJJ REJGYWN0b3J5KiBjcmVhdGUoY29uc3QgV2ViU3RyaW5nJiBkZWZhdWx0RGF0YURpcik7CiAKICAg ICB2aXJ0dWFsIH5XZWJJREJGYWN0b3J5KCkgeyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYklEQkZhY3RvcnlJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYklEQkZhY3RvcnlJbXBsLmNwcAppbmRleCBkODc1ZTExYmM2NWVmNTg4ZTA2 ZTJiNWY1MWRhYzE2ZDI2YjYwOGVjLi5jNmMwYmRlMjY0N2NhOWNjYWQ5MDQ3ZDViOTE4MWNkODky MmRiNjkwIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJGYWN0 b3J5SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSURCRmFjdG9y eUltcGwuY3BwCkBAIC00NiwxMSArNDYsMTcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIFdlYklE QkZhY3RvcnkqIFdlYklEQkZhY3Rvcnk6OmNyZWF0ZSgpCiB7Ci0gICAgcmV0dXJuIG5ldyBXZWJJ REJGYWN0b3J5SW1wbCgpOworICAgIHJldHVybiBuZXcgV2ViSURCRmFjdG9yeUltcGwoV2ViU3Ry aW5nKCkpOwogfQogCi1XZWJJREJGYWN0b3J5SW1wbDo6V2ViSURCRmFjdG9yeUltcGwoKQorV2Vi SURCRmFjdG9yeSogV2ViSURCRmFjdG9yeTo6Y3JlYXRlKGNvbnN0IFdlYlN0cmluZyYgZGVmYXVs dERhdGFEaXIpCit7CisgICAgcmV0dXJuIG5ldyBXZWJJREJGYWN0b3J5SW1wbChkZWZhdWx0RGF0 YURpcik7Cit9CisKK1dlYklEQkZhY3RvcnlJbXBsOjpXZWJJREJGYWN0b3J5SW1wbChjb25zdCBX ZWJTdHJpbmcmIGRlZmF1bHREYXRhRGlyKQogICAgIDogbV9pZGJGYWN0b3J5QmFja2VuZChJREJG YWN0b3J5QmFja2VuZEltcGw6OmNyZWF0ZSgpKQorICAgICwgbV9kZWZhdWx0RGF0YURpcihkZWZh dWx0RGF0YURpcikKIHsKIH0KIApAQCAtNjAsMTggKzY2LDE4IEBAIFdlYklEQkZhY3RvcnlJbXBs Ojp+V2ViSURCRmFjdG9yeUltcGwoKQogCiB2b2lkIFdlYklEQkZhY3RvcnlJbXBsOjpnZXREYXRh YmFzZU5hbWVzKFdlYklEQkNhbGxiYWNrcyogY2FsbGJhY2tzLCBjb25zdCBXZWJTZWN1cml0eU9y aWdpbiYgb3JpZ2luLCBXZWJGcmFtZSosIGNvbnN0IFdlYlN0cmluZyYgZGF0YURpcikKIHsKLSAg ICBtX2lkYkZhY3RvcnlCYWNrZW5kLT5nZXREYXRhYmFzZU5hbWVzKElEQkNhbGxiYWNrc1Byb3h5 OjpjcmVhdGUoYWRvcHRQdHIoY2FsbGJhY2tzKSksIG9yaWdpbiwgMCwgZGF0YURpcik7CisgICAg bV9pZGJGYWN0b3J5QmFja2VuZC0+Z2V0RGF0YWJhc2VOYW1lcyhJREJDYWxsYmFja3NQcm94eTo6 Y3JlYXRlKGFkb3B0UHRyKGNhbGxiYWNrcykpLCBvcmlnaW4sIDAsIGRhdGFEaXIuaXNFbXB0eSgp ID8gbV9kZWZhdWx0RGF0YURpciA6IGRhdGFEaXIpOwogfQogCiAKIHZvaWQgV2ViSURCRmFjdG9y eUltcGw6Om9wZW4oY29uc3QgV2ViU3RyaW5nJiBuYW1lLCBXZWJJREJDYWxsYmFja3MqIGNhbGxi YWNrcywgY29uc3QgV2ViU2VjdXJpdHlPcmlnaW4mIG9yaWdpbiwgV2ViRnJhbWUqLCBjb25zdCBX ZWJTdHJpbmcmIGRhdGFEaXIpCiB7Ci0gICAgbV9pZGJGYWN0b3J5QmFja2VuZC0+b3BlbihuYW1l LCBJREJDYWxsYmFja3NQcm94eTo6Y3JlYXRlKGFkb3B0UHRyKGNhbGxiYWNrcykpLmdldCgpLCBv cmlnaW4sIDAsIGRhdGFEaXIpOworICAgIG1faWRiRmFjdG9yeUJhY2tlbmQtPm9wZW4obmFtZSwg SURCQ2FsbGJhY2tzUHJveHk6OmNyZWF0ZShhZG9wdFB0cihjYWxsYmFja3MpKS5nZXQoKSwgb3Jp Z2luLCAwLCBkYXRhRGlyLmlzRW1wdHkoKSA/IG1fZGVmYXVsdERhdGFEaXIgOiBkYXRhRGlyKTsK IH0KIAogdm9pZCBXZWJJREJGYWN0b3J5SW1wbDo6ZGVsZXRlRGF0YWJhc2UoY29uc3QgV2ViU3Ry aW5nJiBuYW1lLCBXZWJJREJDYWxsYmFja3MqIGNhbGxiYWNrcywgY29uc3QgV2ViU2VjdXJpdHlP cmlnaW4mIG9yaWdpbiwgV2ViRnJhbWUqLCBjb25zdCBXZWJTdHJpbmcmIGRhdGFEaXIpCiB7Ci0g ICAgbV9pZGJGYWN0b3J5QmFja2VuZC0+ZGVsZXRlRGF0YWJhc2UobmFtZSwgSURCQ2FsbGJhY2tz UHJveHk6OmNyZWF0ZShhZG9wdFB0cihjYWxsYmFja3MpKSwgb3JpZ2luLCAwLCBkYXRhRGlyKTsK KyAgICBtX2lkYkZhY3RvcnlCYWNrZW5kLT5kZWxldGVEYXRhYmFzZShuYW1lLCBJREJDYWxsYmFj a3NQcm94eTo6Y3JlYXRlKGFkb3B0UHRyKGNhbGxiYWNrcykpLCBvcmlnaW4sIDAsIGRhdGFEaXIu aXNFbXB0eSgpID8gbV9kZWZhdWx0RGF0YURpciA6IGRhdGFEaXIpOwogfQogCiB9IC8vIG5hbWVz cGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklE QkZhY3RvcnlJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJGYWN0b3J5 SW1wbC5oCmluZGV4IGIzZTQ3NGRmOTI1NWU4NzdmMmZmNmQwZTYzMTAzNTU2MjQ2ZDE3MTkuLjhh YjgyYjNlZjQ5MDYxZmM3MjBlNmY4MWM5YzhlZGIyNTQ1MWQ2ODEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQkZhY3RvcnlJbXBsLmgKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViSURCRmFjdG9yeUltcGwuaApAQCAtNDEsNyArNDEsNyBAQCBu YW1lc3BhY2UgV2ViS2l0IHsKIAogY2xhc3MgV2ViSURCRmFjdG9yeUltcGwgOiBwdWJsaWMgV2Vi SURCRmFjdG9yeSB7CiBwdWJsaWM6Ci0gICAgV2ViSURCRmFjdG9yeUltcGwoKTsKKyAgICBXZWJJ REJGYWN0b3J5SW1wbChjb25zdCBXZWJTdHJpbmcmIGRlZmF1bHREYXRhRGlyKTsKICAgICB2aXJ0 dWFsIH5XZWJJREJGYWN0b3J5SW1wbCgpOwogCiAgICAgdmlydHVhbCB2b2lkIGdldERhdGFiYXNl TmFtZXMoV2ViSURCQ2FsbGJhY2tzKiwgY29uc3QgV2ViU2VjdXJpdHlPcmlnaW4mLCBXZWJGcmFt ZSosIGNvbnN0IFdlYlN0cmluZyYgZGF0YURpcik7CkBAIC01MCw2ICs1MCw3IEBAIHB1YmxpYzoK IAogcHJpdmF0ZToKICAgICBXVEY6OlJlZlB0cjxXZWJDb3JlOjpJREJGYWN0b3J5QmFja2VuZElu dGVyZmFjZT4gbV9pZGJGYWN0b3J5QmFja2VuZDsKKyAgICBXZWJTdHJpbmcgbV9kZWZhdWx0RGF0 YURpcjsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=