86497 2012-05-15 10:31:15 -0700 SVGElement::addEventListener has peculiar RefPtr usage 2012-05-24 11:02:44 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin aestes gustavo philn webkit.review.bot xan.lopez zimmermann oldest_to_newest 624239 0 darin 2012-05-15 10:31:15 -0700 SVGElement::addEventListener has peculiar RefPtr usage 624242 1 141996 darin 2012-05-15 10:32:01 -0700 Created attachment 141996 Patch 624253 2 141996 buildbot 2012-05-15 10:41:29 -0700 Comment on attachment 141996 Patch Attachment 141996 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/12684878 624256 3 141996 aestes 2012-05-15 10:44:55 -0700 Comment on attachment 141996 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141996&action=review > Source/WebCore/svg/SVGElement.cpp:371 > return Node::addEventListener(eventType, listener, useCapture); As the EFL bot says, listener is used here > Source/WebCore/svg/SVGElement.cpp:373 > + RefPtr<EventListener> listener = prpListener; ...but isn't declared until here. 624257 4 aestes 2012-05-15 10:45:09 -0700 EWS, not EFL 624438 5 141996 darin 2012-05-15 13:01:51 -0700 Comment on attachment 141996 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141996&action=review >> Source/WebCore/svg/SVGElement.cpp:373 >> + RefPtr<EventListener> listener = prpListener; > > ...but isn't declared until here. Oops. Just need to move that up a few lines and say listener.release(). I’ll do that next time I’m at a computer with a source tree. 631223 6 143462 darin 2012-05-22 22:27:27 -0700 Created attachment 143462 Patch 632949 7 143462 webkit.review.bot 2012-05-24 11:02:39 -0700 Comment on attachment 143462 Patch Clearing flags on attachment: 143462 Committed r118393: <http://trac.webkit.org/changeset/118393> 632950 8 webkit.review.bot 2012-05-24 11:02:44 -0700 All reviewed patches have been landed. Closing bug. 141996 2012-05-15 10:32:01 -0700 2012-05-22 22:27:22 -0700 Patch bug-86497-20120515103200.patch text/plain 2559 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzA4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA1LTE1ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBTVkdFbGVtZW50OjphZGRFdmVudExp c3RlbmVyIGhhcyBwZWN1bGlhciBSZWZQdHIgdXNhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NDk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvU1ZHRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTVkdFbGVtZW50OjphZGRFdmVudExpc3RlbmVyKTogU3dpdGNoIHRvIGEgbW9yZS1z dGFuZGFyZCBzdHlsZSBvZiBSZWZQdHIgdXNhZ2UsCisgICAgICAgIGdldHRpbmcgcmlkIG9mIHNv bWUgdW5uZWVkZWQgcmVmZXJlbmNlIGNvdW50IGNodXJuLgorCiAyMDEyLTA1LTE1ICBSb2IgQnVp cyAgPHJidWlzQHJpbS5jb20+CiAKICAgICAgICAgUmVmYWN0b3IgU1ZHIHBhcnRzIG9mIE5vZGU6 OmFkZEV2ZW50TGlzdGVuZXIvcmVtb3ZlRXZlbnRMaXN0ZW5lcgpJbmRleDogU291cmNlL1dlYkNv cmUvc3ZnL1NWR0VsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9T VkdFbGVtZW50LmNwcAkocmV2aXNpb24gMTE3MDg2KQorKysgU291cmNlL1dlYkNvcmUvc3ZnL1NW R0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjMsMTggKzM2MywxNyBAQCBzdGF0aWMg aW5saW5lIHZvaWQgY29sbGVjdEluc3RhbmNlc0ZvclNWCiAgICAgaW5zdGFuY2VzID0gc3R5bGVk RWxlbWVudC0+aW5zdGFuY2VzRm9yRWxlbWVudCgpOwogfQogCi1ib29sIFNWR0VsZW1lbnQ6OmFk ZEV2ZW50TGlzdGVuZXIoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIFBhc3NSZWZQdHI8 RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIsIGJvb2wgdXNlQ2FwdHVyZSkKK2Jvb2wgU1ZHRWxlbWVu dDo6YWRkRXZlbnRMaXN0ZW5lcihjb25zdCBBdG9taWNTdHJpbmcmIGV2ZW50VHlwZSwgUGFzc1Jl ZlB0cjxFdmVudExpc3RlbmVyPiBwcnBMaXN0ZW5lciwgYm9vbCB1c2VDYXB0dXJlKQogewogICAg IEhhc2hTZXQ8U1ZHRWxlbWVudEluc3RhbmNlKj4gaW5zdGFuY2VzOwogICAgIGNvbGxlY3RJbnN0 YW5jZXNGb3JTVkdFbGVtZW50KHRoaXMsIGluc3RhbmNlcyk7CiAgICAgaWYgKGluc3RhbmNlcy5p c0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBOb2RlOjphZGRFdmVudExpc3RlbmVyKGV2ZW50VHlw ZSwgbGlzdGVuZXIsIHVzZUNhcHR1cmUpOwogCi0gICAgUmVmUHRyPEV2ZW50TGlzdGVuZXI+IGxp c3RlbmVyRm9yUmVndWxhclRyZWUgPSBsaXN0ZW5lcjsKLSAgICBSZWZQdHI8RXZlbnRMaXN0ZW5l cj4gbGlzdGVuZXJGb3JTaGFkb3dUcmVlID0gbGlzdGVuZXJGb3JSZWd1bGFyVHJlZTsKKyAgICBS ZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIgPSBwcnBMaXN0ZW5lcjsKIAogICAgIC8vIEFk ZCBldmVudCBsaXN0ZW5lciB0byByZWd1bGFyIERPTSBlbGVtZW50Ci0gICAgaWYgKCFOb2RlOjph ZGRFdmVudExpc3RlbmVyKGV2ZW50VHlwZSwgbGlzdGVuZXJGb3JSZWd1bGFyVHJlZS5yZWxlYXNl KCksIHVzZUNhcHR1cmUpKQorICAgIGlmICghTm9kZTo6YWRkRXZlbnRMaXN0ZW5lcihldmVudFR5 cGUsIGxpc3RlbmVyLCB1c2VDYXB0dXJlKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAg Ly8gQWRkIGV2ZW50IGxpc3RlbmVyIHRvIGFsbCBzaGFkb3cgdHJlZSBET00gZWxlbWVudCBpbnN0 YW5jZXMKQEAgLTM4Myw4ICszODIsNyBAQCBib29sIFNWR0VsZW1lbnQ6OmFkZEV2ZW50TGlzdGVu ZXIoY29uc3QgCiAgICAgICAgIEFTU0VSVCgoKml0KS0+c2hhZG93VHJlZUVsZW1lbnQoKSk7CiAg ICAgICAgIEFTU0VSVCgoKml0KS0+Y29ycmVzcG9uZGluZ0VsZW1lbnQoKSA9PSB0aGlzKTsKIAot ICAgICAgICBSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXJGb3JDdXJyZW50U2hhZG93VHJl ZUVsZW1lbnQgPSBsaXN0ZW5lckZvclNoYWRvd1RyZWU7Ci0gICAgICAgIGJvb2wgcmVzdWx0ID0g KCppdCktPnNoYWRvd1RyZWVFbGVtZW50KCktPk5vZGU6OmFkZEV2ZW50TGlzdGVuZXIoZXZlbnRU eXBlLCBsaXN0ZW5lckZvckN1cnJlbnRTaGFkb3dUcmVlRWxlbWVudC5yZWxlYXNlKCksIHVzZUNh cHR1cmUpOworICAgICAgICBib29sIHJlc3VsdCA9ICgqaXQpLT5zaGFkb3dUcmVlRWxlbWVudCgp LT5Ob2RlOjphZGRFdmVudExpc3RlbmVyKGV2ZW50VHlwZSwgbGlzdGVuZXIsIHVzZUNhcHR1cmUp OwogICAgICAgICBBU1NFUlRfVU5VU0VEKHJlc3VsdCwgcmVzdWx0KTsKICAgICB9CiAK 143462 2012-05-22 22:27:27 -0700 2012-05-24 11:02:39 -0700 Patch bug-86497-20120522222726.patch text/plain 2859 darin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExODEyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA1LTE1ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBTVkdFbGVtZW50OjphZGRFdmVudExp c3RlbmVyIGhhcyBwZWN1bGlhciBSZWZQdHIgdXNhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NDk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvU1ZHRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpTVkdFbGVtZW50OjphZGRFdmVudExpc3RlbmVyKTogU3dpdGNoIHRvIGEgbW9yZS1z dGFuZGFyZCBzdHlsZSBvZiBSZWZQdHIgdXNhZ2UsCisgICAgICAgIGdldHRpbmcgcmlkIG9mIHNv bWUgdW5uZWVkZWQgcmVmZXJlbmNlIGNvdW50IGNodXJuOyBhbHNvIHJlbW92ZWQgYW4gdW5uZWVk ZWQgc3BlY2lhbCBjYXNlCisgICAgICAgIGZvciB6ZXJvIGxpc3RlbmVycy4KKwogMjAxMi0wNS0y MiAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XVtQ ZXJmb3JtYW5jZV0gUGFzcyBJc29sYXRlIHRvIHY4OjpOdWxsKCkgaW4gVjhOb2RlOjp0b1Y4KCkK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9zdmcvU1ZHRWxlbWVudC5jcHAJKHJldmlzaW9uIDExODEyMSkKKysrIFNv dXJjZS9XZWJDb3JlL3N2Zy9TVkdFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzYyLDI4 ICszNjIsMjMgQEAgc3RhdGljIGlubGluZSB2b2lkIGNvbGxlY3RJbnN0YW5jZXNGb3JTVgogICAg IGluc3RhbmNlcyA9IHN0eWxlZEVsZW1lbnQtPmluc3RhbmNlc0ZvckVsZW1lbnQoKTsKIH0KIAot Ym9vbCBTVkdFbGVtZW50OjphZGRFdmVudExpc3RlbmVyKGNvbnN0IEF0b21pY1N0cmluZyYgZXZl bnRUeXBlLCBQYXNzUmVmUHRyPEV2ZW50TGlzdGVuZXI+IGxpc3RlbmVyLCBib29sIHVzZUNhcHR1 cmUpCitib29sIFNWR0VsZW1lbnQ6OmFkZEV2ZW50TGlzdGVuZXIoY29uc3QgQXRvbWljU3RyaW5n JiBldmVudFR5cGUsIFBhc3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gcHJwTGlzdGVuZXIsIGJvb2wg dXNlQ2FwdHVyZSkKIHsKLSAgICBIYXNoU2V0PFNWR0VsZW1lbnRJbnN0YW5jZSo+IGluc3RhbmNl czsKLSAgICBjb2xsZWN0SW5zdGFuY2VzRm9yU1ZHRWxlbWVudCh0aGlzLCBpbnN0YW5jZXMpOwot ICAgIGlmIChpbnN0YW5jZXMuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gTm9kZTo6YWRkRXZl bnRMaXN0ZW5lcihldmVudFR5cGUsIGxpc3RlbmVyLCB1c2VDYXB0dXJlKTsKLQotICAgIFJlZlB0 cjxFdmVudExpc3RlbmVyPiBsaXN0ZW5lckZvclJlZ3VsYXJUcmVlID0gbGlzdGVuZXI7Ci0gICAg UmVmUHRyPEV2ZW50TGlzdGVuZXI+IGxpc3RlbmVyRm9yU2hhZG93VHJlZSA9IGxpc3RlbmVyRm9y UmVndWxhclRyZWU7Ci0KKyAgICBSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIgPSBwcnBM aXN0ZW5lcjsKKyAgICAKICAgICAvLyBBZGQgZXZlbnQgbGlzdGVuZXIgdG8gcmVndWxhciBET00g ZWxlbWVudAotICAgIGlmICghTm9kZTo6YWRkRXZlbnRMaXN0ZW5lcihldmVudFR5cGUsIGxpc3Rl bmVyRm9yUmVndWxhclRyZWUucmVsZWFzZSgpLCB1c2VDYXB0dXJlKSkKKyAgICBpZiAoIU5vZGU6 OmFkZEV2ZW50TGlzdGVuZXIoZXZlbnRUeXBlLCBsaXN0ZW5lciwgdXNlQ2FwdHVyZSkpCiAgICAg ICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8vIEFkZCBldmVudCBsaXN0ZW5lciB0byBhbGwgc2hh ZG93IHRyZWUgRE9NIGVsZW1lbnQgaW5zdGFuY2VzCisgICAgSGFzaFNldDxTVkdFbGVtZW50SW5z dGFuY2UqPiBpbnN0YW5jZXM7CisgICAgY29sbGVjdEluc3RhbmNlc0ZvclNWR0VsZW1lbnQodGhp cywgaW5zdGFuY2VzKTsgICAgCiAgICAgY29uc3QgSGFzaFNldDxTVkdFbGVtZW50SW5zdGFuY2Uq Pjo6Y29uc3RfaXRlcmF0b3IgZW5kID0gaW5zdGFuY2VzLmVuZCgpOwogICAgIGZvciAoSGFzaFNl dDxTVkdFbGVtZW50SW5zdGFuY2UqPjo6Y29uc3RfaXRlcmF0b3IgaXQgPSBpbnN0YW5jZXMuYmVn aW4oKTsgaXQgIT0gZW5kOyArK2l0KSB7CiAgICAgICAgIEFTU0VSVCgoKml0KS0+c2hhZG93VHJl ZUVsZW1lbnQoKSk7CiAgICAgICAgIEFTU0VSVCgoKml0KS0+Y29ycmVzcG9uZGluZ0VsZW1lbnQo KSA9PSB0aGlzKTsKIAotICAgICAgICBSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXJGb3JD dXJyZW50U2hhZG93VHJlZUVsZW1lbnQgPSBsaXN0ZW5lckZvclNoYWRvd1RyZWU7Ci0gICAgICAg IGJvb2wgcmVzdWx0ID0gKCppdCktPnNoYWRvd1RyZWVFbGVtZW50KCktPk5vZGU6OmFkZEV2ZW50 TGlzdGVuZXIoZXZlbnRUeXBlLCBsaXN0ZW5lckZvckN1cnJlbnRTaGFkb3dUcmVlRWxlbWVudC5y ZWxlYXNlKCksIHVzZUNhcHR1cmUpOworICAgICAgICBib29sIHJlc3VsdCA9ICgqaXQpLT5zaGFk b3dUcmVlRWxlbWVudCgpLT5Ob2RlOjphZGRFdmVudExpc3RlbmVyKGV2ZW50VHlwZSwgbGlzdGVu ZXIsIHVzZUNhcHR1cmUpOwogICAgICAgICBBU1NFUlRfVU5VU0VEKHJlc3VsdCwgcmVzdWx0KTsK ICAgICB9CiAK