86489 2012-05-15 09:00:21 -0700 [Qt] plugin is loaded to the web process via MainResourceLoader::substituteMIMETypeFromPluginDatabase 2012-06-28 02:36:19 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kbalazs kbalazs japhet jochen kenneth webkit.review.bot yael oldest_to_newest 624157 0 kbalazs 2012-05-15 09:00:21 -0700 We should not load plugins to the web process, especially not via the wk1 plugin code path. 626388 1 kbalazs 2012-05-17 02:03:43 -0700 This code has been added in https://bugs.webkit.org/show_bug.cgi?id=32572. It's possible to reimplement it in a way that fits with WebKit2 by going trough PluginData -> WebPlatformStrategies -> UI process but I have trouble with testing this functionality. I could not load an swf file with QtTestBrowser on unpatched trunk - actually I found an swf file that loads but it doesn't show anything else than black. Do you think it should work on trunk? Could you give an example I can test with? Or maybe we should just drop that? 642566 2 146053 kbalazs 2012-06-06 10:02:51 -0700 Created attachment 146053 Patch 659207 3 146053 hausmann 2012-06-27 22:31:51 -0700 Comment on attachment 146053 Patch I very much agree with this, the symptom (webprocess shouldn't load plugins through wk1 code path by use of PluginDatabase) as well as the removal of this hack :) 659356 4 146053 kbalazs 2012-06-28 02:36:12 -0700 Comment on attachment 146053 Patch Clearing flags on attachment: 146053 Committed r121423: <http://trac.webkit.org/changeset/121423> 659357 5 kbalazs 2012-06-28 02:36:19 -0700 All reviewed patches have been landed. Closing bug. 146053 2012-06-06 10:02:51 -0700 2012-06-28 02:36:12 -0700 Patch bug-86489-20120606190249.patch text/plain 3067 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTE5NDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTlmOTVlNWMxZjliZDQz NmM4YjcxNGQ4Mzc4NjI5M2U0NjVkZmMzZi4uN2Q5YmU5Y2Y4MjkyZWFiM2EzMjRiZGFkYmE2YTU0 MDRhMjFjMTcwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA2LTA2ICBCYWxh enMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKworICAgICAgICBbUXRdIHBsdWdpbiBp cyBsb2FkZWQgdG8gdGhlIHdlYiBwcm9jZXNzIHZpYSBNYWluUmVzb3VyY2VMb2FkZXI6OnN1YnN0 aXR1dGVNSU1FVHlwZUZyb21QbHVnaW5EYXRhYmFzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY0ODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIHRoZSBzdWJzdGl0dXRlTUlNRVR5cGVGcm9t UGx1Z2luRGF0YWJhc2UgcXVpcmsgZnJvbQorICAgICAgICBNYWluUmVzb3VyY2VMb2FkZXIuIEl0 IHdvdWxkIGJlIHBvc3NpYmxlIHRvIGZpeCBpdCBpbiBhIHdheQorICAgICAgICB0aGF0IGlzIGNv bXBhdGlibGUgd2l0aCBXZWJLaXQyLCBidXQgZ2l2ZW4gdGhhdCBpdCB3YXMgYSBRdAorICAgICAg ICBvbmx5IGZpeCwgYW5kIHRoYXQgaXQncyBub3QgY2xlYXIgdGhhdCB3ZSBzdGlsbCBuZWVkIGl0 LCBhbmQKKyAgICAgICAgaXQncyBub3QgZXZlbiB3b3JrIGN1cnJlbnRseSwgSSBkZWNpZGVkIHRv IHJlbW92ZSBpdC4gQXQgbGVhc3QKKyAgICAgICAgaXQgaXMgLTEgcGxhdGZvcm0gaWZkZWYgaW4g Y29tbW9uIGNvZGUuCisKKyAgICAgICAgSnVzdCByZW1vdmVkIGEgbm9uLXRlc3RlZCBxdWlyaywg bm8gdGVzdCBuZWVkZWQuCisKKyAgICAgICAgKiBsb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok1haW5SZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3Bv bnNlKToKKwogMjAxMi0wNi0wNSAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNISUZUIGtleSBhcyBoZWxwZXIgdG8gY29s b3IgYWRqdXN0bWVudCBpbiBjb2xvciBwaWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xvYWRlci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL01h aW5SZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggNTdkMDExMzRiZTU4NWJiOWMxOTQ1NjljMTAzMDQ2 OGRhMmM4YWM5NS4uOGIyMjA0ZDI0YmZmMjQzYjNjYjQ0ZjdkZjBkNTI0OWZmOTFmYzkzMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL01haW5SZXNvdXJjZUxvYWRlci5jcHAKQEAgLTM1Miwy OSArMzUyLDYgQEAgdm9pZCBNYWluUmVzb3VyY2VMb2FkZXI6OmNvbnRpbnVlQWZ0ZXJDb250ZW50 UG9saWN5KFBvbGljeUFjdGlvbiBwb2xpY3kpCiAgICAgZGVyZWYoKTsgLy8gYmFsYW5jZXMgcmVm IGluIGRpZFJlY2VpdmVSZXNwb25zZQogfQogCi0jaWYgUExBVEZPUk0oUVQpCi12b2lkIE1haW5S ZXNvdXJjZUxvYWRlcjo6c3Vic3RpdHV0ZU1JTUVUeXBlRnJvbVBsdWdpbkRhdGFiYXNlKGNvbnN0 IFJlc291cmNlUmVzcG9uc2UmIHIpCi17Ci0gICAgaWYgKCFtX2ZyYW1lLT5sb2FkZXIoKS0+c3Vi ZnJhbWVMb2FkZXIoKS0+YWxsb3dQbHVnaW5zKE5vdEFib3V0VG9JbnN0YW50aWF0ZVBsdWdpbikp Ci0gICAgICAgIHJldHVybjsKLQotICAgIFN0cmluZyBmaWxlbmFtZSA9IHIudXJsKCkubGFzdFBh dGhDb21wb25lbnQoKTsKLSAgICBpZiAoZmlsZW5hbWUuZW5kc1dpdGgoJy8nKSkKLSAgICAgICAg cmV0dXJuOwotCi0gICAgc2l6ZV90IGV4dGVuc2lvblBvcyA9IGZpbGVuYW1lLnJldmVyc2VGaW5k KCcuJyk7Ci0gICAgaWYgKGV4dGVuc2lvblBvcyA9PSBub3RGb3VuZCkKLSAgICAgICAgcmV0dXJu OwotCi0gICAgU3RyaW5nIGV4dGVuc2lvbiA9IGZpbGVuYW1lLnN1YnN0cmluZyhleHRlbnNpb25Q b3MgKyAxKTsKLSAgICBTdHJpbmcgbWltZVR5cGUgPSBQbHVnaW5EYXRhYmFzZTo6aW5zdGFsbGVk UGx1Z2lucygpLT5NSU1FVHlwZUZvckV4dGVuc2lvbihleHRlbnNpb24pOwotICAgIGlmICghbWlt ZVR5cGUuaXNFbXB0eSgpKSB7Ci0gICAgICAgIFJlc291cmNlUmVzcG9uc2UqIHJlc3BvbnNlID0g Y29uc3RfY2FzdDxSZXNvdXJjZVJlc3BvbnNlKj4oJnIpOwotICAgICAgICByZXNwb25zZS0+c2V0 TWltZVR5cGUobWltZVR5cGUpOwotICAgIH0KLX0KLSNlbmRpZgotCiB2b2lkIE1haW5SZXNvdXJj ZUxvYWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHIpCiB7 CiAgICAgaWYgKGRvY3VtZW50TG9hZGVyKCktPmFwcGxpY2F0aW9uQ2FjaGVIb3N0KCktPm1heWJl TG9hZEZhbGxiYWNrRm9yTWFpblJlc3BvbnNlKHJlcXVlc3QoKSwgcikpCkBAIC0zOTksMTEgKzM3 Niw2IEBAIHZvaWQgTWFpblJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlUmVzcG9uc2UoY29uc3Qg UmVzb3VyY2VSZXNwb25zZSYgcikKICAgICBBU1NFUlQoc2hvdWxkTG9hZEFzRW1wdHlEb2N1bWVu dChyLnVybCgpKSB8fCAhZGVmZXJzTG9hZGluZygpKTsKICNlbmRpZgogCi0jaWYgUExBVEZPUk0o UVQpCi0gICAgaWYgKHIubWltZVR5cGUoKSA9PSAiYXBwbGljYXRpb24vb2N0ZXQtc3RyZWFtIikK LSAgICAgICAgc3Vic3RpdHV0ZU1JTUVUeXBlRnJvbVBsdWdpbkRhdGFiYXNlKHIpOwotI2VuZGlm Ci0KICAgICBpZiAobV9sb2FkaW5nTXVsdGlwYXJ0Q29udGVudCkgewogICAgICAgICBmcmFtZUxv YWRlcigpLT5hY3RpdmVEb2N1bWVudExvYWRlcigpLT5zZXR1cEZvclJlcGxhY2VCeU1JTUVUeXBl KHIubWltZVR5cGUoKSk7CiAgICAgICAgIGNsZWFyUmVzb3VyY2VEYXRhKCk7Cg==