86466 2012-05-15 04:48:23 -0700 Web Inspector: AdvancedSearchController is not stopped then view is hidden. 2012-10-12 04:04:22 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 eustas.bug eustas.bug apavlov bweinstein eustas.bug joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 623898 0 eustas.bug 2012-05-15 04:48:23 -0700 AdvancedSearchController overrides "wasHidden" method instead on "willHide". 623902 1 141918 eustas.bug 2012-05-15 04:53:36 -0700 Created attachment 141918 Patch 623924 2 141918 vsevik 2012-05-15 05:13:44 -0700 Comment on attachment 141918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review > Source/WebCore/ChangeLog:6 > + AdvancedSearchController overrides "wasHidden" method instead of "willHide". Please move this line below "Reviewed by". > Source/WebCore/inspector/front-end/AdvancedSearchController.js:360 > + * @override We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors). 623969 3 141918 eustas.bug 2012-05-15 06:15:57 -0700 Comment on attachment 141918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review >> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360 >> + * @override > > We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors). I've tried it before writing this annotation. Compiler doesn't catch this error, that's no good. But we can hope it will do some day. BUT this annotation not only for compiler, but also for developers, because it make code a way core clear. 623973 4 141918 eustas.bug 2012-05-15 06:20:12 -0700 Comment on attachment 141918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review >> Source/WebCore/ChangeLog:6 >> + AdvancedSearchController overrides "wasHidden" method instead of "willHide". > > Please move this line below "Reviewed by". OK 623980 5 141948 eustas.bug 2012-05-15 06:27:52 -0700 Created attachment 141948 Patch 624010 6 141918 vsevik 2012-05-15 06:45:25 -0700 Comment on attachment 141918 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141918&action=review >>> Source/WebCore/inspector/front-end/AdvancedSearchController.js:360 >>> + * @override >> >> We don't use @overrride annotation because it does not catch any error (try renaming back to wasHidden and observe no compiler errors). > > I've tried it before writing this annotation. > Compiler doesn't catch this error, that's no good. But we can hope it will do some day. > > BUT this annotation not only for compiler, but also for developers, because it make code a way core clear. I don't think we should add compiler annotations for developers. We don't even add comments usually. Please remove this for consistency. 624069 7 141966 eustas.bug 2012-05-15 07:35:20 -0700 Created attachment 141966 Patch 624165 8 141966 webkit.review.bot 2012-05-15 09:12:21 -0700 Comment on attachment 141966 Patch Clearing flags on attachment: 141966 Committed r117080: <http://trac.webkit.org/changeset/117080> 624167 9 webkit.review.bot 2012-05-15 09:12:26 -0700 All reviewed patches have been landed. Closing bug. 141918 2012-05-15 04:53:36 -0700 2012-05-15 06:45:25 -0700 Patch bug-86466-20120515155334.patch text/plain 1515 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFmMmNhNzU2MTgzZjU3 YjIwNjZkYjg5NzQwMDJhNjY2OWI0M2MxMy4uNDNjZTI1Njc5OTYwNzk1YTAwZDlmYzY0NmI1Y2Qz NzYyY2I3NWQ3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTE1ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBBZHZhbmNlZFNlYXJjaENvbnRyb2xsZXIgaXMgbm90IHN0b3BwZWQgdGhlbiB2aWV3 IGlzIGhpZGRlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg2NDY2CisKKyAgICAgICAgQWR2YW5jZWRTZWFyY2hDb250cm9sbGVyIG92ZXJyaWRlcyAi d2FzSGlkZGVuIiBtZXRob2QgaW5zdGVhZCBvZiAid2lsbEhpZGUiLgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVJIGV2ZW50LWZsb3csIG5vdCB0ZXN0 ZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0FkdmFuY2VkU2VhcmNoQ29udHJv bGxlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TZWFyY2hWaWV3LnByb3RvdHlwZS53aWxs SGlkZSk6IFJlbmFtZWQgZnVuY3Rpb24uCisKIDIwMTItMDUtMTQgIEdhdmluIFBldGVycyAgPGdh dmlucEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIFByZXJlbmRlcmVyLCBQcmVyZW5kZXJI YW5kbGUgYW5kIGEgY2hyb21pdW0gaW50ZXJmYWNlIGZvciBQcmVyZW5kZXJpbmcuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0FkdmFuY2VkU2VhcmNoQ29u dHJvbGxlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWR2YW5jZWRT ZWFyY2hDb250cm9sbGVyLmpzCmluZGV4IDhlZTE1YjJkODg0ZGMwMDM5NjY0YWViNmJmZDBlZDFm NjdlYzRlNDcuLjVkOWEwNTNhYzA0ODdhMmQyMTE4YzYzYmJkODQwMzI4ZTZjYjczNWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWR2YW5jZWRTZWFyY2hD b250cm9sbGVyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWR2 YW5jZWRTZWFyY2hDb250cm9sbGVyLmpzCkBAIC0zNTYsNyArMzU2LDEwIEBAIFdlYkluc3BlY3Rv ci5TZWFyY2hWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5mb2N1cygpOwogICAgIH0s CiAKLSAgICB3YXNIaWRkZW46IGZ1bmN0aW9uKCkKKyAgICAvKioKKyAgICAgKiBAb3ZlcnJpZGUK KyAgICAgKi8KKyAgICB3aWxsSGlkZTogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5f Y29udHJvbGxlci5zdG9wU2VhcmNoKCk7CiAgICAgfSwK 141948 2012-05-15 06:27:52 -0700 2012-05-15 07:35:10 -0700 Patch bug-86466-20120515172750.patch text/plain 1515 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODFmMmNhNzU2MTgzZjU3 YjIwNjZkYjg5NzQwMDJhNjY2OWI0M2MxMy4uYTA3OTYzNWZkZGE2NWU5ZDQwOTBkMjQzODY2Y2Ey ZTEzYzYxM2NjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTE1ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBBZHZhbmNlZFNlYXJjaENvbnRyb2xsZXIgaXMgbm90IHN0b3BwZWQgdGhlbiB2aWV3 IGlzIGhpZGRlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg2NDY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWR2YW5jZWRTZWFyY2hDb250cm9sbGVyIG92ZXJyaWRlcyAid2FzSGlkZGVuIiBtZXRob2Qg aW5zdGVhZCBvZiAid2lsbEhpZGUiLgorCisgICAgICAgIFVJIGV2ZW50LWZsb3csIG5vdCB0ZXN0 ZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0FkdmFuY2VkU2VhcmNoQ29udHJv bGxlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TZWFyY2hWaWV3LnByb3RvdHlwZS53aWxs SGlkZSk6IFJlbmFtZWQgZnVuY3Rpb24uCisKIDIwMTItMDUtMTQgIEdhdmluIFBldGVycyAgPGdh dmlucEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIFByZXJlbmRlcmVyLCBQcmVyZW5kZXJI YW5kbGUgYW5kIGEgY2hyb21pdW0gaW50ZXJmYWNlIGZvciBQcmVyZW5kZXJpbmcuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0FkdmFuY2VkU2VhcmNoQ29u dHJvbGxlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWR2YW5jZWRT ZWFyY2hDb250cm9sbGVyLmpzCmluZGV4IDhlZTE1YjJkODg0ZGMwMDM5NjY0YWViNmJmZDBlZDFm NjdlYzRlNDcuLjVkOWEwNTNhYzA0ODdhMmQyMTE4YzYzYmJkODQwMzI4ZTZjYjczNWYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWR2YW5jZWRTZWFyY2hD b250cm9sbGVyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQWR2 YW5jZWRTZWFyY2hDb250cm9sbGVyLmpzCkBAIC0zNTYsNyArMzU2LDEwIEBAIFdlYkluc3BlY3Rv ci5TZWFyY2hWaWV3LnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5mb2N1cygpOwogICAgIH0s CiAKLSAgICB3YXNIaWRkZW46IGZ1bmN0aW9uKCkKKyAgICAvKioKKyAgICAgKiBAb3ZlcnJpZGUK KyAgICAgKi8KKyAgICB3aWxsSGlkZTogZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5f Y29udHJvbGxlci5zdG9wU2VhcmNoKCk7CiAgICAgfSwK 141966 2012-05-15 07:35:20 -0700 2012-05-15 09:12:21 -0700 Patch bug-86466-20120515183518.patch text/plain 1459 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDMyZDVjYTIwY2I4MWEw MGE3MmI5NDE1ZmZjNzNmZjQ2Zjc2Yzc3ZS4uMGU2YzJjN2MxMjFkYTg5MDQ1YjBiYzIzZjUyN2I4 ZmI0YTA5NzRkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTE1ICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBBZHZhbmNlZFNlYXJjaENvbnRyb2xsZXIgaXMgbm90IHN0b3BwZWQgdGhlbiB2aWV3 IGlzIGhpZGRlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg2NDY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWR2YW5jZWRTZWFyY2hDb250cm9sbGVyIG92ZXJyaWRlcyAid2FzSGlkZGVuIiBtZXRob2Qg aW5zdGVhZCBvZiAid2lsbEhpZGUiLgorCisgICAgICAgIFVJIGV2ZW50LWZsb3csIG5vdCB0ZXN0 ZWQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0FkdmFuY2VkU2VhcmNoQ29udHJv bGxlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TZWFyY2hWaWV3LnByb3RvdHlwZS53aWxs SGlkZSk6IFJlbmFtZWQgZnVuY3Rpb24uCisKIDIwMTItMDUtMTUgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIHNob3cv aGlkZSBkZWJ1Z2dlciBzaWRlYmFyIGJ1dHRvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQWR2YW5jZWRTZWFyY2hDb250cm9sbGVyLmpzIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BZHZhbmNlZFNlYXJjaENvbnRyb2xsZXIuanMK aW5kZXggOGVlMTViMmQ4ODRkYzAwMzk2NjRhZWI2YmZkMGVkMWY2N2VjNGU0Ny4uYzIxNWY5OWZl NGZkNGIyMDVjNmY0OTZmOWQxMzQ3MWExNzg0ZWFhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BZHZhbmNlZFNlYXJjaENvbnRyb2xsZXIuanMKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BZHZhbmNlZFNlYXJjaENvbnRyb2xs ZXIuanMKQEAgLTM1Niw3ICszNTYsNyBAQCBXZWJJbnNwZWN0b3IuU2VhcmNoVmlldy5wcm90b3R5 cGUgPSB7CiAgICAgICAgIHRoaXMuZm9jdXMoKTsKICAgICB9LAogCi0gICAgd2FzSGlkZGVuOiBm dW5jdGlvbigpCisgICAgd2lsbEhpZGU6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHRoaXMu X2NvbnRyb2xsZXIuc3RvcFNlYXJjaCgpOwogICAgIH0sCg==