8646 2006-04-28 05:27:23 -0700 REGRESSION: window.screen.pixelDepth returns wrong value 2006-06-01 22:41:47 -0700 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED FIXED http://developer.mozilla.org/en/docs/DOM:window.screen.pixelDepth EasyFix, Regression P1 Minor --- 1 kimmo.t.kinnunen dacarson oldest_to_newest 40661 0 kimmo.t.kinnunen 2006-04-28 05:27:23 -0700 To reproduce enter following url to the safari url bar javascript:alert(window.screen.pixelDepth) For me it produces dialog with the text "520" in it. bug is in WebKit/WebCore/platform/mac/ScreenMac.mm From the ADC docs about NSScreen -- - (NSWindowDepth)depth Discussion The return value is not directly usable; you must pass it to functions such as NSBitsPerPixelFromDepth and NSColorSpaceFromDepth to obtain concrete values. -- Using NSBitsPerPixelFromDepth returns 24, where as stock Safari (312+?) and Firefox return 32 40663 1 ap 2006-04-28 06:39:32 -0700 Same problem with window.screen.colorDepth. 40691 2 darin 2006-04-28 14:11:27 -0700 It seems to me that we do want to use NSBitsPerPixelFromDepth, despite the fact that Firefox returns 32. But I'm not absolutely sure. We should look at older versions of Safari to see exactly where the 32 was coming from. 40704 3 darin 2006-04-28 21:04:40 -0700 (In reply to comment #2) > We should look at older versions of Safari to see exactly where the 32 was > coming from. It was coming from CGDisplayBitsPerPixel(kCGDirectMainDisplay). 43238 4 8471 dacarson 2006-05-22 20:51:46 -0700 Created attachment 8471 patch, test case and change log pixelDepth now returns 24. Even though FF returns 32. 43409 5 8471 hyatt 2006-05-24 12:56:01 -0700 Comment on attachment 8471 patch, test case and change log r=me 44348 6 darin 2006-06-01 22:41:47 -0700 Committed revision 14678. 8471 2006-05-22 20:51:46 -0700 2006-05-24 12:56:01 -0700 patch, test case and change log depth.txt text/plain 3509 dacarson SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0NTE0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDUtWFggRGF2aWQgQ2Fyc29uIDxkYWNh cnNvbkBnbWFpbC5jb20+CisgICAgICAgIAorICAgICAgICBSZXZpZXdlZCBieSBYWFhYCisgICAg ICAgIAorICAgICAgICBUZXN0cyBmb3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3No b3dfYnVnLmNnaT9pZD04NjQ2CisgICAgICAgIFRlc3QgdGhlIHdpbmRvdy5zY3JlZW4ucGl4ZWxE ZXB0aCBhbmQgd2luZG93LnNjcmVlbi5jb2xvckRlcHRoCisgICAgICAgIAorICAgICAgICAqIGZh c3QvZG9tL3dpbmRvdy93aW5kb3ctc2NyZWVuLXByb3BlcnRpZXMuaHRtbDogQWRkZWQKKyAgICAg ICAgKiBmYXN0L2RvbS93aW5kb3cvd2luZG93LXNjcmVlbi1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4 dDogQWRkZWQuCisKIDIwMDYtMDUtMjAgIEFuZGVycyBDYXJsc3NvbiAgPGFjYXJsc3NvbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYuCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2RvbS9XaW5kb3cvd2luZG93LXNjcmVlbi1wcm9wZXJ0aWVzLmh0bWwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1zY3JlZW4tcHJvcGVydGllcy5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1z Y3JlZW4tcHJvcGVydGllcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDkgQEAKK1RoZSBj dXJyZW50IHBpeGVsIGRlcHRoIHJldHVybmVkIGJ5IHdpbmRvdy5zY3JlZW4ucGl4ZWxEZXB0aCBp czoKKzxzY3JpcHQ+Citkb2N1bWVudC53cml0ZSh3aW5kb3cuc2NyZWVuLnBpeGVsRGVwdGgpOwor PC9zY3JpcHQ+Cis8YnI+CitUaGUgY3VycmVudCBjb2xvciBkZXB0aCByZXR1cm5lZCBieSB3aW5k b3cuc2NyZWVuLmNvbG9yRGVwdGggaXM6Cis8c2NyaXB0PgorZG9jdW1lbnQud3JpdGUod2luZG93 LnNjcmVlbi5jb2xvckRlcHRoKTsKKzwvc2NyaXB0PgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L3dpbmRvdy1zY3JlZW4tcHJvcGVydGllcy1leHBlY3RlZC50eHQKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRvdy1zY3JlZW4tcHJvcGVydGll cy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5k b3cvd2luZG93LXNjcmVlbi1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwxNCBAQAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckNhbnZh cyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBS ZW5kZXJCbG9jayB7SFRNTH0gYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7 Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3ODR4NTg0CisgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQg KDAsMCkgc2l6ZSA0MTl4MTgKKyAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNDE5OiAi VGhlIGN1cnJlbnQgcGl4ZWwgZGVwdGggcmV0dXJuZWQgYnkgd2luZG93LnNjcmVlbi5waXhlbERl cHRoIGlzOiAiCisgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDQxOSwwKSBzaXplIDIweDE4 CisgICAgICAgIHRleHQgcnVuIGF0ICg0MTksMCkgd2lkdGggMjA6ICIyNCAiCisgICAgICBSZW5k ZXJCUiB7QlJ9IGF0ICg0MzksMTQpIHNpemUgMHgwCisgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0g YXQgKDAsMTgpIHNpemUgNDIxeDE4CisgICAgICAgIHRleHQgcnVuIGF0ICgwLDE4KSB3aWR0aCA0 MjE6ICJUaGUgY3VycmVudCBjb2xvciBkZXB0aCByZXR1cm5lZCBieSB3aW5kb3cuc2NyZWVuLmNv bG9yRGVwdGggaXM6ICIKKyAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoNDIxLDE4KSBzaXpl IDE2eDE4CisgICAgICAgIHRleHQgcnVuIGF0ICg0MjEsMTgpIHdpZHRoIDE2OiAiMjQiCkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JlZW5NYWMubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9wbGF0Zm9ybS9tYWMvU2NyZWVuTWFjLm1tCShyZXZpc2lvbiAxNDUxNCkKKysrIFdlYkNvcmUv cGxhdGZvcm0vbWFjL1NjcmVlbk1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNDcsNyArNDcsOSBA QCBzdGF0aWMgTlNSZWN0IGZsaXBHbG9iYWxSZWN0KE5TUmVjdCByZWN0CiAKIGludCBzY3JlZW5E ZXB0aChXaWRnZXQqIHdpZGdldCkKIHsKLSAgICByZXR1cm4gW3NjcmVlbih3aWRnZXQpIGRlcHRo XTsKKyAgICAvL3JldHVybiBDR0Rpc3BsYXlCaXRzUGVyUGl4ZWwoa0NHRGlyZWN0TWFpbkRpc3Bs YXkpOworICAgIE5TV2luZG93RGVwdGggZCA9IFtzY3JlZW4od2lkZ2V0KSBkZXB0aF07CisJcmV0 dXJuIE5TQml0c1BlclBpeGVsRnJvbURlcHRoKGQpOwogfQogCiBJbnRSZWN0IHNjcmVlblJlY3Qo V2lkZ2V0KiB3aWRnZXQpCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTQ1MTQpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA2LTA1LXh4IERhdmlkIENhcnNvbiA8 ZGFjYXJzb25AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IFhYWFgKKworICAgICAg ICBGaXggZm9yIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODY0NgorICAgICAgICBDb3JyZWN0aW5nIHRoZSB2YWx1ZSByZXR1cm5lZCBmb3Igd2luZG93LnNj cmVlbi5waXhlbERlcHRoIGFuZAorICAgICAgICB3aW5kb3cuc2NyZWVuLmNvbG9yRGVwdGgKKyAg ICAgICAgCisgICAgICAgICogcGxhdGZvcm0vbWFjL1NjcmVlbk1hYy5tbQorICAgICAgICAoc2Ny ZWVuRGVwdGgpOiAKKyAgICAgICAgQ2hhbmdlZCB0byByZXR1cm4gdGhlIEJpdHNQZXJQaXhlbEZy b21EZXB0aCByYXRoZXIgdGhhbiB0aGUgV2luZG93RGVwdGgKKwogMjAwNi0wNS0yMSAgRGF2ZSBI eWF0dCA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBXaW4zMiBidXN0YWdlLiAgIEkg Zm9yZ290IHRvIGFkZCBhIGJ1bmNoIG9mIGZpbGVzLgo=