86459 2012-05-15 03:11:34 -0700 MediaStream API: Setting onended on a LocalMediaStream triggers an assertion in V8 2012-05-15 11:15:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 56459 1 tommyw tommyw abarth eric.carlson feature-media-reviews ojan webkit.review.bot oldest_to_newest 623859 0 tommyw 2012-05-15 03:11:34 -0700 Setting onended on a MediaStream (either remote or created) works just fine. LocalMediaStream inherits from MediaStream, but only MediaStream have the EventTarget idl attribute. Adding the attribute to LocalMediaStream as well fixes the issue. 623861 1 141907 tommyw 2012-05-15 03:15:45 -0700 Created attachment 141907 Patch 624241 2 141907 abarth 2012-05-15 10:32:01 -0700 Comment on attachment 141907 Patch Yeah, it's lame that we don't inherit these sorts of attributes. 624287 3 141907 webkit.review.bot 2012-05-15 11:14:59 -0700 Comment on attachment 141907 Patch Clearing flags on attachment: 141907 Committed r117102: <http://trac.webkit.org/changeset/117102> 624288 4 webkit.review.bot 2012-05-15 11:15:05 -0700 All reviewed patches have been landed. Closing bug. 141907 2012-05-15 03:15:45 -0700 2012-05-15 11:14:59 -0700 Patch bug-86459-20120515121543.patch text/plain 4364 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTE3MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmNhNjE2ZTcyMDBkOWEx OTc1MjQzNjE4ZjljMzE4MzU0NmVkYjI5Ny4uZjMxYWRhYjA2NmQ5MTNjZDY1Yzk1NjYxNzRiYmFm ZTdkM2ZlNTNkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA1LTE1ICBUb21t eSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIE1lZGlhU3RyZWFt IEFQSTogU2V0dGluZyBvbmVuZGVkIG9uIGEgTG9jYWxNZWRpYVN0cmVhbSB0cmlnZ2VycyBhbiBh c3NlcnRpb24gaW4gVjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg2NDU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTG9jYWxNZWRpYVN0cmVhbSBpbmhlcml0cyBmcm9tIE1lZGlhU3RyZWFtLCBidXQgb25s eSBNZWRpYVN0cmVhbSBoYXZlIHRoZQorICAgICAgICBFdmVudFRhcmdldCBpZGwgYXR0cmlidXRl LiBBZGRpbmcgdGhlIGF0dHJpYnV0ZSB0byBMb2NhbE1lZGlhU3RyZWFtIGFzIHdlbGwgZml4ZXMg dGhlIGlzc3VlLgorCisgICAgICAgIFRlc3Q6IGZhc3QvbWVkaWFzdHJlYW0vTG9jYWxNZWRpYVN0 cmVhbS1vbmVuZGVkLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vTG9jYWxN ZWRpYVN0cmVhbS5pZGw6CisKIDIwMTItMDUtMTUgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdv b2dsZS5jb20+CiAKICAgICAgICAgS2lsbCB1bm5lY2Vzc2FyeSBSdW50aW1lRW5hYmxlZEZlYXR1 cmVzLmggaW5jbHVzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL0xvY2FsTWVkaWFTdHJlYW0uaWRsIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRp YXN0cmVhbS9Mb2NhbE1lZGlhU3RyZWFtLmlkbAppbmRleCBlOTk0NGNmNGM5YmQ3ODVkOGNhMTY4 MTljNDFlM2EzNzMwZjAyNDg3Li41ZTc2OWFmZjg4Y2NhOThiMDBhNzU4YTM5YjcyODAzOGQ1NWIw YzkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL0xvY2Fs TWVkaWFTdHJlYW0uaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0v TG9jYWxNZWRpYVN0cmVhbS5pZGwKQEAgLTI2LDYgKzI2LDcgQEAgbW9kdWxlIGNvcmUgewogCiAg ICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29uZGl0aW9uYWw9TUVESUFfU1RSRUFNLAorICAgICAg ICBFdmVudFRhcmdldCwKICAgICAgICAgSlNHZW5lcmF0ZVRvTmF0aXZlT2JqZWN0LAogICAgICAg ICBKU0dlbmVyYXRlVG9KU09iamVjdAogICAgIF0gTG9jYWxNZWRpYVN0cmVhbSA6IE1lZGlhU3Ry ZWFtIHsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCAwOGUyNTU1MTIxNzE5OTYwZTBmOTM0ZGJkZmEzODk4MTBmMWY2OGVjLi4y Njg1NTQxY2NiYjVlNzE2NTdhZDRmNzMwNWFiZGQ5OTIyYWFjMjA3IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMTItMDUtMTUgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdvb2dsZS5jb20+ CisKKyAgICAgICAgTWVkaWFTdHJlYW0gQVBJOiBTZXR0aW5nIG9uZW5kZWQgb24gYSBMb2NhbE1l ZGlhU3RyZWFtIHRyaWdnZXJzIGFuIGFzc2VydGlvbiBpbiBWOAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODY0NTkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbWVkaWFzdHJlYW0vTG9jYWxNZWRp YVN0cmVhbS1vbmVuZGVkLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9tZWRp YXN0cmVhbS9Mb2NhbE1lZGlhU3RyZWFtLW9uZW5kZWQuaHRtbDogQWRkZWQuCisKIDIwMTItMDUt MTUgIE1pY2hhZWwgQnLDvG5pbmcgIDxtaWNoYWVsLmJydW5pbmdAbm9raWEuY29tPgogCiAgICAg ICAgIFtRdF1bV0syXSBodHRwL3Rlc3RzL25hdmlnYXRpb24vaHR0cHMtaW4tcGFnZS1jYWNoZS5o dG1sIGZhaWxzIHdpdGggdGltZW91dApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRp YXN0cmVhbS9Mb2NhbE1lZGlhU3RyZWFtLW9uZW5kZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9tZWRpYXN0cmVhbS9Mb2NhbE1lZGlhU3RyZWFtLW9uZW5kZWQtZXhwZWN0ZWQudHh0 Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjI0MTJhYzdjNDBjYjJlMWM5MWRmN2ZiYmIwM2FkMjM2Y2ZiNmY4ZWMKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL0xvY2FsTWVkaWFT dHJlYW0tb25lbmRlZC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMCBAQAorVGVzdHMgTG9jYWxN ZWRpYVN0cmVhbTo6b25lbmRlZCBjYWxsYmFjay4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2Vl IGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUi LgorCisKK1BBU1Mgc3RyZWFtRW5kZWQgd2FzIGNhbGxlZC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L21lZGlhc3RyZWFtL0xvY2FsTWVkaWFTdHJlYW0tb25lbmRlZC5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9tZWRpYXN0cmVhbS9Mb2NhbE1lZGlhU3RyZWFtLW9uZW5kZWQuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi45ODY0MTVhMDU2OWE4NDAzMmQ0NGM1MzdiOGFlNzhiNmM0MzRhYjE1Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9Mb2NhbE1lZGlhU3RyZWFtLW9u ZW5kZWQuaHRtbApAQCAtMCwwICsxLDUwIEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lF VEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0 IiBocmVmPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBzcmM9 Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eT4KKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8 c2NyaXB0PgorZGVzY3JpcHRpb24oIlRlc3RzIExvY2FsTWVkaWFTdHJlYW06Om9uZW5kZWQgY2Fs bGJhY2suIik7CisKK2Z1bmN0aW9uIGVycm9yKCkgeworICAgIHRlc3RGYWlsZWQoJ1N0cmVhbSBn ZW5lcmF0aW9uIGZhaWxlZC4nKTsKKyAgICBmaW5pc2hKU1Rlc3QoKTsKK30KKworZnVuY3Rpb24g Z2V0VXNlck1lZGlhKGRpY3Rpb25hcnksIGNhbGxiYWNrKSB7CisgICAgdHJ5IHsKKyAgICAgICAg bmF2aWdhdG9yLndlYmtpdEdldFVzZXJNZWRpYShkaWN0aW9uYXJ5LCBjYWxsYmFjaywgZXJyb3Ip OworICAgIH0gY2F0Y2ggKGUpIHsKKyAgICAgICAgdGVzdEZhaWxlZCgnd2Via2l0R2V0VXNlck1l ZGlhIHRocmV3IGV4Y2VwdGlvbiA6JyArIGUpOworICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAg ICB9Cit9CisKK2Z1bmN0aW9uIHN0cmVhbUVuZGVkKCkgeworICAgIHRlc3RQYXNzZWQoJ3N0cmVh bUVuZGVkIHdhcyBjYWxsZWQuJyk7CisgICAgZmluaXNoSlNUZXN0KCk7Cit9CisKK2Z1bmN0aW9u IGdvdFN0cmVhbShzKSB7CisgICAgc3RyZWFtID0gczsKKyAgICB0cnkgeworICAgICAgICBzdHJl YW0ub25lbmRlZCA9IHN0cmVhbUVuZGVkOworICAgICAgICBzdHJlYW0uc3RvcCgpOworICAgIH0g Y2F0Y2ggKGUpIHsKKyAgICAgICAgdGVzdEZhaWxlZCgnTG9jYWxNZWRpYVN0cmVhbSB0aHJldyBl eGNlcHRpb24gOicgKyBlKTsKKyAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgfQorfQorCitn ZXRVc2VyTWVkaWEoe2F1ZGlvOnRydWUsIHZpZGVvOnRydWV9LCBnb3RTdHJlYW0pOworCit3aW5k b3cuanNUZXN0SXNBc3luYyA9IHRydWU7Cit3aW5kb3cuc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1 ZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3Qu anMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=