<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>86456</bug_id>
          
          <creation_ts>2012-05-15 02:36:58 -0700</creation_ts>
          <short_desc>[EFL] WebKit style should apply to all ewk files but public headers</short_desc>
          <delta_ts>2012-05-16 05:25:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit EFL</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>84572</dependson>
    
    <dependson>85178</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Thiago Marcos P. Santos">tmpsantos</reporter>
          <assigned_to name="Thiago Marcos P. Santos">tmpsantos</assigned_to>
          <cc>g.czajkowski</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>lucas.de.marchi</cc>
    
    <cc>rakuco</cc>
    
    <cc>t.morawski</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>623838</commentid>
    <comment_count>0</comment_count>
    <who name="Thiago Marcos P. Santos">tmpsantos</who>
    <bug_when>2012-05-15 02:36:58 -0700</bug_when>
    <thetext>My preliminary investigation tells that we need to update the port specific rules on checker.py and move the public headers to another folder.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>624468</commentid>
    <comment_count>1</comment_count>
    <who name="Raphael Kubo da Costa (:rakuco)">rakuco</who>
    <bug_when>2012-05-15 13:20:20 -0700</bug_when>
    <thetext>Or just add enough logic to the checker to skip some style checks for public headers?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>624612</commentid>
    <comment_count>2</comment_count>
    <who name="Thiago Marcos P. Santos">tmpsantos</who>
    <bug_when>2012-05-15 14:59:42 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Or just add enough logic to the checker to skip some style checks for public headers?

IMO it would need regex support when matching files. I&apos;m going to evaluate tomorrow to check if it&apos;s not overkill.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>625297</commentid>
    <comment_count>3</comment_count>
    <who name="Thiago Marcos P. Santos">tmpsantos</who>
    <bug_when>2012-05-16 05:25:42 -0700</bug_when>
    <thetext>&quot;readability/naming&quot; cannot be enabled for ewk/. Even if enable only for the .cpp files, it will still complain about the function names. IMO not much can be done.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>