86429 2012-05-14 19:12:08 -0700 RenderLayer::repaintRectIncludingDescendants shouldn't include repaint rects of composited descendants 2012-05-14 23:11:37 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton eric simon.fraser webkit.review.bot oldest_to_newest 623568 0 thorton 2012-05-14 19:12:08 -0700 As it stands, we can end up unioning a rect with a page-relative origin and a rect with a 0,0 origin (the compositing layer), creating huge repaint rects with some content. Composited descendants don't need to be factored in here (the only use of repaintRectIncludingDescendants is in scrollContentsFathPath, and composited layers won't need to be invalidated manually there). This is a significant scrolling performance win on some pages. <rdar://problem/11445132> 623578 1 141845 thorton 2012-05-14 19:56:46 -0700 Created attachment 141845 patch 623676 2 thorton 2012-05-14 23:11:37 -0700 http://trac.webkit.org/changeset/117032 141845 2012-05-14 19:56:46 -0700 2012-05-14 20:48:41 -0700 patch comp.diff text/plain 3561 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyODNiMzIyLi43NTJhOTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDUtMTQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUmVuZGVyTGF5ZXI6OnJlcGFpbnRSZWN0SW5jbHVkaW5nRGVzY2VuZGFudHMgc2hv dWxkbid0IGluY2x1ZGUgcmVwYWludCByZWN0cyBvZiBjb21wb3NpdGVkIGRlc2NlbmRhbnRzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjQyOQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMTE0NDUxMzI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIHJlcGFpbnRSZWN0SW5jbHVkaW5nRGVzY2Vu ZGFudHMgdG8gbm90IGluY2x1ZGUgcmVwYWludCByZWN0cyBmb3IgY29tcG9zaXRlZCBjaGlsZCBs YXllcnMsCisgICAgICAgIGFuZCByZW5hbWUgdGhlIGZ1bmN0aW9uIHRvIG1ha2UgaXQgbW9yZSBj bGVhciB0aGF0IHRoYXQncyB3aGF0IGl0IGRvZXMgbm93LgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgc2Nyb2xsaW5nIHBlcmZvcm1hbmNlIG9wdGltaXphdGlvbi4KKworICAgICAgICAqIHBhZ2Uv RnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6c2Nyb2xsQ29udGVu dHNGYXN0UGF0aCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpyZXBhaW50UmVjdEluY2x1ZGluZ05vbkNvbXBvc2l0 aW5nRGVzY2VuZGFudHMpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5oOgorICAg ICAgICAoUmVuZGVyTGF5ZXIpOgorCiAyMDEyLTA1LTE0ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5y ZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCBy MTE2OTY5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIv U291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGE5Y2MyMjAuLmU0NGUzYzYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTE0ODksNyArMTQ4OSw3IEBAIGJvb2wg RnJhbWVWaWV3OjpzY3JvbGxDb250ZW50c0Zhc3RQYXRoKGNvbnN0IEludFNpemUmIHNjcm9sbERl bHRhLCBjb25zdCBJbnRSZWN0CiAgICAgICAgIGlmIChyZW5kZXJCb3gtPmlzQ29tcG9zaXRlZCgp KQogICAgICAgICAgICAgY29udGludWU7CiAjZW5kaWYKLSAgICAgICAgSW50UmVjdCB1cGRhdGVS ZWN0ID0gcGl4ZWxTbmFwcGVkSW50UmVjdChyZW5kZXJCb3gtPmxheWVyKCktPnJlcGFpbnRSZWN0 SW5jbHVkaW5nRGVzY2VuZGFudHMoKSk7CisgICAgICAgIEludFJlY3QgdXBkYXRlUmVjdCA9IHBp eGVsU25hcHBlZEludFJlY3QocmVuZGVyQm94LT5sYXllcigpLT5yZXBhaW50UmVjdEluY2x1ZGlu Z05vbkNvbXBvc2l0aW5nRGVzY2VuZGFudHMoKSk7CiAgICAgICAgIHVwZGF0ZVJlY3QgPSBjb250 ZW50c1RvUm9vdFZpZXcodXBkYXRlUmVjdCk7CiAgICAgICAgIGlmICghaXNDb21wb3NpdGVkQ29u dGVudExheWVyICYmIGNsaXBzUmVwYWludHMoKSkKICAgICAgICAgICAgIHVwZGF0ZVJlY3QuaW50 ZXJzZWN0KHJlY3RUb1Njcm9sbCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy LmNwcAppbmRleCBkN2Q4M2UwLi41MTNhYjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllci5jcHAKQEAgLTQ1MiwxMSArNDUyLDE2IEBAIHZvaWQgUmVuZGVyTGF5ZXI6OnVw ZGF0ZUxheWVyUG9zaXRpb25zKExheW91dFBvaW50KiBvZmZzZXRGcm9tUm9vdCwgVXBkYXRlTGF5 ZXJQCiAgICAgICAgICpvZmZzZXRGcm9tUm9vdCA9IG9sZE9mZnNldEZyb21Sb290OwogfQogCi1M YXlvdXRSZWN0IFJlbmRlckxheWVyOjpyZXBhaW50UmVjdEluY2x1ZGluZ0Rlc2NlbmRhbnRzKCkg Y29uc3QKK0xheW91dFJlY3QgUmVuZGVyTGF5ZXI6OnJlcGFpbnRSZWN0SW5jbHVkaW5nTm9uQ29t cG9zaXRpbmdEZXNjZW5kYW50cygpIGNvbnN0CiB7CiAgICAgTGF5b3V0UmVjdCByZXBhaW50UmVj dCA9IG1fcmVwYWludFJlY3Q7Ci0gICAgZm9yIChSZW5kZXJMYXllciogY2hpbGQgPSBmaXJzdENo aWxkKCk7IGNoaWxkOyBjaGlsZCA9IGNoaWxkLT5uZXh0U2libGluZygpKQotICAgICAgICByZXBh aW50UmVjdC51bml0ZShjaGlsZC0+cmVwYWludFJlY3RJbmNsdWRpbmdEZXNjZW5kYW50cygpKTsK KyAgICBmb3IgKFJlbmRlckxheWVyKiBjaGlsZCA9IGZpcnN0Q2hpbGQoKTsgY2hpbGQ7IGNoaWxk ID0gY2hpbGQtPm5leHRTaWJsaW5nKCkpIHsKKyAgICAgICAgLy8gRG9uJ3QgaW5jbHVkZSByZXBh aW50IHJlY3RzIGZvciBjb21wb3NpdGVkIGNoaWxkIGxheWVyczsgdGhleSB3aWxsIHBhaW50IHRo ZW1zZWx2ZXMgYW5kIGhhdmUgYSBkaWZmZXJlbnQgb3JpZ2luLgorICAgICAgICBpZiAoY2hpbGQt PmlzQ29tcG9zaXRlZCgpKQorICAgICAgICAgICAgY29udGludWU7CisKKyAgICAgICAgcmVwYWlu dFJlY3QudW5pdGUoY2hpbGQtPnJlcGFpbnRSZWN0SW5jbHVkaW5nTm9uQ29tcG9zaXRpbmdEZXNj ZW5kYW50cygpKTsKKyAgICB9CiAgICAgcmV0dXJuIHJlcGFpbnRSZWN0OwogfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuaCBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCmluZGV4IGViMzZjMzQuLmQ0M2EwNDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5oCkBAIC01MTEsNyArNTExLDcgQEAgcHVi bGljOgogCiAgICAgLy8gUmV0dXJuIGEgY2FjaGVkIHJlcGFpbnQgcmVjdCwgY29tcHV0ZWQgcmVs YXRpdmUgdG8gdGhlIGxheWVyIHJlbmRlcmVyJ3MgY29udGFpbmVyRm9yUmVwYWludC4KICAgICBM YXlvdXRSZWN0IHJlcGFpbnRSZWN0KCkgY29uc3QgeyByZXR1cm4gbV9yZXBhaW50UmVjdDsgfQot ICAgIExheW91dFJlY3QgcmVwYWludFJlY3RJbmNsdWRpbmdEZXNjZW5kYW50cygpIGNvbnN0Owor ICAgIExheW91dFJlY3QgcmVwYWludFJlY3RJbmNsdWRpbmdOb25Db21wb3NpdGluZ0Rlc2NlbmRh bnRzKCkgY29uc3Q7CiAKICAgICBlbnVtIFVwZGF0ZUxheWVyUG9zaXRpb25zQWZ0ZXJTY3JvbGxG bGFnIHsKICAgICAgICAgTm9GbGFnID0gMCwK