86420 2012-05-14 17:51:11 -0700 ScrollbarPainter should support expansionTransitionProgress 2012-05-14 18:06:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.7 RESOLVED FIXED InRadar P2 Normal --- 1 bdakin bdakin bdakin oldest_to_newest 623514 0 bdakin 2012-05-14 17:51:11 -0700 ScrollAnimatorMac should handle animating expansionTransitionProgress for ScrollbarPainter. <rdar://problem/11448047> 623516 1 141830 bdakin 2012-05-14 17:53:56 -0700 Created attachment 141830 Patch 623528 2 bdakin 2012-05-14 18:06:20 -0700 Thanks Sam! http://trac.webkit.org/changeset/117021 141830 2012-05-14 17:53:56 -0700 2012-05-14 18:03:39 -0700 Patch for-review.txt text/plain 6326 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNzAyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA1LTE0ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODY0MjAKKyAgICAgICAgU2Nyb2xsYmFyUGFpbnRlciBzaG91bGQg c3VwcG9ydCBleHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3MKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBleHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3Mg d29ya3MgdGhlIHNhbWUgYXMgCisgICAgICAgIHVpU3RhdGVUcmFuc2l0aW9uUHJvZ3Jlc3MuIFRo aXMgY29kZSBqdXN0IGVjaG9lcyB0aGF0IGNvZGUsIGJ1dCBmb3IgCisgICAgICAgIGV4cGFuc2lv biBpbnN0ZWFkIG9mIHVpU3RhdGUuCisgICAgICAgICogcGxhdGZvcm0vbWFjL05TU2Nyb2xsZXJJ bXBEZXRhaWxzLmg6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFjLm1t OgorICAgICAgICAoc3VwcG9ydHNFeHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3MpOgorICAgICAg ICAoLVtXZWJTY3JvbGxiYXJQYXJ0QW5pbWF0aW9uIHNldEN1cnJlbnRQcm9ncmVzczpdKToKKyAg ICAgICAgKC1bV2ViU2Nyb2xsYmFyUGFpbnRlckRlbGVnYXRlIGNhbmNlbEFuaW1hdGlvbnNdKToK KyAgICAgICAgKC1bV2ViU2Nyb2xsYmFyUGFpbnRlckRlbGVnYXRlIHNjcm9sbGVySW1wOmFuaW1h dGVFeHBhbnNpb25UcmFuc2l0aW9uV2l0aER1cmF0aW9uOl0pOgorICAgICAgICAoLVtXZWJTY3Jv bGxiYXJQYWludGVyRGVsZWdhdGUgaW52YWxpZGF0ZV0pOgorCiAyMDEyLTA1LTE0ICBBbmR5IEVz dGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggUnVuTG9vcENGLmNwcCdzIGNv cHlyaWdodCBzdHJpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvTlNTY3Jv bGxlckltcERldGFpbHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t YWMvTlNTY3JvbGxlckltcERldGFpbHMuaAkocmV2aXNpb24gMTE2OTczKQorKysgU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbWFjL05TU2Nyb2xsZXJJbXBEZXRhaWxzLmgJKHdvcmtpbmcgY29weSkK QEAgLTY1LDYgKzY1LDcgQEAgQGludGVyZmFjZSBOU09iamVjdCAoU2Nyb2xsYmFyUGFpbnRlcikK IC0gKEJPT0wpaXNFeHBhbmRlZDsKIC0gKHZvaWQpc2V0RGVsZWdhdGU6KGlkKWRlbGVnYXRlOwog LSAodm9pZClzZXRVaVN0YXRlVHJhbnNpdGlvblByb2dyZXNzOihDR0Zsb2F0KXVpU3RhdGVUcmFu c2l0aW9uUHJvZ3Jlc3M7CistICh2b2lkKXNldEV4cGFuc2lvblRyYW5zaXRpb25Qcm9ncmVzczoo Q0dGbG9hdClleHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3M7CiAtIChCT09MKWlzSG9yaXpvbnRh bDsKIC0gKENHRmxvYXQpdHJhY2tXaWR0aDsKIC0gKENHRmxvYXQpdHJhY2tCb3hXaWR0aDsKQEAg LTc0LDYgKzc1LDcgQEAgQGludGVyZmFjZSBOU09iamVjdCAoU2Nyb2xsYmFyUGFpbnRlcikKIC0g KENHRmxvYXQpdHJhY2tFbmRJbnNldDsKIC0gKENHRmxvYXQpa25vYkVuZEluc2V0OwogLSAoQ0dG bG9hdCl1aVN0YXRlVHJhbnNpdGlvblByb2dyZXNzOworLSAoQ0dGbG9hdClleHBhbnNpb25UcmFu c2l0aW9uUHJvZ3Jlc3M7CiAtIChOU1JlY3QpcmVjdEZvclBhcnQ6KE5TU2Nyb2xsZXJQYXJ0KXBh cnRDb2RlOwogLSAodm9pZClkcmF3S25vYlNsb3RJblJlY3Q6KE5TUmVjdClzbG90UmVjdCBoaWdo bGlnaHQ6KEJPT0wpZmxhZyBhbHBoYTooQ0dGbG9hdClhbHBoYTsKIC0gKHZvaWQpZHJhd0tub2I7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9y TWFjLm1tCShyZXZpc2lvbiAxMTY5NzMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMv U2Nyb2xsQW5pbWF0b3JNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTUzLDYgKzUzLDEyIEBAIHN0 YXRpYyBib29sIHN1cHBvcnRzVUlTdGF0ZVRyYW5zaXRpb25Qcm8KICAgICByZXR1cm4gZ2xvYmFs U3VwcG9ydHNVSVN0YXRlVHJhbnNpdGlvblByb2dyZXNzOwogfQogCitzdGF0aWMgYm9vbCBzdXBw b3J0c0V4cGFuc2lvblRyYW5zaXRpb25Qcm9ncmVzcygpCit7CisgICAgc3RhdGljIGJvb2wgZ2xv YmFsU3VwcG9ydHNFeHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3MgPSBbTlNDbGFzc0Zyb21TdHJp bmcoQCJOU1Njcm9sbGVySW1wIikgaW5zdGFuY2VzUmVzcG9uZFRvU2VsZWN0b3I6QHNlbGVjdG9y KGV4cGFuc2lvblRyYW5zaXRpb25Qcm9ncmVzcyldOworICAgIHJldHVybiBnbG9iYWxTdXBwb3J0 c0V4cGFuc2lvblRyYW5zaXRpb25Qcm9ncmVzczsKK30KKwogc3RhdGljIFNjcm9sbGJhclRoZW1l TWFjKiBtYWNTY3JvbGxiYXJUaGVtZSgpCiB7CiAgICAgU2Nyb2xsYmFyVGhlbWUqIHNjcm9sbGJh clRoZW1lID0gU2Nyb2xsYmFyVGhlbWU6OnRoZW1lKCk7CkBAIC0yNzgsNyArMjg0LDggQEAgLSAo dm9pZClzY3JvbGxlckltcFBhaXI6KGlkKXNjcm9sbGVySW1wUAogZW51bSBGZWF0dXJlVG9Bbmlt YXRlIHsKICAgICBUaHVtYkFscGhhLAogICAgIFRyYWNrQWxwaGEsCi0gICAgVUlTdGF0ZVRyYW5z aXRpb24KKyAgICBVSVN0YXRlVHJhbnNpdGlvbiwKKyAgICBFeHBhbnNpb25UcmFuc2l0aW9uCiB9 OwogCiBAaW50ZXJmYWNlIFdlYlNjcm9sbGJhclBhcnRBbmltYXRpb24gOiBOU0FuaW1hdGlvbgpA QCAtMzUxLDYgKzM1OCw5IEBAIC0gKHZvaWQpc2V0Q3VycmVudFByb2dyZXNzOihOU0FuaW1hdGlv blAKICAgICBjYXNlIFVJU3RhdGVUcmFuc2l0aW9uOgogICAgICAgICBbX3Njcm9sbGJhclBhaW50 ZXIuZ2V0KCkgc2V0VWlTdGF0ZVRyYW5zaXRpb25Qcm9ncmVzczpjdXJyZW50VmFsdWVdOwogICAg ICAgICBicmVhazsKKyAgICBjYXNlIEV4cGFuc2lvblRyYW5zaXRpb246CisgICAgICAgIFtfc2Ny b2xsYmFyUGFpbnRlci5nZXQoKSBzZXRFeHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3M6Y3VycmVu dFZhbHVlXTsKKyAgICAgICAgYnJlYWs7CiAgICAgfQogCiAgICAgX3Njcm9sbGJhci0+aW52YWxp ZGF0ZSgpOwpAQCAtMzczLDYgKzM4Myw3IEBAIEBpbnRlcmZhY2UgV2ViU2Nyb2xsYmFyUGFpbnRl ckRlbGVnYXRlIDoKICAgICBSZXRhaW5QdHI8V2ViU2Nyb2xsYmFyUGFydEFuaW1hdGlvbj4gX2tu b2JBbHBoYUFuaW1hdGlvbjsKICAgICBSZXRhaW5QdHI8V2ViU2Nyb2xsYmFyUGFydEFuaW1hdGlv bj4gX3RyYWNrQWxwaGFBbmltYXRpb247CiAgICAgUmV0YWluUHRyPFdlYlNjcm9sbGJhclBhcnRB bmltYXRpb24+IF91aVN0YXRlVHJhbnNpdGlvbkFuaW1hdGlvbjsKKyAgICBSZXRhaW5QdHI8V2Vi U2Nyb2xsYmFyUGFydEFuaW1hdGlvbj4gX2V4cGFuc2lvblRyYW5zaXRpb25BbmltYXRpb247CiB9 CiAtIChpZClpbml0V2l0aFNjcm9sbGJhcjooV2ViQ29yZTo6U2Nyb2xsYmFyKilzY3JvbGxiYXI7 CiAtICh2b2lkKWNhbmNlbEFuaW1hdGlvbnM7CkBAIC0zOTYsNiArNDA3LDcgQEAgLSAodm9pZClj YW5jZWxBbmltYXRpb25zCiAgICAgW19rbm9iQWxwaGFBbmltYXRpb24uZ2V0KCkgc3RvcEFuaW1h dGlvbl07CiAgICAgW190cmFja0FscGhhQW5pbWF0aW9uLmdldCgpIHN0b3BBbmltYXRpb25dOwog ICAgIFtfdWlTdGF0ZVRyYW5zaXRpb25BbmltYXRpb24uZ2V0KCkgc3RvcEFuaW1hdGlvbl07Cisg ICAgW19leHBhbnNpb25UcmFuc2l0aW9uQW5pbWF0aW9uLmdldCgpIHN0b3BBbmltYXRpb25dOwog ICAgIEVORF9CTE9DS19PQkpDX0VYQ0VQVElPTlM7CiB9CiAKQEAgLTUzMCw2ICs1NDIsMzYgQEAg LSAodm9pZClzY3JvbGxlckltcDooaWQpc2Nyb2xsZXJJbXAgYW5pbQogICAgIFtfdWlTdGF0ZVRy YW5zaXRpb25BbmltYXRpb24uZ2V0KCkgc3RhcnRBbmltYXRpb25dOwogfQogCistICh2b2lkKXNj cm9sbGVySW1wOihpZClzY3JvbGxlckltcCBhbmltYXRlRXhwYW5zaW9uVHJhbnNpdGlvbldpdGhE dXJhdGlvbjooTlNUaW1lSW50ZXJ2YWwpZHVyYXRpb24KK3sKKyAgICBpZiAoIV9zY3JvbGxiYXIp CisgICAgICAgIHJldHVybjsKKworICAgIGlmICghc3VwcG9ydHNFeHBhbnNpb25UcmFuc2l0aW9u UHJvZ3Jlc3MoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgQVNTRVJUKHNjcm9sbGVySW1wID09 IHNjcm9sbGJhclBhaW50ZXJGb3JTY3JvbGxiYXIoX3Njcm9sbGJhcikpOworCisgICAgU2Nyb2xs YmFyUGFpbnRlciBzY3JvbGxiYXJQYWludGVyID0gKFNjcm9sbGJhclBhaW50ZXIpc2Nyb2xsZXJJ bXA7CisKKyAgICAvLyBFeHBhbnNpb25UcmFuc2l0aW9uIGFsd2F5cyBhbmltYXRlcyB0byAxLiBJ biBjYXNlIGFuIGFuaW1hdGlvbiBpcyBpbiBwcm9ncmVzcyB0aGlzIGF2b2lkcyBhIGhhcmQgdHJh bnNpdGlvbi4KKyAgICBbc2Nyb2xsYmFyUGFpbnRlciBzZXRFeHBhbnNpb25UcmFuc2l0aW9uUHJv Z3Jlc3M6MSAtIFtzY3JvbGxlckltcCBleHBhbnNpb25UcmFuc2l0aW9uUHJvZ3Jlc3NdXTsKKwor ICAgIGlmICghX2V4cGFuc2lvblRyYW5zaXRpb25BbmltYXRpb24pIHsKKyAgICAgICAgX2V4cGFu c2lvblRyYW5zaXRpb25BbmltYXRpb24uYWRvcHROUyhbW1dlYlNjcm9sbGJhclBhcnRBbmltYXRp b24gYWxsb2NdIGluaXRXaXRoU2Nyb2xsYmFyOl9zY3JvbGxiYXIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBmZWF0dXJlVG9BbmltYXRlOkV4cGFuc2lvblRyYW5zaXRpb24KKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGFuaW1hdGVGcm9tOltzY3JvbGxiYXJQYWludGVyIGV4cGFuc2lv blRyYW5zaXRpb25Qcm9ncmVzc10KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYW5p bWF0ZVRvOjEuMAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZHVyYXRpb246ZHVy YXRpb25dKTsKKyAgICB9IGVsc2UgeworICAgICAgICAvLyBJZiB3ZSBkb24ndCBuZWVkIHRvIGlu aXRpYWxpemUgdGhlIGFuaW1hdGlvbiwganVzdCByZXNldCB0aGUgdmFsdWVzIGluIGNhc2UgdGhl eSBoYXZlIGNoYW5nZWQuCisgICAgICAgIFtfZXhwYW5zaW9uVHJhbnNpdGlvbkFuaW1hdGlvbi5n ZXQoKSBzZXRTdGFydFZhbHVlOltzY3JvbGxiYXJQYWludGVyIHVpU3RhdGVUcmFuc2l0aW9uUHJv Z3Jlc3NdXTsKKyAgICAgICAgW19leHBhbnNpb25UcmFuc2l0aW9uQW5pbWF0aW9uLmdldCgpIHNl dEVuZFZhbHVlOjEuMF07CisgICAgICAgIFtfZXhwYW5zaW9uVHJhbnNpdGlvbkFuaW1hdGlvbi5n ZXQoKSBzZXREdXJhdGlvbjpkdXJhdGlvbl07CisgICAgfQorICAgIFtfZXhwYW5zaW9uVHJhbnNp dGlvbkFuaW1hdGlvbi5nZXQoKSBzdGFydEFuaW1hdGlvbl07Cit9CisKIC0gKHZvaWQpc2Nyb2xs ZXJJbXA6KGlkKXNjcm9sbGVySW1wIG92ZXJsYXlTY3JvbGxlclN0YXRlQ2hhbmdlZFRvOihOU1VJ bnRlZ2VyKW5ld092ZXJsYXlTY3JvbGxlclN0YXRlCiB7CiAgICAgVU5VU0VEX1BBUkFNKHNjcm9s bGVySW1wKTsKQEAgLTU0Myw2ICs1ODUsNyBAQCAtICh2b2lkKWludmFsaWRhdGUKICAgICBbX2tu b2JBbHBoYUFuaW1hdGlvbi5nZXQoKSBpbnZhbGlkYXRlXTsKICAgICBbX3RyYWNrQWxwaGFBbmlt YXRpb24uZ2V0KCkgaW52YWxpZGF0ZV07CiAgICAgW191aVN0YXRlVHJhbnNpdGlvbkFuaW1hdGlv bi5nZXQoKSBpbnZhbGlkYXRlXTsKKyAgICBbX2V4cGFuc2lvblRyYW5zaXRpb25BbmltYXRpb24u Z2V0KCkgaW52YWxpZGF0ZV07CiAgICAgRU5EX0JMT0NLX09CSkNfRVhDRVBUSU9OUzsKIH0KIAo=