86417 2012-05-14 17:27:21 -0700 check-webkit-style complains about anonymous blocks in C code 2012-05-14 17:30:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All NEW P2 Normal --- 1 aestes webkit-unassigned eric oldest_to_newest 623487 0 aestes 2012-05-14 17:27:21 -0700 When using an anonymous block in C code, such as: dispatch_async(queue, ^{ // anonymous block }); check-webkit-style complains: "Missing space before { [whitespace/braces] [5]" As far as I know our style guide doesn't cover blocks specifically, but this is a common style and should probably be allowed. 623489 1 aestes 2012-05-14 17:28:09 -0700 The patch in <https://bugs.webkit.org/show_bug.cgi?id=86411> has an example of such a block. 623492 2 levin 2012-05-14 17:30:58 -0700 Should be too hard to fix the regex if it bothers you: http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py&exact_package=chromium&q=%22Missing%20space%20before%20%7B%22&l=1911 and add a corresponding test here: http://code.google.com/searchframe#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py&exact_package=chromium&q=%22Missing%20space%20before%20%7B%22&l=1633