86408 2012-05-14 16:18:48 -0700 Increase Debug Logging in MarkStack::validate() 2012-05-21 15:22:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 623410 0 msaboff 2012-05-14 16:18:48 -0700 Improve the diagnostic information in MarkStack::validate() beyond crashing. 623419 1 141806 msaboff 2012-05-14 16:23:49 -0700 Created attachment 141806 Patch 623423 2 141806 fpizlo 2012-05-14 16:29:00 -0700 Comment on attachment 141806 Patch rs=me, but change to dataLog(). 623442 3 msaboff 2012-05-14 16:44:58 -0700 Committed r117013: <http://trac.webkit.org/changeset/117013> 629585 4 141806 eric 2012-05-21 15:22:14 -0700 Comment on attachment 141806 Patch Cleared review? from attachment 141806 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 141806 2012-05-14 16:23:49 -0700 2012-05-21 15:22:13 -0700 Patch 86408.patch text/plain 2395 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE3MDExKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA1LTE0ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIEluY3JlYXNlIERlYnVnIExvZ2dpbmcgaW4gTWFya1N0YWNrOjp2YWxpZGF0ZSgpCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjQwOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHNvbWUgZGVz Y3JpcHRpdmUgZnByaW50ZidzIGZvciB0aGUgY29uZGl0aW9ucyBhbmQKKyAgICAgICAgdmFsdWVz IHdoZW4gYSBjZWxsIHZhbGlkYXRpb24gZmFpbHMuOndxCisKKyAgICAgICAgKiBoZWFwL01hcmtT dGFjay5jcHA6CisgICAgICAgIChKU0M6Ok1hcmtTdGFjazo6dmFsaWRhdGUpOgorCiAyMDEyLTA1 LTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLiBGaXggbWFrZSBkaXN0Y2hlY2suCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9NYXJrU3RhY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL01hcmtTdGFjay5jcHAJKHJldmlzaW9uIDExNjk1OCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9oZWFwL01hcmtTdGFjay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzNSwxNiAr NTM1LDI5IEBAIHZvaWQgU2xvdFZpc2l0b3I6OmZpbmFsaXplVW5jb25kaXRpb25hbEYKICNpZiBF TkFCTEUoR0NfVkFMSURBVElPTikKIHZvaWQgTWFya1N0YWNrOjp2YWxpZGF0ZShKU0NlbGwqIGNl bGwpCiB7Ci0gICAgaWYgKCFjZWxsKQorICAgIGlmICghY2VsbCkgeworICAgICAgICBmcHJpbnRm KHN0ZGVyciwgImNlbGwgaXMgTlVMTFxuIik7CiAgICAgICAgIENSQVNIKCk7CisgICAgfQogCi0g ICAgaWYgKCFjZWxsLT5zdHJ1Y3R1cmUoKSkKKyAgICBpZiAoIWNlbGwtPnN0cnVjdHVyZSgpKSB7 CisgICAgICAgIGZwcmludGYoc3RkZXJyLCAiY2VsbCBhdCAlcCBoYXMgYSBudWxsIHN0cnVjdHVy ZVxuIiAsIGNlbGwpOwogICAgICAgICBDUkFTSCgpOworICAgIH0KIAogICAgIC8vIEJvdGggdGhl IGNlbGwncyBzdHJ1Y3R1cmUsIGFuZCB0aGUgY2VsbCdzIHN0cnVjdHVyZSdzIHN0cnVjdHVyZSBz aG91bGQgYmUgdGhlIFN0cnVjdHVyZSBTdHJ1Y3R1cmUuCiAgICAgLy8gSSBoYXRlIHRoaXMgc2Vu dGVuY2UuCi0gICAgaWYgKGNlbGwtPnN0cnVjdHVyZSgpLT5zdHJ1Y3R1cmUoKS0+SlNDZWxsOjpj bGFzc0luZm8oKSAhPSBjZWxsLT5zdHJ1Y3R1cmUoKS0+SlNDZWxsOjpjbGFzc0luZm8oKSkKKyAg ICBpZiAoY2VsbC0+c3RydWN0dXJlKCktPnN0cnVjdHVyZSgpLT5KU0NlbGw6OmNsYXNzSW5mbygp ICE9IGNlbGwtPnN0cnVjdHVyZSgpLT5KU0NlbGw6OmNsYXNzSW5mbygpKSB7CisgICAgICAgIGNv bnN0IGNoYXIqIHBhcmVudENsYXNzTmFtZSA9IDA7CisgICAgICAgIGNvbnN0IGNoYXIqIG91ckNs YXNzTmFtZSA9IDA7CisgICAgICAgIGlmIChjZWxsLT5zdHJ1Y3R1cmUoKS0+c3RydWN0dXJlKCkg JiYgY2VsbC0+c3RydWN0dXJlKCktPnN0cnVjdHVyZSgpLT5KU0NlbGw6OmNsYXNzSW5mbygpKQor ICAgICAgICAgICAgcGFyZW50Q2xhc3NOYW1lID0gY2VsbC0+c3RydWN0dXJlKCktPnN0cnVjdHVy ZSgpLT5KU0NlbGw6OmNsYXNzSW5mbygpLT5jbGFzc05hbWU7CisgICAgICAgIGlmIChjZWxsLT5z dHJ1Y3R1cmUoKS0+SlNDZWxsOjpjbGFzc0luZm8oKSkKKyAgICAgICAgICAgIG91ckNsYXNzTmFt ZSA9IGNlbGwtPnN0cnVjdHVyZSgpLT5KU0NlbGw6OmNsYXNzSW5mbygpLT5jbGFzc05hbWU7Cisg ICAgICAgIGZwcmludGYoc3RkZXJyLCAicGFyZW50IHN0cnVjdHVyZSAoJXAgPCVzPikgb2YgY2Vs bCBhdCAlcCBkb2Vzbid0IG1hdGNoIGNlbGwncyBzdHJ1Y3R1cmUgKCVwIDwlcz4pXG4iLAorICAg ICAgICAgICAgICAgIGNlbGwtPnN0cnVjdHVyZSgpLT5zdHJ1Y3R1cmUoKSwgcGFyZW50Q2xhc3NO YW1lLCBjZWxsLCBjZWxsLT5zdHJ1Y3R1cmUoKSwgb3VyQ2xhc3NOYW1lKTsKICAgICAgICAgQ1JB U0goKTsKKyAgICB9CiB9CiAjZWxzZQogdm9pZCBNYXJrU3RhY2s6OnZhbGlkYXRlKEpTQ2VsbCop Cg==