86399 2012-05-14 13:59:41 -0700 Convert CSS and Parser tests to runs/s tests 2012-05-14 14:19:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 rniwa rniwa abarth eric kling menard ojan paroga tony oldest_to_newest 623302 0 rniwa 2012-05-14 13:59:41 -0700 Convert CSS and Parser tests to runs/s tests 623303 1 141785 rniwa 2012-05-14 14:00:39 -0700 Created attachment 141785 Converted CSS and Parser tests to use runPerSecond 623306 2 eric 2012-05-14 14:05:47 -0700 I don't understand what this change does. Could you please explain more in teh ChangeLOg? 623314 3 141785 ojan 2012-05-14 14:10:33 -0700 Comment on attachment 141785 Converted CSS and Parser tests to use runPerSecond r=me assuming you add a more descriptive changelog. IMO, reducing bot cycle time is the secondary benefit. The other advantage is that runPerSecond is less likely to degrade overtime as we improve performance on the test. 623320 4 rniwa 2012-05-14 14:13:40 -0700 (In reply to comment #2) > I don't understand what this change does. Could you please explain more in teh ChangeLOg? Sorry I forgot to mention that this is a follow up to http://trac.webkit.org/changeset/116916. Basically we want to measure performance in runs/s (i.e. function calls per second) instead of ms so that when WebKit gets faster, we can still measure it reliably (e.g. granularity of Date.now() appears to be around 10-50ms) without having to modify tests to make them artificially slower. 623325 5 rniwa 2012-05-14 14:19:00 -0700 Committed r117001: <http://trac.webkit.org/changeset/117001> 141785 2012-05-14 14:00:39 -0700 2012-05-14 14:10:32 -0700 Converted CSS and Parser tests to use runPerSecond bug-86399-20120514140135.patch text/plain 5137 rniwa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTY5OTUpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA1LTE0ICBS eW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIENvbnZlcnQgQ1NTIGFu ZCBQYXJzZXIgdGVzdHMgdG8gcnVucy9zIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjM5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVzZSBydW5QZXJTZWNvbmQgaW5zdGVhZCBvZiBydW4uIFRo aXMgc2hvdWxkIHJlZHVjZSBwZXJmLiBib3RzIGN5Y2xlIHRpbWUuCisKKyAgICAgICAgKiBDU1Mv Q1NTUHJvcGVydHlTZXR0ZXJHZXR0ZXIuaHRtbDoKKyAgICAgICAgKiBDU1MvQ1NTUHJvcGVydHlV cGRhdGVWYWx1ZS5odG1sOgorICAgICAgICAqIFBhcnNlci9jc3MtcGFyc2VyLXl1aS5odG1sOgor ICAgICAgICAqIFBhcnNlci9zaW1wbGUtdXJsLmh0bWw6CisgICAgICAgICogUGFyc2VyL3Rpbnkt aW5uZXJIVE1MLmh0bWw6CisgICAgICAgICogUGFyc2VyL3VybC1wYXJzZXIuaHRtbDoKKyAgICAg ICAgKiBQYXJzZXIveG1sLXBhcnNlci5odG1sOgorCiAyMDEyLTA1LTE0ICBEYW4gQmVybnN0ZWlu ICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgbGluZSBsYXlvdXQgcGVyZm9ybWFu Y2UgdGVzdApJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9DU1MvQ1NTUHJvcGVydHlTZXR0ZXJHZXR0 ZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3RzL0NTUy9DU1NQcm9wZXJ0eVNl dHRlckdldHRlci5odG1sCShyZXZpc2lvbiAxMTY5OTApCisrKyBQZXJmb3JtYW5jZVRlc3RzL0NT Uy9DU1NQcm9wZXJ0eVNldHRlckdldHRlci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC03MSwxMiAr NzEsMTIgQEAgdmFyIHByb3BlcnRpZXMgPSB7CiAnd2Via2l0VHJhbnNmb3JtJyA6ICdzY2FsZTNk KDAuNSwgMC41LCAwLjUpJywKICd3b3JkU3BhY2luZycgOiAnNDBweCcsCiB9OwotUGVyZlRlc3RS dW5uZXIucnVuKGZ1bmN0aW9uKCkgeworUGVyZlRlc3RSdW5uZXIucnVuUGVyU2Vjb25kKHtydW46 ZnVuY3Rpb24oKSB7CiAgICAgZm9yIChrZXkgaW4gcHJvcGVydGllcykgewogICAgICAgICB2YXIg dmFsdWUgPSBkaXYuc3R5bGVba2V5XTsKICAgICAgICAgZGl2LnN0eWxlW2tleV0gPSAiIjsKICAg ICAgICAgZGl2LnN0eWxlW2tleV0gPSBwcm9wZXJ0aWVzW2tleV07CiAgICAgfQotfSwgNTAwMCk7 Cit9fSk7CiA8L3NjcmlwdD4KIDwvaHRtbD4KSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ1NTL0NT U1Byb3BlcnR5VXBkYXRlVmFsdWUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQZXJmb3JtYW5jZVRlc3Rz L0NTUy9DU1NQcm9wZXJ0eVVwZGF0ZVZhbHVlLmh0bWwJKHJldmlzaW9uIDExNjk5MCkKKysrIFBl cmZvcm1hbmNlVGVzdHMvQ1NTL0NTU1Byb3BlcnR5VXBkYXRlVmFsdWUuaHRtbAkod29ya2luZyBj b3B5KQpAQCAtNzIsOSArNzIsOSBAQCB2YXIgcHJvcGVydGllcyA9IHsKICd3b3JkU3BhY2luZycg OiAnNDBweCcsCiB9OwogLy8gVGhlIGZpcnN0IHJ1biB3aWxsIGp1c3QgYWRkIHRoZSBwcm9wZXJ0 aWVzIGJ1dCBpdCdzIGZpbmUgYXMgdGhlIGZpcnN0IHJ1biBvZiB0aGUgYmVuY2htYXJrIGlzIGFs d2F5cyBpZ25vcmVkLgotUGVyZlRlc3RSdW5uZXIucnVuKGZ1bmN0aW9uKCkgeworUGVyZlRlc3RS dW5uZXIucnVuUGVyU2Vjb25kKHtydW46ZnVuY3Rpb24oKSB7CiAgICAgZm9yIChrZXkgaW4gcHJv cGVydGllcykKICAgICAgICAgZGl2LnN0eWxlW2tleV0gPSBwcm9wZXJ0aWVzW2tleV07Ci19LCAx MDAwMCk7Cit9fSk7CiA8L3NjcmlwdD4KIDwvaHRtbD4KSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMv UGFyc2VyL2Nzcy1wYXJzZXIteXVpLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0 cy9QYXJzZXIvY3NzLXBhcnNlci15dWkuaHRtbAkocmV2aXNpb24gMTE2OTkwKQorKysgUGVyZm9y bWFuY2VUZXN0cy9QYXJzZXIvY3NzLXBhcnNlci15dWkuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MjYxOSwxMSArMjYxOSwxMSBAQCBsZWdlbmQgewogdmFyIGVsZW1lbnQgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgic3R5bGVFbGVtZW50Iik7CiB2YXIgY3NzVGV4dCA9IGVsZW1lbnQudGV4dENv bnRlbnQ7CiB2YXIgY291bnQgPSAwOwotUGVyZlRlc3RSdW5uZXIucnVuKGZ1bmN0aW9uKCkgewor UGVyZlRlc3RSdW5uZXIucnVuUGVyU2Vjb25kKHtydW46ZnVuY3Rpb24oKSB7CiAgICAgZWxlbWVu dC50ZXh0Q29udGVudCA9ICIiOwogICAgIGVsZW1lbnQudGV4dENvbnRlbnQgPSBjc3NUZXh0ICsg IiNzb21lIiArIGNvdW50ICsgIntjb2xvcjpibGFja307IjsKICAgICBjb3VudCsrOwotfSwgMTAw KTsKK319KTsKIAogPC9zY3JpcHQ+CiA8L2JvZHk+CkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1Bh cnNlci9zaW1wbGUtdXJsLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9QYXJz ZXIvc2ltcGxlLXVybC5odG1sCShyZXZpc2lvbiAxMTY5OTApCisrKyBQZXJmb3JtYW5jZVRlc3Rz L1BhcnNlci9zaW1wbGUtdXJsLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTMsMTAgKzMsMTAgQEAK IDxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvcnVubmVyLmpzIj48L3NjcmlwdD4KIDxzY3JpcHQ+ CiB2YXIgYW5jaG9yID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYSIpOwotUGVyZlRlc3RSdW5u ZXIucnVuKGZ1bmN0aW9uKCkgeworUGVyZlRlc3RSdW5uZXIucnVuUGVyU2Vjb25kKHtydW46ZnVu Y3Rpb24oKSB7CiAgICAgZm9yICh2YXIgeCA9IDA7IHggPCAyMDAwMDA7IHgrKykgewogICAgICAg ICBhbmNob3IuaHJlZiA9ICJodHRwOi8vd3d3LmFwcGxlLmNvbS8iCiAgICAgfQotfSk7Cit9fSk7 CiA8L3NjcmlwdD4KIDwvYm9keT4KSW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvUGFyc2VyL3Rpbnkt aW5uZXJIVE1MLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvdGlu eS1pbm5lckhUTUwuaHRtbAkocmV2aXNpb24gMTE2OTkwKQorKysgUGVyZm9ybWFuY2VUZXN0cy9Q YXJzZXIvdGlueS1pbm5lckhUTUwuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMiw3ICsyLDcgQEAK IDxib2R5PgogPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9ydW5uZXIuanMiPjwvc2NyaXB0Pgog PHNjcmlwdD4KLVBlcmZUZXN0UnVubmVyLnJ1bihmdW5jdGlvbigpIHsKK1BlcmZUZXN0UnVubmVy LnJ1blBlclNlY29uZCh7cnVuOmZ1bmN0aW9uKCkgewogICAgIHZhciB0ZXN0RGl2ID0gZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgdGVzdERpdi5zdHlsZS5kaXNwbGF5ID0gIm5v bmUiOwogICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQodGVzdERpdik7CkBAIC0xMCw2ICsx MCw2IEBAIFBlcmZUZXN0UnVubmVyLnJ1bihmdW5jdGlvbigpIHsKICAgICAgICAgdGVzdERpdi5p bm5lckhUTUwgPSAiVGhpcyBpcyBhIHRpbnkgSFRNTCBkb2N1bWVudCI7CiAgICAgfQogICAgIGRv Y3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQodGVzdERpdik7Ci19KTsKK319KTsKIDwvc2NyaXB0Pgog PC9ib2R5PgpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvdXJsLXBhcnNlci5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvUGFyc2VyL3VybC1wYXJzZXIuaHRtbAkocmV2 aXNpb24gMTE2OTkwKQorKysgUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIvdXJsLXBhcnNlci5odG1s CSh3b3JraW5nIGNvcHkpCkBAIC01LDEwICs1LDEwIEBACiB2YXIgdXJscyA9IFBlcmZUZXN0UnVu bmVyLmxvYWRGaWxlKCJyZXNvdXJjZXMvZmluYWwtdXJsLWVuIikuc3BsaXQoIlxuIik7CiB2YXIg YW5jaG9yID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYSIpOwogCi1QZXJmVGVzdFJ1bm5lci5y dW4oZnVuY3Rpb24oKSB7CitQZXJmVGVzdFJ1bm5lci5ydW5QZXJTZWNvbmQoe3J1bjpmdW5jdGlv bigpIHsKICAgICBmb3IgKHZhciB4ID0gMDsgeCA8IHVybHMubGVuZ3RoOyB4KyspIHsKICAgICAg ICAgYW5jaG9yLmhyZWYgPSB1cmxzW3hdOwogICAgIH0KLX0pOworfX0pOwogPC9zY3JpcHQ+CiA8 L2JvZHk+CkluZGV4OiBQZXJmb3JtYW5jZVRlc3RzL1BhcnNlci94bWwtcGFyc2VyLmh0bWwKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9QYXJzZXIveG1sLXBhcnNlci5odG1sCShyZXZp c2lvbiAxMTY5OTApCisrKyBQZXJmb3JtYW5jZVRlc3RzL1BhcnNlci94bWwtcGFyc2VyLmh0bWwJ KHdvcmtpbmcgY29weSkKQEAgLTExLDggKzExLDggQEAgZm9yICh2YXIgaSA9IDA7IGkgPCAweDdG RkY7ICsraSkKIHhtbEFycmF5LnB1c2goJzwvcm9vdD4nKQogdmFyIHhtbERhdGEgPSB4bWxBcnJh eS5qb2luKCcnKTsKIAotUGVyZlRlc3RSdW5uZXIucnVuKGZ1bmN0aW9uKCkgeworUGVyZlRlc3RS dW5uZXIucnVuUGVyU2Vjb25kKHtydW46ZnVuY3Rpb24oKSB7CiAgICAgZG9tUGFyc2VyLnBhcnNl RnJvbVN0cmluZyh4bWxEYXRhLCAidGV4dC94bWwiKTsKLX0pOworfX0pOwogPC9zY3JpcHQ+CiA8 L2JvZHk+Cg==