86395 2012-05-14 13:37:25 -0700 The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version 2012-05-14 13:49:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 623259 0 andersca 2012-05-14 13:37:25 -0700 The "plug-in was blocked" callback needs to include enough info to uniquely identify the plug-in + version 623262 1 141777 andersca 2012-05-14 13:38:25 -0700 Created attachment 141777 Patch 623272 2 141777 sullivan 2012-05-14 13:44:28 -0700 Comment on attachment 141777 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141777&action=review > Source/WebKit2/UIProcess/WebLoaderClient.cpp:275 > + m_client.pluginDidFail(toAPI(page), kWKErrorCodeCannotLoadPlugIn, toAPI(mimeType.impl()), 0, 0, m_client.clientInfo); It would be good to explain in the ChangeLog why we don't pass the new parameters here. 623284 3 andersca 2012-05-14 13:49:05 -0700 Committed r116993: <http://trac.webkit.org/changeset/116993> 141777 2012-05-14 13:38:25 -0700 2012-05-14 13:44:27 -0700 Patch bug-86395-20120514134048.patch text/plain 5539 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2OTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGQxY2IyMjNjMDUwYzdm YmNhNDEwZTg5N2I2ZmVhYjUxMzkwY2I3ZS4uYWJiOWVjNmE0NDA1ZGQ0Zjg5MmIzOTJlNTYyNDEx ODgwYTcwMTViNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA1LTE0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlICJwbHVnLWlu IHdhcyBibG9ja2VkIiBjYWxsYmFjayBuZWVkcyB0byBpbmNsdWRlIGVub3VnaCBpbmZvIHRvIHVu aXF1ZWx5IGlkZW50aWZ5IHRoZSBwbHVnLWluICsgdmVyc2lvbgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYzOTUKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzExNDQ3NjUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCB0aGUgcGx1Zy1pbiBpZGVudGlmaWVyIGFuZCB2ZXJzaW9uIHN0cmluZyB0byB0 aGUgZGlkRmFpbCBjbGllbnQgY2FsbGJhY2suCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Mv V0tQYWdlLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYkxvYWRlckNsaWVudC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYkxvYWRlckNsaWVudDo6ZGlkRmFpbFRvSW5pdGlhbGl6ZVBsdWdpbik6 CisgICAgICAgIChXZWJLaXQ6OldlYkxvYWRlckNsaWVudDo6ZGlkQmxvY2tJbnNlY3VyZVBsdWdp blZlcnNpb24pOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuaDoKKyAgICAg ICAgKFdlYkxvYWRlckNsaWVudCk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGlkQmxvY2tJbnNlY3VyZVBsdWdp blZlcnNpb24pOgorCiAyMDEyLTA1LTE0ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFybmUudmVz dGJvQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIFNpbXBsaWZ5IE9USEVSX0ZJTEVTIGZvciBR TUwgdGVzdHMgcHJvamVjdCBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9DL1dLUGFnZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFn ZS5oCmluZGV4IGFlZWZlZTc5NjA4OTIzYWIxNWRjNDRlMjFkMDllZDQwZGUzNzNlYWMuLjQ3YzA3 NmY4YzNjMjNlN2MyYmNjNWEyMTgzNzgwZmU2NjAyZGQwNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0MvV0tQYWdlLmgKQEAgLTcyLDcgKzcyLDcgQEAgdHlwZWRlZiB2b2lkICgqV0tQ YWdlRGlkQ2hhbmdlQmFja0ZvcndhcmRMaXN0Q2FsbGJhY2spKFdLUGFnZVJlZiBwYWdlLCBXS0Jh Y2tGb3IKIHR5cGVkZWYgYm9vbCAoKldLUGFnZVNob3VsZEdvVG9CYWNrRm9yd2FyZExpc3RJdGVt Q2FsbGJhY2spKFdLUGFnZVJlZiBwYWdlLCBXS0JhY2tGb3J3YXJkTGlzdEl0ZW1SZWYgaXRlbSwg Y29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7CiB0eXBlZGVmIHZvaWQgKCpXS1BhZ2VEaWROZXdGaXJz dFZpc3VhbGx5Tm9uRW1wdHlMYXlvdXRDYWxsYmFjaykoV0tQYWdlUmVmIHBhZ2UsIFdLVHlwZVJl ZiB1c2VyRGF0YSwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7CiB0eXBlZGVmIHZvaWQgKCpXS1Bh Z2VXaWxsR29Ub0JhY2tGb3J3YXJkTGlzdEl0ZW1DYWxsYmFjaykoV0tQYWdlUmVmIHBhZ2UsIFdL QmFja0ZvcndhcmRMaXN0SXRlbVJlZiBpdGVtLCBXS1R5cGVSZWYgdXNlckRhdGEsIGNvbnN0IHZv aWQgKmNsaWVudEluZm8pOwotdHlwZWRlZiB2b2lkICgqV0tQYWdlUGx1Z2luRGlkRmFpbENhbGxi YWNrKShXS1BhZ2VSZWYgcGFnZSwgV0tFcnJvckNvZGUgZXJyb3JDb2RlLCBXS1N0cmluZ1JlZiBt aW1lVHlwZSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbyk7Cit0eXBlZGVmIHZvaWQgKCpXS1BhZ2VQ bHVnaW5EaWRGYWlsQ2FsbGJhY2spKFdLUGFnZVJlZiBwYWdlLCBXS0Vycm9yQ29kZSBlcnJvckNv ZGUsIFdLU3RyaW5nUmVmIG1pbWVUeXBlLCBXS1N0cmluZ1JlZiBwbHVnaW5JZGVudGlmaWVyLCBX S1N0cmluZ1JlZiBwbHVnaW5WZXJzaW9uLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKTsKIAogLy8g RGVwcmVjYXRlZAogdHlwZWRlZiB2b2lkICgqV0tQYWdlRGlkRmFpbFRvSW5pdGlhbGl6ZVBsdWdp bkNhbGxiYWNrX2RlcHJlY2F0ZWRGb3JVc2VXaXRoVjApKFdLUGFnZVJlZiBwYWdlLCBXS1N0cmlu Z1JlZiBtaW1lVHlwZSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbyk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViTG9hZGVyQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuY3BwCmluZGV4IDVhN2Y3MTc2NjRiYjUyMjNhYTdk MDk2Njg4MGRjYTVmNzZkMjUwNzEuLjkyNzUwMTI0ZWFkYWUwNGI1MjY0ODExZmQyNDI5NDZkNmE3 ZjY0M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGll bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuY3Bw CkBAIC0yNzIsMTUgKzI3MiwxNSBAQCB2b2lkIFdlYkxvYWRlckNsaWVudDo6ZGlkRmFpbFRvSW5p dGlhbGl6ZVBsdWdpbihXZWJQYWdlUHJveHkqIHBhZ2UsIGNvbnN0IFN0cmluZwogICAgIGlmICgh bV9jbGllbnQucGx1Z2luRGlkRmFpbCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV9jbGllbnQu cGx1Z2luRGlkRmFpbCh0b0FQSShwYWdlKSwga1dLRXJyb3JDb2RlQ2Fubm90TG9hZFBsdWdJbiwg dG9BUEkobWltZVR5cGUuaW1wbCgpKSwgbV9jbGllbnQuY2xpZW50SW5mbyk7CisgICAgbV9jbGll bnQucGx1Z2luRGlkRmFpbCh0b0FQSShwYWdlKSwga1dLRXJyb3JDb2RlQ2Fubm90TG9hZFBsdWdJ biwgdG9BUEkobWltZVR5cGUuaW1wbCgpKSwgMCwgMCwgbV9jbGllbnQuY2xpZW50SW5mbyk7CiB9 CiAKLXZvaWQgV2ViTG9hZGVyQ2xpZW50OjpkaWRCbG9ja0luc2VjdXJlUGx1Z2luVmVyc2lvbihX ZWJQYWdlUHJveHkqIHBhZ2UsIGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCit2b2lkIFdlYkxvYWRl ckNsaWVudDo6ZGlkQmxvY2tJbnNlY3VyZVBsdWdpblZlcnNpb24oV2ViUGFnZVByb3h5KiBwYWdl LCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBjb25zdCBTdHJpbmcmIHBsdWdpbklkZW50aWZpZXIs IGNvbnN0IFN0cmluZyYgcGx1Z2luVmVyc2lvbikKIHsKICAgICBpZiAoIW1fY2xpZW50LnBsdWdp bkRpZEZhaWwpCiAgICAgICAgIHJldHVybjsKIAotICAgIG1fY2xpZW50LnBsdWdpbkRpZEZhaWwo dG9BUEkocGFnZSksIGtXS0Vycm9yQ29kZUluc2VjdXJlUGx1Z0luVmVyc2lvbiwgdG9BUEkobWlt ZVR5cGUuaW1wbCgpKSwgbV9jbGllbnQuY2xpZW50SW5mbyk7CisgICAgbV9jbGllbnQucGx1Z2lu RGlkRmFpbCh0b0FQSShwYWdlKSwga1dLRXJyb3JDb2RlSW5zZWN1cmVQbHVnSW5WZXJzaW9uLCB0 b0FQSShtaW1lVHlwZS5pbXBsKCkpLCB0b0FQSShwbHVnaW5JZGVudGlmaWVyLmltcGwoKSksIHRv QVBJKHBsdWdpblZlcnNpb24uaW1wbCgpKSwgbV9jbGllbnQuY2xpZW50SW5mbyk7CiB9CiAKIH0g Ly8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYkxvYWRlckNsaWVudC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkxvYWRlckNs aWVudC5oCmluZGV4IGE3ODc4OGQ3NjhjODAwZjg4NTc4MjFjNDhlZjdhZWY5OWVkY2Y3M2YuLjhj ZjY4N2I5NzBhNDQxMTYzYWRjNjlmZjdjOGFjYmJmYmU0MGJhZTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJMb2FkZXJDbGllbnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViTG9hZGVyQ2xpZW50LmgKQEAgLTg3LDcgKzg3LDcgQEAgcHVibGljOgog ICAgIHZvaWQgd2lsbEdvVG9CYWNrRm9yd2FyZExpc3RJdGVtKFdlYlBhZ2VQcm94eSosIFdlYkJh Y2tGb3J3YXJkTGlzdEl0ZW0qLCBBUElPYmplY3QqKTsKIAogICAgIHZvaWQgZGlkRmFpbFRvSW5p dGlhbGl6ZVBsdWdpbihXZWJQYWdlUHJveHkqLCBjb25zdCBTdHJpbmcmIG1pbWVUeXBlKTsKLSAg ICB2b2lkIGRpZEJsb2NrSW5zZWN1cmVQbHVnaW5WZXJzaW9uKFdlYlBhZ2VQcm94eSosIGNvbnN0 IFN0cmluZyYgbWltZVR5cGUpOworICAgIHZvaWQgZGlkQmxvY2tJbnNlY3VyZVBsdWdpblZlcnNp b24oV2ViUGFnZVByb3h5KiwgY29uc3QgU3RyaW5nJiBtaW1lVHlwZSwgY29uc3QgU3RyaW5nJiBw bHVnaW5JZGVudGlmaWVyLCBjb25zdCBTdHJpbmcmIHBsdWdpblZlcnNpb24pOwogfTsKIAogfSAv LyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHku Y3BwCmluZGV4IGNhMTFiNjRjYWQzZWFmZjBiNWViMjNiODllMGI4NzM2ZWFlM2Q5YTIuLmZmMThj NTgwYzllNGFkYTc5ZTZkMTUxYTM0YjU1YTIxYTRiOGY4YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC0zNjIzLDcgKzM2MjMsMTggQEAgdm9pZCBXZWJQ YWdlUHJveHk6OmRpZEZhaWxUb0luaXRpYWxpemVQbHVnaW4oY29uc3QgU3RyaW5nJiBtaW1lVHlw ZSkKIAogdm9pZCBXZWJQYWdlUHJveHk6OmRpZEJsb2NrSW5zZWN1cmVQbHVnaW5WZXJzaW9uKGNv bnN0IFN0cmluZyYgbWltZVR5cGUpCiB7Ci0gICAgbV9sb2FkZXJDbGllbnQuZGlkQmxvY2tJbnNl Y3VyZVBsdWdpblZlcnNpb24odGhpcywgbWltZVR5cGUpOworICAgIFN0cmluZyBwbHVnaW5JZGVu dGlmaWVyOworICAgIFN0cmluZyBwbHVnaW5WZXJzaW9uOworCisjaWYgUExBVEZPUk0oTUFDKQor ICAgIFN0cmluZyBuZXdNaW1lVHlwZSA9IG1pbWVUeXBlOworICAgIFBsdWdpbk1vZHVsZUluZm8g cGx1Z2luID0gbV9wcm9jZXNzLT5jb250ZXh0KCktPnBsdWdpbkluZm9TdG9yZSgpLmZpbmRQbHVn aW4obmV3TWltZVR5cGUsIEtVUkwoKSk7CisKKyAgICBwbHVnaW5JZGVudGlmaWVyID0gcGx1Z2lu LmJ1bmRsZUlkZW50aWZpZXI7CisgICAgcGx1Z2luVmVyc2lvbiA9IHBsdWdpbi52ZXJzaW9uU3Ry aW5nOworI2VuZGlmCisKKyAgICBtX2xvYWRlckNsaWVudC5kaWRCbG9ja0luc2VjdXJlUGx1Z2lu VmVyc2lvbih0aGlzLCBtaW1lVHlwZSwgcGx1Z2luSWRlbnRpZmllciwgcGx1Z2luVmVyc2lvbik7 CiB9CiAKIGJvb2wgV2ViUGFnZVByb3h5Ojp3aWxsSGFuZGxlSG9yaXpvbnRhbFNjcm9sbEV2ZW50 cygpIGNvbnN0Cg==