86378 2012-05-14 09:13:18 -0700 REGRESSION(r116796): Assertion failure in API tests 2012-05-14 11:16:37 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 86386 86143 1 koivisto kling andersca kling koivisto webkit.review.bot oldest_to_newest 623031 0 koivisto 2012-05-14 09:13:18 -0700 Looks like r116796 caused an assertion failure. From http://build.webkit.org/builders/Lion%20Debug%20%28Tests%29/builds/6498/steps/run-api-tests/logs/stdio : Note: Google Test filter = WebKit2.WKConnectionTest [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WebKit2 [ RUN ] WebKit2.WKConnectionTest [ OK ] WebKit2.WKConnectionTest (153 ms) [----------] 1 test from WebKit2 (153 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (153 ms total) [ PASSED ] 1 test. YOU HAVE 1 DISABLED TEST ASSERTION FAILED: !m_isValid /Volumes/Data/slave/lion-intel-debug/build/Source/WebKit2/Platform/WorkQueue.cpp(39) : WorkQueue::~WorkQueue() 1 0x10f1a3d25 WorkQueue::~WorkQueue() 2 0x10efc3506 WebKit::WebContext::~WebContext() 3 0x10efc3125 WebKit::WebContext::~WebContext() 4 0x10efc30f9 WebKit::WebContext::~WebContext() 5 0x10ee444c3 WTF::ThreadSafeRefCounted<WebKit::APIObject>::deref() 6 0x10efd8ffc void WTF::derefIfNotNull<WebKit::WebContext>(WebKit::WebContext*) 7 0x10f148ea8 WTF::RefPtr<WebKit::WebContext>::~RefPtr() 8 0x10f13e6f5 WTF::RefPtr<WebKit::WebContext>::~RefPtr() 9 0x10f13bca4 WebKit::WebProcessProxy::~WebProcessProxy() 10 0x10f13b9b5 WebKit::WebProcessProxy::~WebProcessProxy() 11 0x10f13b989 WebKit::WebProcessProxy::~WebProcessProxy() 12 0x10ee44c33 WTF::RefCounted<WebKit::WebProcessProxy>::deref() 13 0x10ee44bcc void WTF::derefIfNotNull<WebKit::WebProcessProxy>(WebKit::WebProcessProxy*) 14 0x10ee44b98 WTF::RefPtr<WebKit::WebProcessProxy>::~RefPtr() 15 0x10ee43ef5 WTF::RefPtr<WebKit::WebProcessProxy>::~RefPtr() 16 0x10f098f14 WebKit::WebPageProxy::~WebPageProxy() 17 0x10f098ba5 WebKit::WebPageProxy::~WebPageProxy() 18 0x10f098b79 WebKit::WebPageProxy::~WebPageProxy() 19 0x10ee444c3 WTF::ThreadSafeRefCounted<WebKit::APIObject>::deref() 20 0x10f05949c void WTF::derefIfNotNull<WebKit::WebPageProxy>(WebKit::WebPageProxy*) 21 0x10f0594c8 WTF::RefPtr<WebKit::WebPageProxy>::~RefPtr() 22 0x10f0592f5 WTF::RefPtr<WebKit::WebPageProxy>::~RefPtr() 23 0x10f184f80 -[WKViewData .cxx_destruct] 24 0x7fff945b24ed object_cxxDestructFromClass 25 0x7fff945ae5f1 objc_destructInstance 26 0x7fff945aed33 object_dispose 27 0x7fff892c5276 -[NSObject dealloc] 28 0x10f185511 -[WKView dealloc] 29 0x7fff945af03c (anonymous namespace)::AutoreleasePoolPage::pop(void*) 30 0x7fff892c5b05 _CFAutoreleasePoolPop 31 0x7fff8ac916f3 -[NSAutoreleasePool drain] 623037 1 kling 2012-05-14 09:22:14 -0700 Looks like I intentionally broke everything. Taking. 623090 2 141751 kling 2012-05-14 10:35:51 -0700 Created attachment 141751 Patch 623113 3 kling 2012-05-14 11:03:50 -0700 Committed r116969: <http://trac.webkit.org/changeset/116969> 623121 4 webkit.review.bot 2012-05-14 11:10:19 -0700 Re-opened since this is blocked by 86386 623130 5 141751 kling 2012-05-14 11:16:22 -0700 Comment on attachment 141751 Patch Clearing flags on attachment: 141751 Committed r116971: <http://trac.webkit.org/changeset/116971> 623131 6 kling 2012-05-14 11:16:37 -0700 All reviewed patches have been landed. Closing bug. 141751 2012-05-14 10:35:51 -0700 2012-05-14 11:16:22 -0700 Patch bug-86378.diff text/plain 1223 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjZDI0ZGE2Li43YjNkZWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDUtMTQgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjExNjc5Nik6IEFzc2VydGlvbiBmYWlsdXJlIGluIEFQSSB0ZXN0cwor ICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi84NjM3OD4KKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzEwNzc3MjE4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEludmFsaWRhdGUgdGhlIHBsdWdpbiB3b3JrIHF1ZXVlIGluIH5XZWJDb250ZXh0IHRv IGF2b2lkIGhpdHRpbmcKKyAgICAgICAgdGhlICFtX2lzVmFsaWQgYXNzZXJ0aW9uIGluIH5Xb3Jr UXVldWUgbGF0ZXIgb24uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQ29udGV4dC5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYkNvbnRleHQ6On5XZWJDb250ZXh0KToKKwogMjAxMi0wNS0xNCAg QWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAgICAg ICBbUXRdIERvZXNuJ3QgYnVpbGQgd2l0aCBFTkFCTEVfSU5TUEVDVE9SPTAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcAppbmRleCAxN2FiNWMyLi44ZWJkOWI2IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCkBAIC0xNjYsNiArMTY2LDggQEAgV2Vi Q29udGV4dDo6V2ViQ29udGV4dChQcm9jZXNzTW9kZWwgcHJvY2Vzc01vZGVsLCBjb25zdCBTdHJp bmcmIGluamVjdGVkQnVuZGxlUGEKIAogV2ViQ29udGV4dDo6fldlYkNvbnRleHQoKQogeworICAg IG1fcGx1Z2luV29ya1F1ZXVlLmludmFsaWRhdGUoKTsKKwogICAgIGlmIChtX3Byb2Nlc3MgJiYg bV9wcm9jZXNzLT5pc1ZhbGlkKCkpCiAgICAgICAgIG1fcHJvY2Vzcy0+Y29ubmVjdGlvbigpLT5y ZW1vdmVRdWV1ZUNsaWVudCh0aGlzKTsKIAo=