86375 2012-05-14 08:19:59 -0700 Web Inspector: Add keyboard shortcut for closing tab on scripts panel. 2014-03-02 12:36:02 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 0 vsevik vsevik apavlov bburg bweinstein joepeck keishi lmjabreu loislo pfeldman pmuellr rik yurys oldest_to_newest 622997 0 vsevik 2012-05-14 08:19:59 -0700 Patch to follow. 623003 1 141735 vsevik 2012-05-14 08:26:56 -0700 Created attachment 141735 Patch 623010 2 141735 pfeldman 2012-05-14 08:34:48 -0700 Comment on attachment 141735 Patch I don't think we need a shortcut for this. Could you park this bug for now? 797494 3 lmjabreu 2012-12-27 03:21:04 -0800 Pavel, can you share your reasoning? My reasoning is that by offering shortcuts for many other features of the web inspector: opening files, switching between tabs, controlling execution, etc. For reasons of consistency, it would also make sense to allow the currently focused file source (tab) to be closed. On an unrelated note, it seems the web inspector shorcuts weren't properly sandboxed, sometimes, as it is with the case of jump to line, an already-existing keyboard shortcut is remapped based on context, and there's no relation between contexts. 797509 4 pfeldman 2012-12-27 04:18:13 -0800 I think that it should either be a standard shortcut (Ctrl/Cmd+W) or nothing. But we can't make it Ctrl+W. So in this case, I would argue that the functionality is not valuable enough to bring in yet another confusion such as the one you refer to (jump to line). 141735 2012-05-14 08:26:56 -0700 2012-05-14 08:34:48 -0700 Patch bug-86375-20120514192654.patch text/plain 4290 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGRmM2ZlMzI0OGZkNWU2 MTYxNDdlZWVlMWNiZTRkYzI4YmRiOTYyMy4uZjkzODRhY2U3NTEzYWE5ZDZjZTJlMWJlYmI2YTQ5 NTI3OWQ5YzYzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA1LTE0ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEFkZCBrZXlib2FyZCBzaG9ydGN1dCBmb3IgY2xvc2luZyB0YWIgb24gc2NyaXB0cyBwYW5l bC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2Mzc1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgS2V5Ym9h cmQgc2hvcnRjdXQgKEFsdCArIFcpIGFkZGVkIGZvciBjbG9zaW5nIHRhYiBvbiBzY3JpcHRzIHBh bmVsLgorCisgICAgICAgICogRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAg ICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0c1BhbmVsLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlNjcmlwdHNQYW5lbC5wcm90b3R5cGUuX2hhbmRsZUNsb3NlVGFiKToKKyAgICAg ICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJlZEVkaXRvckNvbnRhaW5lci5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UYWJiZWRFZGl0b3JDb250YWluZXIucHJvdG90eXBlLmNsb3NlRmls ZSk6CisKIDIwMTItMDUtMTQgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgW1F0XSBUZXh0dXJlTWFwcGVyR0w6OmRyYXdUZXh0dXJlIG1hcmtlZCBPVkVSUklERSBi dXQgZG9lcyBub3Qgb3ZlcnJpZGUgYW55IG1lbWJlciBmdW5jdGlvbi4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9X ZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwppbmRleCBlMTg2ZDhkNzRk MDZhN2NjZDZlMjhmMmEyMGI4MmIzNmViNmMwYzYxLi43NWJkMjJjZTFlOGRjMTI5MDQ0MzE0ZjU5 NTUwOWZlNzJlYTg3NTE3IDEwMDY0NApHSVQgYmluYXJ5IHBhdGNoCmRlbHRhIDQ5CnpjbWNjQSRH V0RVd1A2Y21rbyl2c1k+WDxDNDtabWJ8RUo1eSFDSnpRJGRFTEJ3SnhKMTUxN2ZJIzkrPDkjUSpA VwpDMkBVZkEKCmRlbHRhIDExClNjbVozfSZ3OG5rd1A2Y21rVUliIzAwZVhaCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwppbmRleCAx ZDk5NGY4MDcwNWEzOTI4MDAwZmRmNTA5MWY5MDY5NGZmZDBmYzIzLi5mOTkyNjUwOWNlZWNlYzFl NzFjNGFmYWI4NDNlMDdhNjQ3MjM1NzY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1NjcmlwdHNQYW5lbC5qcwpAQCAtMTI4LDYgKzEyOCwxMCBAQCBXZWJJ bnNwZWN0b3IuU2NyaXB0c1BhbmVsID0gZnVuY3Rpb24ocHJlc2VudGF0aW9uTW9kZWwpCiAgICAg aGVscFNlY3Rpb24uYWRkS2V5KHNjcmlwdE91dGxpbmVTaG9ydGN1dC5uYW1lLCBXZWJJbnNwZWN0 b3IuVUlTdHJpbmcoIkdvIHRvIGZ1bmN0aW9uIikpOwogICAgIHRoaXMucmVnaXN0ZXJTaG9ydGN1 dChzY3JpcHRPdXRsaW5lU2hvcnRjdXQua2V5LCB0aGlzLl9zaG93SmF2YVNjcmlwdE91dGxpbmVE aWFsb2cuYmluZCh0aGlzKSk7CiAKKyAgICB2YXIgY2xvc2VUYWJTaG9ydGN1dCA9IFdlYkluc3Bl Y3Rvci5LZXlib2FyZFNob3J0Y3V0Lm1ha2VEZXNjcmlwdG9yKCJ3IiwgV2ViSW5zcGVjdG9yLktl eWJvYXJkU2hvcnRjdXQuTW9kaWZpZXJzLkFsdCk7CisgICAgaGVscFNlY3Rpb24uYWRkS2V5KGNs b3NlVGFiU2hvcnRjdXQubmFtZSwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDbG9zZSB0YWIiKSk7 CisgICAgdGhpcy5yZWdpc3RlclNob3J0Y3V0KGNsb3NlVGFiU2hvcnRjdXQua2V5LCB0aGlzLl9o YW5kbGVDbG9zZVRhYi5iaW5kKHRoaXMpKTsKKwogICAgIHZhciBwYW5lbEVuYWJsZXJIZWFkaW5n ID0gV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJZb3UgbmVlZCB0byBlbmFibGUgZGVidWdnaW5nIGJl Zm9yZSB5b3UgY2FuIHVzZSB0aGUgU2NyaXB0cyBwYW5lbC4iKTsKICAgICB2YXIgcGFuZWxFbmFi bGVyRGlzY2xhaW1lciA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiRW5hYmxpbmcgZGVidWdnaW5n IHdpbGwgbWFrZSBzY3JpcHRzIHJ1biBzbG93ZXIuIik7CiAgICAgdmFyIHBhbmVsRW5hYmxlckJ1 dHRvbiA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiRW5hYmxlIERlYnVnZ2luZyIpOwpAQCAtODE5 LDYgKzgyMywxMiBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9IHsKICAg ICAgICAgcmV0dXJuIGRlYnVnVG9vbGJhcjsKICAgICB9LAogCisgICAgX2hhbmRsZUNsb3NlVGFi OiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBpZiAodGhpcy5fY3VycmVudFVJU291cmNlQ29k ZSkKKyAgICAgICAgICAgIHRoaXMuX2VkaXRvckNvbnRhaW5lci5jbG9zZUZpbGUodGhpcy5fY3Vy cmVudFVJU291cmNlQ29kZSk7CisgICAgfSwKKwogICAgIF9jcmVhdGVCdXR0b25BbmRSZWdpc3Rl clNob3J0Y3V0czogZnVuY3Rpb24oYnV0dG9uSWQsIGJ1dHRvblRpdGxlLCBoYW5kbGVyLCBzaG9y dGN1dHMsIHNob3J0Y3V0RGVzY3JpcHRpb24pCiAgICAgewogICAgICAgICB2YXIgYnV0dG9uID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYnV0dG9uIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RhYmJlZEVkaXRvckNvbnRhaW5lci5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkRWRpdG9yQ29udGFpbmVyLmpzCmlu ZGV4IDU3ZTY5NmJiZTNkNWNhMDlkZTlhODBhNmZlZDhmYzJlOWFhYjA2ZjAuLjQxYjhmMjA2Mjhk NTFjODFhZWFhMDY4YTM3ZmI0MThmNmU1YWQ3MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkRWRpdG9yQ29udGFpbmVyLmpzCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGFiYmVkRWRpdG9yQ29udGFpbmVyLmpzCkBA IC0xNjksNiArMTY5LDE0IEBAIFdlYkluc3BlY3Rvci5UYWJiZWRFZGl0b3JDb250YWluZXIucHJv dG90eXBlID0gewogICAgIC8qKgogICAgICAqIEBwYXJhbSB7V2ViSW5zcGVjdG9yLlVJU291cmNl Q29kZX0gdWlTb3VyY2VDb2RlCiAgICAgICovCisgICAgY2xvc2VGaWxlOiBmdW5jdGlvbih1aVNv dXJjZUNvZGUpCisgICAgeworICAgICAgICB0aGlzLl9yZW1vdmVGaWxlVGFiKHVpU291cmNlQ29k ZSwgdHJ1ZSk7CisgICAgfSwKKworICAgIC8qKgorICAgICAqIEBwYXJhbSB7V2ViSW5zcGVjdG9y LlVJU291cmNlQ29kZX0gdWlTb3VyY2VDb2RlCisgICAgICovCiAgICAgX2VkaXRvckNsb3NlZEJ5 VXNlckFjdGlvbjogZnVuY3Rpb24odWlTb3VyY2VDb2RlKQogICAgIHsKICAgICAgICAgdGhpcy5f dXNlclNlbGVjdGVkRmlsZXMgPSB0cnVlOwpAQCAtMjI0LDEzICsyMzIsMTMgQEAgV2ViSW5zcGVj dG9yLlRhYmJlZEVkaXRvckNvbnRhaW5lci5wcm90b3R5cGUgPSB7CiAKICAgICAvKioKICAgICAg KiBAcGFyYW0ge1dlYkluc3BlY3Rvci5VSVNvdXJjZUNvZGV9IHVpU291cmNlQ29kZQorICAgICAq IEBwYXJhbSB7Ym9vbGVhbj19IHVzZXJHZXN0dXJlCiAgICAgICovCi0gICAgX3JlbW92ZUZpbGVU YWI6IGZ1bmN0aW9uKHVpU291cmNlQ29kZSkKKyAgICBfcmVtb3ZlRmlsZVRhYjogZnVuY3Rpb24o dWlTb3VyY2VDb2RlLCB1c2VyR2VzdHVyZSkKICAgICB7CiAgICAgICAgIHZhciB0YWJJZCA9IHRo aXMuX3RhYklkcy5nZXQodWlTb3VyY2VDb2RlKTsKLSAgICAgICAgCiAgICAgICAgIGlmICh0YWJJ ZCkKLSAgICAgICAgICAgIHRoaXMuX3RhYmJlZFBhbmUuY2xvc2VUYWIodGFiSWQpOworICAgICAg ICAgICAgdGhpcy5fdGFiYmVkUGFuZS5jbG9zZVRhYih0YWJJZCwgdXNlckdlc3R1cmUpOwogICAg IH0sCiAKICAgICAvKioK