86371 2012-05-14 07:37:46 -0700 Web Inspector: do not update $0-$4 console variables for the objects from loaded from file heap snapshot. 2012-05-14 10:11:26 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 622960 0 loislo 2012-05-14 07:37:46 -0700 %subj% 623035 1 141739 loislo 2012-05-14 09:19:10 -0700 Created attachment 141739 Patch 623053 2 141739 yurys 2012-05-14 09:56:48 -0700 Comment on attachment 141739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=141739&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:278 > + temporaryProfile._fromFile = true; Why not have WebInspector.ProfileHeader.prototype.loadFromFile do this? 623067 3 loislo 2012-05-14 10:11:26 -0700 Committed r116959: <http://trac.webkit.org/changeset/116959> 141739 2012-05-14 09:19:10 -0700 2012-05-14 09:56:48 -0700 Patch bug-86371-20120514201908.patch text/plain 5853 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTE2OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGJmMzM1NDk0MTA3OWZi OTY3NTg3ZDBmYWQ1NzUzMzdiNmRlMjU4MS4uMjVmYmY4ODhiMzQzZTM4MTM3M2NhMWZlMThhNjk1 ZDgyODZlOGY2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA1LTE0ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBkbyBub3QgdXBkYXRlICQwLSQ0IGNvbnNvbGUgdmFyaWFibGVzIGZvciB0aGUgb2JqZWN0 cyBmcm9tIGxvYWRlZCBmcm9tIGZpbGUgaGVhcCBzbmFwc2hvdC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2MzcxCisKKyAgICAgICAgV2hlbiB0aGUg dXNlciBzZWxlY3RzIGFuIG9iamVjdCBpbiBIZWFwU25hcHNob3Qgd2UgYXJlIHVwZGF0aW5nICQw IHZhcmlhYmxlIGluIGNvbnNvbGUgQVBJLgorICAgICAgICBCdXQgaWYgdGhlIHNuYXBzaG90IHdh cyBsb2FkZWQgZnJvbSBmaWxlIHRoZW4gd2UgY2FuJ3QgbWFwIG9iamVjdCBpZCBmb3IgdGhlIHNl bGVjdGVkIG9iZWN0CisgICAgICAgIGZyb20gdGhlIHNuYXBzaG90IHRvIHRoZSBsaXZlIG9iamVj dHMgaW4gdGhlIGluc3BlY3RlZCBwYWdlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25hcHNob3RWaWV3 LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFZpZXcucHJvdG90eXBlLl9p bnNwZWN0ZWRPYmplY3RDaGFuZ2VkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNo b3RWaWV3LnByb3RvdHlwZS5fdXBkYXRlRmlsdGVyT3B0aW9ucyk6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuSGVhcFByb2ZpbGVIZWFkZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkhlYXBQcm9m aWxlSGVhZGVyLnByb3RvdHlwZS5jYW5TYXZlVG9GaWxlKToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5IZWFwUHJvZmlsZUhlYWRlci5wcm90b3R5cGUuc2F2ZVRvRmlsZSk6CisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlByb2ZpbGVIZWFkZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2ZpbGVIZWFkZXIucHJv dG90eXBlLmxvYWRGcm9tRmlsZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZUhlYWRl ci5wcm90b3R5cGUuZnJvbUZpbGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFu ZWwucHJvdG90eXBlLl9sb2FkRnJvbUZpbGUpOgorCiAyMDEyLTA1LTE0ICBQYXZlbCBGZWxkbWFu ICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHByZXNl cnZlIHRhYiBpbmRleCB3aGlsZSB3aWRlbmluZyAvIHNocmlua2luZyB0YWJiZWQgcGFuZSBhcmVh LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25h cHNob3RWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9IZWFwU25h cHNob3RWaWV3LmpzCmluZGV4IGJlNzkwZDEwNTI4NzZjOTZhYTFiYWZmMmIwZWZkYjFjYTViMTgz MzMuLjI2YTFjMDYzNWNiZWFiM2QxYmE2MDk2ZmIzMTA2ZWQyYzA1MzQ3MzAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90Vmlldy5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hvdFZpZXcu anMKQEAgLTQ1Miw3ICs0NTIsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90Vmlldy5wcm90 b3R5cGUgPSB7CiAgICAgX2luc3BlY3RlZE9iamVjdENoYW5nZWQ6IGZ1bmN0aW9uKGV2ZW50KQog ICAgIHsKICAgICAgICAgdmFyIHNlbGVjdGVkTm9kZSA9IGV2ZW50LnRhcmdldC5zZWxlY3RlZE5v ZGU7Ci0gICAgICAgIGlmIChzZWxlY3RlZE5vZGUgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuSGVh cFNuYXBzaG90R2VuZXJpY09iamVjdE5vZGUpCisgICAgICAgIGlmICghdGhpcy5wcm9maWxlLmZy b21GaWxlKCkgJiYgc2VsZWN0ZWROb2RlIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkhlYXBTbmFw c2hvdEdlbmVyaWNPYmplY3ROb2RlKQogICAgICAgICAgICAgQ29uc29sZUFnZW50LmFkZEluc3Bl Y3RlZEhlYXBPYmplY3Qoc2VsZWN0ZWROb2RlLnNuYXBzaG90Tm9kZUlkKTsKICAgICB9LAogCkBA IC01NTksNiArNTU5LDggQEAgV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdFZpZXcucHJvdG90eXBl ID0gewogCiAgICAgX3Jlc29sdmVPYmplY3RGb3JQb3BvdmVyOiBmdW5jdGlvbihlbGVtZW50LCBz aG93Q2FsbGJhY2ssIG9iamVjdEdyb3VwTmFtZSkKICAgICB7CisgICAgICAgIGlmICh0aGlzLnBy b2ZpbGUuZnJvbUZpbGUoKSkKKyAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgZWxlbWVudC5u b2RlLnF1ZXJ5T2JqZWN0Q29udGVudChzaG93Q2FsbGJhY2ssIG9iamVjdEdyb3VwTmFtZSk7CiAg ICAgfSwKIApAQCAtNjg4LDcgKzY5MCw3IEBAIFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RWaWV3 LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuZmlsdGVyU2VsZWN0RWxlbWVudC5hcHBl bmRDaGlsZChmaWx0ZXJPcHRpb24pOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKHRoaXMucHJv ZmlsZS5fZnJvbUZpbGUpCisgICAgICAgIGlmICh0aGlzLnByb2ZpbGUuZnJvbUZpbGUoKSkKICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgZm9yICh2YXIgaSA9IHRoaXMuZmlsdGVyU2VsZWN0 RWxlbWVudC5sZW5ndGggLSAxLCBuID0gbGlzdC5sZW5ndGg7IGkgPCBuOyArK2kpIHsKICAgICAg ICAgICAgIHZhciBwcm9maWxlID0gbGlzdFtpXTsKQEAgLTc5Myw3ICs3OTUsNiBAQCBXZWJJbnNw ZWN0b3IuSGVhcFByb2ZpbGVIZWFkZXIgPSBmdW5jdGlvbih0aXRsZSwgdWlkLCBtYXhKU09iamVj dElkKQogICAgIFdlYkluc3BlY3Rvci5Qcm9maWxlSGVhZGVyLmNhbGwodGhpcywgV2ViSW5zcGVj dG9yLkhlYXBTbmFwc2hvdFByb2ZpbGVUeXBlLlR5cGVJZCwgdGl0bGUsIHVpZCk7CiAgICAgdGhp cy5tYXhKU09iamVjdElkID0gbWF4SlNPYmplY3RJZDsKICAgICB0aGlzLl9sb2FkZWQgPSBmYWxz ZTsKLSAgICB0aGlzLl9mcm9tRmlsZSA9IGZhbHNlOwogICAgIHRoaXMuX3RvdGFsTnVtYmVyT2ZD aHVua3MgPSAwOwogfQogCkBAIC04ODQsNyArODg1LDcgQEAgV2ViSW5zcGVjdG9yLkhlYXBQcm9m aWxlSGVhZGVyLnByb3RvdHlwZSA9IHsKICAgICAgKi8KICAgICBjYW5TYXZlVG9GaWxlOiBmdW5j dGlvbigpCiAgICAgewotICAgICAgICByZXR1cm4gIXRoaXMuX2Zyb21GaWxlICYmIHRoaXMuX2xv YWRlZCAmJiAhdGhpcy5fc2F2ZWRDaHVua3NDb3VudCAmJiBXZWJJbnNwZWN0b3IuZmlsZU1hbmFn ZXIuY2FuQXBwZW5kKCk7CisgICAgICAgIHJldHVybiAhdGhpcy5mcm9tRmlsZSgpICYmIHRoaXMu X2xvYWRlZCAmJiAhdGhpcy5fc2F2ZWRDaHVua3NDb3VudCAmJiBXZWJJbnNwZWN0b3IuZmlsZU1h bmFnZXIuY2FuQXBwZW5kKCk7CiAgICAgfSwKIAogICAgIC8qKgpAQCAtOTA3LDcgKzkwOCw3IEBA IFdlYkluc3BlY3Rvci5IZWFwUHJvZmlsZUhlYWRlci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAg ICBQcm9maWxlckFnZW50LmdldFByb2ZpbGUodGhpcy50eXBlSWQsIHRoaXMudWlkKTsKICAgICAg ICAgfQogCi0gICAgICAgIHRoaXMuX2ZpbGVOYW1lID0gdGhpcy5fZmlsZU5hbWUgfHwgIkhlYXAt IiArIG5ldyBEYXRlKCkudG9JU084NjAxQ29tcGFjdCgpICsgIi5qc29uIjsKKyAgICAgICAgdGhp cy5fZmlsZU5hbWUgPSB0aGlzLl9maWxlTmFtZSB8fCAiSGVhcC0iICsgbmV3IERhdGUoKS50b0lT Tzg2MDFDb21wYWN0KCkgKyAiLmhlYXBzbmFwc2hvdCI7CiAgICAgICAgIFdlYkluc3BlY3Rvci5m aWxlTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5GaWxlTWFuYWdlci5FdmVu dFR5cGVzLlNhdmVkVVJMLCBzdGFydFNhdmluZ1NuYXBzaG90LCB0aGlzKTsKICAgICAgICAgV2Vi SW5zcGVjdG9yLmZpbGVNYW5hZ2VyLnNhdmUodGhpcy5fZmlsZU5hbWUsICIiLCB0cnVlKTsKICAg ICB9LApAQCAtOTQyLDcgKzk0Myw2IEBAIFdlYkluc3BlY3Rvci5IZWFwUHJvZmlsZUhlYWRlci5w cm90b3R5cGUgPSB7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAotICAgICAgICB0aGlzLl9m cm9tRmlsZSA9IHRydWU7CiAgICAgICAgIHRoaXMudGl0bGUgPSBmaWxlLm5hbWU7CiAgICAgICAg IHRoaXMuc2lkZWJhckVsZW1lbnQuc3VidGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkxv YWRpbmdcdTIwMjYiKTsKICAgICAgICAgdGhpcy5zaWRlYmFyRWxlbWVudC53YWl0ID0gdHJ1ZTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQ YW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5l bC5qcwppbmRleCAxOTQ4MWYzNjJjOGVmMDEwZTM0ZjQ5Y2FlZDhiNTAxMjJiZDcwODkyLi5mNDU3 NDE3NWI0ZjlhMGQ5YjExMzQ1NGI2MzBiOWY1ZWNkMzNkZjI0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCkBAIC0xMzksNiAr MTM5LDcgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVIZWFkZXIgPSBmdW5jdGlvbihwcm9maWxlVHlw ZSwgdGl0bGUsIHVpZCkKICAgICAgICAgdGhpcy51aWQgPSB1aWQ7CiAgICAgICAgIHRoaXMuaXNU ZW1wb3JhcnkgPSBmYWxzZTsKICAgICB9CisgICAgdGhpcy5fZnJvbUZpbGUgPSBmYWxzZTsKIH0K IAogV2ViSW5zcGVjdG9yLlByb2ZpbGVIZWFkZXIucHJvdG90eXBlID0gewpAQCAtMTYyLDcgKzE2 MywxMiBAQCBXZWJJbnNwZWN0b3IuUHJvZmlsZUhlYWRlci5wcm90b3R5cGUgPSB7CiAgICAgLyoq CiAgICAgICogQHBhcmFtIHtGaWxlfSBmaWxlCiAgICAgICovCi0gICAgbG9hZEZyb21GaWxlOiBm dW5jdGlvbihmaWxlKSB7IHRocm93IG5ldyBFcnJvcigiTmVlZHMgaW1wbGVtZW50ZWQiKTsgfQor ICAgIGxvYWRGcm9tRmlsZTogZnVuY3Rpb24oZmlsZSkgeyB0aHJvdyBuZXcgRXJyb3IoIk5lZWRz IGltcGxlbWVudGVkIik7IH0sCisKKyAgICAvKioKKyAgICAgKiBAcmV0dXJuIHtib29sZWFufQor ICAgICAqLworICAgIGZyb21GaWxlOiBmdW5jdGlvbigpIHsgcmV0dXJuIHRoaXMuX2Zyb21GaWxl OyB9CiB9CiAKIC8qKgpAQCAtMjY5LDYgKzI3NSw3IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlc1Bh bmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIHRlbXBvcmFyeVByb2ZpbGUgPSBwcm9maWxl VHlwZS5jcmVhdGVUZW1wb3JhcnlQcm9maWxlKFVzZXJJbml0aWF0ZWRQcm9maWxlTmFtZSArICIu IiArIGZpbGUubmFtZSk7CiAgICAgICAgIHRoaXMuYWRkUHJvZmlsZUhlYWRlcih0ZW1wb3JhcnlQ cm9maWxlKTsKIAorICAgICAgICB0ZW1wb3JhcnlQcm9maWxlLl9mcm9tRmlsZSA9IHRydWU7CiAg ICAgICAgIHRlbXBvcmFyeVByb2ZpbGUubG9hZEZyb21GaWxlKGZpbGUpOwogICAgICAgICB0aGlz Ll9jcmVhdGVGaWxlU2VsZWN0b3JFbGVtZW50KCk7CiAgICAgfSwK