86370 2012-05-14 07:20:25 -0700 [EFL] API for PageGroup visited links hash populating 2012-05-25 01:00:59 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82579 0 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 622953 0 mikhail.pozdnyakov 2012-05-14 07:20:25 -0700 An API that would let the client to populate PageGroup visited links hash from a persistent storage is needed in EFL port as a part of Global History Delegate functionality. There should be also a notification mechanism so that WebCore can ask the client to fulfill the visited links hash. 623911 1 141921 mikhail.pozdnyakov 2012-05-15 05:01:24 -0700 Created attachment 141921 patch 631109 2 141921 gyuyoung.kim 2012-05-22 20:03:27 -0700 Comment on attachment 141921 patch View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review > Source/WebKit/efl/ChangeLog:9 > + persistent history storage to fill the visited links cache; what is ; at cache; ? > Source/WebKit/efl/ewk/ewk_view.cpp:1635 > +Eina_Bool ewk_view_add_visited_link(Evas_Object* ewkView, const char* visitedUrl) Style nit : Is ewk_view_visited_link_add better? 631110 3 141921 gyuyoung.kim 2012-05-22 20:06:37 -0700 Comment on attachment 141921 patch View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review Is this patch's test cases covered by Bug 82579 ? > Source/WebKit/efl/ewk/ewk_view.h:1049 > +EAPI Eina_Bool ewk_view_add_visited_link(Evas_Object *o, const char *visited_url); Do not two spaces in front of const keyword. 631495 4 mikhail.pozdnyakov 2012-05-23 04:32:06 -0700 (In reply to comment #3) > (From update of attachment 141921 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review > > Is this patch's test cases covered by Bug 82579 ? > Yes. This bug is enabler for 82579 which is responsible for DRT part. 631534 5 143541 mikhail.pozdnyakov 2012-05-23 05:17:22 -0700 Created attachment 143541 patch v2 (fixed review comments) 631535 6 mikhail.pozdnyakov 2012-05-23 05:19:08 -0700 (In reply to comment #2) > (From update of attachment 141921 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=141921&action=review > > > Source/WebKit/efl/ChangeLog:9 > > + persistent history storage to fill the visited links cache; > > what is ; at cache; ? > > > Source/WebKit/efl/ewk/ewk_view.cpp:1635 > > +Eina_Bool ewk_view_add_visited_link(Evas_Object* ewkView, const char* visitedUrl) > > Style nit : Is ewk_view_visited_link_add better? Fixed all above. Thanks for review. 632341 7 gyuyoung.kim 2012-05-23 19:45:53 -0700 Looks good to me now. 633662 8 143541 webkit.review.bot 2012-05-25 01:00:51 -0700 Comment on attachment 143541 patch v2 (fixed review comments) Clearing flags on attachment: 143541 Committed r118491: <http://trac.webkit.org/changeset/118491> 633664 9 webkit.review.bot 2012-05-25 01:00:59 -0700 All reviewed patches have been landed. Closing bug. 141921 2012-05-15 05:01:24 -0700 2012-05-23 05:17:22 -0700 patch bug86370 text/plain 5092 mikhail.pozdnyakov Y29tbWl0IGUxNDU5ZTc5N2Y3NDVkY2Y2NjIzZWYwNjcxZTg3YTBkN2VhNjNlMGUKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg VHVlIE1heSAxNSAxNDo1OTo1MCAyMDEyICswMzAwCgogICAgYnVnODYzNzAKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VM b2cKaW5kZXggMWU3NTA1MS4uZWM4Nzc2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTA1LTE1ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZA aW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIEFQSSBmb3IgUGFnZUdyb3VwIHZpc2l0ZWQgbGlu a3MgaGFzaCBwb3B1bGF0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NjM3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZvbGxvd2luZyBhZGRlZCB0byBld2tfdmlldzogInBvcHVsYXRlLHZpc2l0ZWQs bGlua3MiIHNpZ25hbCB0aGF0IHRlbGxzIHRvIHRoZSBjbGllbnQgbWFuYWdpbmcKKyAgICAgICAg cGVyc2lzdGVudCBoaXN0b3J5IHN0b3JhZ2UgdG8gZmlsbCB0aGUgdmlzaXRlZCBsaW5rcyBjYWNo ZTsKKyAgICAgICAgQVBJIGZvciB0aGUgUGFnZUdyb3VwIHZpc2l0ZWQgbGlua3MgaGFzaCBwb3B1 bGF0aW5nLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkNocm9tZUNsaWVudEVmbDo6cG9wdWxhdGVWaXNpdGVkTGlua3Mp OiBJbXBsZW1lbnRhdGlvbiBhZGRlZCAoc2VuZHMgbm90aWZpY2F0aW9uKS4KKyAgICAgICAgKFdl YkNvcmUpOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5oOgorICAg ICAgICAoQ2hyb21lQ2xpZW50RWZsKToKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAg ICAgICAoX0V3a19WaWV3X1ByaXZhdGVfRGF0YSk6CisgICAgICAgIChld2tfdmlld19hZGRfdmlz aXRlZF9saW5rKTogUGFnZUdyb3VwIHZpc2l0ZWQgbGlua3MgaGFzaCBwb3B1bGF0aW5nLgorICAg ICAgICAqIGV3ay9ld2tfdmlldy5oOgorCiAyMDEyLTA1LTE0ICBSYXBoYWVsIEt1Ym8gZGEgQ29z dGEgIDxyYWt1Y29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBbRUZMXSBSZW1vdmUgZXdrX3ZpZXdf Y29yZV9wYWdlX2dldCgpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1 cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNvcmVTdXBw b3J0L0Nocm9tZUNsaWVudEVmbC5jcHAKaW5kZXggNGVkNGY5My4uYjllYjIyNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3Bw CkBAIC0zOTMsNiArMzkzLDExIEBAIHZvaWQgQ2hyb21lQ2xpZW50RWZsOjpyZWFjaGVkQXBwbGlj YXRpb25DYWNoZU9yaWdpblF1b3RhKFNlY3VyaXR5T3JpZ2luKiwgaW50NjRfCiAgICAgbm90SW1w bGVtZW50ZWQoKTsKIH0KIAordm9pZCBDaHJvbWVDbGllbnRFZmw6OnBvcHVsYXRlVmlzaXRlZExp bmtzKCkKK3sKKyAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKG1fdmlldywgInBv cHVsYXRlLHZpc2l0ZWQsbGlua3MiLCAwKTsKK30KKwogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMp CiB2b2lkIENocm9tZUNsaWVudEVmbDo6bmVlZFRvdWNoRXZlbnRzKGJvb2wgbmVlZGVkKQogewpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50 RWZsLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwu aAppbmRleCA2NWVhZWIzLi45ZTlmM2QzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9X ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9X ZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuaApAQCAtMTI1LDYgKzEyNSw4IEBAIHB1Ymxp YzoKICAgICB2aXJ0dWFsIHZvaWQgcmVhY2hlZE1heEFwcENhY2hlU2l6ZShpbnQ2NF90IHNwYWNl TmVlZGVkKTsKICAgICB2aXJ0dWFsIHZvaWQgcmVhY2hlZEFwcGxpY2F0aW9uQ2FjaGVPcmlnaW5R dW90YShTZWN1cml0eU9yaWdpbiosIGludDY0X3QgdG90YWxTcGFjZU5lZWRlZCk7CiAKKyAgICB2 aXJ0dWFsIHZvaWQgcG9wdWxhdGVWaXNpdGVkTGlua3MoKTsKKwogI2lmIEVOQUJMRShUT1VDSF9F VkVOVFMpCiAgICAgdmlydHVhbCB2b2lkIG5lZWRUb3VjaEV2ZW50cyhib29sKTsKICNlbmRpZgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggYzY4ZmNmNy4uYjgyYjQ2YSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC00Nyw2ICs0Nyw3IEBACiAjaW5jbHVkZSAiSlNM b2NrLmgiCiAjaW5jbHVkZSAiTGF5b3V0VHlwZXMuaCIKICNpbmNsdWRlICJQYWdlQ2xpZW50RWZs LmgiCisjaW5jbHVkZSAiUGFnZUdyb3VwLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1Nb3VzZUV2ZW50 LmgiCiAjaW5jbHVkZSAiUG9wdXBNZW51Q2xpZW50LmgiCiAjaW5jbHVkZSAiUHJvZ3Jlc3NUcmFj a2VyLmgiCkBAIC0xNjMxLDYgKzE2MzIsMTkgQEAgRXdrX0hpc3RvcnkqIGV3a192aWV3X2hpc3Rv cnlfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogICAgIHJldHVybiBwcml2LT5oaXN0 b3J5OwogfQogCitFaW5hX0Jvb2wgZXdrX3ZpZXdfYWRkX3Zpc2l0ZWRfbGluayhFdmFzX09iamVj dCogZXdrVmlldywgY29uc3QgY2hhciogdmlzaXRlZFVybCkKK3sKKyAgICBFV0tfVklFV19TRF9H RVRfT1JfUkVUVVJOKGV3a1ZpZXcsIHNtYXJ0RGF0YSwgZmFsc2UpOworICAgIEVXS19WSUVXX1BS SVZfR0VUX09SX1JFVFVSTihzbWFydERhdGEsIHByaXYsIGZhbHNlKTsKKworICAgIEVJTkFfU0FG RVRZX09OX05VTExfUkVUVVJOX1ZBTChwcml2LT5wYWdlLCBmYWxzZSk7CisgICAgRUlOQV9TQUZF VFlfT05fTlVMTF9SRVRVUk5fVkFMKHByaXYtPnBhZ2UtPmdyb3VwUHRyKCksIGZhbHNlKTsKKwor ICAgIFdlYkNvcmU6OktVUkwga3VybChXZWJDb3JlOjpLVVJMKCksIFdURjo6U3RyaW5nOjpmcm9t VVRGOCh2aXNpdGVkVXJsKSk7CisgICAgcHJpdi0+cGFnZS0+Z3JvdXBQdHIoKS0+YWRkVmlzaXRl ZExpbmsoa3VybCk7CisgICAgcmV0dXJuIHRydWU7Cit9CisKIGZsb2F0IGV3a192aWV3X3pvb21f Z2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogewogICAgIEVXS19WSUVXX1NEX0dFVF9P Ul9SRVRVUk4oZXdrVmlldywgc21hcnREYXRhLCAtMS4wKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3 LmgKaW5kZXggOTgyMTBmOC4uYWYwMTU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKQEAg LTcxLDYgKzcxLDcgQEAKICAqICAtICJtaXhlZGNvbnRlbnQsZGlzcGxheWVkIiwgdm9pZDogYW55 IG9mIHRoZSBjb250YWluaW5nIGZyYW1lcyBoYXMgbG9hZGVkIGFuZCBkaXNwbGF5ZWQgbWl4ZWQg Y29udGVudC4KICAqICAtICJtaXhlZGNvbnRlbnQscnVuIiwgdm9pZDogYW55IG9mIHRoZSBjb250 YWluaW5nIGZyYW1lcyBoYXMgbG9hZGVkIGFuZCBydW4gbWl4ZWQgY29udGVudC4KICAqICAtICJv bmxvYWQsZXZlbnQiLCBFdmFzX09iamVjdCo6IGEgZnJhbWUgb25sb2FkIGV2ZW50IGhhcyBiZWVu IHJlY2VpdmVkLgorICogIC0gInBvcHVsYXRlLHZpc2l0ZWQsbGlua3MiOiB0ZWxscyB0aGUgY2xp ZW50IHRvIGZpbGwgdGhlIHZpc2l0ZWQgbGlua3Mgc2V0LgogICogIC0gInJlYWR5Iiwgdm9pZDog cGFnZSBpcyBmdWxseSBsb2FkZWQuCiAgKiAgLSAicmVzb3VyY2UscmVxdWVzdCxuZXciLCBFd2tf RnJhbWVfUmVzb3VyY2VfUmVxdWVzdCo6IHJlcG9ydHMgdGhhdAogICogICAgdGhlcmUncyBhIG5l dyByZXNvdXJjZSByZXF1ZXN0LgpAQCAtMTAzNSw2ICsxMDM2LDE5IEBAIEVBUEkgRWluYV9Cb29s ICAgIGV3a192aWV3X2hpc3RvcnlfZW5hYmxlX3NldChFdmFzX09iamVjdCAqbywgRWluYV9Cb29s IGVuYWJsZSk7CiBFQVBJIEV3a19IaXN0b3J5ICpld2tfdmlld19oaXN0b3J5X2dldChjb25zdCBF dmFzX09iamVjdCAqbyk7CiAKIC8qKgorICogQWRkcyBAYSB2aXNpdGVkX3VybCB0byB0aGUgdmll dydzIHZpc2l0ZWQgbGlua3MgY2FjaGUuCisgKgorICogVGhpcyBmdW5jdGlvbiBpcyB0byBiZSBp bnZva2VkIGJ5IHRoZSBjbGllbnQgbWFuYWdpbmcgcGVyc2lzdGVudCBoaXN0b3J5IHN0b3JhZ2UK KyAqIHdoZW4gInBvcHVsYXRlLHZpc2l0ZWQsbGlua3MiIHNpZ25hbCBpcyByZWNlaXZlZC4KKyAq CisgKiBAcGFyYW0gbyB2aWV3IG9iamVjdCB0byBhZGQgdmlzaXRlZCBsaW5rcyBkYXRhLgorICog QHBhcmFtIHZpc2l0ZWRfdXJsIHZpc2l0ZWQgdXJsLgorICoKKyAqIEByZXR1cm4gQGMgRUlOQV9U UlVFIG9uIHN1Y2Nlc3MsIEBjIEVJTkFfRkFMU0Ugb24gZmFpbHVyZS4KKyAqLworRUFQSSBFaW5h X0Jvb2wgIGV3a192aWV3X2FkZF92aXNpdGVkX2xpbmsoRXZhc19PYmplY3QgKm8sICBjb25zdCBj aGFyICp2aXNpdGVkX3VybCk7CisKKy8qKgogICogR2V0cyB0aGUgY3VycmVudCBwYWdlIHpvb20g bGV2ZWwgb2YgdGhlIG1haW4gZnJhbWUuCiAgKgogICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8g Z2V0IHRoZSB6b29tIGxldmVsCg== 143541 2012-05-23 05:17:22 -0700 2012-05-25 01:00:50 -0700 patch v2 (fixed review comments) bug86370_v2 text/plain 5147 mikhail.pozdnyakov Y29tbWl0IDE1MDU2YTQyMmQxNjNiZWVjZTEwOTE2Y2QzM2YxODEzZTFjYjAyOGIKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPHBvemRueWFrb3YubWlraGFpbEBnbWFpbC5jb20+CkRhdGU6ICAg VHVlIE1heSAxNSAxNDo1OTo1MCAyMDEyICswMzAwCgogICAgYnVnODYzNzAKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VM b2cKaW5kZXggMjkyNWEwMC4uOTE0YWE2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTA1LTE1ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZA aW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIEFQSSBmb3IgUGFnZUdyb3VwIHZpc2l0ZWQgbGlu a3MgaGFzaCBwb3B1bGF0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04NjM3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZGVkICJwb3B1bGF0ZSx2aXNpdGVkLGxpbmtzIiBld2tfdmlldyBzaWduYWwg dGhhdCB0ZWxscyB0byB0aGUgY2xpZW50IG1hbmFnaW5nCisgICAgICAgIHBlcnNpc3RlbnQgaGlz dG9yeSBzdG9yYWdlIHRvIGZpbGwgdGhlIHZpc2l0ZWQgbGlua3MgY2FjaGUuCisgICAgICAgIEFk ZGVkIEFQSSBmb3IgdGhlIFBhZ2VHcm91cCB2aXNpdGVkIGxpbmtzIGhhc2ggcG9wdWxhdGluZy4K KworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDaHJvbWVDbGllbnRFZmw6OnBvcHVsYXRlVmlzaXRlZExpbmtzKTogSW1wbGVt ZW50YXRpb24gYWRkZWQgKHNlbmRzIG5vdGlmaWNhdGlvbikuCisgICAgICAgIChXZWJDb3JlKToK KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuaDoKKyAgICAgICAgKENo cm9tZUNsaWVudEVmbCk6CisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9F d2tfVmlld19Qcml2YXRlX0RhdGEpOgorICAgICAgICAoZXdrX3ZpZXdfdmlzaXRlZF9saW5rX2Fk ZCk6IFBhZ2VHcm91cCB2aXNpdGVkIGxpbmtzIGhhc2ggcG9wdWxhdGluZy4KKyAgICAgICAgKiBl d2svZXdrX3ZpZXcuaDoKKwogMjAxMi0wNS0yMyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9w aGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIEVGTCdzIERSVCBkb2VzIG5vdCBw cmludCBkaWRGYWlsUHJvdmlzaW9uYWxMb2FkV2l0aEVycm9yIG1lc3NhZ2VzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwIGIv U291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmNwcAppbmRl eCA4YWFkYWNhLi45OGEwODI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3Jl U3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL1dlYkNv cmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHAKQEAgLTQwOSw2ICs0MDksMTEgQEAgdm9pZCBD aHJvbWVDbGllbnRFZmw6OnJlYWNoZWRBcHBsaWNhdGlvbkNhY2hlT3JpZ2luUXVvdGEoU2VjdXJp dHlPcmlnaW4qIG9yaWdpbiwKICAgICBld2tfc2VjdXJpdHlfb3JpZ2luX2ZyZWUoZXdrT3JpZ2lu KTsKIH0KIAordm9pZCBDaHJvbWVDbGllbnRFZmw6OnBvcHVsYXRlVmlzaXRlZExpbmtzKCkKK3sK KyAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKG1fdmlldywgInBvcHVsYXRlLHZp c2l0ZWQsbGlua3MiLCAwKTsKK30KKwogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiB2b2lkIENo cm9tZUNsaWVudEVmbDo6bmVlZFRvdWNoRXZlbnRzKGJvb2wgbmVlZGVkKQogewpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hyb21lQ2xpZW50RWZsLmggYi9T b3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuaAppbmRleCA0 YmQ2NmM5Li4wOGNhZGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3Vw cG9ydC9DaHJvbWVDbGllbnRFZmwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9XZWJDb3JlU3Vw cG9ydC9DaHJvbWVDbGllbnRFZmwuaApAQCAtMTI1LDYgKzEyNSw4IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIHZvaWQgcmVhY2hlZE1heEFwcENhY2hlU2l6ZShpbnQ2NF90IHNwYWNlTmVlZGVkKTsK ICAgICB2aXJ0dWFsIHZvaWQgcmVhY2hlZEFwcGxpY2F0aW9uQ2FjaGVPcmlnaW5RdW90YShTZWN1 cml0eU9yaWdpbiosIGludDY0X3QgdG90YWxTcGFjZU5lZWRlZCk7CiAKKyAgICB2aXJ0dWFsIHZv aWQgcG9wdWxhdGVWaXNpdGVkTGlua3MoKTsKKwogI2lmIEVOQUJMRShUT1VDSF9FVkVOVFMpCiAg ICAgdmlydHVhbCB2b2lkIG5lZWRUb3VjaEV2ZW50cyhib29sKTsKICNlbmRpZgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAKaW5kZXggNTQyOWEzZS4uZGM5NzJjMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3ZpZXcuY3BwCkBAIC00Nyw2ICs0Nyw3IEBACiAjaW5jbHVkZSAiSlNMb2NrLmgiCiAj aW5jbHVkZSAiTGF5b3V0VHlwZXMuaCIKICNpbmNsdWRlICJQYWdlQ2xpZW50RWZsLmgiCisjaW5j bHVkZSAiUGFnZUdyb3VwLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1Nb3VzZUV2ZW50LmgiCiAjaW5j bHVkZSAiUG9wdXBNZW51Q2xpZW50LmgiCiAjaW5jbHVkZSAiUHJvZ3Jlc3NUcmFja2VyLmgiCkBA IC0xNzA1LDYgKzE3MDYsMTkgQEAgRXdrX0hpc3RvcnkqIGV3a192aWV3X2hpc3RvcnlfZ2V0KGNv bnN0IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogICAgIHJldHVybiBwcml2LT5oaXN0b3J5OwogfQog CitFaW5hX0Jvb2wgZXdrX3ZpZXdfdmlzaXRlZF9saW5rX2FkZChFdmFzX09iamVjdCogZXdrVmll dywgY29uc3QgY2hhciogdmlzaXRlZFVybCkKK3sKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVU VVJOKGV3a1ZpZXcsIHNtYXJ0RGF0YSwgZmFsc2UpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09S X1JFVFVSTihzbWFydERhdGEsIHByaXYsIGZhbHNlKTsKKworICAgIEVJTkFfU0FGRVRZX09OX05V TExfUkVUVVJOX1ZBTChwcml2LT5wYWdlLCBmYWxzZSk7CisgICAgRUlOQV9TQUZFVFlfT05fTlVM TF9SRVRVUk5fVkFMKHByaXYtPnBhZ2UtPmdyb3VwUHRyKCksIGZhbHNlKTsKKworICAgIFdlYkNv cmU6OktVUkwga3VybChXZWJDb3JlOjpLVVJMKCksIFdURjo6U3RyaW5nOjpmcm9tVVRGOCh2aXNp dGVkVXJsKSk7CisgICAgcHJpdi0+cGFnZS0+Z3JvdXBQdHIoKS0+YWRkVmlzaXRlZExpbmsoa3Vy bCk7CisgICAgcmV0dXJuIHRydWU7Cit9CisKIGZsb2F0IGV3a192aWV3X3pvb21fZ2V0KGNvbnN0 IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogewogICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4o ZXdrVmlldywgc21hcnREYXRhLCAtMS4wKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKaW5kZXgg YjhiMGFiNi4uZTI4YjJkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192 aWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmgKQEAgLTczLDYgKzcz LDcgQEAKICAqICAtICJtaXhlZGNvbnRlbnQscnVuIiwgdm9pZDogYW55IG9mIHRoZSBjb250YWlu aW5nIGZyYW1lcyBoYXMgbG9hZGVkIGFuZCBydW4gbWl4ZWQgY29udGVudC4KICAqICAtICJwcm90 b2NvbGhhbmRsZXIscmVnaXN0cmF0aW9uLHJlcXVlc3RlZCIsIEV3a19DdXN0b21fSGFuZGxlcl9E YXRhOiBhZGQgYSBoYW5kbGVyIHVybCBmb3IgdGhlIGdpdmVuIHByb3RvY29sLgogICogIC0gIm9u bG9hZCxldmVudCIsIEV2YXNfT2JqZWN0KjogYSBmcmFtZSBvbmxvYWQgZXZlbnQgaGFzIGJlZW4g cmVjZWl2ZWQuCisgKiAgLSAicG9wdWxhdGUsdmlzaXRlZCxsaW5rcyI6IHRlbGxzIHRoZSBjbGll bnQgdG8gZmlsbCB0aGUgdmlzaXRlZCBsaW5rcyBzZXQuCiAgKiAgLSAicmVhZHkiLCB2b2lkOiBw YWdlIGlzIGZ1bGx5IGxvYWRlZC4KICAqICAtICJyZXNvdXJjZSxyZXF1ZXN0LG5ldyIsIEV3a19G cmFtZV9SZXNvdXJjZV9SZXF1ZXN0KjogcmVwb3J0cyB0aGF0CiAgKiAgICB0aGVyZSdzIGEgbmV3 IHJlc291cmNlIHJlcXVlc3QuCkBAIC0xMTAxLDYgKzExMDIsMTkgQEAgRUFQSSBFaW5hX0Jvb2wg ICAgZXdrX3ZpZXdfaGlzdG9yeV9lbmFibGVfc2V0KEV2YXNfT2JqZWN0ICpvLCBFaW5hX0Jvb2wg ZW5hYmxlKTsKIEVBUEkgRXdrX0hpc3RvcnkgKmV3a192aWV3X2hpc3RvcnlfZ2V0KGNvbnN0IEV2 YXNfT2JqZWN0ICpvKTsKIAogLyoqCisgKiBBZGRzIEBhIHZpc2l0ZWRfdXJsIHRvIHRoZSB2aWV3 J3MgdmlzaXRlZCBsaW5rcyBjYWNoZS4KKyAqCisgKiBUaGlzIGZ1bmN0aW9uIGlzIHRvIGJlIGlu dm9rZWQgYnkgdGhlIGNsaWVudCBtYW5hZ2luZyBwZXJzaXN0ZW50IGhpc3Rvcnkgc3RvcmFnZQor ICogd2hlbiAicG9wdWxhdGUsdmlzaXRlZCxsaW5rcyIgc2lnbmFsIGlzIHJlY2VpdmVkLgorICoK KyAqIEBwYXJhbSBvIHZpZXcgb2JqZWN0IHRvIGFkZCB2aXNpdGVkIGxpbmtzIGRhdGEuCisgKiBA cGFyYW0gdmlzaXRlZF91cmwgdmlzaXRlZCB1cmwuCisgKgorICogQHJldHVybiBAYyBFSU5BX1RS VUUgb24gc3VjY2VzcywgQGMgRUlOQV9GQUxTRSBvbiBmYWlsdXJlLgorICovCitFQVBJIEVpbmFf Qm9vbCAgZXdrX3ZpZXdfdmlzaXRlZF9saW5rX2FkZChFdmFzX09iamVjdCAqbywgY29uc3QgY2hh ciAqdmlzaXRlZF91cmwpOworCisvKioKICAqIEdldHMgdGhlIGN1cnJlbnQgcGFnZSB6b29tIGxl dmVsIG9mIHRoZSBtYWluIGZyYW1lLgogICoKICAqIEBwYXJhbSBvIHZpZXcgb2JqZWN0IHRvIGdl dCB0aGUgem9vbSBsZXZlbAo=