86365 2012-05-14 05:58:02 -0700 [GTK] [WK2] Memory leaks in WebKitWebSettings 2012-05-14 08:32:25 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cgarcia gustavo mrobinson webkit.review.bot oldest_to_newest 622879 0 naginenis 2012-05-14 05:58:02 -0700 Valgrind reports many memory leaks in WebKitWebSettings. I think we can fix these leaks by adopting an allocation using adoptWK. ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,464 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC1F0: WKPreferencesCopyFixedFontFamily (WKPreferences.cpp:208) ==27084== by 0x60E1E7F: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:925) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x40B020: main (main.c:209) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,465 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC28C: WKPreferencesCopySerifFontFamily (WKPreferences.cpp:218) ==27084== by 0x60E1F0A: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:928) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x40B020: main (main.c:209) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,466 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC328: WKPreferencesCopySansSerifFontFamily (WKPreferences.cpp:228) ==27084== by 0x60E1F95: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:931) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x40B020: main (main.c:209) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,467 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC3C4: WKPreferencesCopyCursiveFontFamily (WKPreferences.cpp:238) ==27084== by 0x60E2020: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:934) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x40B020: main (main.c:209) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,468 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC460: WKPreferencesCopyFantasyFontFamily (WKPreferences.cpp:248) ==27084== by 0x60E209C: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:937) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x40B020: main (main.c:209) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,469 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC4FC: WKPreferencesCopyPictographFontFamily (WKPreferences.cpp:258) ==27084== by 0x60E2118: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:940) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x40B020: main (main.c:209) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,470 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC6E4: WKPreferencesCopyDefaultTextEncodingName (WKPreferences.cpp:308) ==27084== by 0x60E2194: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:943) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x40B020: main (main.c:209) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,471 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x6082DFA: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==27084== by 0x6082A2D: WKStringCreateWithUTF8CString (WKString.cpp:41) ==27084== by 0x60E3ED6: webkit_settings_set_serif_font_family (WebKitSettings.cpp:1514) ==27084== by 0x60E0609: webKitSettingsSetProperty(_GObject*, unsigned int, _GValue const*, _GParamSpec*) (WebKitSettings.cpp:162) ==27084== by 0xAF1722D: g_object_constructor (gobject.c:1352) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x40B020: main (main.c:209) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,472 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC154: WKPreferencesCopyStandardFontFamily (WKPreferences.cpp:198) ==27084== by 0x60E1DF4: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:922) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x60ECE02: webkitWebViewConstructed(_GObject*) (WebKitWebView.cpp:274) ==27084== by 0xAF18B82: g_object_newv (gobject.c:1741) ==27084== by 0xAF18EC5: g_object_new_valist (gobject.c:1830) ==27084== by 0xAF191D3: g_object_new (gobject.c:1545) ==27084== by 0x60EE76D: webkit_web_view_new_with_context (WebKitWebView.cpp:1094) ==27084== by 0x60EE6AD: webkit_web_view_new (WebKitWebView.cpp:1079) ==27084== by 0x40A8A2: createBrowserWindow (main.c:47) ==27084== by 0x40B0F6: main (main.c:229) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,473 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC1F0: WKPreferencesCopyFixedFontFamily (WKPreferences.cpp:208) ==27084== by 0x60E1E7F: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:925) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x60ECE02: webkitWebViewConstructed(_GObject*) (WebKitWebView.cpp:274) ==27084== by 0xAF18B82: g_object_newv (gobject.c:1741) ==27084== by 0xAF18EC5: g_object_new_valist (gobject.c:1830) ==27084== by 0xAF191D3: g_object_new (gobject.c:1545) ==27084== by 0x60EE76D: webkit_web_view_new_with_context (WebKitWebView.cpp:1094) ==27084== by 0x60EE6AD: webkit_web_view_new (WebKitWebView.cpp:1079) ==27084== by 0x40A8A2: createBrowserWindow (main.c:47) ==27084== by 0x40B0F6: main (main.c:229) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,474 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC28C: WKPreferencesCopySerifFontFamily (WKPreferences.cpp:218) ==27084== by 0x60E1F0A: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:928) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x60ECE02: webkitWebViewConstructed(_GObject*) (WebKitWebView.cpp:274) ==27084== by 0xAF18B82: g_object_newv (gobject.c:1741) ==27084== by 0xAF18EC5: g_object_new_valist (gobject.c:1830) ==27084== by 0xAF191D3: g_object_new (gobject.c:1545) ==27084== by 0x60EE76D: webkit_web_view_new_with_context (WebKitWebView.cpp:1094) ==27084== by 0x60EE6AD: webkit_web_view_new (WebKitWebView.cpp:1079) ==27084== by 0x40A8A2: createBrowserWindow (main.c:47) ==27084== by 0x40B0F6: main (main.c:229) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,475 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC328: WKPreferencesCopySansSerifFontFamily (WKPreferences.cpp:228) ==27084== by 0x60E1F95: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:931) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x60ECE02: webkitWebViewConstructed(_GObject*) (WebKitWebView.cpp:274) ==27084== by 0xAF18B82: g_object_newv (gobject.c:1741) ==27084== by 0xAF18EC5: g_object_new_valist (gobject.c:1830) ==27084== by 0xAF191D3: g_object_new (gobject.c:1545) ==27084== by 0x60EE76D: webkit_web_view_new_with_context (WebKitWebView.cpp:1094) ==27084== by 0x60EE6AD: webkit_web_view_new (WebKitWebView.cpp:1079) ==27084== by 0x40A8A2: createBrowserWindow (main.c:47) ==27084== by 0x40B0F6: main (main.c:229) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,476 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC3C4: WKPreferencesCopyCursiveFontFamily (WKPreferences.cpp:238) ==27084== by 0x60E2020: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:934) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x60ECE02: webkitWebViewConstructed(_GObject*) (WebKitWebView.cpp:274) ==27084== by 0xAF18B82: g_object_newv (gobject.c:1741) ==27084== by 0xAF18EC5: g_object_new_valist (gobject.c:1830) ==27084== by 0xAF191D3: g_object_new (gobject.c:1545) ==27084== by 0x60EE76D: webkit_web_view_new_with_context (WebKitWebView.cpp:1094) ==27084== by 0x60EE6AD: webkit_web_view_new (WebKitWebView.cpp:1079) ==27084== by 0x40A8A2: createBrowserWindow (main.c:47) ==27084== by 0x40B0F6: main (main.c:229) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,477 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC460: WKPreferencesCopyFantasyFontFamily (WKPreferences.cpp:248) ==27084== by 0x60E209C: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:937) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x60ECE02: webkitWebViewConstructed(_GObject*) (WebKitWebView.cpp:274) ==27084== by 0xAF18B82: g_object_newv (gobject.c:1741) ==27084== by 0xAF18EC5: g_object_new_valist (gobject.c:1830) ==27084== by 0xAF191D3: g_object_new (gobject.c:1545) ==27084== by 0x60EE76D: webkit_web_view_new_with_context (WebKitWebView.cpp:1094) ==27084== by 0x60EE6AD: webkit_web_view_new (WebKitWebView.cpp:1079) ==27084== by 0x40A8A2: createBrowserWindow (main.c:47) ==27084== by 0x40B0F6: main (main.c:229) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,478 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC4FC: WKPreferencesCopyPictographFontFamily (WKPreferences.cpp:258) ==27084== by 0x60E2118: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:940) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x60ECE02: webkitWebViewConstructed(_GObject*) (WebKitWebView.cpp:274) ==27084== by 0xAF18B82: g_object_newv (gobject.c:1741) ==27084== by 0xAF18EC5: g_object_new_valist (gobject.c:1830) ==27084== by 0xAF191D3: g_object_new (gobject.c:1545) ==27084== by 0x60EE76D: webkit_web_view_new_with_context (WebKitWebView.cpp:1094) ==27084== by 0x60EE6AD: webkit_web_view_new (WebKitWebView.cpp:1079) ==27084== by 0x40A8A2: createBrowserWindow (main.c:47) ==27084== by 0x40B0F6: main (main.c:229) ==27084== ==27084== 24 bytes in 1 blocks are definitely lost in loss record 2,479 of 7,584 ==27084== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==27084== by 0xC0CF4AA: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==27084== by 0x605BD16: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==27084== by 0x607CBB0: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==27084== by 0x607CC7E: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==27084== by 0x60CC6E4: WKPreferencesCopyDefaultTextEncodingName (WKPreferences.cpp:308) ==27084== by 0x60E2194: webkit_settings_init(_WebKitSettings*) (WebKitSettings.cpp:943) ==27084== by 0xAF32956: g_type_create_instance (gtype.c:1892) ==27084== by 0xAF170B8: g_object_constructor (gobject.c:1849) ==27084== by 0xAF186E3: g_object_newv (gobject.c:1713) ==27084== by 0xAF191EB: g_object_new (gobject.c:1542) ==27084== by 0x60E22D4: webkit_settings_new (WebKitSettings.cpp:963) ==27084== by 0x60ECE02: webkitWebViewConstructed(_GObject*) (WebKitWebView.cpp:274) ==27084== by 0xAF18B82: g_object_newv (gobject.c:1741) ==27084== by 0xAF18EC5: g_object_new_valist (gobject.c:1830) ==27084== by 0xAF191D3: g_object_new (gobject.c:1545) ==27084== by 0x60EE76D: webkit_web_view_new_with_context (WebKitWebView.cpp:1094) ==27084== by 0x60EE6AD: webkit_web_view_new (WebKitWebView.cpp:1079) ==27084== by 0x40A8A2: createBrowserWindow (main.c:47) ==27084== by 0x40B0F6: main (main.c:229) ==27084== 622910 1 141715 naginenis 2012-05-14 06:27:20 -0700 Created attachment 141715 Fix memory leaks 622912 2 webkit.review.bot 2012-05-14 06:29:05 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 622931 3 141715 cgarcia 2012-05-14 06:52:55 -0700 Comment on attachment 141715 Fix memory leaks Looks good to me, good catch! 622986 4 141715 mrobinson 2012-05-14 08:14:36 -0700 Comment on attachment 141715 Fix memory leaks Great work. 622994 5 naginenis 2012-05-14 08:19:37 -0700 Thanks for your review Carlos and Martin. 623007 6 141715 webkit.review.bot 2012-05-14 08:32:21 -0700 Comment on attachment 141715 Fix memory leaks Clearing flags on attachment: 141715 Committed r116950: <http://trac.webkit.org/changeset/116950> 623008 7 webkit.review.bot 2012-05-14 08:32:25 -0700 All reviewed patches have been landed. Closing bug. 141715 2012-05-14 06:27:20 -0700 2012-05-14 08:32:21 -0700 Fix memory leaks 86365.patch text/plain 4383 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NmI3NzY1Li44NWQyMWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDUtMTQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0dUS10gW1dLMl0gTWVtb3J5IGxlYWtzIGluIFdl YktpdFdlYlNldHRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04NjM2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEZpeCBtZW1vcnkgbGVha3MgaW4gV2ViS2l0V2ViU2V0dGluZ3MgYnkgYWRvcHRpbmcg YWxsb2NhdGlvbnMKKyAgICAgICAgdXNpbmcgYWRvcHRXSy4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFNldHRpbmdzLmNwcDoKKyAgICAgICAgKHdlYmtpdF9zZXR0aW5nc19p bml0KToKKyAgICAgICAgKHdlYmtpdF9zZXR0aW5nc19zZXRfc2VyaWZfZm9udF9mYW1pbHkpOgor CiAyMDEyLTA1LTExICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K IAogICAgICAgICBJbnRyb2R1Y2UgUHJvcGVydHlOYW1lIGNsYXNzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRTZXR0aW5ncy5jcHAKaW5kZXggNWMwMjcw NC4uY2QwNGViMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0U2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFNldHRpbmdzLmNwcApAQCAtOTE5LDI4ICs5MTksMjggQEAgc3RhdGljIHZvaWQgd2Vi a2l0X3NldHRpbmdzX2luaXQoV2ViS2l0U2V0dGluZ3MqIHNldHRpbmdzKQogCiAgICAgcHJpdi0+ cHJlZmVyZW5jZXMgPSBhZG9wdFdLKFdLUHJlZmVyZW5jZXNDcmVhdGUoKSk7CiAKLSAgICBXS1Jl dGFpblB0cjxXS1N0cmluZ1JlZj4gZGVmYXVsdEZvbnRGYW1pbHlSZWYgPSBXS1ByZWZlcmVuY2Vz Q29weVN0YW5kYXJkRm9udEZhbWlseShwcml2LT5wcmVmZXJlbmNlcy5nZXQoKSk7CisgICAgV0tS ZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGRlZmF1bHRGb250RmFtaWx5UmVmID0gYWRvcHRXSyhXS1By ZWZlcmVuY2VzQ29weVN0YW5kYXJkRm9udEZhbWlseShwcml2LT5wcmVmZXJlbmNlcy5nZXQoKSkp OwogICAgIHByaXYtPmRlZmF1bHRGb250RmFtaWx5ID0gIFdlYktpdDo6dG9JbXBsKGRlZmF1bHRG b250RmFtaWx5UmVmLmdldCgpKS0+c3RyaW5nKCkudXRmOCgpOwogCi0gICAgV0tSZXRhaW5QdHI8 V0tTdHJpbmdSZWY+IG1vbm9zcGFjZUZvbnRGYW1pbHlSZWYgPSBXS1ByZWZlcmVuY2VzQ29weUZp eGVkRm9udEZhbWlseShwcml2LT5wcmVmZXJlbmNlcy5nZXQoKSk7CisgICAgV0tSZXRhaW5QdHI8 V0tTdHJpbmdSZWY+IG1vbm9zcGFjZUZvbnRGYW1pbHlSZWYgPSBhZG9wdFdLKFdLUHJlZmVyZW5j ZXNDb3B5Rml4ZWRGb250RmFtaWx5KHByaXYtPnByZWZlcmVuY2VzLmdldCgpKSk7CiAgICAgcHJp di0+bW9ub3NwYWNlRm9udEZhbWlseSA9IFdlYktpdDo6dG9JbXBsKG1vbm9zcGFjZUZvbnRGYW1p bHlSZWYuZ2V0KCkpLT5zdHJpbmcoKS51dGY4KCk7CiAKLSAgICBXS1JldGFpblB0cjxXS1N0cmlu Z1JlZj4gc2VyaWZGb250RmFtaWx5UmVmID0gV0tQcmVmZXJlbmNlc0NvcHlTZXJpZkZvbnRGYW1p bHkocHJpdi0+cHJlZmVyZW5jZXMuZ2V0KCkpOworICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVm PiBzZXJpZkZvbnRGYW1pbHlSZWYgPSBhZG9wdFdLKFdLUHJlZmVyZW5jZXNDb3B5U2VyaWZGb250 RmFtaWx5KHByaXYtPnByZWZlcmVuY2VzLmdldCgpKSk7CiAgICAgcHJpdi0+c2VyaWZGb250RmFt aWx5ID0gV2ViS2l0Ojp0b0ltcGwoc2VyaWZGb250RmFtaWx5UmVmLmdldCgpKS0+c3RyaW5nKCku dXRmOCgpOwogCi0gICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHNhbnNTZXJpZkZvbnRGYW1p bHlSZWYgPSBXS1ByZWZlcmVuY2VzQ29weVNhbnNTZXJpZkZvbnRGYW1pbHkocHJpdi0+cHJlZmVy ZW5jZXMuZ2V0KCkpOworICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBzYW5zU2VyaWZGb250 RmFtaWx5UmVmID0gYWRvcHRXSyhXS1ByZWZlcmVuY2VzQ29weVNhbnNTZXJpZkZvbnRGYW1pbHko cHJpdi0+cHJlZmVyZW5jZXMuZ2V0KCkpKTsKICAgICBwcml2LT5zYW5zU2VyaWZGb250RmFtaWx5 ID0gV2ViS2l0Ojp0b0ltcGwoc2Fuc1NlcmlmRm9udEZhbWlseVJlZi5nZXQoKSktPnN0cmluZygp LnV0ZjgoKTsKIAotICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBjdXJzaXZlRm9udEZhbWls eVJlZiA9IFdLUHJlZmVyZW5jZXNDb3B5Q3Vyc2l2ZUZvbnRGYW1pbHkocHJpdi0+cHJlZmVyZW5j ZXMuZ2V0KCkpOworICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBjdXJzaXZlRm9udEZhbWls eVJlZiA9IGFkb3B0V0soV0tQcmVmZXJlbmNlc0NvcHlDdXJzaXZlRm9udEZhbWlseShwcml2LT5w cmVmZXJlbmNlcy5nZXQoKSkpOwogICAgIHByaXYtPmN1cnNpdmVGb250RmFtaWx5ID0gV2ViS2l0 Ojp0b0ltcGwoY3Vyc2l2ZUZvbnRGYW1pbHlSZWYuZ2V0KCkpLT5zdHJpbmcoKS51dGY4KCk7CiAK LSAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gZmFudGFzeUZvbnRGYW1pbHlSZWYgPSBXS1By ZWZlcmVuY2VzQ29weUZhbnRhc3lGb250RmFtaWx5KHByaXYtPnByZWZlcmVuY2VzLmdldCgpKTsK KyAgICBXS1JldGFpblB0cjxXS1N0cmluZ1JlZj4gZmFudGFzeUZvbnRGYW1pbHlSZWYgPSBhZG9w dFdLKFdLUHJlZmVyZW5jZXNDb3B5RmFudGFzeUZvbnRGYW1pbHkocHJpdi0+cHJlZmVyZW5jZXMu Z2V0KCkpKTsKICAgICBwcml2LT5mYW50YXN5Rm9udEZhbWlseSA9IFdlYktpdDo6dG9JbXBsKGZh bnRhc3lGb250RmFtaWx5UmVmLmdldCgpKS0+c3RyaW5nKCkudXRmOCgpOwogCi0gICAgV0tSZXRh aW5QdHI8V0tTdHJpbmdSZWY+IHBpY3RvZ3JhcGhGb250RmFtaWx5UmVmID0gV0tQcmVmZXJlbmNl c0NvcHlQaWN0b2dyYXBoRm9udEZhbWlseShwcml2LT5wcmVmZXJlbmNlcy5nZXQoKSk7CisgICAg V0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHBpY3RvZ3JhcGhGb250RmFtaWx5UmVmID0gYWRvcHRX SyhXS1ByZWZlcmVuY2VzQ29weVBpY3RvZ3JhcGhGb250RmFtaWx5KHByaXYtPnByZWZlcmVuY2Vz LmdldCgpKSk7CiAgICAgcHJpdi0+cGljdG9ncmFwaEZvbnRGYW1pbHkgPSBXZWJLaXQ6OnRvSW1w bChwaWN0b2dyYXBoRm9udEZhbWlseVJlZi5nZXQoKSktPnN0cmluZygpLnV0ZjgoKTsKIAotICAg IFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBkZWZhdWx0Q2hhcnNldFJlZiA9IFdLUHJlZmVyZW5j ZXNDb3B5RGVmYXVsdFRleHRFbmNvZGluZ05hbWUocHJpdi0+cHJlZmVyZW5jZXMuZ2V0KCkpOwor ICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiBkZWZhdWx0Q2hhcnNldFJlZiA9IGFkb3B0V0so V0tQcmVmZXJlbmNlc0NvcHlEZWZhdWx0VGV4dEVuY29kaW5nTmFtZShwcml2LT5wcmVmZXJlbmNl cy5nZXQoKSkpOwogICAgIHByaXYtPmRlZmF1bHRDaGFyc2V0ID0gV2ViS2l0Ojp0b0ltcGwoZGVm YXVsdENoYXJzZXRSZWYuZ2V0KCkpLT5zdHJpbmcoKS51dGY4KCk7CiB9CiAKQEAgLTE1MTEsNyAr MTUxMSw3IEBAIHZvaWQgd2Via2l0X3NldHRpbmdzX3NldF9zZXJpZl9mb250X2ZhbWlseShXZWJL aXRTZXR0aW5ncyogc2V0dGluZ3MsIGNvbnN0IGdjaGFyCiAgICAgaWYgKCFnX3N0cmNtcDAocHJp di0+c2VyaWZGb250RmFtaWx5LmRhdGEoKSwgc2VyaWZGb250RmFtaWx5KSkKICAgICAgICAgcmV0 dXJuOwogCi0gICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHNlcmlmRm9udEZhbWlseVJlZiA9 IFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKHNlcmlmRm9udEZhbWlseSk7CisgICAgV0tS ZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHNlcmlmRm9udEZhbWlseVJlZiA9IGFkb3B0V0soV0tTdHJp bmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoc2VyaWZGb250RmFtaWx5KSk7CiAgICAgV0tQcmVmZXJl bmNlc1NldFNlcmlmRm9udEZhbWlseShwcml2LT5wcmVmZXJlbmNlcy5nZXQoKSwgc2VyaWZGb250 RmFtaWx5UmVmLmdldCgpKTsKICAgICBwcml2LT5zZXJpZkZvbnRGYW1pbHkgPSBXZWJLaXQ6OnRv SW1wbChzZXJpZkZvbnRGYW1pbHlSZWYuZ2V0KCkpLT5zdHJpbmcoKS51dGY4KCk7CiAK