86310 2012-05-12 20:21:56 -0700 [GStreamer] media/media-continues-playing-after-replace-source.html fails 2012-08-09 14:33:06 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/builders/EFL Linux Debug/builds/1574 LayoutTestFailure, MakingBotsRed P2 Normal --- 93658 86235 1 rakuco pnormand d-r eric.carlson feature-media-reviews gustavo gyuyoung.kim menard mfeil mrobinson ossy pnormand spena tmpsantos webkit.review.bot zan oldest_to_newest 622454 0 rakuco 2012-05-12 20:21:56 -0700 <http://trac.webkit.org/changeset/116858> has made the EFL and GTK+ bots fail the media/media-continues-playing-after-replace-source.html and should be fixed. Layout test results for the bots can be accessed via http://build.webkit.org/results 622509 1 mfeil 2012-05-13 10:15:28 -0700 (In reply to comment #0) > <http://trac.webkit.org/changeset/116858> has made the EFL and GTK+ bots fail the media/media-continues-playing-after-replace-source.html and should be fixed. This changeset is a result of https://bugs.webkit.org/show_bug.cgi?id=86235. The EWS analysis shows all green, including for efl and gtk. In fact different versions of this test passed both efl and gtk 3 times on separate EWS analyses. So I'm wondering what's going on here. The failed test results for EFL are: FAIL: Timed out waiting for notifyDone to be called Test that media keeps playing when the source element is replaced. The failed test results for GTK are: FAIL: Timed out waiting for notifyDone to be called Test that media keeps playing when the source element is replaced. EVENT(canplaythrough) EXPECTED (testElement.currentTime == '0') OK EVENT(playing) EXPECTED (testElement.currentTime > '0') OK Replacing the media's source element: EXPECTED (testElement.currentTime == '0') OK These seem like actual bugs. So what I propose to do is to add this test to the "skipped" files for these two ports, and then open new bugs to determine why the test fails. 622510 2 mfeil 2012-05-13 10:24:58 -0700 (In reply to comment #1) > These seem like actual bugs. The EFL case looks like the Layout Test framework is not set up to support any HTML5 media tests. They are all failing. This is just one more in a long list of failures. Is the correct thing to put this test in the Skipped file in that case? Why aren't all the other media tests in the Skipped file? 622511 3 mfeil 2012-05-13 10:28:15 -0700 In the GTK case, I'm thinking that it may be best to leave the test failure outstanding, rather than hide it via the Skipped file. This test has highlighted an area where the GTK port is different than the other major ports, and perhaps should be brought in line instead of ignoring the test. 622530 4 rakuco 2012-05-13 14:01:28 -0700 (In reply to comment #1) > This changeset is a result of https://bugs.webkit.org/show_bug.cgi?id=86235. The EWS analysis shows all green, including for efl and gtk. In fact different versions of this test passed both efl and gtk 3 times on separate EWS analyses. So I'm wondering what's going on here. Most of the EWS bots only build the patches, they don't run the layout tests. (In reply to comment #2) > The EFL case looks like the Layout Test framework is not set up to support any HTML5 media tests. They are all failing. This is just one more in a long list of failures. Is the correct thing to put this test in the Skipped file in that case? Why aren't all the other media tests in the Skipped file? They aren't all skipped because they pass :-) As you said, I think the best option for now is to skip the test on the port to get things green and then investigate. 622534 5 rakuco 2012-05-13 14:09:02 -0700 I've skipped the test for the EFL port in <http://trac.webkit.org/changeset/116901>, and have filed bug 86322. 623154 6 mfeil 2012-05-14 11:39:21 -0700 (In reply to comment #4) > Most of the EWS bots only build the patches, they don't run the layout tests. Thanks for that piece of information. I assumed all the EWS bots ran layout tests, as this is an important verification of the sanity of a patch. Can you tell me which bots don't run layout tests of the 7 ports which are currently part of EWS? Also, can you tell me how to actually run a proposed layout test on all major ports to ensure that it passes before I submit a patch for review? > They aren't all skipped because they pass :-) I am looking at results in http://build.webkit.org/results/EFL%20Linux%20Release/ and every media test that I look at has the following line in the actual results: FAIL: Timed out waiting for notifyDone to be called Am I looking in the wrong place? 623160 7 rakuco 2012-05-14 11:45:36 -0700 (In reply to comment #6) > (In reply to comment #4) > > Most of the EWS bots only build the patches, they don't run the layout tests. > > Thanks for that piece of information. I assumed all the EWS bots ran layout tests, as this is an important verification of the sanity of a patch. Can you tell me which bots don't run layout tests of the 7 ports which are currently part of EWS? IIRC, only the chromium bot runs layout tests, all the others only build the patches. > Also, can you tell me how to actually run a proposed layout test on all major ports to ensure that it passes before I submit a patch for review? This has been discussed a few times in webkit-dev but I don't think we've reached an agreement yet. Since people are not expected to have all ports built locally and then run all tests, the best we can do for now is to work with the people who do gardening for the ports and make sure the bots look green -- this means the tests need to be skipped until the failures are further investigated, or the commit which introduced them needs to be rolled out. > > They aren't all skipped because they pass :-) > > I am looking at results in http://build.webkit.org/results/EFL%20Linux%20Release/ and every media test that I look at has the following line in the actual results: > > FAIL: Timed out waiting for notifyDone to be called > > Am I looking in the wrong place? The Release bot is not in a very good state at the moment -- I recommend taking a look at the Debug bot instead. Anyway, the very fact that some tests are present in the results zip file means it has failed somehow; OTOH, tests which are not there have passed. 623517 8 mfeil 2012-05-14 17:54:22 -0700 I looked in http://build.webkit.org/results/ and the results for this test are as follows: Chromium Linux Release (Tests): Test not in results.html, but in tests_run1.txt (i.e. PASS) Qt Linux Release: Test not in results.html, OR tests_run*.txt (?) GTK Linux 32-bit Release: time goes to 0 but 2nd source does not play (FAIL) Lion Leaks: Test not in results.html, but in tests_run7.txt (i.e. PASS) Lion Debug (Tests): Test not in results.html, but in tests_run3.txt (i.e. PASS) Lion Debug (WebKit2 Tests): Test not in results.html, but in tests_run3.txt (i.e. PASS) Windows: I can't find any up to date test results EFL Linux Debug: time goes to 0 but 2nd source does not play (FAIL) Both the GTK and EFL ports are skipping this test for now. 624975 9 pnormand 2012-05-15 22:08:01 -0700 This is not a regression in the sense that this new test simply highlights a previously-hidden bug :) The issue is that when the media element loads the new <source> element a new MediaPlayerPrivate instance is created and it sets the gst pipeline state to PAUSED instead of PLAYING, so the test forever waits for never-arriving timeupdate events. One problem I see here is that the MediaPlayerPrivate is not aware that the up-layer previously tried another <source> element. So it's difficult to know when ::load() should set the pipeline to PLAYING instead of simply pausing it. :( Maybe the MediaPlayerClient could be made aware of a previous URI that it attempted to play, so ::load() could compare the new and old URIs. I wonder if that could be used by the Blackberry player as well and they could remove their not-so-great ::isElementPaused() which seems to be a layer violation, accessing the HTMLMediaElement API from the private player. 626943 10 rakuco 2012-05-17 14:03:29 -0700 *** Bug 86322 has been marked as a duplicate of this bug. *** 631176 11 pnormand 2012-05-22 21:30:11 -0700 I tested this on WebKitGTK WK1 and WK2 (with Martin's patch), I can clearly see that playback is not smooth. 631178 12 pnormand 2012-05-22 21:30:48 -0700 (In reply to comment #11) > I tested this on WebKitGTK WK1 and WK2 (with Martin's patch), I can clearly see that playback is not smooth. wrong bug, I should get some sleep... sorry for the noise! 648815 13 147488 pnormand 2012-06-13 22:41:21 -0700 Created attachment 147488 Patch 677975 14 pnormand 2012-07-25 06:15:15 -0700 Eric, can you please review this patch? 678129 15 147488 eric.carlson 2012-07-25 09:08:22 -0700 Comment on attachment 147488 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147488&action=review > Source/WebCore/html/HTMLMediaElement.cpp:948 > + if (!m_currentSrc.isEmpty()) > + m_previousSrc = m_currentSrc; Why is this necessary? It would be good to have a comment here and in the change log. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:312 > + // Reset network and ready states if the media element previously > + // used another location. This allows the media player client to > + // potentially emit a timeupdate event while the new location is being > + // loaded. States are synchronized again after the pipeline > + // pre-rolled. > + if (!m_player->mediaPlayerClient()->mediaPlayerPreviousUrl().isEmpty()) { > + m_networkState = MediaPlayer::Loading; > + m_player->networkStateChanged(); > + m_readyState = MediaPlayer::HaveNothing; > + m_player->readyStateChanged(); > + } Why don't you *always* reset the states to Loading and HaveNothing like other ports do? 682908 16 155487 pnormand 2012-07-31 04:15:47 -0700 Created attachment 155487 Patch Thanks Eric for the feedback. Unconditionally resetting the network and ready states is indeed the right and simpler fix. 690398 17 155487 eric.carlson 2012-08-08 09:26:31 -0700 Comment on attachment 155487 Patch Much simpler, thanks! 690461 18 pnormand 2012-08-08 10:18:31 -0700 Committed r125045: <http://trac.webkit.org/changeset/125045> 691859 19 ossy 2012-08-09 14:33:06 -0700 (In reply to comment #18) > Committed r125045: <http://trac.webkit.org/changeset/125045> It caused a regression on Qt WK2 - https://bugs.webkit.org/show_bug.cgi?id=93658 Could you check it, please? 147488 2012-06-13 22:41:21 -0700 2012-07-31 04:15:47 -0700 Patch bug-86310-20120613224127.patch text/plain 7704 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk4YWYwNzU0MTg0OGJk NTlmMDg5Y2I1Nzg5NDE4YzlkYjZkNmZiOS4uOTM5YmY5NjU3NjYwY2YwNmNkYTU4NTc5ZWVhOGY4 NGZkZDM5OTE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTA2LTEzICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBtZWRpYS9tZWRpYS1jb250aW51ZXMtcGxheWluZy1hZnRlci1yZXBsYWNlLXNvdXJjZS5odG1s IGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NjMxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl c2V0IHRoZSBwbGF5ZXIncyBuZXR3b3JrIGFuZCByZWFkeSBzdGF0ZXMgaWYgdGhlIG1lZGlhIGVs ZW1lbnQgcHJldmlvdXNseQorICAgICAgICB1c2VkIGFub3RoZXIgbG9jYXRpb24uIFRoaXMgYWxs b3dzIHRoZSBtZWRpYSBwbGF5ZXIgY2xpZW50IHRvCisgICAgICAgIHBvdGVudGlhbGx5IGVtaXQg YSB0aW1ldXBkYXRlIGV2ZW50IHdoaWxlIHRoZSBuZXcgbG9jYXRpb24gaXMgYmVpbmcKKyAgICAg ICAgbG9hZGVkLiBTdGF0ZXMgYXJlIHN5bmNocm9uaXplZCBhZ2FpbiBhZnRlciB0aGUgcGlwZWxp bmUKKyAgICAgICAgcHJlLXJvbGxlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYnV0IGZpeGVz IG1lZGlhL21lZGlhLWNvbnRpbnVlcy1wbGF5aW5nLWFmdGVyLXJlcGxhY2Utc291cmNlLmh0bWwK KworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MTWVkaWFFbGVtZW50Ojpsb2FkUmVzb3VyY2UpOgorICAgICAgICAoV2ViQ29yZTo6SFRN TE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJQcmV2aW91c1VybCk6CisgICAgICAgIChXZWJDb3Jl KToKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoKKyAgICAgICAgKEhUTUxNZWRp YUVsZW1lbnQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmg6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllckNsaWVudDo6bWVkaWFQbGF5ZXJQcmV2aW91c1Vy bCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXI6OmxvYWQpOgorCiAyMDEyLTA2LTEzICBEYW5hIEphbnNlbnMgIDxkYW5ha2pAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQ3JlYXRlIGEgQ0NTdHJlYW1WaWRlb0Ry YXdRdWFkIHVzZWQgZm9yIFN0cmVhbVRleHR1cmUgdmlkZW8gb3V0cHV0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCBjMzAwOGU5MzllMzdlM2YzNzI5ZGFlNTNl NTUxZmJkNGVhZTYyNmRmLi5mNWMzNjkwZTFmZTE4MjhiNWU4NmMyZGYzMDk5MTJmZjJmOGRhMzRj IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTk0NCw2ICs5 NDQsOSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmxvYWRSZXNvdXJjZShjb25zdCBLVVJMJiBp bml0aWFsVVJMLCBDb250ZW50VHlwZSYgY29udGVudAogICAgIH0KICNlbmRpZgogCisgICAgaWYg KCFtX2N1cnJlbnRTcmMuaXNFbXB0eSgpKQorICAgICAgICBtX3ByZXZpb3VzU3JjID0gbV9jdXJy ZW50U3JjOworCiAgICAgLy8gU2V0IG1fY3VycmVudFNyYyAqYmVmb3JlKiBjaGFuZ2luZyB0byB0 aGUgY2FjaGUgdXJsLCB0aGUgZmFjdCB0aGF0IHdlIGFyZSBsb2FkaW5nIGZyb20gdGhlIGFwcAog ICAgIC8vIGNhY2hlIGlzIGFuIGludGVybmFsIGRldGFpbCBub3QgZXhwb3NlZCB0aHJvdWdoIHRo ZSBtZWRpYSBlbGVtZW50IEFQSS4KICAgICBtX2N1cnJlbnRTcmMgPSB1cmw7CkBAIC00NDczLDYg KzQ0NzYsMTEgQEAgTWVkaWFQbGF5ZXJDbGllbnQ6OkNPUlNNb2RlIEhUTUxNZWRpYUVsZW1lbnQ6 Om1lZGlhUGxheWVyQ09SU01vZGUoKSBjb25zdAogICAgIHJldHVybiBBbm9ueW1vdXM7CiB9CiAK K0tVUkwgSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJQcmV2aW91c1VybCgpIGNvbnN0Cit7 CisgICAgcmV0dXJuIG1fcHJldmlvdXNTcmM7Cit9CisKIGJvb2wgSFRNTE1lZGlhRWxlbWVudDo6 bWVkaWFQbGF5ZXJOZWVkc1NpdGVTcGVjaWZpY0hhY2tzKCkgY29uc3QKIHsKICAgICBTZXR0aW5n cyogc2V0dGluZ3MgPSBkb2N1bWVudCgpLT5zZXR0aW5ncygpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxNZWRpYUVsZW1lbnQuaAppbmRleCAxNjczZTE1MzUyNDkxOGQ1Mjk1NzFlOGI5NWVkMmVhNTRk ZjkzNTgwLi44ZDZlZWY4YjE2MzQzOTFhNjRmOTcxODU4YjM0NmFiMTBlNTZiZTcxIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaApAQCAtNDI4LDYgKzQyOCw3IEBAIHByaXZh dGU6CiAgICAgdmlydHVhbCBTdHJpbmcgbWVkaWFQbGF5ZXJSZWZlcnJlcigpIGNvbnN0IE9WRVJS SURFOwogICAgIHZpcnR1YWwgU3RyaW5nIG1lZGlhUGxheWVyVXNlckFnZW50KCkgY29uc3QgT1ZF UlJJREU7CiAgICAgdmlydHVhbCBDT1JTTW9kZSBtZWRpYVBsYXllckNPUlNNb2RlKCkgY29uc3Qg T1ZFUlJJREU7CisgICAgdmlydHVhbCBLVVJMIG1lZGlhUGxheWVyUHJldmlvdXNVcmwoKSBjb25z dCBPVkVSUklERTsKIAogICAgIHZpcnR1YWwgYm9vbCBtZWRpYVBsYXllck5lZWRzU2l0ZVNwZWNp ZmljSGFja3MoKSBjb25zdCBPVkVSUklERTsKICAgICB2aXJ0dWFsIFN0cmluZyBtZWRpYVBsYXll ckRvY3VtZW50SG9zdCgpIGNvbnN0IE9WRVJSSURFOwpAQCAtNTUxLDYgKzU1Miw3IEBAIHByaXZh dGU6CiAgICAgUmVhZHlTdGF0ZSBtX3JlYWR5U3RhdGU7CiAgICAgUmVhZHlTdGF0ZSBtX3JlYWR5 U3RhdGVNYXhpbXVtOwogICAgIEtVUkwgbV9jdXJyZW50U3JjOworICAgIEtVUkwgbV9wcmV2aW91 c1NyYzsKIAogICAgIFJlZlB0cjxNZWRpYUVycm9yPiBtX2Vycm9yOwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuaAppbmRleCAzZmRmY2NlNmVkMTg4 OWRmNzhhNjc2YTFjYmIxY2M3NjVlMjAwOWJkLi5jM2JlNWM5OGJmZDE2YmYzNDVhYTJkMGNiZTY4 MDgwZGQ0ZjgyY2UxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9NZWRpYVBsYXllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01l ZGlhUGxheWVyLmgKQEAgLTE4MSw2ICsxODEsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBTdHJp bmcgbWVkaWFQbGF5ZXJSZWZlcnJlcigpIGNvbnN0IHsgcmV0dXJuIFN0cmluZygpOyB9CiAgICAg dmlydHVhbCBTdHJpbmcgbWVkaWFQbGF5ZXJVc2VyQWdlbnQoKSBjb25zdCB7IHJldHVybiBTdHJp bmcoKTsgfQogICAgIHZpcnR1YWwgQ09SU01vZGUgbWVkaWFQbGF5ZXJDT1JTTW9kZSgpIGNvbnN0 IHsgcmV0dXJuIFVuc3BlY2lmaWVkOyB9CisgICAgdmlydHVhbCBLVVJMIG1lZGlhUGxheWVyUHJl dmlvdXNVcmwoKSBjb25zdCB7IHJldHVybiBLVVJMKCk7IH0KIH07CiAKIGNsYXNzIE1lZGlhUGxh eWVyU3VwcG9ydHNUeXBlQ2xpZW50IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggMmQwZTg3OTJhMDhkNmNiYTkwZjMxN2I0N2FlNmI5MWVi ODRhOGMwMS4uZWZlMTFkNzU4ZjQ1ZDYyZmEyNzFlMTY4ZjllNTQ4YWJiZjFiZDFjZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTI5OSw2 ICsyOTksMTggQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmxvYWQoY29uc3Qg U3RyaW5nJiB1cmwpCiAgICAgICAgIG1fZGVsYXlpbmdMb2FkID0gdHJ1ZTsKICAgICB9CiAKKyAg ICAvLyBSZXNldCBuZXR3b3JrIGFuZCByZWFkeSBzdGF0ZXMgaWYgdGhlIG1lZGlhIGVsZW1lbnQg cHJldmlvdXNseQorICAgIC8vIHVzZWQgYW5vdGhlciBsb2NhdGlvbi4gVGhpcyBhbGxvd3MgdGhl IG1lZGlhIHBsYXllciBjbGllbnQgdG8KKyAgICAvLyBwb3RlbnRpYWxseSBlbWl0IGEgdGltZXVw ZGF0ZSBldmVudCB3aGlsZSB0aGUgbmV3IGxvY2F0aW9uIGlzIGJlaW5nCisgICAgLy8gbG9hZGVk LiBTdGF0ZXMgYXJlIHN5bmNocm9uaXplZCBhZ2FpbiBhZnRlciB0aGUgcGlwZWxpbmUKKyAgICAv LyBwcmUtcm9sbGVkLgorICAgIGlmICghbV9wbGF5ZXItPm1lZGlhUGxheWVyQ2xpZW50KCktPm1l ZGlhUGxheWVyUHJldmlvdXNVcmwoKS5pc0VtcHR5KCkpIHsKKyAgICAgICAgbV9uZXR3b3JrU3Rh dGUgPSBNZWRpYVBsYXllcjo6TG9hZGluZzsKKyAgICAgICAgbV9wbGF5ZXItPm5ldHdvcmtTdGF0 ZUNoYW5nZWQoKTsKKyAgICAgICAgbV9yZWFkeVN0YXRlID0gTWVkaWFQbGF5ZXI6OkhhdmVOb3Ro aW5nOworICAgICAgICBtX3BsYXllci0+cmVhZHlTdGF0ZUNoYW5nZWQoKTsKKyAgICB9CisKICAg ICAvLyBHU3RyZWFtZXIgbmVlZHMgdG8gaGF2ZSB0aGUgcGlwZWxpbmUgc2V0IHRvIGEgcGF1c2Vk IHN0YXRlIHRvCiAgICAgLy8gc3RhcnQgcHJvdmlkaW5nIGFueXRoaW5nIHVzZWZ1bC4KICAgICBn c3RfZWxlbWVudF9zZXRfc3RhdGUobV9wbGF5QmluLCBHU1RfU1RBVEVfUEFVU0VEKTsKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCAzMjVkNjcxNDU1ZDkwNGQzMTA2NGJmYTZhM2M0YWUxYWRiMGI3M2QzLi43YTA0NTk5ZDgzMGZk MzU4NmQ2YzRjMTM3ZjMwOTQwYmRhNjEwNjBlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTIt MDYtMTMgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAg IFtHU3RyZWFtZXJdIG1lZGlhL21lZGlhLWNvbnRpbnVlcy1wbGF5aW5nLWFmdGVyLXJlcGxhY2Ut c291cmNlLmh0bWwgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg2MzEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVW5mbGFnIG5vdyBwYXNzaW5nIG1lZGlhIHRlc3Qgb24gR1RLIGFuZCBFRkwuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0wNi0xMyAgTWluIFFpbiAgPHFpbm1p bkBnb29nbGUuY29tPgogCiAgICAgICAgIEFkZHJlc3Mgc29tZSBmZWVkYmFja3MgaW4gbGF5b3V0 IHRlc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRp b25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOGVk MjU5NWM2NzQwZjcwYTdlMDhkYmVjNjA3OWIzZWYyZmE1YjY1MC4uZDA5YzY0ZDI1NTU0NjZkODI3 ZWRlZTc3NGZkNTE0MjJmZTBmZDYyYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v ZWZsL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RF eHBlY3RhdGlvbnMKQEAgLTYzMSw5ICs2MzEsNiBAQCBCVUdXSzg2MTM3IDogaWV0ZXN0Y2VudGVy L2NzczMvbmFtZXNwYWNlcy9wcmVmaXgtMDA3LnhtbCA9IElNQUdFCiBCVUdXSzg2MTM5IDogaWV0 ZXN0Y2VudGVyL2NzczMvbmFtZXNwYWNlcy9wcmVmaXgtMDEwLnhtbCA9IElNQUdFCiBCVUdXSzg2 MTQyIDogaWV0ZXN0Y2VudGVyL2NzczMvbmFtZXNwYWNlcy9zeW50YXgtMDIxLnhtbCA9IElNQUdF CiAKLS8vIE5ldyB0ZXN0IGludHJvZHVjZWQgaW4gcjExNjg1OCBmYWlscwotQlVHV0s4NjMxMCA6 IG1lZGlhL21lZGlhLWNvbnRpbnVlcy1wbGF5aW5nLWFmdGVyLXJlcGxhY2Utc291cmNlLmh0bWwg PSBURVhUCi0KIC8vIEZ1bGxzY3JlZW4gQVBJIGlzIGVuYWJsZWQgYnV0IG5vdCBmdWxseSBpbXBs ZW1lbnRlZC4KIEJVR1dLODY1OTcgOiBmdWxsc2NyZWVuL3ZpZGVvLWNvbnRyb2xzLWRyYWcuaHRt bCA9IFRFWFQKIEJVR1dLODYxODcgOiBtZWRpYS9tZWRpYS1mdWxsc2NyZWVuLW5vdC1pbi1kb2N1 bWVudC5odG1sID0gVEVYVApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rl c3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9u cwppbmRleCAwOTBkMzRjMTdmMmE5NTRkYWRjNGE4YzFiODI2ZTI1OGFjYmNmNjhkLi5hNzRjZDY3 NjViOWY4NGFjYmNjNjE1NjI1ODkwNDU4ZmNmZjViY2QyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTI0NSw4ICsxMjQ1LDYgQEAgQlVHV0s4NjEzNyA6 IGlldGVzdGNlbnRlci9jc3MzL25hbWVzcGFjZXMvcHJlZml4LTAwNy54bWwgPSBJTUFHRQogQlVH V0s4NjEzOSA6IGlldGVzdGNlbnRlci9jc3MzL25hbWVzcGFjZXMvcHJlZml4LTAxMC54bWwgPSBJ TUFHRQogQlVHV0s4NjE0MiA6IGlldGVzdGNlbnRlci9jc3MzL25hbWVzcGFjZXMvc3ludGF4LTAy MS54bWwgPSBJTUFHRQogCi1CVUdXSzg2MzEwIDogbWVkaWEvbWVkaWEtY29udGludWVzLXBsYXlp bmctYWZ0ZXItcmVwbGFjZS1zb3VyY2UuaHRtbCA9IFRFWFQKLQogQlVHV0s4NjQ0MyA6IHBsdWdp bnMvbnBydW50aW1lL2RlbGV0ZS1wbHVnaW4td2l0aGluLWhhc1Byb3BlcnR5LXJldHVybi1mYWxz ZS5odG1sID0gVEVYVAogQlVHV0s4NjQ0MyA6IHBsdWdpbnMvbnBydW50aW1lL2RlbGV0ZS1wbHVn aW4td2l0aGluLWhhc1Byb3BlcnR5LXJldHVybi10cnVlLmh0bWwgPSBURVhUCiBCVUdXSzg2NDQz IDogcGx1Z2lucy9ucHJ1bnRpbWUvZGVsZXRlLXBsdWdpbi13aXRoaW4tc2V0UHJvcGVydHkuaHRt bCA9IFRFWFQK 155487 2012-07-31 04:15:47 -0700 2012-08-08 09:26:30 -0700 Patch 0001-Patch.patch text/plain 4688 pnormand RnJvbSBlMDAwNDU4MmI0ZDk4MjIxYWJiZTY0YWFjMjJhZmY0Y2JhNDZmMjQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDMxIEp1bCAyMDEyIDEzOjEzOjA4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g UGF0Y2gKCi0tLQogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVz dEV4cGVjdGF0aW9ucyAgICAgICAgICAgIHwgICAgMyAtLS0KIExheW91dFRlc3RzL3BsYXRmb3Jt L2d0ay9UZXN0RXhwZWN0YXRpb25zICAgICAgICAgICAgfCAgICAyIC0tCiBTb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxOCArKysrKysrKysr KysrKysrKysKIC4uLi9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCAg ICAgICAgfCAgICA3ICsrKysrKysKIDUgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwg NSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjAxZTU0Yi4uM2M0OTlkMyAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEyLTA3LTMxICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1N0cmVhbWVyXSBtZWRpYS9tZWRpYS1jb250aW51ZXMtcGxheWluZy1h ZnRlci1yZXBsYWNlLXNvdXJjZS5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NjMxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVuZmxhZyBub3cgcGFzc2luZyBtZWRpYSB0ZXN0IG9uIEdU SyBhbmQgRUZMLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnM6Cisg ICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMDctMzAgIEtl aXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgSW1wbGVtZW50IGRh dGFsaXN0IFVJIGZvciBpbnB1dCB0eXBlIGNvbG9yIGZvciBDaHJvbWl1bQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBlNDIxMjM5Li5mMzk0MmU3IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNjY4LDkgKzY2OCw2 IEBAIEJVR1dLODYxMzcgOiBpZXRlc3RjZW50ZXIvY3NzMy9uYW1lc3BhY2VzL3ByZWZpeC0wMDcu eG1sID0gSU1BR0UKIEJVR1dLODYxMzkgOiBpZXRlc3RjZW50ZXIvY3NzMy9uYW1lc3BhY2VzL3By ZWZpeC0wMTAueG1sID0gSU1BR0UKIEJVR1dLODYxNDIgOiBpZXRlc3RjZW50ZXIvY3NzMy9uYW1l c3BhY2VzL3N5bnRheC0wMjEueG1sID0gSU1BR0UKIAotLy8gTmV3IHRlc3QgaW50cm9kdWNlZCBp biByMTE2ODU4IGZhaWxzCi1CVUdXSzg2MzEwIDogbWVkaWEvbWVkaWEtY29udGludWVzLXBsYXlp bmctYWZ0ZXItcmVwbGFjZS1zb3VyY2UuaHRtbCA9IFRFWFQKLQogLy8gRnVsbHNjcmVlbiBBUEkg aXMgZW5hYmxlZCBidXQgbm90IGZ1bGx5IGltcGxlbWVudGVkLgogQlVHV0s4NjU5NyA6IGZ1bGxz Y3JlZW4vdmlkZW8tY29udHJvbHMtZHJhZy5odG1sID0gVEVYVAogQlVHV0s4NjE4NyA6IG1lZGlh L21lZGlhLWZ1bGxzY3JlZW4tbm90LWluLWRvY3VtZW50Lmh0bWwgPSBURVhUCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDMwM2IzMGIuLjMxZmM1Y2QgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBi L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMTkwLDggKzEx OTAsNiBAQCBCVUdXSzg2MTM3IDogaWV0ZXN0Y2VudGVyL2NzczMvbmFtZXNwYWNlcy9wcmVmaXgt MDA3LnhtbCA9IElNQUdFCiBCVUdXSzg2MTM5IDogaWV0ZXN0Y2VudGVyL2NzczMvbmFtZXNwYWNl cy9wcmVmaXgtMDEwLnhtbCA9IElNQUdFCiBCVUdXSzg2MTQyIDogaWV0ZXN0Y2VudGVyL2NzczMv bmFtZXNwYWNlcy9zeW50YXgtMDIxLnhtbCA9IElNQUdFCiAKLUJVR1dLODYzMTAgOiBtZWRpYS9t ZWRpYS1jb250aW51ZXMtcGxheWluZy1hZnRlci1yZXBsYWNlLXNvdXJjZS5odG1sID0gVEVYVAot CiBCVUdXSzg2NDQzIDogcGx1Z2lucy9ucHJ1bnRpbWUvZGVsZXRlLXBsdWdpbi13aXRoaW4taGFz UHJvcGVydHktcmV0dXJuLWZhbHNlLmh0bWwgPSBURVhUCiBCVUdXSzg2NDQzIDogcGx1Z2lucy9u cHJ1bnRpbWUvZGVsZXRlLXBsdWdpbi13aXRoaW4taGFzUHJvcGVydHktcmV0dXJuLXRydWUuaHRt bCA9IFRFWFQKIEJVR1dLODY0NDMgOiBwbHVnaW5zL25wcnVudGltZS9kZWxldGUtcGx1Z2luLXdp dGhpbi1zZXRQcm9wZXJ0eS5odG1sID0gVEVYVApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDBjMWIzMmUuLjEzNDRk NjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0wNy0zMSAgUGhpbGlwcGUgTm9y bWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gbWVkaWEv bWVkaWEtY29udGludWVzLXBsYXlpbmctYWZ0ZXItcmVwbGFjZS1zb3VyY2UuaHRtbCBmYWlscwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODYzMTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNldCB0aGUg cGxheWVyJ3MgbmV0d29yayBhbmQgcmVhZHkgc3RhdGVzLCB0aGlzIGFsbG93cyB0aGUgbWVkaWEK KyAgICAgICAgcGxheWVyIGNsaWVudCB0byBwb3RlbnRpYWxseSBlbWl0IGEgdGltZXVwZGF0ZSBl dmVudCB3aGlsZSB0aGUgbmV3CisgICAgICAgIGxvY2F0aW9uIGlzIGJlaW5nIGxvYWRlZC4gU3Rh dGVzIGFyZSBzeW5jaHJvbml6ZWQgYWdhaW4gYWZ0ZXIgdGhlCisgICAgICAgIHBpcGVsaW5lIHBy ZS1yb2xsZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJ1dCBmaXhlcworICAgICAgICBtZWRp YS9tZWRpYS1jb250aW51ZXMtcGxheWluZy1hZnRlci1yZXBsYWNlLXNvdXJjZS5odG1sCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l cjo6bG9hZCk6CisKIDIwMTItMDctMzEgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWls LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGNyYXNoIGZpeCBhZnRlciByMTI0MTM1LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBmYmE4 MjUyLi5iYjYxZmFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmNwcApAQCAtMzAxLDYgKzMwMSwxMyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lcjo6bG9hZChjb25zdCBTdHJpbmcmIHVybCkKICAgICAgICAgbV9kZWxheWluZ0xvYWQg PSB0cnVlOwogICAgIH0KIAorICAgIC8vIFJlc2V0IG5ldHdvcmsgYW5kIHJlYWR5IHN0YXRlcy4g VGhvc2Ugd2lsbCBiZSBzZXQgcHJvcGVybHkgb25jZQorICAgIC8vIHRoZSBwaXBlbGluZSBwcmUt cm9sbGVkLgorICAgIG1fbmV0d29ya1N0YXRlID0gTWVkaWFQbGF5ZXI6OkxvYWRpbmc7CisgICAg bV9wbGF5ZXItPm5ldHdvcmtTdGF0ZUNoYW5nZWQoKTsKKyAgICBtX3JlYWR5U3RhdGUgPSBNZWRp YVBsYXllcjo6SGF2ZU5vdGhpbmc7CisgICAgbV9wbGF5ZXItPnJlYWR5U3RhdGVDaGFuZ2VkKCk7 CisKICAgICAvLyBHU3RyZWFtZXIgbmVlZHMgdG8gaGF2ZSB0aGUgcGlwZWxpbmUgc2V0IHRvIGEg cGF1c2VkIHN0YXRlIHRvCiAgICAgLy8gc3RhcnQgcHJvdmlkaW5nIGFueXRoaW5nIHVzZWZ1bC4K ICAgICBnc3RfZWxlbWVudF9zZXRfc3RhdGUobV9wbGF5QmluLCBHU1RfU1RBVEVfUEFVU0VEKTsK LS0gCjEuNy4xMC40Cgo=